@itwin/core-geometry 4.10.0-dev.3 → 4.10.0-dev.30

package/lib/cjs/curve/internalContexts/CurveCurveIntersectXY.js

@@ -21,6 +21,7 @@ const Point4d_1 = require("../../geometry4d/Point4d");
 const BezierPolynomials_1 = require("../../numerics/BezierPolynomials");
 const Newton_1 = require("../../numerics/Newton");
 const Polynomials_1 = require("../../numerics/Polynomials");
+const SmallSystem_1 = require("../../numerics/SmallSystem");
 const Arc3d_1 = require("../Arc3d");
 const CurveChainWithDistanceIndex_1 = require("../CurveChainWithDistanceIndex");
 const CurveCollection_1 = require("../CurveCollection");
@@ -66,7 +67,9 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
     resetGeometry(geometryB) {
         this._geometryB = geometryB;
     }
+    /** Accept the fraction if it falls inside (possibly extended) fraction range. */
     acceptFraction(extend0, fraction, extend1, fractionTol = 1.0e-12) {
+        // Note that default tol is tighter than Geometry.smallFraction. We aggressively toss intersections past endpoints.
         if (!extend0 && fraction < -fractionTol)
             return false;
         if (!extend1 && fraction > 1.0 + fractionTol)
@@ -181,7 +184,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
                 this.recordPointWithLocalFractions(overlap.detailA.fraction, cpA, fractionA0, fractionA1, overlap.detailB.fraction, cpB, fractionB0, fractionB1, reversed, overlap);
             }
         }
-        else if (Polynomials_1.SmallSystem.lineSegment3dXYTransverseIntersectionUnbounded(pointA0, pointA1, pointB0, pointB1, uv)) {
+        else if (SmallSystem_1.SmallSystem.lineSegment3dXYTransverseIntersectionUnbounded(pointA0, pointA1, pointB0, pointB1, uv)) {
             if (this.acceptFractionOnLine(extendA0, uv.x, extendA1, pointA0, pointA1, this._coincidentGeometryContext.tolerance) &&
                 this.acceptFractionOnLine(extendB0, uv.y, extendB1, pointB0, pointB1, this._coincidentGeometryContext.tolerance)) {
                 this.recordPointWithLocalFractions(uv.x, cpA, fractionA0, fractionA1, uv.y, cpB, fractionB0, fractionB1, reversed);
@@ -201,7 +204,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
         this._worldToLocalPerspective.multiplyPoint3d(pointA1, 1, hA1);
         this._worldToLocalPerspective.multiplyPoint3d(pointB0, 1, hB0);
         this._worldToLocalPerspective.multiplyPoint3d(pointB1, 1, hB1);
-        const fractionAB = Polynomials_1.SmallSystem.lineSegment3dHXYTransverseIntersectionUnbounded(hA0, hA1, hB0, hB1);
+        const fractionAB = SmallSystem_1.SmallSystem.lineSegment3dHXYTransverseIntersectionUnbounded(hA0, hA1, hB0, hB1);
         if (fractionAB !== undefined) {
             const fractionA = fractionAB.x;
             const fractionB = fractionAB.y;
@@ -253,12 +256,8 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
             const numRoots = Polynomials_1.AnalyticRoots.appendImplicitLineUnitCircleIntersections(alpha, beta, gamma, cosines, sines, radians);
             for (let i = 0; i < numRoots; i++) {
                 const arcPoint = data.center.plus2Scaled(data.vector0, cosines.atUncheckedIndex(i), data.vector90, sines.atUncheckedIndex(i));
-                let arcFraction = data.sweep.radiansToSignedPeriodicFraction(radians.atUncheckedIndex(i));
-                if (extendB0 && arcFraction > 1)
-                    arcFraction -= 2;
-                else if (extendB1 && arcFraction < 0)
-                    arcFraction += 2;
-                const lineFraction = Polynomials_1.SmallSystem.lineSegment3dHXYClosestPointUnbounded(pointA0H, pointA1H, arcPoint);
+                const arcFraction = data.sweep.radiansToSignedFraction(radians.atUncheckedIndex(i), extendB0);
+                const lineFraction = SmallSystem_1.SmallSystem.lineSegment3dHXYClosestPointUnbounded(pointA0H, pointA1H, arcPoint);
                 if (lineFraction !== undefined &&
                     this.acceptFraction(extendA0, lineFraction, extendA1) &&
                     this.acceptFraction(extendB0, arcFraction, extendB1)) {
@@ -281,16 +280,12 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
             const sines = new GrowableFloat64Array_1.GrowableFloat64Array(2);
             const radians = new GrowableFloat64Array_1.GrowableFloat64Array(2);
             const numRoots = Polynomials_1.AnalyticRoots.appendImplicitLineUnitCircleIntersections(alpha, beta, gamma, cosines, sines, radians);
-            const lineFractionTol = 1.0e-10;
+            const lineFractionTol = 1.0e-10; // TODO: why are we loosening tolerances here?
             const arcFractionTol = 1.0e-7;
             for (let i = 0; i < numRoots; i++) {
                 const arcPoint = data.center.plus2Scaled(data.vector0, cosines.atUncheckedIndex(i), data.vector90, sines.atUncheckedIndex(i));
-                let arcFraction = data.sweep.radiansToSignedPeriodicFraction(radians.atUncheckedIndex(i));
-                if (extendB0 && arcFraction > 1)
-                    arcFraction -= 2;
-                else if (extendB1 && arcFraction < 0)
-                    arcFraction += 2;
-                const lineFraction = Polynomials_1.SmallSystem.lineSegment3dXYClosestPointUnbounded(pointA0Local, pointA1Local, arcPoint);
+                const arcFraction = data.sweep.radiansToSignedFraction(radians.atUncheckedIndex(i), extendB0);
+                const lineFraction = SmallSystem_1.SmallSystem.lineSegment3dXYClosestPointUnbounded(pointA0Local, pointA1Local, arcPoint);
                 if (lineFraction !== undefined &&
                     this.acceptFraction(extendA0, lineFraction, extendA1, lineFractionTol) &&
                     this.acceptFraction(extendB0, arcFraction, extendB1, arcFractionTol)) {
@@ -306,7 +301,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
      */
     dispatchArcArcThisOrder(cpA, // arc closer to being circular
     matrixA, extendA0, extendA1, cpB, matrixB, extendB0, extendB1, reversed) {
-        // inverseA transforms arcA to its local coordinates, where it is the unit xy-circle.
+        // inverseA transforms arcA to its local coordinates, where it is the unit xy-circle
         const inverseA = matrixA.inverse();
         if (inverseA) {
             // localB defines the arc formed by transforming arcB into the local coordinates of arcA
@@ -320,16 +315,8 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
             ellipseRadians, circleRadians);
             // the intersections are transform-invariant, so the solution angles apply directly to the input arcs
             for (let i = 0; i < ellipseRadians.length; i++) {
-                let fractionA = cpA.sweep.radiansToSignedPeriodicFraction(circleRadians[i]);
-                let fractionB = cpB.sweep.radiansToSignedPeriodicFraction(ellipseRadians[i]);
-                if (extendA0 && fractionA > 1)
-                    fractionA -= 2;
-                else if (extendA1 && fractionA < 0)
-                    fractionA += 2;
-                if (extendB0 && fractionB > 1)
-                    fractionB -= 2;
-                else if (extendB1 && fractionB < 0)
-                    fractionB += 2;
+                const fractionA = cpA.sweep.radiansToSignedFraction(circleRadians[i], extendA0);
+                const fractionB = cpB.sweep.radiansToSignedFraction(ellipseRadians[i], extendB0);
                 if (this.acceptFraction(extendA0, fractionA, extendA1) && this.acceptFraction(extendB0, fractionB, extendB1))
                     this.recordPointWithLocalFractions(fractionA, cpA, 0, 1, fractionB, cpB, 0, 1, reversed);
             }
@@ -440,13 +427,11 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
                             const bcurvePoint4d = bezier.fractionToPoint4d(root);
                             const c = bcurvePoint4d.dotProductXYZW(axx, axy, axz, axw);
                             const s = bcurvePoint4d.dotProductXYZW(ayx, ayy, ayz, ayw);
-                            let arcFraction = cpA.sweep.radiansToSignedPeriodicFraction(Math.atan2(s, c));
-                            if (extendA0 && arcFraction > 1)
-                                arcFraction -= 2;
-                            else if (extendA1 && arcFraction < 0)
-                                arcFraction += 2;
-                            if (this.acceptFraction(extendA0, arcFraction, extendA1) && this.acceptFraction(extendB0, fractionB, extendB1))
+                            const arcFraction = cpA.sweep.radiansToSignedFraction(Math.atan2(s, c), extendA0);
+                            if (this.acceptFraction(extendA0, arcFraction, extendA1) &&
+                                this.acceptFraction(extendB0, fractionB, extendB1)) {
                                 this.recordPointWithLocalFractions(arcFraction, cpA, 0, 1, fractionB, cpB, 0, 1, reversed);
+                            }
                         }
                     }
                 }
@@ -515,7 +500,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
                 for (const r of roots) {
                     let bezierBFraction = r;
                     bezierB.fractionToPoint4d(bezierBFraction, this._xyzwB);
-                    const segmentAFraction = Polynomials_1.SmallSystem.lineSegment3dHXYClosestPointUnbounded(this._xyzwA0, this._xyzwA1, this._xyzwB);
+                    const segmentAFraction = SmallSystem_1.SmallSystem.lineSegment3dHXYClosestPointUnbounded(this._xyzwA0, this._xyzwA1, this._xyzwB);
                     if (segmentAFraction && Geometry_1.Geometry.isIn01WithTolerance(segmentAFraction, intervalTolerance)) {
                         let bezierAFraction = Geometry_1.Geometry.interpolate(f0, segmentAFraction, f1);
                         // We have a near intersection at fractions on the two beziers
@@ -529,7 +514,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
                         }
                         const bcurveAFraction = bezierA.fractionToParentFraction(bezierAFraction);
                         const bcurveBFraction = bezierB.fractionToParentFraction(bezierBFraction);
-                        if (!"verify results") {
+                        if (false) { // verify results
                             const xyzA0 = bezierA.fractionToPoint(bezierAFraction);
                             const xyzA1 = bcurveA.fractionToPoint(bcurveAFraction);
                             const xyzB0 = bezierB.fractionToPoint(bezierBFraction);
@@ -623,7 +608,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
             const fractionB = detail.fraction;
             const curvePoint = detail.point;
             const curvePointH = this.projectPoint(curvePoint);
-            const lineFraction = Polynomials_1.SmallSystem.lineSegment3dHXYClosestPointUnbounded(pointA0H, pointA1H, curvePointH);
+            const lineFraction = SmallSystem_1.SmallSystem.lineSegment3dHXYClosestPointUnbounded(pointA0H, pointA1H, curvePointH);
             if (lineFraction !== undefined) {
                 if (this.acceptFraction(extendA0, lineFraction, extendA1) && this.acceptFraction(extendB0, fractionB, extendB1)) {
                     this.recordPointWithLocalFractions(lineFraction, cpA, fractionA0, fractionA1, fractionB, bcurve, 0, 1, reversed);
@@ -706,10 +691,6 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
             let fB0;
             let fA1;
             let fB1;
-            const extendA0 = this._extendA0;
-            const extendA1 = this._extendA1;
-            const extendB0 = this._extendB0;
-            const extendB1 = this._extendB1;
             lsA.pointAt(0, pointA0);
             for (let ia = 1; ia < numA; ia++, pointA0.setFrom(pointA1), fA0 = fA1) {
                 fA1 = ia * dfA;
@@ -719,7 +700,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
                 for (let ib = 1; ib < numB; ib++, pointB0.setFrom(pointB1), fB0 = fB1) {
                     lsB.pointAt(ib, pointB1);
                     fB1 = ib * dfB;
-                    this.dispatchSegmentSegment(lsA, ia === 1 && extendA0, pointA0, fA0, pointA1, fA1, (ia + 1) === numA && extendA1, lsB, ib === 1 && extendB0, pointB0, fB0, pointB1, fB1, (ib + 1) === numB && extendB1, reversed);
+                    this.dispatchSegmentSegment(lsA, ia === 1 && this._extendA0, pointA0, fA0, pointA1, fA1, (ia + 1) === numA && this._extendA1, lsB, ib === 1 && this._extendB0, pointB0, fB0, pointB1, fB1, (ib + 1) === numB && this._extendB1, reversed);
                 }
             }
         }
@@ -743,19 +724,16 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
         const extendB1 = this._extendB1; // save
         for (let i = 0; i < children.length; i++) {
             this.resetGeometry(children[i]);
-            if (geomB instanceof Path_1.Path) {
-                if (i === 0) // first child only extends from start
-                    this._extendB1 = false;
-                else if (i === children.length - 1) // last child only extends from end
-                    this._extendB0 = false;
-                else { // middle children do not extend
-                    this._extendB0 = false;
-                    this._extendB1 = false;
-                }
+            if (geomB instanceof Path_1.Path && children.length > 1) {
+                if (i === 0)
+                    this._extendB1 = false; // first child can only extend from start
+                else if (i === children.length - 1)
+                    this._extendB0 = false; // last child can only extend from end
+                else
+                    this._extendB0 = this._extendB1 = false; // middle children cannot extend
             }
-            else if (geomB instanceof Loop_1.Loop) { // Loop never extends
-                this._extendB0 = false;
-                this._extendB1 = false;
+            else if (geomB instanceof Loop_1.Loop) {
+                this._extendB0 = this._extendB1 = false; // Loops cannot extend
             }
             geomAHandler(geomA);
             this._extendB0 = extendB0; // restore
@@ -771,7 +749,7 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
         if (!this._geometryB || !(this._geometryB instanceof CurveChainWithDistanceIndex_1.CurveChainWithDistanceIndex))
             return;
         if (geomA instanceof CurveChainWithDistanceIndex_1.CurveChainWithDistanceIndex) {
-            (0, core_bentley_1.assert)(!"call handleCurveChainWithDistanceIndex(geomA) instead");
+            (0, core_bentley_1.assert)(false, "call handleCurveChainWithDistanceIndex(geomA) instead");
             return;
         }
         const index0 = this._results.length;
@@ -791,19 +769,16 @@ class CurveCurveIntersectXY extends GeometryHandler_1.RecurseToCurvesGeometryHan
         const extendA1 = this._extendA1; // save
         if (children)
             for (let i = 0; i < children.length; i++) {
-                if (g instanceof Path_1.Path) {
-                    if (i === 0) // first child only extends from start
-                        this._extendA1 = false;
-                    else if (i === children.length - 1) // last child only extends from end
-                        this._extendA0 = false;
-                    else { // middle children do not extend
-                        this._extendA0 = false;
-                        this._extendA1 = false;
-                    }
+                if (g instanceof Path_1.Path && children.length > 1) {
+                    if (i === 0)
+                        this._extendA1 = false; // first child can only extend from start
+                    else if (i === children.length - 1)
+                        this._extendA0 = false; // last child can only extend from end
+                    else
+                        this._extendA0 = this._extendA1 = false; // middle children cannot extend
                 }
-                else if (g instanceof Loop_1.Loop) { // Loop never extends
-                    this._extendA0 = false;
-                    this._extendA1 = false;
+                else if (g instanceof Loop_1.Loop) {
+                    this._extendA0 = this._extendA1 = false; // Loops cannot extend
                 }
                 children[i].dispatchToGeometryHandler(this);
                 this._extendA0 = extendA0; // restore