@itwin/core-backend 5.9.0-dev.4 → 5.9.0-dev.5

package/lib/esm/test/element/ElementRoundTrip.test.js

@@ -4,6 +4,7 @@
 *--------------------------------------------------------------------------------------------*/
 import { assert, expect } from "chai";
 import { DbResult, Id64 } from "@itwin/core-bentley";
+import { withEditTxn } from "../../EditTxn";
 import { BriefcaseIdValue, Code, ColorDef, ElementGeometry, IModel, QueryRowFormat, SubCategoryAppearance, } from "@itwin/core-common";
 import { Angle, Arc3d, Cone, IModelJson as GeomJson, LineSegment3d, Point2d, Point3d } from "@itwin/core-geometry";
 import { _nativeDb, IModelDb, IModelJsFs, PhysicalModel, PhysicalObject, SnapshotDb, SpatialCategory } from "../../core-backend";
@@ -462,18 +463,17 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
         const imodel = SnapshotDb.createEmpty(iModelPath, { rootSubject: { name: "RoundTripTest" } });
         await imodel.importSchemas([testSchemaPath]);
         imodel[_nativeDb].resetBriefcaseId(BriefcaseIdValue.Unassigned);
-        IModelTestUtils.createAndInsertPhysicalPartitionAndModel(imodel, Code.createEmpty(), true);
-        let spatialCategoryId = SpatialCategory.queryCategoryIdByName(imodel, IModel.dictionaryId, categoryName);
+        withEditTxn(imodel, (txn) => IModelTestUtils.createAndInsertPhysicalPartitionAndModel(txn, Code.createEmpty(), true));
+        const spatialCategoryId = SpatialCategory.queryCategoryIdByName(imodel, IModel.dictionaryId, categoryName);
         if (undefined === spatialCategoryId)
-            spatialCategoryId = SpatialCategory.insert(imodel, IModel.dictionaryId, categoryName, new SubCategoryAppearance({ color: ColorDef.create("rgb(255,0,0)").toJSON() }));
-        imodel.saveChanges();
+            withEditTxn(imodel, (txn) => SpatialCategory.insert(txn, IModel.dictionaryId, categoryName, new SubCategoryAppearance({ color: ColorDef.create("rgb(255,0,0)").toJSON() })));
         imodel.close();
     });
     it("Roundtrip all type of properties via ElementApi, ConcurrentQuery and ECSqlStatement via insert and update", async () => {
         const testFileName = IModelTestUtils.prepareOutputFile(subDirName, "roundtrip_correct_data.bim");
         const imodel = IModelTestUtils.createSnapshotFromSeed(testFileName, iModelPath);
         const spatialCategoryId = SpatialCategory.queryCategoryIdByName(imodel, IModel.dictionaryId, categoryName);
-        const [, newModelId] = IModelTestUtils.createAndInsertPhysicalPartitionAndModel(imodel, Code.createEmpty(), true);
+        const [, newModelId] = withEditTxn(imodel, (txn) => IModelTestUtils.createAndInsertPhysicalPartitionAndModel(txn, Code.createEmpty(), true));
         // create element with auto handled properties
         const expectedValue = initElemProps("TestElement", imodel, newModelId, spatialCategoryId, {
             ...primInst1,
@@ -483,9 +483,8 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
         });
         // insert a element
         const geomElement = imodel.elements.createElement(expectedValue);
-        const id = imodel.elements.insertElement(geomElement.toJSON());
+        const id = withEditTxn(imodel, (txn) => txn.insertElement(geomElement.toJSON()));
         assert.isTrue(Id64.isValidId64(id), "insert worked");
-        imodel.saveChanges();
         const expectedSystemProperty = {
             id,
             className: `ElementRoundTripTest.TestElement`,
@@ -537,8 +536,7 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
             array_st: [{ ...primInst2, ...primArrInst2 }, { ...primInst1, ...primArrInst1 }],
         });
         // update element
-        imodel.elements.updateElement(actualValue);
-        imodel.saveChanges();
+        withEditTxn(imodel, (txn) => txn.updateElement(actualValue));
         // verify updated values
         const updatedValue = imodel.elements.getElementProps(id);
         verifyTestElement(updatedValue, actualValue);
@@ -623,12 +621,12 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
         const testFileName = IModelTestUtils.prepareOutputFile(subDirName, "roundtrip_apsect_correct_data.bim");
         const imodel = IModelTestUtils.createSnapshotFromSeed(testFileName, iModelPath);
         const spatialCategoryId = SpatialCategory.queryCategoryIdByName(imodel, IModel.dictionaryId, categoryName);
-        const [, newModelId] = IModelTestUtils.createAndInsertPhysicalPartitionAndModel(imodel, Code.createEmpty(), true);
+        const [, newModelId] = withEditTxn(imodel, (txn) => IModelTestUtils.createAndInsertPhysicalPartitionAndModel(txn, Code.createEmpty(), true));
         // Create an element to use with the ElementAspects
         const expectedValue = initElemProps("TestElement", imodel, newModelId, spatialCategoryId, {});
         // Insert an element
         const geomElement = imodel.elements.createElement(expectedValue);
-        const elId = imodel.elements.insertElement(geomElement.toJSON());
+        const elId = withEditTxn(imodel, (txn) => txn.insertElement(geomElement.toJSON()));
         assert.isTrue(Id64.isValidId64(elId), "Element insertion succeeded");
         const expectedAspectValue = initElementAspectProps("TestElementAspect", imodel, elId, {
             ...primInst1,
@@ -637,8 +635,9 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
             array_st: [{ ...primInst1, ...primArrInst2 }, { ...primInst2, ...primArrInst1 }],
         });
         // Insert an element aspect
-        const elementAspectId = imodel.elements.insertAspect(expectedAspectValue);
-        imodel.saveChanges();
+        const elementAspectId = withEditTxn(imodel, (txn) => {
+            return txn.insertAspect(expectedAspectValue);
+        });
         // Verify inserted element aspect properties
         const actualAspectValue = await verifyElementAspect(elementAspectId, expectedAspectValue, elId, expectedAspectValue.classFullName, imodel);
         // Update the element's autohandled properties
@@ -649,8 +648,9 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
             array_st: [{ ...primInst2, ...primArrInst2 }, { ...primInst1, ...primArrInst1 }],
         });
         // Update the element
-        imodel.elements.updateAspect(actualAspectValue[0]);
-        imodel.saveChanges();
+        withEditTxn(imodel, (txn) => {
+            txn.updateAspect(actualAspectValue[0]);
+        });
         // Verify updated element aspect properties
         await verifyElementAspect(elementAspectId, actualAspectValue[0], elId, expectedAspectValue.classFullName, imodel);
         imodel.close();
@@ -665,15 +665,15 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
         const testFileName = IModelTestUtils.prepareOutputFile(subDirName, "roundtrip_relationships_correct_data.bim");
         const imodel = IModelTestUtils.createSnapshotFromSeed(testFileName, iModelPath);
         const spatialCategoryId = SpatialCategory.queryCategoryIdByName(imodel, IModel.dictionaryId, categoryName);
-        const [, newModelId] = IModelTestUtils.createAndInsertPhysicalPartitionAndModel(imodel, Code.createEmpty(), true);
+        const [, newModelId] = withEditTxn(imodel, (txn) => IModelTestUtils.createAndInsertPhysicalPartitionAndModel(txn, Code.createEmpty(), true));
         // create elements to use
         const element1 = initElemProps("TestElement", imodel, newModelId, spatialCategoryId, {});
         const element2 = initElemProps("TestElement", imodel, newModelId, spatialCategoryId, {});
         const geomElement1 = imodel.elements.createElement(element1);
-        const elId1 = imodel.elements.insertElement(geomElement1.toJSON());
+        const elId1 = withEditTxn(imodel, (txn) => txn.insertElement(geomElement1.toJSON()));
         assert.isTrue(Id64.isValidId64(elId1), "insert of element 1 worked");
         const geomElement2 = imodel.elements.createElement(element2);
-        const elId2 = imodel.elements.insertElement(geomElement2.toJSON());
+        const elId2 = withEditTxn(imodel, (txn) => txn.insertElement(geomElement2.toJSON()));
         assert.isTrue(Id64.isValidId64(elId2), "insert of element 2 worked");
         // TODO: Skipping structs here, because of a bug that prevents querying from link tables that have an overflow table, by skipping the struct we reduce the amount of used columns
         const expectedRelationshipValue = initElementRefersToElementsProps("TestElementRefersToElements", imodel, elId1, elId2, {
@@ -683,8 +683,7 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
             array_st: [{ ...primInst1, ...primArrInst2 }, { ...primInst2, ...primArrInst1 }], */
         });
         const instance = expectedRelationshipValue; // imodel.relationships.createInstance(expectedRelationshipValue);
-        const relationshipId = imodel.relationships.insertInstance(instance); // initElementRefersToElementsProps lies about return type.
-        imodel.saveChanges();
+        const relationshipId = withEditTxn(imodel, (txn) => txn.insertRelationship(instance)); // initElementRefersToElementsProps lies about return type.
         // verify inserted properties
         const actualRelationshipValue = imodel.relationships.getInstance(expectedRelationshipValue.classFullName, relationshipId);
         assert.exists(actualRelationshipValue);
@@ -741,8 +740,7 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
                   array_st: [{ ...primInst2, ...primArrInst2 }, { ...primInst1, ...primArrInst1 }],*/
         });
         // update
-        imodel.relationships.updateInstance(updatedExpectedValue.toJSON());
-        imodel.saveChanges();
+        withEditTxn(imodel, (txn) => txn.updateRelationship(updatedExpectedValue.toJSON()));
         // verify updated values
         const updatedValue = imodel.relationships.getInstance(expectedRelationshipValue.classFullName, relationshipId);
         verifyTestElementRefersToElements(updatedValue, updatedExpectedValue);
@@ -799,18 +797,21 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
         expectedPlacementOverrides = {}, } = {}) => {
             const imodelPath = IModelTestUtils.prepareOutputFile(subDirName, `roundtrip_placement-${name}.bim`);
             let imodel = IModelTestUtils.createSnapshotFromSeed(imodelPath, iModelPath);
-            const modelId = PhysicalModel.insert(imodel, IModelDb.rootSubjectId, "model");
-            const categoryId = SpatialCategory.insert(imodel, IModelDb.dictionaryId, "model", {});
-            const expectedPlacement = { ...placement, ...expectedPlacementOverrides };
-            const objId = imodel.elements.insertElement({
-                classFullName: PhysicalObject.classFullName,
-                code: Code.createEmpty(),
-                model: modelId,
-                placement,
-                category: categoryId,
-                ...extraProps,
+            const { objId } = withEditTxn(imodel, (txn) => {
+                const modelId = PhysicalModel.insert(txn, IModelDb.rootSubjectId, "model");
+                const categoryId = SpatialCategory.insert(txn, IModelDb.dictionaryId, "model", {});
+                return {
+                    objId: txn.insertElement({
+                        classFullName: PhysicalObject.classFullName,
+                        code: Code.createEmpty(),
+                        model: modelId,
+                        placement,
+                        category: categoryId,
+                        ...extraProps,
+                    }),
+                };
             });
-            imodel.saveChanges();
+            const expectedPlacement = { ...placement, ...expectedPlacementOverrides };
             const inMemoryCopy = imodel.elements.getElement({ id: objId, wantGeometry: true }, PhysicalObject);
             expect(inMemoryCopy.placement).to.deep.advancedEqual(expectedPlacement);
             // reload db since there is a different path for loading properties not in memory that we want to force
@@ -871,7 +872,7 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
         const testFileName = IModelTestUtils.prepareOutputFile(subDirName, "roundtrip_properties_null_update.bim");
         const imodel = IModelTestUtils.createSnapshotFromSeed(testFileName, iModelPath);
         const spatialCategoryId = SpatialCategory.queryCategoryIdByName(imodel, IModel.dictionaryId, categoryName);
-        const [, newModelId] = IModelTestUtils.createAndInsertPhysicalPartitionAndModel(imodel, Code.createEmpty(), true);
+        const [, newModelId] = withEditTxn(imodel, (txn) => IModelTestUtils.createAndInsertPhysicalPartitionAndModel(txn, Code.createEmpty(), true));
         // Create an element to be used
         const expectedValue = initElemProps("TestElement", imodel, newModelId, spatialCategoryId, {
             ...primInst1,
@@ -881,9 +882,8 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
         });
         // Insert an element
         const geomElement = imodel.elements.createElement(expectedValue);
-        const id = imodel.elements.insertElement(geomElement.toJSON());
+        const id = withEditTxn(imodel, (txn) => txn.insertElement(geomElement.toJSON()));
         assert.isTrue(Id64.isValidId64(id), "insert worked");
-        imodel.saveChanges();
         // Verify inserted element properties
         const actualValue = imodel.elements.getElementProps(id);
         verifyTestElement(actualValue, expectedValue);
@@ -914,8 +914,7 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
                 array_st: null,
             });
             // Update the element
-            imodel.elements.updateElement(actualValue);
-            imodel.saveChanges();
+            withEditTxn(imodel, (txn) => txn.updateElement(actualValue));
             // Verify updated value properties
             const updatedValue = imodel.elements.getElementProps(id);
             verifyTestElement(updatedValue, actualValue);