@itwin/core-backend 5.13.0-dev.12 → 5.13.0-dev.14

package/lib/esm/test/element/ElementRoundTrip.test.js

@@ -3,11 +3,11 @@
 * See LICENSE.md in the project root for license terms and full copyright notice.
 *--------------------------------------------------------------------------------------------*/
 import { assert, expect } from "chai";
-import { DbResult, Id64 } from "@itwin/core-bentley";
+import { DbResult, Id64, OpenMode } from "@itwin/core-bentley";
 import { EditTxn, withEditTxn } from "../../EditTxn";
 import { BriefcaseIdValue, Code, ColorDef, ElementGeometry, IModel, QueryRowFormat, SubCategoryAppearance, } from "@itwin/core-common";
 import { Angle, Arc3d, Cone, IModelJson as GeomJson, LineSegment3d, Point2d, Point3d, Range2d, Range3d } from "@itwin/core-geometry";
-import { _nativeDb, CategorySelector, DefinitionModel, DisplayStyle2d, DisplayStyle3d, DrawingCategory, DrawingViewDefinition, IModelDb, IModelJsFs, ModelSelector, OrthographicViewDefinition, PhysicalModel, PhysicalObject, SnapshotDb, SpatialCategory, SpatialViewDefinition } from "../../core-backend";
+import { _nativeDb, CategorySelector, ChannelControl, DefinitionModel, DisplayStyle2d, DisplayStyle3d, DrawingCategory, DrawingViewDefinition, GeometricElement3d, IModelDb, IModelJsFs, ModelSelector, OrthographicViewDefinition, PhysicalModel, PhysicalObject, SnapshotDb, SpatialCategory, SpatialViewDefinition, StandaloneDb } from "../../core-backend";
 import { IModelTestUtils } from "../IModelTestUtils";
 import { EntityClass, RelationshipClass } from "@itwin/ecschema-metadata";
 function verifyPrimitiveBase(actualValue, expectedValue) {
@@ -878,6 +878,84 @@ describe("Element and ElementAspect roundtrip test for all type of properties",
         testBox({ baseOriginX: 5 }, 5);
         testBox({ originX: 2, baseOriginX: 4 }, 2);
     });
+    it("Does not deserialize an absent placement, but preserves an origin without a bbox", async () => {
+        const imodelPath = IModelTestUtils.prepareOutputFile(subDirName, "roundtrip_placement_without_bbox.bim");
+        let imodel = IModelTestUtils.createSnapshotFromSeed(imodelPath, iModelPath);
+        const { noPlacementId, originOnlyId } = withEditTxn(imodel, (txn) => {
+            const modelId = PhysicalModel.insert(txn, IModelDb.rootSubjectId, "model");
+            const categoryId = SpatialCategory.insert(txn, IModelDb.dictionaryId, "model", {});
+            const baseProps = {
+                classFullName: PhysicalObject.classFullName,
+                code: Code.createEmpty(),
+                model: modelId,
+                category: categoryId,
+            };
+            const originOnlyProps = {
+                ...baseProps,
+                placement: {
+                    origin: { x: 10, y: 20, z: 30 },
+                    angles: { yaw: 0, pitch: 0, roll: 0 },
+                },
+            };
+            return {
+                noPlacementId: txn.insertElement(baseProps),
+                originOnlyId: txn.insertElement(originOnlyProps),
+            };
+        });
+        imodel.close();
+        imodel = SnapshotDb.openFile(imodelPath);
+        const noPlacement = imodel.elements.getElementProps({ id: noPlacementId });
+        assert.isUndefined(noPlacement.placement);
+        const noPlacementElement = imodel.elements.getElement(noPlacementId, PhysicalObject);
+        assert.isUndefined(noPlacementElement.toJSON().placement);
+        const writableImodel = StandaloneDb.openFile(imodelPath, OpenMode.ReadWrite);
+        writableImodel.channels.addAllowedChannel(ChannelControl.sharedChannelName);
+        withEditTxn(writableImodel, (txn) => txn.updateElement(noPlacementElement.toJSON()));
+        writableImodel.close();
+        imodel.close();
+        imodel = SnapshotDb.openFile(imodelPath);
+        const reloadedNoPlacement = imodel.elements.getElement(noPlacementId, PhysicalObject);
+        assert.isUndefined(reloadedNoPlacement.toJSON().placement);
+        reloadedNoPlacement.placement.origin.x = 10;
+        assert.deepEqual(reloadedNoPlacement.toJSON().placement?.origin, { x: 10, y: 0, z: 0 });
+        assert.isUndefined(imodel.elements.getElementProps({ id: noPlacementId }).placement);
+        // eslint-disable-next-line @typescript-eslint/no-deprecated
+        const spatialIndexCount = imodel.withPreparedStatement("SELECT COUNT(*) FROM bis.SpatialIndex WHERE ECInstanceId=?", (stmt) => {
+            stmt.bindId(1, noPlacementId);
+            assert.equal(stmt.step(), DbResult.BE_SQLITE_ROW);
+            return stmt.getValue(0).getInteger();
+        });
+        assert.equal(spatialIndexCount, 0);
+        const originOnly = imodel.elements.getElementProps({ id: originOnlyId });
+        assert.deepEqual(originOnly.placement?.origin, [10, 20, 30]);
+        assert.isDefined(originOnly.placement);
+        const originOnlyElement = imodel.elements.getElement(originOnlyId, PhysicalObject);
+        assert.deepEqual(originOnlyElement.toJSON().placement?.origin, { x: 10, y: 20, z: 30 });
+        imodel.close();
+    });
+    it("Preserves a placement returned by 3d geometry deserialization", () => {
+        const placement = {
+            origin: [10, 20, 30],
+            angles: { yaw: 0, pitch: 0, roll: 0 },
+            bbox: { low: [-1, -2, -3], high: [1, 2, 3] },
+        };
+        const nativeDb = {
+            patchJsonProperties: (json) => json,
+            convertOrUpdateGeometrySource: () => ({ geom: [], placement }),
+        };
+        const row = {
+            classFullName: GeometricElement3d.classFullName,
+            id: "0x1",
+            model: { id: "0x1" },
+            codeValue: "",
+            codeSpec: { id: "0x0" },
+            codeScope: { id: "0x0" },
+            category: { id: "0x2" },
+            geometryStream: new Uint8Array([1]),
+        };
+        const props = GeometricElement3d.deserialize({ row, iModel: { [_nativeDb]: nativeDb } });
+        assert.deepEqual(props.placement, placement);
+    });
     it("Roundtrip updating properties to null", async () => {
         const testFileName = IModelTestUtils.prepareOutputFile(subDirName, "roundtrip_properties_null_update.bim");
         const imodel = IModelTestUtils.createSnapshotFromSeed(testFileName, iModelPath);