@itwin/core-backend 5.10.0-dev.9 → 5.11.0-dev.1

package/lib/esm/test/imodel/IModel.test.js

@@ -1041,6 +1041,7 @@ describe("iModel", () => {
                     targetId: row.ECInstanceId,
                 });
                 const relationship = imodel.relationships.getInstance("BisCore:ElementHasLinks", relId);
+                // eslint-disable-next-line @typescript-eslint/no-deprecated
                 const metadata = await relationship.getMetaData();
                 assert.isDefined(metadata, "metadata should be defined");
             }
@@ -1077,6 +1078,7 @@ describe("iModel", () => {
                     targetId: row.ECInstanceId,
                 });
                 const relationship = imodel.relationships.getInstance("BisCore:ElementHasLinks", relId);
+                // eslint-disable-next-line @typescript-eslint/no-deprecated
                 relationship.forEach((propName, propMeta) => {
                     assert.isDefined(propName, "Property name should be defined");
                     assert.isDefined(propMeta, "Property metadata should be defined");
@@ -2275,6 +2277,35 @@ describe("iModel", () => {
         txn.end("abandon");
         db.close();
     });
+    it("inserting a second element with an empty code must not evict the first from the element props cache", () => {
+        const standaloneFile = IModelTestUtils.prepareOutputFile("IModel", "EmptyCodeCacheCollision.bim");
+        const db = StandaloneDb.createEmpty(standaloneFile, { rootSubject: { name: "EmptyCodeCacheCollision" } });
+        withEditTxn(db, (txn) => {
+            const categoryId = SpatialCategory.insert(txn, IModel.dictionaryId, "TestCategory", new SubCategoryAppearance());
+            const modelId = PhysicalModel.insert(txn, IModel.rootSubjectId, "TestModel");
+            const emptyCodeProps = {
+                classFullName: PhysicalObject.classFullName,
+                model: modelId,
+                category: categoryId,
+                code: Code.createEmpty(),
+            };
+            // Insert the first element
+            const id1 = txn.insertElement({ ...emptyCodeProps });
+            db.elements.getElementProps(id1); // populate the element props cache
+            const cacheSizeAfterFirstInsertAndRead = db.elements[_cache].size;
+            expect(cacheSizeAfterFirstInsertAndRead).to.be.greaterThan(0, "cache should be populated after getElementProps");
+            // Insert a second element with the same empty code
+            const id2 = txn.insertElement({ ...emptyCodeProps });
+            // The first element must still be in the cache.
+            const cached1 = db.elements[_cache].get({ id: id1 });
+            expect(cached1, "first element should still be in cache after inserting second element with the same empty code").to.not.be.undefined;
+            expect(cached1.elProps.id).to.equal(id1);
+            expect(Id64.isValidId64(id1)).to.be.true;
+            expect(Id64.isValidId64(id2)).to.be.true;
+            expect(id1).to.not.equal(id2);
+        });
+        db.close();
+    });
     it("Standalone iModel properties", () => {
         const standaloneRootSubjectName = "Standalone";
         const standaloneFile1 = IModelTestUtils.prepareOutputFile("IModel", "Standalone1.bim");
@@ -2903,50 +2934,50 @@ describe("iModel", () => {
             IModelJsFs.unlinkSync(imodelPath);
         const testImodel = SnapshotDb.createEmpty(imodelPath, { rootSubject: { name: "invalidRelationshipClass" } });
         await testImodel.importSchemaStrings([
-            `<?xml version="1.0" encoding="UTF-8"?>
-      <ECSchema schemaName="TestRelationSchema" alias="trs" version="01.00" xmlns="http://www.bentley.com/schemas/Bentley.ECXML.3.1">
-          <ECSchemaReference name="BisCore" version="01.00" alias="bis"/>
-          <ECEntityClass typeName="TestElement">
-              <BaseClass>bis:PhysicalElement</BaseClass>
-              <ECProperty propertyName="Name" typeName="string" />
-          </ECEntityClass>
-
-          <ECEntityClass typeName="ChildA" >
-            <BaseClass>TestElement</BaseClass>
-            <ECNavigationProperty propertyName="NavPropChildB" relationshipName="ADrivesB" direction="Forward" readOnly="True">
-            </ECNavigationProperty>
-          </ECEntityClass>
-
-          <ECEntityClass typeName="ChildB" >
-            <BaseClass>TestElement</BaseClass>
-          </ECEntityClass>
-
-          <ECRelationshipClass typeName="ADrivesB" strengthDirection="Backward" strength="referencing" modifier="Sealed">
-            <Source multiplicity="(0..*)" polymorphic="true" roleLabel="drives">
-              <Class class="ChildA"/>
-            </Source>
-            <Target multiplicity="(0..1)" polymorphic="true" roleLabel="is driven by">
-              <Class class="ChildB"/>
-            </Target>
-          </ECRelationshipClass>
-
-          <ECEntityClass typeName="ChildC">
-            <BaseClass>TestElement</BaseClass>
-          </ECEntityClass>
-
-          <ECEntityClass typeName="ChildD">
-            <BaseClass>TestElement</BaseClass>
-          </ECEntityClass>
-
-          <ECRelationshipClass typeName="CIsRelatedToD" strength="referencing" modifier="Sealed">
-             <BaseClass>bis:ElementRefersToElements</BaseClass>
-            <Source multiplicity="(0..*)" roleLabel="IsRelatedTo" polymorphic="true">
-              <Class class="ChildC"/>
-            </Source>
-            <Target multiplicity="(0..*)" roleLabel="IsRelatedTo (Reversed)" polymorphic="true">
-              <Class class="ChildD"/>
-            </Target>
-          </ECRelationshipClass>
+            `<?xml version="1.0" encoding="UTF-8"?>
+      <ECSchema schemaName="TestRelationSchema" alias="trs" version="01.00" xmlns="http://www.bentley.com/schemas/Bentley.ECXML.3.1">
+          <ECSchemaReference name="BisCore" version="01.00" alias="bis"/>
+          <ECEntityClass typeName="TestElement">
+              <BaseClass>bis:PhysicalElement</BaseClass>
+              <ECProperty propertyName="Name" typeName="string" />
+          </ECEntityClass>
+
+          <ECEntityClass typeName="ChildA" >
+            <BaseClass>TestElement</BaseClass>
+            <ECNavigationProperty propertyName="NavPropChildB" relationshipName="ADrivesB" direction="Forward" readOnly="True">
+            </ECNavigationProperty>
+          </ECEntityClass>
+
+          <ECEntityClass typeName="ChildB" >
+            <BaseClass>TestElement</BaseClass>
+          </ECEntityClass>
+
+          <ECRelationshipClass typeName="ADrivesB" strengthDirection="Backward" strength="referencing" modifier="Sealed">
+            <Source multiplicity="(0..*)" polymorphic="true" roleLabel="drives">
+              <Class class="ChildA"/>
+            </Source>
+            <Target multiplicity="(0..1)" polymorphic="true" roleLabel="is driven by">
+              <Class class="ChildB"/>
+            </Target>
+          </ECRelationshipClass>
+
+          <ECEntityClass typeName="ChildC">
+            <BaseClass>TestElement</BaseClass>
+          </ECEntityClass>
+
+          <ECEntityClass typeName="ChildD">
+            <BaseClass>TestElement</BaseClass>
+          </ECEntityClass>
+
+          <ECRelationshipClass typeName="CIsRelatedToD" strength="referencing" modifier="Sealed">
+             <BaseClass>bis:ElementRefersToElements</BaseClass>
+            <Source multiplicity="(0..*)" roleLabel="IsRelatedTo" polymorphic="true">
+              <Class class="ChildC"/>
+            </Source>
+            <Target multiplicity="(0..*)" roleLabel="IsRelatedTo (Reversed)" polymorphic="true">
+              <Class class="ChildD"/>
+            </Target>
+          </ECRelationshipClass>
         </ECSchema>`
         ]);
         // Enable ECSQL write validation and verify it's set