@itentialopensource/adapter-utils 5.10.19 → 5.10.21

package/lib/propertyUtil.js

@@ -1149,6 +1149,11 @@ class AdapterPropertyUtil {
     const origin = `${this.myid}-propertyUtil-scrubSensitiveInfo`;
     log.trace(origin);
 
+    // If too much to check, performance becomes an issue
+    const maxStringSize = 50000;
+    const maxArraySize = 1000;
+    const maxObjectSize = 500;
+
     // no reason to scan numbers, booleans or functions
     if (!inData || typeof inData === 'number' || typeof inData === 'boolean' || typeof inData === 'function') {
       return inData;
@@ -1167,6 +1172,12 @@ class AdapterPropertyUtil {
 
     // if we are scrubbbing a string (e.g. URL)
     if (typeof actualData === 'string') {
+      // if the string of data is too large we can not do a deep dive due to time it might take
+      if (actualData.length > maxStringSize) {
+        log.debug(`${origin}: Masking entire string, too large (${actualData.length}) to search effectively`);
+        return '** masked **';
+      }
+
       // if it is a Stringified JSON
       try {
         // need to see if it is stringified JSON
@@ -1231,16 +1242,14 @@ class AdapterPropertyUtil {
 
     // want to make a copy and not alter the original object or array
     const retData = JSON.parse(JSON.stringify(actualData));
-    if (retData && typeof retData.response === 'string') {
-      try {
-        const parsed = JSON.parse(retData.response);
-        retData.response = parsed;
-      } catch (e) {
-        // ignore parse error
-      }
-    }
     // if we are scrubbing an array
     if (Array.isArray(retData)) {
+      // if the array of data is too large we can not do a deep dive due to time it might take
+      if (retData.length > maxArraySize) {
+        log.debug(`${origin}: Masking entire array, too large (${retData.length}) to search effectively`);
+        return '** masked **';
+      }
+
       // need to go through each item in the array
       for (let i = 0; i < retData.length; i += 1) {
         retData[i] = this.scrubSensitiveInfo(retData[i], addItems);
@@ -1252,17 +1261,30 @@ class AdapterPropertyUtil {
 
     // if we are scrubbing an object (or string that has been parsed)
     if (typeof retData === 'object') {
+      const objectKeys = Object.keys(retData);
+      // if the object of data is too large we can not do a deep dive due to time it might take
+      if (objectKeys.length > maxObjectSize) {
+        log.debug(`${origin}: Masking entire object, too large (${objectKeys.length}) to search effectively`);
+        return '** masked **';
+      }
+
       // go through each item in the object
-      Object.keys(retData).forEach((key) => {
+      objectKeys.forEach((key) => {
         // go deep through an object with recursive call
         if (typeof retData[key] === 'object') {
           if (Array.isArray(retData[key])) {
-            // Handle arrays that may contain sensitive info
-            for (let k = 0; k < retData[key].length; k += 1) {
-              if (sensList.includes(key.toLowerCase())) {
-                retData[key][k] = '** masked **';
-              } else {
-                retData[key][k] = this.scrubSensitiveInfo(retData[key][k], addItems);
+            // if the array of data is too large we can not do a deep dive due to time it might take
+            if (retData[key].length > maxArraySize) {
+              log.debug(`${origin}: Masking entire array, too large (${retData[key].length}) to search effectively`);
+              retData[key] = '** masked **';
+            } else {
+              // Handle arrays that may contain sensitive info
+              for (let k = 0; k < retData[key].length; k += 1) {
+                if (sensList.includes(key.toLowerCase())) {
+                  retData[key][k] = '** masked **';
+                } else {
+                  retData[key][k] = this.scrubSensitiveInfo(retData[key][k], addItems);
+                }
               }
             }
           } else {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@itentialopensource/adapter-utils",
-  "version": "5.10.19",
+  "version": "5.10.21",
   "description": "Itential Adapter Utility Libraries",
   "scripts": {
     "postinstall": "node utils/setup.js",
@@ -31,7 +31,7 @@
     "cookie": "^0.7.1",
     "crypto-js": "^4.1.1",
     "ejs": "^3.1.10",
-    "form-data": "^4.0.0",
+    "form-data": "^4.0.4",
     "fs-extra": "^11.2.0",
     "https-proxy-agent": "^7.0.0",
     "json-query": "^2.2.2",