@itentialopensource/adapter-servicenow 2.9.2 → 2.9.3

package/CHANGELOG.md

@@ -1,4 +1,12 @@
 
+## 2.9.3 [09-17-2024]
+
+* add workshop and fix vulnerabilities
+
+See merge request itentialopensource/adapters/adapter-servicenow!40
+
+---
+
 ## 2.9.2 [08-15-2024]
 
 * Changes made at 2024.08.14_19:49PM

package/TAB2.md

@@ -67,7 +67,7 @@ Sample Properties can be used to help you configure the adapter in the Itential
       "auth_method": "basic user_password",
       "username": "username",
       "password": "password",
-      "token": "",
+      "token": "token",
       "token_timeout": 180000,
       "token_cache": "local",
       "invalid_token_error": 401,

package/metadata.json

@@ -1,8 +1,10 @@
 {
   "name": "adapter-servicenow",
   "webName": "Adapter for Integration to ServiceNow",
+  "supportLevel": "certified",
   "vendor": "ServiceNow",
   "product": "IT Service Management",
+  "techAlliance": true,
   "osVersions": [
     "San Diego",
     "Tokyo",
@@ -44,7 +46,7 @@
     "storeLink": "",
     "npmLink": "https://www.npmjs.com/package/@itentialopensource/adapter-servicenow",
     "repoLink": "https://gitlab.com/itentialopensource/adapters/adapter-servicenow",
-    "docLink": "https://docs.itential.com/opensource/docs/servicenow",
+    "docLink": "https://gitlab.com/itentialopensource/adapters/adapter-servicenow/-/blob/master/README.md?ref_type=heads",
     "demoLinks": [
       {
         "title": "Getting Real (Time) with Automating Network Change Management With ServiceNow",
@@ -52,7 +54,7 @@
       },
       {
         "title": "Integrating ServiceNow CMDB as a Source Of Truth to Drive Network Automation with Itential",
-        "link": "https://www.itential.com/resource/demo/integrating-servicenow-cmdb-as-a-source-of-truth-to-drive-network-automation-with-itential-2/"
+        "link": "https://www.itential.com/resource/demo/integrating-servicenow-cmdb-as-a-source-of-truth-to-drive-network-automation-with-itential/"
       },
       {
         "title": "INTEGRATION - Itential + ServiceNow",
@@ -93,7 +95,14 @@
         "public": true
       }
     ],
-    "workshopLinks": [],
+    "workshopLinks": [
+      {
+        "title": "Create/Update Change Request"
+      },
+      {
+        "title": "Create/Update Incident"
+      }
+    ],
     "workshopHomePage": "https://www.itential.com/get-started/"
   },
   "assets": [],
@@ -130,7 +139,5 @@
     ],
     "transformationProjects": [],
     "exampleProjects": []
-  },
-  "supportLevel": "community",
-  "techAlliance": false
+  }
 }

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@itentialopensource/adapter-servicenow",
-  "version": "2.9.2",
+  "version": "2.9.3",
   "description": "This adapter integrates with system described as: servicenowMadrid.",
   "main": "adapter.js",
   "systemName": "ServiceNow",
   "wizardVersion": "2.44.7",
-  "engineVersion": "1.67.19",
+  "engineVersion": "1.68.2",
   "adapterType": "http",
   "scripts": {
     "artifactize": "npm i && node utils/packModificationScript.js",
@@ -54,7 +54,7 @@
   "author": "Itential",
   "homepage": "https://gitlab.com/itentialopensource/adapters/adapter-servicenow#readme",
   "dependencies": {
-    "@itentialopensource/adapter-utils": "^5.6.0",
+    "@itentialopensource/adapter-utils": "^5.8.0",
     "acorn": "^8.12.1",
     "ajv": "^8.17.1",
     "axios": "^1.7.4",
@@ -69,7 +69,7 @@
     "prompts": "^2.4.2",
     "readline-sync": "^1.4.10",
     "semver": "^7.6.3",
-    "winston": "^3.13.1"
+    "winston": "^3.14.2"
   },
   "devDependencies": {
     "chai": "^4.3.7",

package/report/adapterInfo.json

@@ -1,10 +1,10 @@
 {
-  "version": "2.8.7",
+  "version": "2.9.2",
   "configLines": 8406,
   "scriptLines": 1783,
   "codeLines": 12921,
-  "testLines": 11858,
-  "testCases": 613,
-  "totalCodeLines": 26562,
+  "testLines": 11842,
+  "testCases": 612,
+  "totalCodeLines": 26546,
   "wfTasks": 165
 }

package/sampleProperties.json

@@ -17,7 +17,7 @@
       "auth_method": "basic user_password",
       "username": "username",
       "password": "password",
-      "token": "",
+      "token": "token",
       "token_timeout": 180000,
       "token_cache": "local",
       "invalid_token_error": 401,
@@ -136,7 +136,7 @@
             "ostypePrefix": "meraki-",
             "port": "{port}",
             "ipaddress": "{ip_addr}",
-            "serial" : "{serial}"
+            "serial": "{serial}"
           }
         }
       ],
@@ -162,7 +162,7 @@
             "ostypePrefix": "meraki-",
             "port": "{port}",
             "ipaddress": "{ip_addr}",
-            "serial" : "{serial}",
+            "serial": "{serial}",
             "id": "{myid}"
           }
         }
@@ -246,7 +246,7 @@
                 "ostypePrefix": "meraki-",
                 "port": "{port}",
                 "ipaddress": "{ip_addr}",
-                "serial" : "{serial}",
+                "serial": "{serial}",
                 "id": "{myid}"
               }
             }

package/test/integration/adapterTestConnectivity.js

@@ -4,7 +4,6 @@
 /* eslint no-unused-vars: warn */
 
 const assert = require('assert');
-const http = require('http');
 const https = require('https');
 const mocha = require('mocha');
 const ping = require('ping');
@@ -53,29 +52,6 @@ describe('[integration] Adapter Test', () => {
         });
     });
 
-    it('Support HTTP on port 80', (done) => {
-      const requestOptions = {
-        host,
-        port: 80,
-        method: 'HEAD'
-      };
-
-      const req = http.request(requestOptions, (res) => {
-        try {
-          assert.ok(res.statusCode >= 200 && res.statusCode < 400);
-          done();
-        } catch (error) {
-          done(error);
-        }
-      });
-
-      req.on('error', (err) => {
-        done(err);
-      });
-
-      req.end();
-    });
-
     it('Support HTTPS on port 443', (done) => {
       const requestOptions = {
         host,

package/test/integration/adapterTestIntegration.js

@@ -36,13 +36,17 @@ const samProps = require(`${adaptdir}/sampleProperties.json`).properties;
 // these variables can be changed to run in integrated mode so easier to set them here
 // always check these in with bogus data!!!
 samProps.stub = true;
-samProps.host = 'replace.hostorip.here';
-samProps.authentication.username = 'username';
-samProps.authentication.password = 'password';
-samProps.protocol = 'http';
-samProps.port = 80;
-samProps.ssl.enabled = false;
-samProps.ssl.accept_invalid_cert = false;
+
+// uncomment if connecting
+// samProps.host = 'replace.hostorip.here';
+// samProps.authentication.username = 'username';
+// samProps.authentication.password = 'password';
+// samProps.authentication.token = 'password';
+// samProps.protocol = 'http';
+// samProps.port = 80;
+// samProps.ssl.enabled = false;
+// samProps.ssl.accept_invalid_cert = false;
+
 if (samProps.request.attempt_timeout < 30000) {
   samProps.request.attempt_timeout = 30000;
 }
@@ -2504,7 +2508,7 @@ describe('[integration] Servicenow Adapter Test', () => {
 
     const usersCreateUsersBodyParam = {
       username: `IAP${randExt}`,
-      password: 'metemp'
+      password: samProps.authentication.password
     };
     let usersId = '02826bf03710200044e0bfc8bcbe5d3f';
     const usersUpdateUsersBodyParam = { name: 'IAP TESTER' };

package/test/unit/adapterTestUnit.js

@@ -36,13 +36,17 @@ const samProps = require(`${adaptdir}/sampleProperties.json`).properties;
 // these variables can be changed to run in integrated mode so easier to set them here
 // always check these in with bogus data!!!
 samProps.stub = true;
-samProps.host = 'replace.hostorip.here';
-samProps.authentication.username = 'username';
-samProps.authentication.password = 'password';
-samProps.protocol = 'http';
-samProps.port = 80;
-samProps.ssl.enabled = false;
-samProps.ssl.accept_invalid_cert = false;
+
+// uncomment if connecting
+// samProps.host = 'replace.hostorip.here';
+// samProps.authentication.username = 'username';
+// samProps.authentication.password = 'password';
+// samProps.authentication.token = 'password';
+// samProps.protocol = 'http';
+// samProps.port = 80;
+// samProps.ssl.enabled = false;
+// samProps.ssl.accept_invalid_cert = false;
+
 samProps.request.attempt_timeout = 1200000;
 const attemptTimeout = samProps.request.attempt_timeout;
 const { stub } = samProps;
@@ -323,7 +327,7 @@ describe('[unit] Servicenow Adapter Test', () => {
           assert.equal('^0.4.4', packageDotJson.dependencies.ping);
           assert.equal('^1.4.10', packageDotJson.dependencies['readline-sync']);
           assert.equal('^7.6.3', packageDotJson.dependencies.semver);
-          assert.equal('^3.13.1', packageDotJson.dependencies.winston);
+          assert.equal('^3.14.2', packageDotJson.dependencies.winston);
           done();
         } catch (error) {
           log.error(`Test Failure: ${error}`);
@@ -561,7 +565,7 @@ describe('[unit] Servicenow Adapter Test', () => {
           log.error(`Adapter Exception: ${error}`);
           done(error);
         }
-      });
+      }).timeout(attemptTimeout);
     });
 
     describe('propertiesSchema.json', () => {
@@ -6111,7 +6115,7 @@ describe('[unit] Servicenow Adapter Test', () => {
       }).timeout(attemptTimeout);
       it('should error on create a user - no username', (done) => {
         try {
-          const ubody = { password: 'badbody' };
+          const ubody = { password: samProps.authentication.password };
           a.createUsers(ubody, (data, error) => {
             try {
               const displayE = 'Schema validation failed on must have required property \'username\'';

package/compliance-report.json

@@ -1,9 +0,0 @@
-{
-  "ComplianceEntries": [
-    {
-      "name": "Compliance Summary",
-      "numInvalidProjects": 0,
-      "numValidProjects": 0
-    }
-  ]
-}

package/compliance-report.txt

@@ -1,5 +0,0 @@
----------------------------------------------------------------------------------------------
-**** Project Compliance Summary ****
-0 project(s) are not valid
-0 project(s) are valid
----------------------------------------------------------------------------------------------