@itentialopensource/adapter-infoblox 1.14.0 → 1.14.1

package/CHANGELOG.md

@@ -1,4 +1,12 @@
 
+## 1.14.1 [11-06-2023]
+
+* Add empty response handling in some tasks
+
+See merge request itentialopensource/adapters/inventory/adapter-infoblox!33
+
+---
+
 ## 1.14.0 [11-06-2023]
 
 * More migration changes

package/adapter.js

@@ -1531,6 +1531,12 @@ class Infoblox extends AdapterBaseCl {
         if (err) {
           return callback(null, err);
         }
+        if (results.response.length === 0) {
+          const errorObj = this.requestHandlerInst.formatErrorObject(this.id, meth, 'Auth zone not found', [], null, null, null);
+          errorObj.IAPerror.recommendation = 'Make sure the auth zone exists';
+          log.error(`${origin}: ${errorObj.IAPerror.displayString}`);
+          return callback(null, errorObj);
+        }
         let ncKey = results.response[0]._ref;
         const networkPath = 'zone_auth/';
         if (ncKey !== null && ncKey.indexOf(networkPath) === 0) {
@@ -1616,6 +1622,12 @@ class Infoblox extends AdapterBaseCl {
         if (err) {
           return callback(null, err);
         }
+        if (results.response.length === 0) {
+          const errorObj = this.requestHandlerInst.formatErrorObject(this.id, meth, 'Network container not found', [], null, null, null);
+          errorObj.IAPerror.recommendation = 'Make sure the network container exists';
+          log.error(`${origin}: ${errorObj.IAPerror.displayString}`);
+          return callback(null, errorObj);
+        }
         let ncKey = results.response[0]._ref;
         // log.error(ncKey);
         const networkPath = 'networkcontainer/';
@@ -1700,7 +1712,14 @@ class Infoblox extends AdapterBaseCl {
         if (err) {
           return callback(null, err);
         }
-        let ncKey = results.response._ref;
+        if (results.response.length === 0) {
+          const errorObj = this.requestHandlerInst.formatErrorObject(this.id, meth, 'Network not found', [], null, null, null);
+          errorObj.IAPerror.recommendation = 'Make sure the network exists';
+          log.error(`${origin}: ${errorObj.IAPerror.displayString}`);
+          return callback(null, errorObj);
+        }
+        let ncKey = results.response[0]._ref;
+
         // log.error(ncKey);
         const networkPath = 'network/';
         if (ncKey !== null && ncKey.indexOf(networkPath) === 0) {
@@ -2023,6 +2042,12 @@ class Infoblox extends AdapterBaseCl {
           if (err) {
             return callback(null, err);
           }
+          if (results.response.length === 0) {
+            const errorObj = this.requestHandlerInst.formatErrorObject(this.id, meth, 'Network not found', [], null, null, null);
+            errorObj.IAPerror.recommendation = 'Make sure the network exists';
+            log.error(`${origin}: ${errorObj.IAPerror.displayString}`);
+            return callback(null, errorObj);
+          }
           return this.getNextAvailableIps(results.response[0]._ref, number, callback);
         });
       }
@@ -3352,10 +3377,19 @@ class Infoblox extends AdapterBaseCl {
    *                                 (entities) or the error
    */
   assignNextIP2(networkIP, hostName, comment, callback) {
+    const meth = 'adapter-assignNextIP2';
+    const origin = `${this.id}-${meth}`;
+    log.trace(origin);
     return this.getNetworkKeyByIP(networkIP, (results, err) => {
       if (err) {
         return callback(null, err);
       }
+      if (results.response.length === 0) {
+        const errorObj = this.requestHandlerInst.formatErrorObject(this.id, meth, 'Network not found', [], null, null, null);
+        errorObj.IAPerror.recommendation = 'Make sure the network exists';
+        log.error(`${origin}: ${errorObj.IAPerror.displayString}`);
+        return callback(null, errorObj);
+      }
       return this.getNextAvailableIp(results.response[0]._ref, (resultIp, errIp) => {
         if (errIp) {
           return callback(null, errIp);

package/entities/Networks/mockdatafiles/getNetworkDetails.json

@@ -1,6 +1,8 @@
-{
-  "_ref": "network/ZG5zLm5ldHdvcmskMy4xLjEuMC8yNC8w:3.1.1.0/24/default",
-  "comment": "For test purpose",
-  "network": "3.1.1.0/24",
-  "network_view": "default"
-}
+[
+  {
+    "_ref": "network/ZG5zLm5ldHdvcmskMy4xLjEuMC8yNC8w:3.1.1.0/24/default",
+    "comment": "For test purpose",
+    "network": "3.1.1.0/24",
+    "network_view": "default"
+  }
+]

package/entities/Networks/responseSchema.json

@@ -242,7 +242,7 @@
       "external_name": "response"
     },
     "result": {
-      "type": "string",
+      "type": ["string", "array"],
       "description": "",
       "parse": false,
       "encode": false,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@itentialopensource/adapter-infoblox",
-  "version": "1.14.0",
+  "version": "1.14.1",
   "description": "Itential Infoblox Adapter",
   "main": "adapter.js",
   "systemName": "Infoblox",

package/pronghorn.json

@@ -7547,8 +7547,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -7699,8 +7698,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -7821,8 +7819,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -7929,8 +7926,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -8059,8 +8055,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -8175,8 +8170,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -8297,8 +8291,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -8405,8 +8398,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -8555,8 +8547,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -8691,8 +8682,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -8823,9 +8813,9 @@
           "info": "Enter the request body here: }",
           "required": true,
           "schema": {
+            "title": "body",
             "type": "object",
-            "properties": {},
-            "definitions": {}
+            "properties": {}
           }
         }
       ],
@@ -9464,8 +9454,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -9640,9 +9629,9 @@
           "info": "Enter the request body here: }",
           "required": true,
           "schema": {
+            "title": "body",
             "type": "object",
-            "properties": {},
-            "definitions": {}
+            "properties": {}
           }
         }
       ],
@@ -10494,8 +10483,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -10630,8 +10618,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -10760,8 +10747,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -10876,8 +10862,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -11006,8 +10991,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -11122,8 +11106,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -11252,8 +11235,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -11368,8 +11350,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -11498,8 +11479,7 @@
                 "type": "string",
                 "example": "[{'name': 'string', 'stealth': 'bool', 'grid_replicate': 'bool', 'lead': 'bool', 'preferred_primaries': 'extserver', 'enable_preferred_primaries': 'bool'}]"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -11614,8 +11594,7 @@
                 "type": "string",
                 "example": "[{'name': 'string', 'stealth': 'bool', 'grid_replicate': 'bool', 'lead': 'bool', 'preferred_primaries': 'extserver', 'enable_preferred_primaries': 'bool'}]"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -11836,8 +11815,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -11990,8 +11968,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -12130,8 +12107,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -12300,8 +12276,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -12456,8 +12431,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -12774,8 +12748,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -12918,8 +12891,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -13446,8 +13418,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -13656,8 +13627,7 @@
                 "type": "string",
                 "example": "uint"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -13808,8 +13778,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -13990,8 +13959,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -14154,8 +14122,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -14300,8 +14267,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -14846,8 +14812,7 @@
                 "type": "string",
                 "example": "uint"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -15008,8 +14973,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -15156,8 +15120,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -15338,8 +15301,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -15496,8 +15458,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -15640,8 +15601,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -15766,8 +15726,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -15878,8 +15837,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -16012,8 +15970,7 @@
                 "type": "string",
                 "example": "['NXDOMAIN', 'BLACKLIST']"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -16132,8 +16089,7 @@
                 "type": "string",
                 "example": "['NXDOMAIN', 'BLACKLIST']"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -16356,8 +16312,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -16488,8 +16443,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -16634,8 +16588,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -16766,8 +16719,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -16912,8 +16864,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -17044,8 +16995,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -17194,8 +17144,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -17330,8 +17279,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -17488,8 +17436,7 @@
                 "type": "string",
                 "example": "uint"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -17632,8 +17579,7 @@
                 "type": "string",
                 "example": "uint"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -17778,8 +17724,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -17910,8 +17855,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -18048,8 +17992,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -18172,8 +18115,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -18560,8 +18502,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -18658,9 +18599,9 @@
           "info": "Enter the request body here: }",
           "required": true,
           "schema": {
+            "title": "body",
             "type": "object",
-            "properties": {},
-            "definitions": {}
+            "properties": {}
           }
         }
       ],
@@ -19035,8 +18976,7 @@
                 "type": "string",
                 "example": "bool"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -19493,8 +19433,7 @@
                 "type": "string",
                 "example": "['FORWARD', 'IPV4', 'IPV6']"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -19885,8 +19824,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -20061,9 +19999,9 @@
           "info": "Enter the request body here: }",
           "required": true,
           "schema": {
+            "title": "body",
             "type": "object",
-            "properties": {},
-            "definitions": {}
+            "properties": {}
           }
         }
       ],
@@ -20180,8 +20118,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -20312,9 +20249,9 @@
           "info": "Enter the request body here: }",
           "required": true,
           "schema": {
+            "title": "body",
             "type": "object",
-            "properties": {},
-            "definitions": {}
+            "properties": {}
           }
         }
       ],
@@ -20435,8 +20372,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -20567,9 +20503,9 @@
           "info": "Enter the request body here: }",
           "required": true,
           "schema": {
+            "title": "body",
             "type": "object",
-            "properties": {},
-            "definitions": {}
+            "properties": {}
           }
         }
       ],
@@ -20806,8 +20742,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -20984,8 +20919,7 @@
                 "type": "string",
                 "example": "['FORWARD', 'IPV4', 'IPV6']"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],
@@ -21082,9 +21016,9 @@
           "info": "Enter the request body here: }",
           "required": true,
           "schema": {
+            "title": "body",
             "type": "object",
-            "properties": {},
-            "definitions": {}
+            "properties": {}
           }
         }
       ],
@@ -21205,8 +21139,7 @@
                 "type": "string",
                 "example": "string"
               }
-            },
-            "definitions": {}
+            }
           }
         }
       ],

package/report/adapterInfo.json

@@ -1,10 +1,10 @@
 {
-  "version": "1.13.2",
-  "configLines": 23235,
+  "version": "1.14.0",
+  "configLines": 23168,
   "scriptLines": 1783,
-  "codeLines": 29937,
+  "codeLines": 29971,
   "testLines": 22931,
   "testCases": 1141,
-  "totalCodeLines": 54651,
+  "totalCodeLines": 54685,
   "wfTasks": 407
 }