@itentialopensource/adapter-att_mobility 0.1.2 → 0.2.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.eslintignore +0 -1
- package/.jshintrc +3 -0
- package/AUTH.md +11 -14
- package/BROKER.md +3 -3
- package/CALLS.md +59 -23
- package/CHANGELOG.md +8 -0
- package/CONTRIBUTING.md +1 -160
- package/ENHANCE.md +4 -4
- package/PROPERTIES.md +19 -19
- package/README.md +45 -36
- package/SUMMARY.md +2 -2
- package/SYSTEMINFO.md +9 -4
- package/TROUBLESHOOT.md +6 -6
- package/adapter.js +159 -330
- package/adapterBase.js +538 -873
- package/changelogs/changelog.md +16 -0
- package/metadata.json +50 -0
- package/package.json +24 -26
- package/pronghorn.json +474 -142
- package/propertiesSchema.json +447 -43
- package/refs?service=git-upload-pack +0 -0
- package/report/adapter-openapi.json +149 -0
- package/report/adapter-openapi.yaml +133 -0
- package/report/adapterInfo.json +8 -8
- package/report/updateReport1691508426658.json +120 -0
- package/report/updateReport1692202905234.json +120 -0
- package/report/updateReport1694465385247.json +120 -0
- package/sampleProperties.json +64 -3
- package/test/integration/adapterTestBasicGet.js +1 -1
- package/test/integration/adapterTestConnectivity.js +91 -42
- package/test/integration/adapterTestIntegration.js +142 -17
- package/test/unit/adapterBaseTestUnit.js +388 -313
- package/test/unit/adapterTestUnit.js +320 -123
- package/utils/adapterInfo.js +1 -1
- package/utils/addAuth.js +1 -1
- package/utils/artifactize.js +1 -1
- package/utils/checkMigrate.js +1 -1
- package/utils/entitiesToDB.js +1 -0
- package/utils/findPath.js +1 -1
- package/utils/methodDocumentor.js +57 -22
- package/utils/modify.js +13 -15
- package/utils/packModificationScript.js +1 -1
- package/utils/taskMover.js +309 -0
- package/utils/tbScript.js +3 -10
- package/utils/tbUtils.js +2 -3
- package/utils/testRunner.js +1 -1
- package/utils/troubleshootingAdapter.js +1 -3
- package/workflows/README.md +0 -3
package/.eslintignore
CHANGED
package/.jshintrc
CHANGED
package/AUTH.md
CHANGED
|
@@ -1,31 +1,27 @@
|
|
|
1
|
-
## Authenticating
|
|
1
|
+
## Authenticating ATT Mobility Adapter
|
|
2
2
|
|
|
3
|
-
This document will go through the steps for authenticating the
|
|
3
|
+
This document will go through the steps for authenticating the ATT Mobility adapter with the authentication methods we have worked with in the past. Properly configuring the properties for an adapter in IAP is critical for getting the adapter online. You can read more about adapter authentication <a href="https://docs.itential.com/opensource/docs/authentication" target="_blank">HERE</a>.
|
|
4
|
+
|
|
5
|
+
Companies periodically change authentication methods to provide better security. As this happens this section should be updated and contributed/merge back into the adapter repository.
|
|
4
6
|
|
|
5
7
|
### Basic Authentication
|
|
6
|
-
The
|
|
8
|
+
The ATT Mobility adapter authenticates with a basic authentication.
|
|
7
9
|
|
|
8
10
|
STEPS
|
|
9
|
-
1. Ensure you have access to a
|
|
11
|
+
1. Ensure you have access to a ATT Mobility server and that it is running
|
|
10
12
|
2. Follow the steps in the README.md to import the adapter into IAP if you have not already done so
|
|
11
13
|
3. Use the properties below for the ```properties.authentication``` field
|
|
12
14
|
```json
|
|
13
15
|
"authentication": {
|
|
14
16
|
"auth_method": "basic user_password",
|
|
15
|
-
"username": "<username>",
|
|
16
|
-
"password": "<password>",
|
|
17
|
-
"token": "",
|
|
18
|
-
"token_timeout": 1800000,
|
|
19
|
-
"token_cache": "local",
|
|
20
|
-
"invalid_token_error": 401,
|
|
17
|
+
"username": "<your username>",
|
|
18
|
+
"password": "<your password>",
|
|
21
19
|
"auth_field": "header.headers.Authorization",
|
|
22
20
|
"auth_field_format": "Basic {b64}{username}:{password}{/b64}",
|
|
23
|
-
"auth_logging": false
|
|
24
|
-
"client_id": "",
|
|
25
|
-
"client_secret": "",
|
|
26
|
-
"grant_type": ""
|
|
21
|
+
"auth_logging": false
|
|
27
22
|
}
|
|
28
23
|
```
|
|
24
|
+
you can leave all of the other properties in the authentication section, they will not be used when the auth_method is basic user_password.
|
|
29
25
|
4. Restart the adapter. If your properties were set correctly, the adapter should go online.
|
|
30
26
|
|
|
31
27
|
### Troubleshooting
|
|
@@ -36,4 +32,5 @@ STEPS
|
|
|
36
32
|
- The FULL REQUEST log to make sure the proper headers are being sent with the request.
|
|
37
33
|
- The FULL BODY log to make sure the payload is accurate.
|
|
38
34
|
- The CALL RETURN log to see what the other system is telling us.
|
|
35
|
+
- Credentials should be ** masked ** by the adapter so make sure you verify the username and password - including that there are erroneous spaces at the front or end.
|
|
39
36
|
- Remember when you are done to turn auth_logging off as you do not want to log credentials.
|
package/BROKER.md
CHANGED
|
@@ -1,9 +1,9 @@
|
|
|
1
|
-
## Integrating
|
|
1
|
+
## Integrating AttMobility Adapter with IAP Device Broker
|
|
2
2
|
|
|
3
|
-
This document will go through the steps for integrating the
|
|
3
|
+
This document will go through the steps for integrating the AttMobility adapter with IAP's Device Broker. IAP Device Broker integration allows for easier interation into several of IAPs applications (e.g. Configuration Manager). Properly configuring the properties for the adapter in IAP is critical for getting the device broker integration to work. Their is additional information in the configuration section of the adapter readme. This document will go through each of the calls that are utilized by the Device Broker.
|
|
4
4
|
|
|
5
5
|
### getDevicesFiltered
|
|
6
|
-
getDevicesFiltered(options, callback) → This call returns all of the devices within
|
|
6
|
+
getDevicesFiltered(options, callback) → This call returns all of the devices within AttMobility that match the provided filter.
|
|
7
7
|
|
|
8
8
|
#### input
|
|
9
9
|
|
package/CALLS.md
CHANGED
|
@@ -19,7 +19,7 @@ These are adapter methods that IAP or you might use. There are some other method
|
|
|
19
19
|
</tr>
|
|
20
20
|
<tr>
|
|
21
21
|
<td style="padding:15px">healthCheck(callback)</td>
|
|
22
|
-
<td style="padding:15px">This call ensures that the adapter can communicate with
|
|
22
|
+
<td style="padding:15px">This call ensures that the adapter can communicate with Adapter for AT&T Mobility. The actual call that is used is defined in the adapter properties and .system entities action.json file.</td>
|
|
23
23
|
<td style="padding:15px">No</td>
|
|
24
24
|
</tr>
|
|
25
25
|
<tr>
|
|
@@ -29,7 +29,7 @@ These are adapter methods that IAP or you might use. There are some other method
|
|
|
29
29
|
</tr>
|
|
30
30
|
<tr>
|
|
31
31
|
<td style="padding:15px">encryptProperty(property, technique, callback)</td>
|
|
32
|
-
<td style="padding:15px">This call will take the provided property and technique, and return the property encrypted with the technique. This allows the property to be used in the adapterProps section for the credential password so that the password does not have to be in clear text. The adapter will decrypt the property as needed for communications with
|
|
32
|
+
<td style="padding:15px">This call will take the provided property and technique, and return the property encrypted with the technique. This allows the property to be used in the adapterProps section for the credential password so that the password does not have to be in clear text. The adapter will decrypt the property as needed for communications with Adapter for AT&T Mobility.</td>
|
|
33
33
|
<td style="padding:15px">No</td>
|
|
34
34
|
</tr>
|
|
35
35
|
<tr>
|
|
@@ -37,11 +37,6 @@ These are adapter methods that IAP or you might use. There are some other method
|
|
|
37
37
|
<td style="padding:15px">This call provides the ability to update the adapter configuration from IAP - includes actions, schema, mockdata and other configurations.</td>
|
|
38
38
|
<td style="padding:15px">Yes</td>
|
|
39
39
|
</tr>
|
|
40
|
-
<tr>
|
|
41
|
-
<td style="padding:15px">iapFindAdapterPath(apiPath, callback)</td>
|
|
42
|
-
<td style="padding:15px">This call provides the ability to see if a particular API path is supported by the adapter.</td>
|
|
43
|
-
<td style="padding:15px">Yes</td>
|
|
44
|
-
</tr>
|
|
45
40
|
<tr>
|
|
46
41
|
<td style="padding:15px">iapSuspendAdapter(mode, callback)</td>
|
|
47
42
|
<td style="padding:15px">This call provides the ability to suspend the adapter and either have requests rejected or put into a queue to be processed after the adapter is resumed.</td>
|
|
@@ -57,12 +52,16 @@ These are adapter methods that IAP or you might use. There are some other method
|
|
|
57
52
|
<td style="padding:15px">This call will return the requests that are waiting in the queue if throttling is enabled.</td>
|
|
58
53
|
<td style="padding:15px">Yes</td>
|
|
59
54
|
</tr>
|
|
55
|
+
<tr>
|
|
56
|
+
<td style="padding:15px">iapFindAdapterPath(apiPath, callback)</td>
|
|
57
|
+
<td style="padding:15px">This call provides the ability to see if a particular API path is supported by the adapter.</td>
|
|
58
|
+
<td style="padding:15px">Yes</td>
|
|
59
|
+
</tr>
|
|
60
60
|
<tr>
|
|
61
61
|
<td style="padding:15px">iapTroubleshootAdapter(props, persistFlag, adapter, callback)</td>
|
|
62
62
|
<td style="padding:15px">This call can be used to check on the performance of the adapter - it checks connectivity, healthcheck and basic get calls.</td>
|
|
63
63
|
<td style="padding:15px">Yes</td>
|
|
64
64
|
</tr>
|
|
65
|
-
|
|
66
65
|
<tr>
|
|
67
66
|
<td style="padding:15px">iapRunAdapterHealthcheck(adapter, callback)</td>
|
|
68
67
|
<td style="padding:15px">This call will return the results of a healthcheck.</td>
|
|
@@ -83,6 +82,21 @@ These are adapter methods that IAP or you might use. There are some other method
|
|
|
83
82
|
<td style="padding:15px">This call will push the adapter configuration from the entities directory into the Adapter or IAP Database.</td>
|
|
84
83
|
<td style="padding:15px">Yes</td>
|
|
85
84
|
</tr>
|
|
85
|
+
<tr>
|
|
86
|
+
<td style="padding:15px">iapDeactivateTasks(tasks, callback)</td>
|
|
87
|
+
<td style="padding:15px">This call provides the ability to remove tasks from the adapter.</td>
|
|
88
|
+
<td style="padding:15px">Yes</td>
|
|
89
|
+
</tr>
|
|
90
|
+
<tr>
|
|
91
|
+
<td style="padding:15px">iapActivateTasks(tasks, callback)</td>
|
|
92
|
+
<td style="padding:15px">This call provides the ability to add deactivated tasks back into the adapter.</td>
|
|
93
|
+
<td style="padding:15px">Yes</td>
|
|
94
|
+
</tr>
|
|
95
|
+
<tr>
|
|
96
|
+
<td style="padding:15px">iapExpandedGenericAdapterRequest(metadata, uriPath, restMethod, pathVars, queryData, requestBody, addlHeaders, callback)</td>
|
|
97
|
+
<td style="padding:15px">This is an expanded Generic Call. The metadata object allows us to provide many new capabilities within the generic request.</td>
|
|
98
|
+
<td style="padding:15px">Yes</td>
|
|
99
|
+
</tr>
|
|
86
100
|
<tr>
|
|
87
101
|
<td style="padding:15px">genericAdapterRequest(uriPath, restMethod, queryData, requestBody, addlHeaders, callback)</td>
|
|
88
102
|
<td style="padding:15px">This call allows you to provide the path to have the adapter call. It is an easy way to incorporate paths that have not been built into the adapter yet.</td>
|
|
@@ -94,19 +108,42 @@ These are adapter methods that IAP or you might use. There are some other method
|
|
|
94
108
|
<td style="padding:15px">Yes</td>
|
|
95
109
|
</tr>
|
|
96
110
|
<tr>
|
|
97
|
-
<td style="padding:15px">
|
|
98
|
-
<td style="padding:15px">
|
|
99
|
-
<td style="padding:15px">
|
|
111
|
+
<td style="padding:15px">iapRunAdapterLint(callback)</td>
|
|
112
|
+
<td style="padding:15px">Runs lint on the addapter and provides the information back.</td>
|
|
113
|
+
<td style="padding:15px">Yes</td>
|
|
100
114
|
</tr>
|
|
101
115
|
<tr>
|
|
102
|
-
<td style="padding:15px">
|
|
103
|
-
<td style="padding:15px">
|
|
104
|
-
<td style="padding:15px">
|
|
116
|
+
<td style="padding:15px">iapRunAdapterTests(callback)</td>
|
|
117
|
+
<td style="padding:15px">Runs baseunit and unit tests on the adapter and provides the information back.</td>
|
|
118
|
+
<td style="padding:15px">Yes</td>
|
|
105
119
|
</tr>
|
|
106
120
|
<tr>
|
|
107
|
-
<td style="padding:15px">
|
|
108
|
-
<td style="padding:15px">This call
|
|
109
|
-
<td style="padding:15px">
|
|
121
|
+
<td style="padding:15px">iapGetAdapterInventory(callback)</td>
|
|
122
|
+
<td style="padding:15px">This call provides some inventory related information about the adapter.</td>
|
|
123
|
+
<td style="padding:15px">Yes</td>
|
|
124
|
+
</tr>
|
|
125
|
+
</table>
|
|
126
|
+
<br>
|
|
127
|
+
|
|
128
|
+
### Adapter Cache Calls
|
|
129
|
+
|
|
130
|
+
These are adapter methods that are used for adapter caching. If configured, the adapter will cache based on the interval provided. However, you can force a population of the cache manually as well.
|
|
131
|
+
|
|
132
|
+
<table border="1" class="bordered-table">
|
|
133
|
+
<tr>
|
|
134
|
+
<th bgcolor="lightgrey" style="padding:15px"><span style="font-size:12.0pt">Method Signature</span></th>
|
|
135
|
+
<th bgcolor="lightgrey" style="padding:15px"><span style="font-size:12.0pt">Description</span></th>
|
|
136
|
+
<th bgcolor="lightgrey" style="padding:15px"><span style="font-size:12.0pt">Workflow?</span></th>
|
|
137
|
+
</tr>
|
|
138
|
+
<tr>
|
|
139
|
+
<td style="padding:15px">iapPopulateEntityCache(entityTypes, callback)</td>
|
|
140
|
+
<td style="padding:15px">This call populates the adapter cache.</td>
|
|
141
|
+
<td style="padding:15px">Yes</td>
|
|
142
|
+
</tr>
|
|
143
|
+
<tr>
|
|
144
|
+
<td style="padding:15px">iapRetrieveEntitiesCache(entityType, options, callback)</td>
|
|
145
|
+
<td style="padding:15px">This call retrieves the specific items from the adapter cache.</td>
|
|
146
|
+
<td style="padding:15px">Yes</td>
|
|
110
147
|
</tr>
|
|
111
148
|
</table>
|
|
112
149
|
<br>
|
|
@@ -129,32 +166,31 @@ These are adapter methods that are used to integrate to IAP Brokers. This adapte
|
|
|
129
166
|
<tr>
|
|
130
167
|
<td style="padding:15px">getDevice(deviceName, callback)</td>
|
|
131
168
|
<td style="padding:15px">This call returns the details of the requested device.</td>
|
|
132
|
-
<td style="padding:15px">
|
|
169
|
+
<td style="padding:15px">No</td>
|
|
133
170
|
</tr>
|
|
134
171
|
<tr>
|
|
135
172
|
<td style="padding:15px">getDevicesFiltered(options, callback)</td>
|
|
136
173
|
<td style="padding:15px">This call returns the list of devices that match the criteria provided in the options filter.</td>
|
|
137
|
-
<td style="padding:15px">
|
|
174
|
+
<td style="padding:15px">No</td>
|
|
138
175
|
</tr>
|
|
139
176
|
<tr>
|
|
140
177
|
<td style="padding:15px">isAlive(deviceName, callback)</td>
|
|
141
178
|
<td style="padding:15px">This call returns whether the device status is active</td>
|
|
142
|
-
<td style="padding:15px">
|
|
179
|
+
<td style="padding:15px">No</td>
|
|
143
180
|
</tr>
|
|
144
181
|
<tr>
|
|
145
182
|
<td style="padding:15px">getConfig(deviceName, format, callback)</td>
|
|
146
183
|
<td style="padding:15px">This call returns the configuration for the selected device.</td>
|
|
147
|
-
<td style="padding:15px">
|
|
184
|
+
<td style="padding:15px">No</td>
|
|
148
185
|
</tr>
|
|
149
186
|
<tr>
|
|
150
187
|
<td style="padding:15px">iapGetDeviceCount(callback)</td>
|
|
151
188
|
<td style="padding:15px">This call returns the count of devices.</td>
|
|
152
|
-
<td style="padding:15px">
|
|
189
|
+
<td style="padding:15px">No</td>
|
|
153
190
|
</tr>
|
|
154
191
|
</table>
|
|
155
192
|
<br>
|
|
156
193
|
|
|
157
|
-
|
|
158
194
|
### Specific Adapter Calls
|
|
159
195
|
|
|
160
196
|
Specific adapter calls are built based on the API of the Attmobility. The Adapter Builder creates the proper method comments for generating JS-DOC for the adapter. This is the best way to get information on the calls.
|
package/CHANGELOG.md
CHANGED
package/CONTRIBUTING.md
CHANGED
|
@@ -10,163 +10,4 @@ This project and everyone participating in it is governed by the Code of Conduct
|
|
|
10
10
|
|
|
11
11
|
## How to Contribute
|
|
12
12
|
|
|
13
|
-
|
|
14
|
-
|
|
15
|
-
This section guides you through submitting a bug report. Following these guidelines helps maintainers understand your report :pencil:, reproduce the behavior :computer: :left_right_arrow: :computer:, and find related reports :mag_right:.
|
|
16
|
-
|
|
17
|
-
Before creating bug reports, please check before-submitting-a-bug-report, as you might find out that you don't need to create one. When you are creating a bug report, please include as many details as possible. If you have an Itential support contract, please create an Itential Service Desk ticket. If you don't have an Itential support contract, please send an email of the issue to support@itential.com.
|
|
18
|
-
|
|
19
|
-
#### Before Submitting A Bug Report
|
|
20
|
-
|
|
21
|
-
* **Check the README.md.** You might be able to find the cause of the problem and fix things yourself. Most importantly, check if you can reproduce the problem __in the latest version__.
|
|
22
|
-
* **Work through the troubleshooting process.** Troubleshooting will include changing the log level of Itential Automation Platform (IAP) and adapters and checking the logs to see what the issues are. These logs should be included in any ticket you open for this issue.
|
|
23
|
-
* **Check for resolutions to the issue.** Check the <a href="https://itential.atlassian.net/servicedesk/customer/kb/view/286883841?applicationId=605994d2-2cb2-3174-af59-ed5b23ff5fd5&spaceKey=PKB&src=1187380921" target="_blank">Itential Knowledge Base</a> to see if there is a known resolution for the issue you are having.
|
|
24
|
-
* **Ask around in chat if you are an Itential employee** to see if others are experiencing the same issue.
|
|
25
|
-
|
|
26
|
-
#### How to Submit a (Good) Bug Report
|
|
27
|
-
|
|
28
|
-
Bugs are tracked through the Itential Service Desk. Explain the problem and include additional details to help maintainers reproduce the problem:
|
|
29
|
-
|
|
30
|
-
- **Use a clear and descriptive title** for the issue to identify the problem.
|
|
31
|
-
- **Describe the exact steps which reproduce the problem** in as much detail as possible. For example, start by explaining how you configured the adapter (e.g., which properties you used and how they were set) or how you are using an artifact.
|
|
32
|
-
- **Provide specific examples to demonstrate the steps**. Include logs, or copy/paste snippets, in your examples.
|
|
33
|
-
- **Describe the behavior you observed after following the steps** and point out what exactly is the problem with that behavior.
|
|
34
|
-
- **Explain which behavior you expected to see instead and why.**
|
|
35
|
-
- **Include screenshots and animated GIFs** which show you following the described steps and clearly demonstrate the problem. You can use <a href="https://www.cockos.com/licecap/" target="_blank">this tool</a> to record GIFs on macOS and Windows. Use <a href="https://github.com/colinkeenan/silentcast" target="_blank">this tool</a> or <a href="https://github.com/rhcarvalho/byzanz-guiz" target="_blank">program</a> on Linux.
|
|
36
|
-
- **If the problem wasn't triggered by a specific action**, describe what you were doing before the problem happened and share more information using the guidelines below.
|
|
37
|
-
|
|
38
|
-
Provide more context by answering these questions:
|
|
39
|
-
|
|
40
|
-
- **Did the problem start happening recently** (e.g. after updating to a new version/tag) or was this always a problem?
|
|
41
|
-
- If the problem started happening recently, **can you reproduce the problem in an older version/tag?** What's the most recent version in which the problem does not happen?
|
|
42
|
-
- **Can you reliably reproduce the issue?** If not, provide details about how often the problem happens and under which conditions it normally happens.
|
|
43
|
-
|
|
44
|
-
Include details about your configuration and environment:
|
|
45
|
-
|
|
46
|
-
- **Which version of the adapter/artifact are you using?** You can get the exact version by checking the project version in the package.json file.
|
|
47
|
-
- **What's the name and version of the OS you're using**?
|
|
48
|
-
- **Are you running or using IAP in a virtual machine?** If so, which VM software are you using and which operating systems and versions are used for the host and guest?
|
|
49
|
-
- **Are there firewalls between IAP and any other system you are integrating with?** If so, have you tried running curl from the system IAP is on to the other system to verify you have connectivity between the systems?
|
|
50
|
-
|
|
51
|
-
### Your First Code Contribution
|
|
52
|
-
|
|
53
|
-
#### Local development
|
|
54
|
-
|
|
55
|
-
This project can be developed locally on all operating systems. For instructions on how to do this, follow the steps highlighted in the README.md. The README.mdprovides many more details on cloning the repository for local development, how to lint and test your changes.
|
|
56
|
-
|
|
57
|
-
#### Development Process
|
|
58
|
-
|
|
59
|
-
The following provides a local copy of the repository along with dependencies.
|
|
60
|
-
|
|
61
|
-
```json
|
|
62
|
-
go to the repository you are interested in working on
|
|
63
|
-
click on the Clone button to get the link(s) you can use to clone the repository
|
|
64
|
-
git clone <link to clone the project>
|
|
65
|
-
npm install
|
|
66
|
-
```
|
|
67
|
-
|
|
68
|
-
Prior to making changes you should create a branch to work in. The branch should be named with the type of change (major, minor or patch) and then a Jira issue number or a description of the issue.
|
|
69
|
-
|
|
70
|
-
```json
|
|
71
|
-
git checkout -b <name_of_your_new_branch>
|
|
72
|
-
```
|
|
73
|
-
|
|
74
|
-
Make all of the desired changes.
|
|
75
|
-
|
|
76
|
-
> **Note:** All code changes should be accompanied by additional Unit and Integration tests to minimize the likelihood that any changes will negatively impact the adapter/artifact as well as to ensure the desired functionality is achieved.
|
|
77
|
-
|
|
78
|
-
|
|
79
|
-
<table border="1" class="bordered-table">
|
|
80
|
-
<tr>
|
|
81
|
-
<th bgcolor="lightgrey" style="padding:15px"><span style="font-size:12.0pt">Files</span></th>
|
|
82
|
-
<th bgcolor="lightgrey" style="padding:15px"><span style="font-size:12.0pt">Changes</span></th>
|
|
83
|
-
</tr>
|
|
84
|
-
<tr>
|
|
85
|
-
<td style="padding:15px">.codeclimate.yml, .eslintignore, .eslintrc.js, .gitignore, .gitlab-ci.yml, .jshintrc, .npmignore</td>
|
|
86
|
-
<td style="padding:15px">These are foundational files that are used in linting and building of the adapter. Changes to these files are heavily scrutinized and may be implemented in a different manner so that the changes can be implemented across all adapters.</td>
|
|
87
|
-
</tr>
|
|
88
|
-
<tr>
|
|
89
|
-
<td style="padding:15px">CODE_OF_CONDUCT.md, CONTRIBUTING.md, LICENSE, README.md</td>
|
|
90
|
-
<td style="padding:15px">These are license and process files for the repository. Changes to these files may require legal review and may also be implemented in a different manner so that the changes can be implemented across all adapters.</td>
|
|
91
|
-
</tr>
|
|
92
|
-
<tr>
|
|
93
|
-
<td style="padding:15px">utils/*, adapterBase.js</td>
|
|
94
|
-
<td style="padding:15px">Changes to these files will rarely be accepted. These are process files that need to be changed through the builder process and migration.</td>
|
|
95
|
-
</tr>
|
|
96
|
-
<tr>
|
|
97
|
-
<td style="padding:15px">adapter.js</td>
|
|
98
|
-
<td style="padding:15px">Changes to this file are code changes. They should be accompanied by the appropriate unit and integration tests. If new methods are added, they should also be added to the pronghorn.json file, otherwise integration tests are likely to fail.</td>
|
|
99
|
-
</tr>
|
|
100
|
-
<tr>
|
|
101
|
-
<td style="padding:15px">error.json, propertiesSchema.json</td>
|
|
102
|
-
<td style="padding:15px">These files are utilized by the Itential Runtime libraries. You can make changes to these files, but the changes should be appending of new errors or properties. Removal of errors and properties can result in rejection of the changes.</td>
|
|
103
|
-
</tr>
|
|
104
|
-
<tr>
|
|
105
|
-
<td style="padding:15px">pacakge.json, package-lock.json</td>
|
|
106
|
-
<td style="padding:15px">The package-lock.json is automatically generated and should only be updated when the dependencies inside of the package.json are modified. You can make changes to the package.json to add additional scripts, add new dependencies, modify names, etc. However, changing the scripts or dependencies that are Itential specific will be overriden during the acceptance process.</td>
|
|
107
|
-
</tr>
|
|
108
|
-
<tr>
|
|
109
|
-
<td style="padding:15px">pronghorn.json</td>
|
|
110
|
-
<td style="padding:15px">Changes to this file are made for integration into IAP. The most common change here is adding new methods that shoud be exposed to the IAP Workflow.</td>
|
|
111
|
-
</tr>
|
|
112
|
-
<tr>
|
|
113
|
-
<td style="padding:15px">entities/*</td>
|
|
114
|
-
<td style="padding:15px">Changes to these files include adding new capabilities, updating existing capabilities, or removing deprecated capabilities in the adapter. Translation configuration can also be modified here.</td>
|
|
115
|
-
</tr>
|
|
116
|
-
<tr>
|
|
117
|
-
<td style="padding:15px">test/*</td>
|
|
118
|
-
<td style="padding:15px">Changes to these files include adding, updating, or removing unit and integration tests in the adapter. Tests should never be removed unless the methods that are being tested are removed also. Both the unit and integration test file should have a marker that identifies where modification can take place. Modifications above that marker are likely to be rejected or implemented in a different manner.</td>
|
|
119
|
-
</tr>
|
|
120
|
-
</table>
|
|
121
|
-
<br>
|
|
122
|
-
|
|
123
|
-
> **Note:** It is a best practice to lint and test your code prior to committing changes into the repository. You can lint your code by running **npm run lint** and test it by running **node utils/testRunner.sh**. However, there are pre-commit hooks that will run these scripts when you commit your changes.
|
|
124
|
-
|
|
125
|
-
Commit the changes to the repository.
|
|
126
|
-
|
|
127
|
-
```json
|
|
128
|
-
git commit -a -m "<descriptive message>"
|
|
129
|
-
```
|
|
130
|
-
|
|
131
|
-
> **Note:** There are pre-commit hooks in place. If the pre-commit hooks fail, you will need to address those issues before moving forward.
|
|
132
|
-
|
|
133
|
-
Push the changes into the repository. This should only be done after the commit has successfully completed.
|
|
134
|
-
|
|
135
|
-
```json
|
|
136
|
-
git push origin <name_of_your_new_branch>
|
|
137
|
-
```
|
|
138
|
-
|
|
139
|
-
Create a Merge Request.
|
|
140
|
-
|
|
141
|
-
### Merge Requests
|
|
142
|
-
|
|
143
|
-
- Fill out the provided merge request template.
|
|
144
|
-
- Reference related issues and merge requests liberally.
|
|
145
|
-
- Include screenshots and animated GIFs in your merge request whenever possible.
|
|
146
|
-
- Follow the project Styleguide.
|
|
147
|
-
- End all files with a newline.
|
|
148
|
-
|
|
149
|
-
## Styleguide
|
|
150
|
-
|
|
151
|
-
### Git Commit Messages
|
|
152
|
-
|
|
153
|
-
- Use the present tense ("Add feature" not "Added feature")
|
|
154
|
-
- Use the imperative mood ("Move cursor to..." not "Moves cursor to...")
|
|
155
|
-
- Consider starting the commit message with an applicable emoji _(not required)_:
|
|
156
|
-
- :art: `:art:` When improving the format/structure of the code.
|
|
157
|
-
- :racehorse: `:racehorse:` When improving performance
|
|
158
|
-
- :non-potable_water: `:non-potable_water:` When plugging memory leaks.
|
|
159
|
-
- :memo: `:memo:` When writing documentation.
|
|
160
|
-
- :penguin: `:penguin:` When fixing something on Linux.
|
|
161
|
-
- :apple: `:apple:` When fixing something on macOS.
|
|
162
|
-
- :checkered_flag: `:checkered_flag:` When fixing something on Windows.
|
|
163
|
-
- :bug: `:bug:` When fixing a bug.
|
|
164
|
-
- :fire: `:fire:` When removing code or files.
|
|
165
|
-
- :green_heart: `:green_heart:` When fixing the CI build.
|
|
166
|
-
- :white_check_mark: `:white_check_mark:` When adding tests,
|
|
167
|
-
- :lock: `:lock:` When dealing with security.
|
|
168
|
-
- :arrow_up: `:arrow_up:` When upgrading dependencies.
|
|
169
|
-
- :arrow_down: `:arrow_down:` When downgrading dependencies.
|
|
170
|
-
- :shirt: `:shirt:` When removing linter warnings.
|
|
171
|
-
|
|
172
|
-
__Avoid installing unnecessary packages.__ Do not install packages just because they might be "nice to have". Itential Opensource projects are supposed to be minimal, specific, and compact by design.
|
|
13
|
+
Follow the contributing guide (here)[https://gitlab.com/itentialopensource/adapters/contributing-guide]
|
package/ENHANCE.md
CHANGED
|
@@ -11,14 +11,14 @@ There are multiple ways to add calls to an existing adapter.
|
|
|
11
11
|
The easiest way would be to use the Adapter Builder update process. This process takes in a Swagger or OpenAPI document, allows you to select the calls you want to add and then generates a zip file that can be used to update the adapter. Once you have the zip file simply put it in the adapter directory and execute `npm run adapter:update`.
|
|
12
12
|
|
|
13
13
|
```bash
|
|
14
|
-
mv updatePackage.zip adapter-
|
|
15
|
-
cd adapter-
|
|
14
|
+
mv updatePackage.zip adapter-att_mobility
|
|
15
|
+
cd adapter-att_mobility
|
|
16
16
|
npm run adapter:update
|
|
17
17
|
```
|
|
18
18
|
|
|
19
19
|
If you do not have a Swagger or OpenAPI document, you can use a Postman Collection and convert that to an OpenAPI document using APIMatic and then follow the first process.
|
|
20
20
|
|
|
21
|
-
If you want to manually update the adapter that can also be done the key thing is to make sure you update all of the right files. Within the entities directory you will find 1 or more entities. You can create a new entity or add to an existing entity. Each entity has an action.json file, any new call will need to be put in the action.json file. It will also need to be added to the enum for the ph_request_type in the appropriate schema files. Once this configuration is complete you will need to add the call to the adapter.js file and, in order to make it available as a workflow task in IAP, it should also be added to the pronghorn.json file. You can optionally add it to the unit and integration test files. There is more information on how to work on each of these files in the <a href="https://
|
|
21
|
+
If you want to manually update the adapter that can also be done the key thing is to make sure you update all of the right files. Within the entities directory you will find 1 or more entities. You can create a new entity or add to an existing entity. Each entity has an action.json file, any new call will need to be put in the action.json file. It will also need to be added to the enum for the ph_request_type in the appropriate schema files. Once this configuration is complete you will need to add the call to the adapter.js file and, in order to make it available as a workflow task in IAP, it should also be added to the pronghorn.json file. You can optionally add it to the unit and integration test files. There is more information on how to work on each of these files in the <a href="https://docs.itential.com/opensource/docs/adapters" target="_blank">Adapter Technical Resources</a> on our Documentation Site.
|
|
22
22
|
|
|
23
23
|
```text
|
|
24
24
|
Files to update
|
|
@@ -66,4 +66,4 @@ Files to update
|
|
|
66
66
|
* test/integration/adapterTestIntegration.js: add better data for the create and update calls so that they will not fail.
|
|
67
67
|
```
|
|
68
68
|
|
|
69
|
-
As mentioned previously, for most of these changes as well as other possible changes, there is more information on how to work on an adapter in the <a href="https://
|
|
69
|
+
As mentioned previously, for most of these changes as well as other possible changes, there is more information on how to work on an adapter in the <a href="https://docs.itential.com/opensource/docs/adapters" target="_blank">Adapter Technical Resources</a> on our Documentation Site.
|
package/PROPERTIES.md
CHANGED
|
@@ -164,7 +164,7 @@ This section defines **all** the properties that are available for the adapter,
|
|
|
164
164
|
|
|
165
165
|
### Connection Properties
|
|
166
166
|
|
|
167
|
-
These base properties are used to connect to
|
|
167
|
+
These base properties are used to connect to AttMobility upon the adapter initially coming up. It is important to set these properties appropriately.
|
|
168
168
|
|
|
169
169
|
<table border="1" class="bordered-table">
|
|
170
170
|
<tr>
|
|
@@ -205,7 +205,7 @@ These base properties are used to connect to Attmobility upon the adapter initia
|
|
|
205
205
|
</tr>
|
|
206
206
|
<tr>
|
|
207
207
|
<td style="padding:15px">stub</td>
|
|
208
|
-
<td style="padding:15px">Optional. Indicates whether the stub should run instead of making calls to
|
|
208
|
+
<td style="padding:15px">Optional. Indicates whether the stub should run instead of making calls to AttMobility (very useful during basic testing). Default is false (which means connect to AttMobility).</td>
|
|
209
209
|
</tr>
|
|
210
210
|
<tr>
|
|
211
211
|
<td style="padding:15px">protocol</td>
|
|
@@ -218,9 +218,9 @@ A connectivity check tells IAP the adapter has loaded successfully.
|
|
|
218
218
|
|
|
219
219
|
### Authentication Properties
|
|
220
220
|
|
|
221
|
-
The following properties are used to define the authentication process to
|
|
221
|
+
The following properties are used to define the authentication process to AttMobility.
|
|
222
222
|
|
|
223
|
-
>**Note**: Depending on the method that is used to authenticate with
|
|
223
|
+
>**Note**: Depending on the method that is used to authenticate with AttMobility, you may not need to set all of the authentication properties.
|
|
224
224
|
|
|
225
225
|
<table border="1" class="bordered-table">
|
|
226
226
|
<tr>
|
|
@@ -233,11 +233,11 @@ The following properties are used to define the authentication process to Attmob
|
|
|
233
233
|
</tr>
|
|
234
234
|
<tr>
|
|
235
235
|
<td style="padding:15px">username</td>
|
|
236
|
-
<td style="padding:15px">Used to authenticate with
|
|
236
|
+
<td style="padding:15px">Used to authenticate with AttMobility on every request or when pulling a token that will be used in subsequent requests.</td>
|
|
237
237
|
</tr>
|
|
238
238
|
<tr>
|
|
239
239
|
<td style="padding:15px">password</td>
|
|
240
|
-
<td style="padding:15px">Used to authenticate with
|
|
240
|
+
<td style="padding:15px">Used to authenticate with AttMobility on every request or when pulling a token that will be used in subsequent requests.</td>
|
|
241
241
|
</tr>
|
|
242
242
|
<tr>
|
|
243
243
|
<td style="padding:15px">token</td>
|
|
@@ -249,7 +249,7 @@ The following properties are used to define the authentication process to Attmob
|
|
|
249
249
|
</tr>
|
|
250
250
|
<tr>
|
|
251
251
|
<td style="padding:15px">token_timeout</td>
|
|
252
|
-
<td style="padding:15px">Defines how long a token is valid. Measured in milliseconds. Once a dynamic token is no longer valid, the adapter has to pull a new token. If the token_timeout is set to -1, the adapter will pull a token on every request to
|
|
252
|
+
<td style="padding:15px">Defines how long a token is valid. Measured in milliseconds. Once a dynamic token is no longer valid, the adapter has to pull a new token. If the token_timeout is set to -1, the adapter will pull a token on every request to AttMobility. If the timeout_token is 0, the adapter will use the expiration from the token response to determine when the token is no longer valid.</td>
|
|
253
253
|
</tr>
|
|
254
254
|
<tr>
|
|
255
255
|
<td style="padding:15px">token_cache</td>
|
|
@@ -293,11 +293,11 @@ The following properties are used to define the authentication process to Attmob
|
|
|
293
293
|
|
|
294
294
|
### Healthcheck Properties
|
|
295
295
|
|
|
296
|
-
The healthcheck properties defines the API that runs the healthcheck to tell the adapter that it can reach
|
|
296
|
+
The healthcheck properties defines the API that runs the healthcheck to tell the adapter that it can reach AttMobility. There are currently three types of healthchecks.
|
|
297
297
|
|
|
298
|
-
- None - Not recommended. Adapter will not run a healthcheck. Consequently, unable to determine before making a request if the adapter can reach
|
|
298
|
+
- None - Not recommended. Adapter will not run a healthcheck. Consequently, unable to determine before making a request if the adapter can reach AttMobility.
|
|
299
299
|
- Startup - Adapter will check for connectivity when the adapter initially comes up, but it will not check afterwards.
|
|
300
|
-
- Intermittent - Adapter will check connectivity to
|
|
300
|
+
- Intermittent - Adapter will check connectivity to AttMobility at a frequency defined in the `frequency` property.
|
|
301
301
|
|
|
302
302
|
<table border="1" class="bordered-table">
|
|
303
303
|
<tr>
|
|
@@ -346,7 +346,7 @@ The request section defines properties to help handle requests.
|
|
|
346
346
|
</tr>
|
|
347
347
|
<tr>
|
|
348
348
|
<td style="padding:15px">attempt_timeout</td>
|
|
349
|
-
<td style="padding:15px">Optional. Tells how long the adapter should wait before aborting the attempt. On abort, the adapter will do one of two things: 1) return the error; or 2) if **healthcheck\_on\_timeout** is set to true, it will abort the request and run a Healthcheck until it re-establishes connectivity to
|
|
349
|
+
<td style="padding:15px">Optional. Tells how long the adapter should wait before aborting the attempt. On abort, the adapter will do one of two things: 1) return the error; or 2) if **healthcheck\_on\_timeout** is set to true, it will abort the request and run a Healthcheck until it re-establishes connectivity to AttMobility, and then will re-attempt the request that aborted. Default is 5000 milliseconds.</td>
|
|
350
350
|
</tr>
|
|
351
351
|
<tr>
|
|
352
352
|
<td style="padding:15px">global_request</td>
|
|
@@ -378,7 +378,7 @@ The request section defines properties to help handle requests.
|
|
|
378
378
|
</tr>
|
|
379
379
|
<tr>
|
|
380
380
|
<td style="padding:15px">archiving</td>
|
|
381
|
-
<td style="padding:15px">Optional flag. Default is false. It archives the request, the results and the various times (wait time,
|
|
381
|
+
<td style="padding:15px">Optional flag. Default is false. It archives the request, the results and the various times (wait time, AttMobility time and overall time) in the `adapterid_results` collection in MongoDB. Although archiving might be desirable, be sure to develop a strategy before enabling this capability. Consider how much to archive and what strategy to use for cleaning up the collection in the database so that it does not become too large, especially if the responses are large.</td>
|
|
382
382
|
</tr>
|
|
383
383
|
<tr>
|
|
384
384
|
<td style="padding:15px">return_request</td>
|
|
@@ -389,7 +389,7 @@ The request section defines properties to help handle requests.
|
|
|
389
389
|
|
|
390
390
|
### SSL Properties
|
|
391
391
|
|
|
392
|
-
The SSL section defines the properties utilized for ssl authentication with
|
|
392
|
+
The SSL section defines the properties utilized for ssl authentication with AttMobility. SSL can work two different ways: set the `accept\_invalid\_certs` flag to true (only recommended for lab environments), or provide a `ca\_file`.
|
|
393
393
|
|
|
394
394
|
<table border="1" class="bordered-table">
|
|
395
395
|
<tr>
|
|
@@ -433,7 +433,7 @@ The SSL section defines the properties utilized for ssl authentication with Attm
|
|
|
433
433
|
|
|
434
434
|
### Throttle Properties
|
|
435
435
|
|
|
436
|
-
The throttle section is used when requests to
|
|
436
|
+
The throttle section is used when requests to AttMobility must be queued (throttled). All of the properties in this section are optional.
|
|
437
437
|
|
|
438
438
|
<table border="1" class="bordered-table">
|
|
439
439
|
<tr>
|
|
@@ -458,7 +458,7 @@ The throttle section is used when requests to Attmobility must be queued (thrott
|
|
|
458
458
|
</tr>
|
|
459
459
|
<tr>
|
|
460
460
|
<td style="padding:15px">concurrent_max</td>
|
|
461
|
-
<td style="padding:15px">Defines the number of requests the adapter can send to
|
|
461
|
+
<td style="padding:15px">Defines the number of requests the adapter can send to AttMobility at one time (minimum = 1, maximum = 1000). The default is 1 meaning each request must be sent to AttMobility in a serial manner.</td>
|
|
462
462
|
</tr>
|
|
463
463
|
<tr>
|
|
464
464
|
<td style="padding:15px">expire_timeout</td>
|
|
@@ -466,7 +466,7 @@ The throttle section is used when requests to Attmobility must be queued (thrott
|
|
|
466
466
|
</tr>
|
|
467
467
|
<tr>
|
|
468
468
|
<td style="padding:15px">average_runtime</td>
|
|
469
|
-
<td style="padding:15px">Represents the approximate average of how long it takes
|
|
469
|
+
<td style="padding:15px">Represents the approximate average of how long it takes AttMobility to handle each request. Measured in milliseconds (minimum = 50, maximum = 60000). Default is 200. This metric has performance implications. If the runtime number is set too low, it puts extra burden on the CPU and memory as the requests will continually try to run. If the runtime number is set too high, requests may wait longer than they need to before running. The number does not need to be exact but your throttling strategy depends heavily on this number being within reason. If averages range from 50 to 250 milliseconds you might pick an average run-time somewhere in the middle so that when AttMobility performance is exceptional you might run a little slower than you might like, but when it is poor you still run efficiently.</td>
|
|
470
470
|
</tr>
|
|
471
471
|
<tr>
|
|
472
472
|
<td style="padding:15px">priorities</td>
|
|
@@ -477,7 +477,7 @@ The throttle section is used when requests to Attmobility must be queued (thrott
|
|
|
477
477
|
|
|
478
478
|
### Proxy Properties
|
|
479
479
|
|
|
480
|
-
The proxy section defines the properties to utilize when
|
|
480
|
+
The proxy section defines the properties to utilize when AttMobility is behind a proxy server.
|
|
481
481
|
|
|
482
482
|
<table border="1" class="bordered-table">
|
|
483
483
|
<tr>
|
|
@@ -486,7 +486,7 @@ The proxy section defines the properties to utilize when Attmobility is behind a
|
|
|
486
486
|
</tr>
|
|
487
487
|
<tr>
|
|
488
488
|
<td style="padding:15px">enabled</td>
|
|
489
|
-
<td style="padding:15px">Required. Default is false. If
|
|
489
|
+
<td style="padding:15px">Required. Default is false. If AttMobility is behind a proxy server, set enabled flag to true.</td>
|
|
490
490
|
</tr>
|
|
491
491
|
<tr>
|
|
492
492
|
<td style="padding:15px">host</td>
|
|
@@ -573,7 +573,7 @@ The mongo section defines the properties used to connect to a Mongo database. Mo
|
|
|
573
573
|
|
|
574
574
|
### Device Broker Properties
|
|
575
575
|
|
|
576
|
-
The device broker section defines the properties used integrate
|
|
576
|
+
The device broker section defines the properties used integrate AttMobility to the device broker. Each broker call is represented and has an array of calls that can be used to build the response. This describes the calls and then the fields which are available in the calls.
|
|
577
577
|
|
|
578
578
|
<table border="1" class="bordered-table">
|
|
579
579
|
<tr>
|