@itenthusiasm/custom-elements 1.0.1 → 1.0.3

package/CheckboxGroup/CheckboxGroup.js

@@ -40,6 +40,7 @@ class CheckboxGroup extends HTMLElement {
    */
   attributeChangedCallback(_name, _oldValue, _newValue) {
     // NOTE: If we're only watching constraint-related attributes, then we only need to re-run validation here.
+    if (!this.fieldset) return; // eslint-disable-line @typescript-eslint/no-unnecessary-condition -- Check needed here.
     this.#validateConstraints();
   }
 

package/Combobox/ComboboxOption.js

@@ -132,11 +132,19 @@ class ComboboxOption extends HTMLElement {
     if (!this.#combobox) return;
     const combobox = this.#combobox;
 
-    if (this.selected && combobox.value !== this.value) combobox.value = this.value;
-    else if (!this.selected && combobox.value === this.value) {
-      if (combobox.text.data && combobox.acceptsValue(combobox.text.data)) return;
-      if (combobox.acceptsValue("")) return combobox.forceEmptyValue();
-      combobox.formResetCallback();
+    // Selection
+    if (this.selected) {
+      if (combobox.value !== this.value) combobox.value = this.value;
+      else if (this.value === "" && combobox.text.data !== this.label) combobox.text.data = this.label;
+    }
+    // Deslection
+    else {
+      if (combobox.value !== this.value) return;
+
+      if (combobox.text.data && combobox.acceptsValue(combobox.text.data)) {
+        if (combobox.value !== combobox.text.data) combobox.value = combobox.text.data;
+      } else if (combobox.acceptsValue("")) combobox.forceEmptyValue();
+      else combobox.formResetCallback();
     }
   }
 }

package/Combobox/types/preact.d.ts

@@ -30,8 +30,10 @@ declare module "preact" {
     }
 
     // eslint-disable-next-line @typescript-eslint/no-empty-object-type -- This is required to support ComboboxField props
-    interface SelectHTMLAttributes<T extends EventTarget = HTMLSelectElement>
-      extends Omit<ComboboxFieldHTMLAttributes<T>, "onfilterchange"> {}
+    interface SelectHTMLAttributes<T extends EventTarget = HTMLSelectElement> extends Omit<
+      ComboboxFieldHTMLAttributes<T>,
+      "onfilterchange"
+    > {}
 
     interface ComboboxOptionHTMLAttributes<T extends EventTarget = ComboboxOption> extends HTMLAttributes<T> {
       defaultSelected?: Signalish<ComboboxOption["defaultSelected"] | undefined>;

package/Combobox/types/react.d.ts

@@ -22,8 +22,10 @@ declare module "react" {
     onfilterchangeCapture?: ReactEventHandler<T>;
   }
 
-  interface SelectHTMLAttributes<T>
-    extends Omit<ComboboxFieldHTMLAttributes<T>, "filter" | "onfilterchange" | "onfilterchangeCapture"> {
+  interface SelectHTMLAttributes<T> extends Omit<
+    ComboboxFieldHTMLAttributes<T>,
+    "filter" | "onfilterchange" | "onfilterchangeCapture"
+  > {
     filter?: "";
   }
 

package/Combobox/types/solid.d.ts

@@ -37,8 +37,10 @@ declare module "solid-js" {
     }
 
     // eslint-disable-next-line @typescript-eslint/no-empty-object-type -- This is required to support ComboboxField props
-    interface SelectHTMLAttributes<T>
-      extends Omit<ComboboxFieldHTMLAttributes<T>, "onFilterchange" | "onfilterchange" | "on:filterchange"> {}
+    interface SelectHTMLAttributes<T> extends Omit<
+      ComboboxFieldHTMLAttributes<T>,
+      "onFilterchange" | "onfilterchange" | "on:filterchange"
+    > {}
 
     interface ComboboxOptionHTMLAttributes<T> extends HTMLAttributes<T> {
       disabled?: ComboboxOption["disabled"];

package/Combobox/types/svelte.d.ts

@@ -31,8 +31,10 @@ declare module "svelte/elements" {
   }
 
   // eslint-disable-next-line @typescript-eslint/no-empty-object-type -- This is required to support ComboboxField attrs
-  interface HTMLSelectAttributes
-    extends Omit<HTMLComboboxFieldAttributes<HTMLSelectElement>, "onfilterchange" | "on:filterchange"> {}
+  interface HTMLSelectAttributes extends Omit<
+    HTMLComboboxFieldAttributes<HTMLSelectElement>,
+    "onfilterchange" | "on:filterchange"
+  > {}
 
   interface HTMLComboboxOptionAttributes extends HTMLAttributes<ComboboxOption> {
     defaultSelected?: ComboboxOption["defaultSelected"] | null;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@itenthusiasm/custom-elements",
   "type": "module",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "sideEffects": false,
   "license": "MIT",
   "description": "Robust, accessible, and progressively-enhanceable Web Components for common developer needs",

package/types/helpers.d.ts

@@ -1,12 +1,13 @@
 // NOTE: For some reason, TS complains in the JS files if we export a `type`, so we're exporting `interface`s instead.
 /* eslint @typescript-eslint/no-empty-object-type: ["error", { "allowInterfaces": "with-single-extends" }] */
-export interface ExposedInternals
-  extends Pick<
-    ElementInternals,
-    "labels" | "form" | "validity" | "validationMessage" | "willValidate" | "checkValidity" | "reportValidity"
-  > {}
+export interface ExposedInternals extends Pick<
+  ElementInternals,
+  "labels" | "form" | "validity" | "validationMessage" | "willValidate" | "checkValidity" | "reportValidity"
+> {}
 
-export interface FieldPropertiesAndMethods
-  extends Pick<HTMLInputElement, "name" | "required" | "disabled" | "setCustomValidity"> {}
+export interface FieldPropertiesAndMethods extends Pick<
+  HTMLInputElement,
+  "name" | "required" | "disabled" | "setCustomValidity"
+> {}
 
 export interface FieldMinMax extends Pick<HTMLInputElement, "min" | "max"> {}