@isograph/react 0.0.0-main-bee27aa9 → 0.0.0-main-0a7c1aef

package/dist/useRerenderWhenEncounteredRecordChanges.js

@@ -9,6 +9,9 @@ function useRerenderWhenEncounteredRecordChanges(environment, encounteredRecords
         return (0, cache_1.subscribe)(environment, encounteredRecords, () => {
             return setState({});
         });
+        // TODO this is probably buggy — we should re-evaluate the effect when
+        // encounteredRecords changes. However, it is not a stable object, so...
+        // how?
     }, []);
 }
 exports.useRerenderWhenEncounteredRecordChanges = useRerenderWhenEncounteredRecordChanges;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@isograph/react",
-  "version": "0.0.0-main-bee27aa9",
+  "version": "0.0.0-main-0a7c1aef",
   "description": "Use Isograph with React",
   "homepage": "https://isograph.dev",
   "main": "dist/index.js",
@@ -16,8 +16,8 @@
     "prepack": "yarn run test && yarn run compile"
   },
   "dependencies": {
-    "@isograph/disposable-types": "0.0.0-main-bee27aa9",
-    "@isograph/react-disposable-state": "0.0.0-main-bee27aa9",
+    "@isograph/disposable-types": "0.0.0-main-0a7c1aef",
+    "@isograph/react-disposable-state": "0.0.0-main-0a7c1aef",
     "react": "^18.2.0"
   },
   "devDependencies": {

package/src/tests/__isograph/iso.ts

@@ -6,12 +6,24 @@ import entrypoint_Query__meNameSuccessor from '../__isograph/Query/meNameSuccess
 import entrypoint_Query__meName from '../__isograph/Query/meName/entrypoint';
 import entrypoint_Query__nodeField from '../__isograph/Query/nodeField/entrypoint';
 
+// This is the type given to regular client fields.
+// This means that the type of the exported iso literal is exactly
+// the type of the passed-in function, which takes one parameter
+// of type TParam.
 type IdentityWithParam<TParam> = <TClientFieldReturn>(
   x: (param: TParam) => TClientFieldReturn
 ) => (param: TParam) => TClientFieldReturn;
-type IdentityWithParamComponent<TParam> = <TClientFieldReturn, TSecondParam = Record<string, never>>(
-  x: (data: TParam, secondParam: TSecondParam) => TClientFieldReturn
-) => (data: TParam, secondParam: TSecondParam) => TClientFieldReturn;
+
+// This is the type given it to client fields with @component.
+// This means that the type of the exported iso literal is exactly
+// the type of the passed-in function, which takes two parameters.
+// The first has type TParam, and the second has type TAdditionalProps.
+//
+// TAdditionalProps becomes the types of the props you must pass
+// whenever the @component field is rendered.
+type IdentityWithParamComponent<TParam> = <TClientFieldReturn, TAdditionalProps = Record<string, never>>(
+  x: (data: TParam, secondParam: TAdditionalProps) => TClientFieldReturn
+) => (data: TParam, secondParam: TAdditionalProps) => TClientFieldReturn;
 
 type WhitespaceCharacter = ' ' | '\t' | '\n';
 type Whitespace<In> = In extends `${WhitespaceCharacter}${infer In}`

package/src/useRerenderWhenEncounteredRecordChanges.ts

@@ -11,5 +11,8 @@ export function useRerenderWhenEncounteredRecordChanges(
     return subscribe(environment, encounteredRecords, () => {
       return setState({});
     });
+    // TODO this is probably buggy — we should re-evaluate the effect when
+    // encounteredRecords changes. However, it is not a stable object, so...
+    // how?
   }, []);
 }