@isograph/disposable-types 0.0.0-main-ae4fea0e → 0.0.0-main-a8e129cf

package/.turbo/turbo-compile-libs.log

@@ -1,11 +1,11 @@
 ../..                                    |  WARN  Unsupported engine: wanted: {"node":"24.12.0"} (current: {"node":"v24.20.0","pnpm":"10.15.0"})
 
-> @isograph/disposable-types@0.0.0-main-ae4fea0e compile-libs /home/runner/work/isograph/isograph/libs/isograph-disposable-types
+> @isograph/disposable-types@0.0.0-main-a8e129cf compile-libs /home/runner/work/isograph/isograph/libs/isograph-disposable-types
 > tsdown
 
 ℹ tsdown v0.20.1 powered by rolldown v1.0.0-rc.1
 ℹ config file: /home/runner/work/isograph/isograph/tsdown.config.ts 
-(node:2653) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///home/runner/work/isograph/isograph/tsdown.config.ts?no-cache=dea0ee5b-991e-42cf-93dd-ff44b8fc144d is not specified and it doesn't parse as CommonJS.
+(node:2582) [MODULE_TYPELESS_PACKAGE_JSON] Warning: Module type of file:///home/runner/work/isograph/isograph/tsdown.config.ts?no-cache=8163f23a-2e6b-411e-9d32-00b32bf8012c is not specified and it doesn't parse as CommonJS.
 Reparsing as ES module because module syntax was detected. This incurs a performance overhead.
 To eliminate this warning, add "type": "module" to /home/runner/work/isograph/isograph/package.json.
 (Use `node --trace-warnings ...` to show where the warning was created)

package/.turbo/turbo-tsc.log

@@ -1,5 +1,5 @@
 ../..                                    |  WARN  Unsupported engine: wanted: {"node":"24.12.0"} (current: {"node":"v24.20.0","pnpm":"10.15.0"})
 
-> @isograph/disposable-types@0.0.0-main-ae4fea0e tsc /home/runner/work/isograph/isograph/libs/isograph-disposable-types
+> @isograph/disposable-types@0.0.0-main-a8e129cf tsc /home/runner/work/isograph/isograph/libs/isograph-disposable-types
 > tsc
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@isograph/disposable-types",
-  "version": "0.0.0-main-ae4fea0e",
+  "version": "0.0.0-main-a8e129cf",
   "description": "Common types for disposable items",
   "homepage": "https://isograph.dev",
   "main": "./dist/index.cjs",
@@ -28,9 +28,9 @@
   "scripts": {
     "compile-libs": "tsdown",
     "watch-libs": "tsdown --watch",
-    "test": "echo this package has no tests",
-    "test-watch": "echo this package has no tests",
-    "coverage": "echo this package has no coverage",
+    "test": "vitest run",
+    "test-watch": "vitest watch",
+    "coverage": "vitest run --coverage",
     "tsc": "tsc",
     "tsc-force": "tsc --build --clean && tsc --build --force"
   }

package/src/joinCleanups.test.ts

@@ -0,0 +1,97 @@
+import { assert, describe, expect, test } from 'vitest';
+import { joinCleanups } from './index';
+
+describe('joinCleanups', () => {
+  test('Disposes in reverse argument order', () => {
+    const order: string[] = [];
+    const [items, dispose] = joinCleanups(
+      [
+        'a',
+        () => {
+          order.push('a');
+        },
+      ],
+      [
+        'b',
+        () => {
+          order.push('b');
+        },
+      ],
+      [
+        'c',
+        () => {
+          order.push('c');
+        },
+      ],
+    );
+
+    expect(items).toEqual(['a', 'b', 'c']);
+    dispose();
+    expect(order).toEqual(['c', 'b', 'a']);
+  });
+
+  test('If a cleanup throws, remaining cleanups still run and the first error is rethrown', () => {
+    const order: string[] = [];
+    const errorB = new Error('b');
+    const [, dispose] = joinCleanups(
+      [
+        'a',
+        () => {
+          order.push('a');
+        },
+      ],
+      [
+        'b',
+        () => {
+          order.push('b');
+          throw errorB;
+        },
+      ],
+      [
+        'c',
+        () => {
+          order.push('c');
+        },
+      ],
+    );
+
+    let thrown: unknown;
+    try {
+      dispose();
+    } catch (e) {
+      thrown = e;
+    }
+
+    assert(thrown === errorB);
+    expect(order).toEqual(['c', 'b', 'a']);
+  });
+
+  test('If two cleanups throw, the first error in dispose order is rethrown', () => {
+    const errorA = new Error('a');
+    const errorC = new Error('c');
+    const [, dispose] = joinCleanups(
+      [
+        'a',
+        () => {
+          throw errorA;
+        },
+      ],
+      ['b', () => {}],
+      [
+        'c',
+        () => {
+          throw errorC;
+        },
+      ],
+    );
+
+    let thrown: unknown;
+    try {
+      dispose();
+    } catch (e) {
+      thrown = e;
+    }
+
+    assert(thrown === errorC);
+  });
+});