@islamihab/kds 0.5.0 → 0.6.0

package/index.js

@@ -14597,7 +14597,7 @@ import { join } from "path";
 // package.json
 var package_default = {
   name: "cli",
-  version: "0.5.0",
+  version: "0.6.0",
   private: true,
   type: "module",
   bin: {
@@ -15188,6 +15188,14 @@ var ISSUE_OPEN_STATUSES = [
   "changes_requested",
   "approved"
 ];
+var REVIEW_FINDING_CATEGORIES = [
+  "functional_correctness",
+  "maintainability",
+  "security",
+  "performance"
+];
+var REVIEW_FINDING_SEVERITIES = ["critical", "major", "minor", "trivial"];
+var MAX_REVIEW_FINDINGS = 50;
 var ISSUE_LABEL_COLORS = [
   "gray",
   "red",
@@ -18159,9 +18167,10 @@ var runInbox = async (options) => {
 };
 
 // src/lib/input.ts
-var assertSize = (size) => {
-  if (size > MAX_PAGE_HTML_BYTES)
-    throw new Error(`Page is too large (${size} bytes; max ${MAX_PAGE_HTML_BYTES}).`);
+var assertSize = (size, subject = "Page") => {
+  if (size > MAX_PAGE_HTML_BYTES) {
+    throw new Error(`${subject} is too large (${size} bytes; max ${MAX_PAGE_HTML_BYTES}).`);
+  }
 };
 var readBody = async (path) => {
   if (path === "-") {
@@ -18174,6 +18183,18 @@ var readBody = async (path) => {
   return await file2.text();
 };
 var readTextOption = async (value) => value === "-" ? await Bun.stdin.text() : value;
+var readFileOption = async (path) => {
+  if (path === "-") {
+    const text = await Bun.stdin.text();
+    assertSize(new TextEncoder().encode(text).length, "Input");
+    return text;
+  }
+  const file2 = Bun.file(path);
+  if (!await file2.exists())
+    throw new Error(`No file at ${path}.`);
+  assertSize(file2.size, "Input");
+  return await file2.text();
+};
 var readIssueRef = (value) => {
   const trimmed = value.trim();
   if (/^\d+$/.test(trimmed))
@@ -18698,6 +18719,37 @@ More issues match; raise --limit past ${options.limit}.`);
   }
 });
 
+// src/commands/issues/mark-addressed.ts
+var parseFindingRef = (value) => {
+  const match = /^(.+):([1-9]\d*)$/.exec(value);
+  if (!match?.[1] || !match[2])
+    throw new Error(`--finding takes path:line, got "${value}".`);
+  return { path: match[1], line: Number(match[2]) };
+};
+var markAddressed = command({
+  name: "mark-addressed",
+  description: "Mark review findings addressed by a commit and resolve their conversations",
+  positionals: {
+    id: exports_external.string().describe("Issue identifier, number, or URL")
+  },
+  options: {
+    commit: exports_external.string().describe("The commit sha that addressed the findings").meta({ short: "c" }),
+    finding: exports_external.array(exports_external.string()).optional().describe("Mark only this finding, as path:line (repeatable; default all)")
+  },
+  run: async ({ positionals: { id }, options: { commit, finding } }) => {
+    const client3 = await backendClient();
+    const issue2 = await resolveIssue(client3, id);
+    const result = await client3.action(api2.githubReviewer.markAddressed, {
+      id: issue2._id,
+      commitSha: commit,
+      findings: finding?.map(parseFindingRef)
+    });
+    const already = result.alreadyMarked.length ? ` (${result.alreadyMarked.length} already marked)` : "";
+    console.log(`Marked ${result.marked.length} on ${result.identifier} as addressed in ${commit}${already}.`);
+    console.log(result.resolved ? `Resolved ${result.resolved} conversation${result.resolved === 1 ? "" : "s"}.` : "All conversations already resolved.");
+  }
+});
+
 // src/commands/issues/relate.ts
 var relate = command({
   name: "relate",
@@ -18859,15 +18911,16 @@ var start = command({
 // src/commands/issues/start-review.ts
 var startReview = command({
   name: "start-review",
-  description: "Claim review work: move a ready_for_review issue to in_review",
+  description: "Claim review work: move a ready_for_review issue to in_review and announce the review on its pull request",
   positionals: {
     id: exports_external.string().describe("Issue identifier, number, or URL")
   },
   run: async ({ positionals: { id } }) => {
     const client3 = await backendClient();
     const issue2 = await resolveIssue(client3, id);
-    await client3.mutation(api2.issues.startReview, { id: issue2._id });
-    console.log(`Reviewing ${issue2.identifier}: in_review`);
+    const started = await client3.action(api2.githubReviewer.startReview, { id: issue2._id });
+    console.log(`Reviewing ${started.identifier}: in_review`);
+    console.log(`Announced on ${started.prUrl}; check run open.`);
   }
 });
 
@@ -18886,6 +18939,70 @@ var submit = command({
   }
 });
 
+// src/commands/issues/submit-review.ts
+var findingsSchema = exports_external.array(exports_external.object({
+  path: exports_external.string().min(1),
+  line: exports_external.number().int().positive(),
+  startLine: exports_external.number().int().positive().optional(),
+  category: exports_external.enum(REVIEW_FINDING_CATEGORIES),
+  severity: exports_external.enum(REVIEW_FINDING_SEVERITIES),
+  summary: exports_external.string().min(1),
+  body: exports_external.string().min(1),
+  diff: exports_external.string().optional()
+})).min(1).max(MAX_REVIEW_FINDINGS);
+var readFindings = async (path) => {
+  const text = await readFileOption(path);
+  let json2;
+  try {
+    json2 = JSON.parse(text);
+  } catch {
+    throw new Error("The findings file is not valid JSON.");
+  }
+  const parsed = findingsSchema.safeParse(json2);
+  if (!parsed.success)
+    throw new Error(`The findings file is invalid:
+${exports_external.prettifyError(parsed.error)}`);
+  return parsed.data;
+};
+var submitReview = command({
+  name: "submit-review",
+  description: "Submit the review verdict on an issue's linked pull request as the reviewer App",
+  positionals: {
+    id: exports_external.string().describe("Issue identifier, number, or URL")
+  },
+  options: {
+    approve: exports_external.boolean().default(false).describe("Approve: bare APPROVE plus a clean bill"),
+    "request-changes": exports_external.boolean().default(false).describe("Request changes from a findings file"),
+    findings: exports_external.string().optional().describe("Findings JSON file, or - for stdin (with --request-changes)"),
+    bill: exports_external.string().optional().describe("Clean-bill text, or - for stdin (with --approve)")
+  },
+  run: async ({ positionals: { id }, options }) => {
+    if (options.approve === options["request-changes"]) {
+      throw new Error("Pass exactly one of --approve or --request-changes.");
+    }
+    if (options.approve && options.findings !== undefined)
+      throw new Error("--findings goes with --request-changes.");
+    if (options["request-changes"] && options.bill !== undefined)
+      throw new Error("--bill goes with --approve.");
+    let verdict;
+    if (options.approve) {
+      if (options.bill === undefined)
+        throw new Error("--approve needs the clean bill: --bill <text>, or - for stdin.");
+      verdict = { kind: "approve", bill: await readTextOption(options.bill) };
+    } else {
+      if (options.findings === undefined) {
+        throw new Error("--request-changes needs the findings: --findings <file>, or - for stdin.");
+      }
+      verdict = { kind: "request_changes", findings: await readFindings(options.findings) };
+    }
+    const client3 = await backendClient();
+    const issue2 = await resolveIssue(client3, id);
+    const submitted = await client3.action(api2.githubReviewer.submitReview, { id: issue2._id, verdict });
+    console.log(`Submitted review on ${submitted.identifier}: ${submitted.prUrl}`);
+    console.log(submitted.summary);
+  }
+});
+
 // src/commands/issues/tasks.ts
 var position = exports_external.array(exports_external.coerce.number().int().positive());
 var tasks = command({
@@ -19021,6 +19138,8 @@ var issues = group({
     start,
     submit,
     startReview,
+    submitReview,
+    markAddressed,
     tasks,
     relate,
     unrelate,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@islamihab/kds",
-  "version": "0.5.0",
+  "version": "0.6.0",
   "description": "Command-line client for Kai Dev Studio",
   "license": "MIT",
   "publishConfig": {