@iservu-inc/adf-cli 0.5.5 → 0.5.6

package/CHANGELOG.md

@@ -5,6 +5,59 @@ All notable changes to `@iservu-inc/adf-cli` will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.5.6] - 2025-10-05
+
+### 🔧 Fixed Invalid .env State Detection
+
+**FIX:** Automatically detect and reset invalid configuration where ADF_CURRENT_PROVIDER/ADF_CURRENT_MODEL are set but no API key exists.
+
+#### The Problem (Cart Before the Horse)
+
+The .env file could end up in an invalid state:
+```env
+ADF_CURRENT_PROVIDER="openrouter"
+ADF_CURRENT_MODEL="anthropic/claude-sonnet-4-5"
+# But no OPENROUTER_API_KEY present!
+```
+
+This shouldn't be possible - you can't have a "current provider" without an API key for that provider.
+
+#### The Fix
+
+Now we detect this broken state and automatically reset:
+```
+⚠️  Invalid configuration detected:
+   ADF_CURRENT_PROVIDER is set to "openrouter" but no API key found
+   Resetting provider selection...
+```
+
+The invalid ADF_CURRENT_PROVIDER and ADF_CURRENT_MODEL entries are removed from .env, forcing proper configuration.
+
+#### Why This Matters
+
+- **Data integrity**: Prevents cart-before-horse situations
+- **Better UX**: Clear feedback about what's wrong
+- **Auto-healing**: Automatically fixes the broken state
+- **Prevents confusion**: Users aren't told they have an active provider when they don't
+
+#### How It Can Happen
+
+- User manually edited/deleted API key from .env
+- Corrupted .env file
+- Configuration error during setup
+
+Now these scenarios are automatically detected and corrected!
+
+#### Technical Changes
+
+- Modified: `lib/ai/ai-config.js`
+  - Added validation after loading .env
+  - New `saveEnvFile()` helper function
+  - Refactored `saveToEnvFile()` to use `saveEnvFile()`
+  - Auto-reset invalid configuration
+
+---
+
 ## [0.5.5] - 2025-10-05
 
 ### ✅ Fixed AI Provider Configuration Display

package/lib/ai/ai-config.js

@@ -136,12 +136,9 @@ async function ensureGitignore(projectPath) {
 }
 
 /**
- * Save API key to .env file
+ * Save entire env object to .env file
  */
-async function saveToEnvFile(envPath, key, value) {
-  const env = await loadEnvFile(envPath);
-  env[key] = value;
-
+async function saveEnvFile(envPath, env) {
   const lines = [
     '# AI Provider Configuration for adf-cli',
     '# DO NOT commit this file to version control',
@@ -179,6 +176,15 @@ async function saveToEnvFile(envPath, key, value) {
   await ensureGitignore(projectPath);
 }
 
+/**
+ * Save API key to .env file
+ */
+async function saveToEnvFile(envPath, key, value) {
+  const env = await loadEnvFile(envPath);
+  env[key] = value;
+  await saveEnvFile(envPath, env);
+}
+
 /**
  * Load .env file into process.env
  */
@@ -279,8 +285,29 @@ async function configureAIProvider(projectPath = process.cwd()) {
   }
 
   // Get currently active provider and model
-  const currentProvider = process.env.ADF_CURRENT_PROVIDER || existingEnv.ADF_CURRENT_PROVIDER;
-  const currentModel = process.env.ADF_CURRENT_MODEL || existingEnv.ADF_CURRENT_MODEL;
+  let currentProvider = process.env.ADF_CURRENT_PROVIDER || existingEnv.ADF_CURRENT_PROVIDER;
+  let currentModel = process.env.ADF_CURRENT_MODEL || existingEnv.ADF_CURRENT_MODEL;
+
+  // Validate: If ADF_CURRENT_PROVIDER is set but its API key is missing, reset it
+  if (currentProvider) {
+    const currentProviderObj = AI_PROVIDERS[currentProvider.toUpperCase()];
+    if (currentProviderObj) {
+      const currentProviderHasKey = availableProviders.find(p => p.id === currentProvider);
+      if (!currentProviderHasKey) {
+        console.log(chalk.yellow(`⚠️  Invalid configuration detected:`));
+        console.log(chalk.gray(`   ADF_CURRENT_PROVIDER is set to "${currentProvider}" but no API key found`));
+        console.log(chalk.gray(`   Resetting provider selection...\n`));
+
+        // Clear invalid values from .env file
+        delete existingEnv.ADF_CURRENT_PROVIDER;
+        delete existingEnv.ADF_CURRENT_MODEL;
+        await saveEnvFile(envPath, existingEnv);
+
+        currentProvider = null;
+        currentModel = null;
+      }
+    }
+  }
 
   if (availableProviders.length > 0) {
     console.log(chalk.green('✓ Detected API keys for:'));
@@ -290,7 +317,7 @@ async function configureAIProvider(projectPath = process.cwd()) {
     console.log('');
   }
 
-  // Show current active configuration if exists
+  // Show current active configuration if exists (and is valid)
   if (currentProvider && currentModel) {
     const currentProviderObj = AI_PROVIDERS[currentProvider.toUpperCase()];
     if (currentProviderObj) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@iservu-inc/adf-cli",
-  "version": "0.5.5",
+  "version": "0.5.6",
   "description": "CLI tool for AgentDevFramework - AI-assisted development framework with multi-provider AI support",
   "main": "index.js",
   "bin": {