@iservu-inc/adf-cli 0.5.5-debug.0 → 0.5.6

package/CHANGELOG.md

@@ -5,6 +5,103 @@ All notable changes to `@iservu-inc/adf-cli` will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.5.6] - 2025-10-05
+
+### 🔧 Fixed Invalid .env State Detection
+
+**FIX:** Automatically detect and reset invalid configuration where ADF_CURRENT_PROVIDER/ADF_CURRENT_MODEL are set but no API key exists.
+
+#### The Problem (Cart Before the Horse)
+
+The .env file could end up in an invalid state:
+```env
+ADF_CURRENT_PROVIDER="openrouter"
+ADF_CURRENT_MODEL="anthropic/claude-sonnet-4-5"
+# But no OPENROUTER_API_KEY present!
+```
+
+This shouldn't be possible - you can't have a "current provider" without an API key for that provider.
+
+#### The Fix
+
+Now we detect this broken state and automatically reset:
+```
+⚠️  Invalid configuration detected:
+   ADF_CURRENT_PROVIDER is set to "openrouter" but no API key found
+   Resetting provider selection...
+```
+
+The invalid ADF_CURRENT_PROVIDER and ADF_CURRENT_MODEL entries are removed from .env, forcing proper configuration.
+
+#### Why This Matters
+
+- **Data integrity**: Prevents cart-before-horse situations
+- **Better UX**: Clear feedback about what's wrong
+- **Auto-healing**: Automatically fixes the broken state
+- **Prevents confusion**: Users aren't told they have an active provider when they don't
+
+#### How It Can Happen
+
+- User manually edited/deleted API key from .env
+- Corrupted .env file
+- Configuration error during setup
+
+Now these scenarios are automatically detected and corrected!
+
+#### Technical Changes
+
+- Modified: `lib/ai/ai-config.js`
+  - Added validation after loading .env
+  - New `saveEnvFile()` helper function
+  - Refactored `saveToEnvFile()` to use `saveEnvFile()`
+  - Auto-reset invalid configuration
+
+---
+
+## [0.5.5] - 2025-10-05
+
+### ✅ Fixed AI Provider Configuration Display
+
+**FIX:** Restored checkmarks (✓) for configured AI providers alongside the active (★) indicator.
+
+#### What Was Broken
+
+In the AI provider selection menu, only the "★ Active" indicator was showing. The checkmarks that indicate which providers have configured API keys were missing.
+
+**Before (broken):**
+```
+? Select AI provider:
+  Anthropic Claude
+  OpenAI GPT
+  Google Gemini
+  OpenRouter (Multi-Model)  ★ Active
+```
+
+**After (fixed):**
+```
+? Select AI provider:
+  Anthropic Claude  ✓
+  OpenAI GPT  ✓
+  Google Gemini  ✓
+  OpenRouter (Multi-Model)  ✓  ★ Active
+```
+
+#### What We Fixed
+
+- Refactored provider name building logic for clarity
+- Added proper spacing between provider name, checkmark, and active indicator
+- Both indicators now show correctly:
+  - **✓** = API key configured
+  - **★ Active** = Currently selected provider
+
+#### Technical Changes
+
+- Modified: `lib/ai/ai-config.js` - Cleaner `buildProviderName()` function
+- Better string concatenation with consistent spacing
+- Removed debug logging
+
+---
+
 ## [0.5.4] - 2025-10-05
 
 ### ✨ Enhanced Version & Help Display

package/lib/ai/ai-config.js

@@ -136,12 +136,9 @@ async function ensureGitignore(projectPath) {
 }
 
 /**
- * Save API key to .env file
+ * Save entire env object to .env file
  */
-async function saveToEnvFile(envPath, key, value) {
-  const env = await loadEnvFile(envPath);
-  env[key] = value;
-
+async function saveEnvFile(envPath, env) {
   const lines = [
     '# AI Provider Configuration for adf-cli',
     '# DO NOT commit this file to version control',
@@ -179,6 +176,15 @@ async function saveToEnvFile(envPath, key, value) {
   await ensureGitignore(projectPath);
 }
 
+/**
+ * Save API key to .env file
+ */
+async function saveToEnvFile(envPath, key, value) {
+  const env = await loadEnvFile(envPath);
+  env[key] = value;
+  await saveEnvFile(envPath, env);
+}
+
 /**
  * Load .env file into process.env
  */
@@ -275,15 +281,33 @@ async function configureAIProvider(projectPath = process.cwd()) {
     const apiKey = process.env[provider.envVar] || existingEnv[provider.envVar];
     if (apiKey) {
       availableProviders.push(provider);
-      console.log(chalk.gray(`[DEBUG] Found ${provider.id}: ${provider.envVar}=${apiKey ? '***' : 'not found'}`));
     }
   }
-  console.log(chalk.gray(`[DEBUG] availableProviders length: ${availableProviders.length}`));
-  console.log(chalk.gray(`[DEBUG] availableProviders ids: ${availableProviders.map(p => p.id).join(', ')}`));
 
   // Get currently active provider and model
-  const currentProvider = process.env.ADF_CURRENT_PROVIDER || existingEnv.ADF_CURRENT_PROVIDER;
-  const currentModel = process.env.ADF_CURRENT_MODEL || existingEnv.ADF_CURRENT_MODEL;
+  let currentProvider = process.env.ADF_CURRENT_PROVIDER || existingEnv.ADF_CURRENT_PROVIDER;
+  let currentModel = process.env.ADF_CURRENT_MODEL || existingEnv.ADF_CURRENT_MODEL;
+
+  // Validate: If ADF_CURRENT_PROVIDER is set but its API key is missing, reset it
+  if (currentProvider) {
+    const currentProviderObj = AI_PROVIDERS[currentProvider.toUpperCase()];
+    if (currentProviderObj) {
+      const currentProviderHasKey = availableProviders.find(p => p.id === currentProvider);
+      if (!currentProviderHasKey) {
+        console.log(chalk.yellow(`⚠️  Invalid configuration detected:`));
+        console.log(chalk.gray(`   ADF_CURRENT_PROVIDER is set to "${currentProvider}" but no API key found`));
+        console.log(chalk.gray(`   Resetting provider selection...\n`));
+
+        // Clear invalid values from .env file
+        delete existingEnv.ADF_CURRENT_PROVIDER;
+        delete existingEnv.ADF_CURRENT_MODEL;
+        await saveEnvFile(envPath, existingEnv);
+
+        currentProvider = null;
+        currentModel = null;
+      }
+    }
+  }
 
   if (availableProviders.length > 0) {
     console.log(chalk.green('✓ Detected API keys for:'));
@@ -293,7 +317,7 @@ async function configureAIProvider(projectPath = process.cwd()) {
     console.log('');
   }
 
-  // Show current active configuration if exists
+  // Show current active configuration if exists (and is valid)
   if (currentProvider && currentModel) {
     const currentProviderObj = AI_PROVIDERS[currentProvider.toUpperCase()];
     if (currentProviderObj) {
@@ -301,25 +325,40 @@ async function configureAIProvider(projectPath = process.cwd()) {
     }
   }
 
-  // Provider selection
+  // Provider selection with status indicators
+  const buildProviderName = (provider, providerId) => {
+    const isConfigured = availableProviders.find(p => p.id === providerId);
+    const isActive = currentProvider === providerId;
+
+    let name = provider.name;
+    if (isConfigured) {
+      name += chalk.green('  ✓');
+    }
+    if (isActive) {
+      name += chalk.cyan('  ★ Active');
+    }
+
+    return name;
+  };
+
   const providerChoices = [
     {
-      name: `${AI_PROVIDERS.ANTHROPIC.name} ${availableProviders.find(p => p.id === 'anthropic') ? chalk.green('✓ Configured') : ''} ${currentProvider === 'anthropic' ? chalk.cyan('★ Active') : ''}`,
+      name: buildProviderName(AI_PROVIDERS.ANTHROPIC, 'anthropic'),
       value: 'anthropic',
       short: 'Anthropic'
     },
     {
-      name: `${AI_PROVIDERS.OPENAI.name} ${availableProviders.find(p => p.id === 'openai') ? chalk.green('✓ Configured') : ''} ${currentProvider === 'openai' ? chalk.cyan('★ Active') : ''}`,
+      name: buildProviderName(AI_PROVIDERS.OPENAI, 'openai'),
       value: 'openai',
       short: 'OpenAI'
     },
     {
-      name: `${AI_PROVIDERS.GOOGLE.name} ${availableProviders.find(p => p.id === 'google') ? chalk.green('✓ Configured') : ''} ${currentProvider === 'google' ? chalk.cyan('★ Active') : ''}`,
+      name: buildProviderName(AI_PROVIDERS.GOOGLE, 'google'),
       value: 'google',
       short: 'Google'
     },
     {
-      name: `${AI_PROVIDERS.OPENROUTER.name} ${availableProviders.find(p => p.id === 'openrouter') ? chalk.green('✓ Configured') : ''} ${currentProvider === 'openrouter' ? chalk.cyan('★ Active') : ''}`,
+      name: buildProviderName(AI_PROVIDERS.OPENROUTER, 'openrouter'),
       value: 'openrouter',
       short: 'OpenRouter'
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@iservu-inc/adf-cli",
-  "version": "0.5.5-debug.0",
+  "version": "0.5.6",
   "description": "CLI tool for AgentDevFramework - AI-assisted development framework with multi-provider AI support",
   "main": "index.js",
   "bin": {