@iservu-inc/adf-cli 0.4.13 → 0.4.15

package/CHANGELOG.md

@@ -5,6 +5,61 @@ All notable changes to `@iservu-inc/adf-cli` will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.15] - 2025-10-04
+
+### 🐛 Bug Fixes & Enhancements
+
+**Fixed: Block Numbering Confusion (Issue #3)**
+- **Problem:** AI Configuration showed as "Block 1" then interview questions also started with "Block 1 of 5" - creating TWO "Block 1"s
+- **Root Cause:** AI config was labeled as a numbered block when it's actually pre-interview setup
+- **Fix:** Changed label from "📋 Block 1: AI Configuration" to "🤖 AI Provider Configuration (Pre-Interview)"
+- **Impact:** Clearer distinction between pre-interview setup and actual interview blocks
+
+**Added: OpenAI o1 Model Support**
+- **Added:** Support for OpenAI's new o1 reasoning models: `o1`, `o1-mini`, `o1-preview`
+- **Problem Solved:** o1 models were failing with parameter errors
+  - Error 1: "Unsupported parameter: 'max_tokens' is not supported with this model"
+  - Error 2: o1 models don't support temperature parameter
+- **Solution:** Added conditional API parameter handling in `openaiRequest()`
+  - o1 models use `max_completion_tokens` instead of `max_tokens`
+  - o1 models skip `temperature` parameter entirely
+  - Standard GPT models continue to use `max_tokens` and `temperature`
+- **Impact:** o1 models now work correctly for AI-assisted interviews
+
+**Technical Details:**
+- `interviewer.js:365`: Updated AI config label to clarify pre-interview status
+- `ai-config.js:36`: Added o1 models to OpenAI defaultModels array
+- `ai-client.js:115-150`: Rewrote `openaiRequest()` with o1 model detection
+  - Detects o1 models with `this.model.startsWith('o1')`
+  - Uses conditional logic for parameter selection
+- All 120 tests passing
+
+## [0.4.14] - 2025-10-04
+
+### 🐛 Critical Bug Fixes
+
+**Fixed: False .adf Directory Detection (Issue #1)**
+- **Problem:** `adf init` in empty projects incorrectly detected `.adf` directory and asked to overwrite
+- **Root Cause:** `SessionManager.listSessions()` was creating `.adf/sessions/` directory during resume check
+- **Fix:** Modified `listSessions()` to return empty array if directory doesn't exist instead of creating it
+- **Impact:** Clean projects no longer show false "overwrite" prompts
+
+**Fixed: Skip AI Config if Already Configured (Issue #2)**
+- **Problem:** Users who configured AI via `adf config` were still prompted during `adf init`
+- **Solution:** Interview now detects existing `.adf/.env` configuration
+- **Behavior:**
+  - **If configured:** Shows "✓ AI Provider already configured: [Provider Name]" and uses existing config
+  - **If not configured:** Shows "📋 Block 1: AI Configuration" with prompt to configure
+- **Impact:** Better UX - respects user's configuration choices
+
+**Technical Details:**
+- `session-manager.js`: Added existence check before creating directory
+- `interviewer.js`: Added AI config detection logic
+  - Checks for existing API keys in `.adf/.env`
+  - Auto-loads first available provider (Anthropic > OpenAI > Google > OpenRouter)
+  - Shows helpful reminder about `adf config` for managing providers
+- All 120 tests passing
+
 ## [0.4.13] - 2025-10-04
 
 ### 🐛 Bug Fixes & UX Improvements

package/lib/ai/ai-client.js

@@ -113,17 +113,29 @@ class AIClient {
    * OpenAI GPT request
    */
   async openaiRequest(prompt, maxTokens, temperature) {
-    const response = await this.client.chat.completions.create({
+    // o1 models use max_completion_tokens instead of max_tokens
+    const isO1Model = this.model.startsWith('o1');
+
+    const requestParams = {
       model: this.model,
-      max_tokens: maxTokens,
-      temperature,
       messages: [
         {
           role: 'user',
           content: prompt
         }
       ]
-    });
+    };
+
+    // o1 models use different parameter names
+    if (isO1Model) {
+      requestParams.max_completion_tokens = maxTokens;
+      // o1 models don't support temperature parameter
+    } else {
+      requestParams.max_tokens = maxTokens;
+      requestParams.temperature = temperature;
+    }
+
+    const response = await this.client.chat.completions.create(requestParams);
 
     return {
       content: response.choices[0].message.content,

package/lib/ai/ai-config.js

@@ -33,7 +33,7 @@ const AI_PROVIDERS = {
     requiredFormat: 'sk-',
     website: 'https://platform.openai.com/',
     setup: 'Get your API key from https://platform.openai.com/api-keys',
-    defaultModels: ['gpt-4-turbo', 'gpt-4o', 'gpt-4', 'gpt-3.5-turbo']
+    defaultModels: ['gpt-4o', 'gpt-4-turbo', 'gpt-4', 'o1', 'o1-mini', 'o1-preview', 'gpt-3.5-turbo']
   },
   GOOGLE: {
     id: 'google',

package/lib/frameworks/interviewer.js

@@ -63,24 +63,55 @@ class Interviewer {
 
     // Configure AI if not already configured (new sessions only)
     if (!this.aiConfig && !this.isResuming) {
-      console.log(chalk.cyan.bold('━'.repeat(60)));
-      console.log(chalk.cyan.bold('\n📋 Block 1: AI Configuration\n'));
-      console.log(chalk.gray('Configure your AI provider for intelligent follow-up questions\n'));
+      // Check if user already configured AI via 'adf config'
+      const { getEnvFilePath, loadEnvFile, loadEnvIntoProcess } = require('../ai/ai-config');
+      const envPath = getEnvFilePath(this.projectPath);
+
+      if (await fs.pathExists(envPath)) {
+        const envVars = await loadEnvFile(envPath);
+
+        // Check which provider is configured
+        const providerMap = {
+          'ANTHROPIC_API_KEY': { id: 'anthropic', name: 'Anthropic Claude', models: ['claude-sonnet-4-5-20250929', 'claude-3-5-sonnet-20241022'] },
+          'OPENAI_API_KEY': { id: 'openai', name: 'OpenAI GPT', models: ['gpt-4-turbo', 'gpt-4o', 'gpt-4'] },
+          'GOOGLE_API_KEY': { id: 'google', name: 'Google Gemini', models: ['gemini-2.0-flash-exp', 'gemini-1.5-pro'] },
+          'OPENROUTER_API_KEY': { id: 'openrouter', name: 'OpenRouter', models: ['anthropic/claude-sonnet-4-5', 'openai/gpt-4-turbo'] }
+        };
 
-      const { configureAI } = await inquirer.prompt([
-        {
-          type: 'confirm',
-          name: 'configureAI',
-          message: 'Configure AI provider now? (Recommended for best experience)',
-          default: true
+        let configuredProvider = null;
+        for (const [envVar, provider] of Object.entries(providerMap)) {
+          if (envVars[envVar] && envVars[envVar].length > 0) {
+            configuredProvider = { ...provider, envVar, apiKey: envVars[envVar] };
+            break;
+          }
         }
-      ]);
 
-      if (configureAI) {
-        const { configureAIProvider } = require('../ai/ai-config');
-        this.aiConfig = await configureAIProvider(this.projectPath);
+        if (configuredProvider) {
+          // User already configured AI via 'adf config' - just show reminder and use it
+          console.log(chalk.cyan.bold('━'.repeat(60)));
+          console.log(chalk.green(`\n✓ AI Provider already configured: ${configuredProvider.name}`));
+          console.log(chalk.gray('  (configured via: adf config)'));
+          console.log(chalk.gray('  💡 To manage AI providers: adf config\n'));
+
+          // Load env into process
+          loadEnvIntoProcess(envPath);
+
+          // Create config object for this session
+          this.aiConfig = {
+            provider: configuredProvider.id,
+            providerName: configuredProvider.name,
+            model: configuredProvider.models[0], // Use first available model
+            apiKey: configuredProvider.apiKey,
+            envVar: configuredProvider.envVar,
+            envPath
+          };
+        } else {
+          // .env exists but no AI keys - prompt to configure
+          await this.promptAIConfiguration();
+        }
       } else {
-        console.log(chalk.yellow('\n💡 You can configure AI later with: adf config\n'));
+        // No .env file - prompt to configure
+        await this.promptAIConfiguration();
       }
     }
 
@@ -329,6 +360,28 @@ class Interviewer {
     return this.sessionPath;
   }
 
+  async promptAIConfiguration() {
+    console.log(chalk.cyan.bold('━'.repeat(60)));
+    console.log(chalk.cyan.bold('\n🤖 AI Provider Configuration (Pre-Interview)\n'));
+    console.log(chalk.gray('Configure your AI provider for intelligent follow-up questions\n'));
+
+    const { configureAI } = await inquirer.prompt([
+      {
+        type: 'confirm',
+        name: 'configureAI',
+        message: 'Configure AI provider now? (Recommended for best experience)',
+        default: true
+      }
+    ]);
+
+    if (configureAI) {
+      const { configureAIProvider } = require('../ai/ai-config');
+      this.aiConfig = await configureAIProvider(this.projectPath);
+    } else {
+      console.log(chalk.yellow('\n💡 You can configure AI later with: adf config\n'));
+    }
+  }
+
   getFrameworkName() {
     const names = {
       rapid: 'Product Requirement Prompt (PRP)',

package/lib/frameworks/session-manager.js

@@ -15,9 +15,12 @@ class SessionManager {
   }
 
   async listSessions() {
-    await fs.ensureDir(this.sessionsDir);
-    const sessions = await fs.readdir(this.sessionsDir);
+    // Don't create directory if it doesn't exist - just return empty array
+    if (!await fs.pathExists(this.sessionsDir)) {
+      return [];
+    }
 
+    const sessions = await fs.readdir(this.sessionsDir);
     const sessionDetails = [];
 
     for (const sessionId of sessions) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@iservu-inc/adf-cli",
-  "version": "0.4.13",
+  "version": "0.4.15",
   "description": "CLI tool for AgentDevFramework - AI-assisted development framework with multi-provider AI support",
   "main": "index.js",
   "bin": {