@isentinel/jest-roblox 0.2.6 → 0.3.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@isentinel/jest-roblox",
-  "version": "0.2.6",
+  "version": "0.3.0",
   "description": "Jest-compatible CLI for running roblox-ts tests via Roblox Open Cloud",
   "keywords": [
     "jest",
@@ -35,17 +35,18 @@
     "dist",
     "loaders",
     "plugin",
+    "!dist/sea",
     "!dist/**/*.map",
     "!dist/**/*.tsbuildinfo"
   ],
   "dependencies": {
+    "@bedrock-rbx/ocale": "0.1.0-beta.15",
     "@jridgewell/trace-mapping": "0.3.31",
-    "@roblox-ts/rojo-resolver": "1.1.0",
     "arktype": "2.2.0",
-    "c12": "4.0.0-beta.4",
+    "c12": "4.0.0-beta.5",
     "confbox": "0.2.4",
-    "defu": "6.1.6",
-    "get-tsconfig": "4.13.7",
+    "defu": "6.1.7",
+    "get-tsconfig": "4.14.0",
     "highlight.js": "11.11.1",
     "istanbul-lib-coverage": "3.2.2",
     "istanbul-lib-report": "3.0.1",
@@ -54,50 +55,53 @@
     "picomatch": "4.0.4",
     "std-env": "4.0.0",
     "tinyrainbow": "3.1.0",
-    "ws": "8.20.0"
+    "ws": "8.20.1"
   },
   "devDependencies": {
-    "@isentinel/eslint-config": "5.0.0-beta.9",
+    "@isentinel/eslint-config": "5.0.0-beta.11",
+    "@isentinel/roblox-ts": "4.0.2",
     "@isentinel/tsconfig": "1.2.0",
-    "@oxc-project/types": "0.120.0",
+    "@isentinel/weld": "0.2.0",
+    "@oxc-project/types": "0.123.0",
     "@rbxts/jest": "3.13.3-ts.1",
-    "@rbxts/types": "1.0.914",
+    "@rbxts/types": "1.0.920",
     "@total-typescript/shoehorn": "0.1.2",
-    "@tsdown/exe": "0.21.7",
+    "@tsdown/exe": "0.22.0",
     "@types/istanbul-lib-coverage": "2.0.6",
     "@types/istanbul-lib-report": "3.0.3",
     "@types/istanbul-reports": "3.0.4",
-    "@types/node": "24.12.0",
-    "@types/picomatch": "4.0.2",
+    "@types/node": "24.12.3",
+    "@types/picomatch": "4.0.3",
     "@types/ws": "8.18.1",
-    "@typescript/native-preview": "7.0.0-dev.20260325.1",
-    "@vitest/coverage-v8": "4.1.2",
-    "@vitest/eslint-plugin": "1.6.14",
+    "@typescript/native-preview": "7.0.0-dev.20260512.1",
+    "@vitest/coverage-v8": "4.1.5",
+    "@vitest/eslint-plugin": "1.6.17",
     "better-typescript-lib": "2.12.0",
-    "bumpp": "11.0.1",
+    "bumpp": "11.1.0",
     "eslint": "9.39.4",
     "eslint-plugin-jest-extended": "3.0.1",
     "eslint-plugin-n": "17.24.0",
     "eslint-plugin-pnpm": "1.6.0",
     "jest-extended": "7.0.0",
-    "memfs": "4.57.1",
-    "publint": "0.3.18",
-    "tsdown": "0.21.7",
+    "memfs": "4.57.2",
+    "publint": "0.3.21",
+    "tsdown": "0.22.0",
     "type-fest": "5.5.0",
-    "typescript": "5.9.3",
-    "vitest": "4.1.2",
+    "typescript": "6.0.3",
+    "vitest": "4.1.5",
+    "@isentinel/rojo-utils": "0.1.0",
     "@isentinel/luau-ast": "0.1.0",
-    "@isentinel/roblox-runner": "0.1.0",
-    "@isentinel/rojo-utils": "0.1.0"
+    "@isentinel/roblox-runner": "0.1.0"
   },
   "engines": {
     "node": ">=24.10.0"
   },
   "scripts": {
+    "bench": "vitest bench --project unit",
     "build": "pnpm build:packages && pnpm build:bundle && tsdown && pnpm build:plugin",
-    "build:bundle": "darklua process -c .darklua-bundle.json luau/entry.luau src/test-runner.bundled.luau",
+    "build:bundle": "weld",
     "build:packages": "pnpm -r --filter !@isentinel/jest-roblox run build",
-    "build:plugin": "rm -rf plugin/out && darklua process -c .darklua-plugin.json luau/ plugin/out/shared/ && rojo build plugin/plugin.project.json -o plugin/JestRobloxRunner.rbxm",
+    "build:plugin": "rojo build plugin/plugin.project.json -o plugin/JestRobloxRunner.rbxm",
     "lint": "eslint --cache",
     "lint:ci": "eslint --cache --cache-strategy content",
     "release": "bumpp",

package/plugin/plugin.project.json

@@ -3,7 +3,7 @@
 	"tree": {
 		"$path": "src",
 		"shared": {
-			"$path": "out/shared"
+			"$path": "../luau"
 		}
 	}
 }

package/plugin/src/init.server.luau

@@ -11,6 +11,13 @@ end
 local WEBSOCKET_URL = "ws://localhost:3001"
 local RECONNECT_DELAY = 0.1
 
+-- Plugin/CLI protocol version. Must match `STUDIO_PROTOCOL_VERSION` in
+-- `src/backends/studio.ts`. Bumped when the runtime contract changes (e.g.
+-- runtime-injection payload shape). The plugin rejects mismatched CLI
+-- versions with a `version_mismatch` response so users see a clear upgrade
+-- message rather than running with stale behaviour or an opaque timeout.
+local PROTOCOL_VERSION = 2
+
 local IsDebug = ReplicatedStorage:GetAttribute("JEST_ROBLOX_DEBUG") == true
 ReplicatedStorage:GetAttributeChangedSignal("JEST_ROBLOX_DEBUG"):Connect(function(): ()
 	IsDebug = ReplicatedStorage:GetAttribute("JEST_ROBLOX_DEBUG") == true
@@ -96,12 +103,38 @@ local function connect(): ()
 			end
 
 			if message.action == "run_tests" then
+				-- Version handshake: reject a missing or mismatched
+				-- `protocolVersion` synchronously so the user sees an
+				-- upgrade message rather than stale-semantics behaviour.
+				local clientVersion = if typeof(message.protocolVersion) == "number"
+					then message.protocolVersion
+					else nil
+				if clientVersion ~= PROTOCOL_VERSION then
+					warn(
+						"[jest-roblox] Protocol version mismatch — CLI v"
+							.. tostring(clientVersion)
+							.. ", plugin v"
+							.. tostring(PROTOCOL_VERSION)
+					)
+					ws:Send(HttpService:JSONEncode({
+						type = "version_mismatch",
+						actualVersion = PROTOCOL_VERSION,
+						expectedVersion = clientVersion or 0,
+						request_id = message.request_id,
+					}))
+					return
+				end
+
 				print("[jest-roblox] Running tests via StudioTestService...")
 
 				local runOk, result = pcall(function(): any
 					return StudioTestService:ExecuteRunModeAsync({
 						test = true,
 						config = message.config,
+						-- Filtered injection targets (parallel to configs)
+						-- so the Run Mode runner skips mounts that already
+						-- have a user-authored jest.config on disk.
+						runtimeStubMounts = message.runtimeStubMounts,
 					})
 				end)
 
@@ -109,6 +142,7 @@ local function connect(): ()
 					warn("[jest-roblox] ExecuteRunModeAsync failed: " .. tostring(result))
 					ws:Send(HttpService:JSONEncode({
 						type = "results",
+						protocolVersion = PROTOCOL_VERSION,
 						request_id = message.request_id,
 						jestOutput = HttpService:JSONEncode({
 							success = false,
@@ -121,6 +155,11 @@ local function connect(): ()
 
 				ws:Send(HttpService:JSONEncode({
 					type = "results",
+					-- Echo the protocol version. A stale plugin that ignored
+					-- the request-side version would also omit the echo, so
+					-- the CLI's schema validation rejects it as malformed
+					-- rather than treating it as a valid v1 success.
+					protocolVersion = PROTOCOL_VERSION,
 					request_id = message.request_id,
 					jestOutput = result.jestOutput or HttpService:JSONEncode({
 						success = false,

package/plugin/src/test-in-run-mode.server.luau

@@ -31,7 +31,6 @@ if testArgs == nil then
 end
 
 if testArgs == nil then
-	endWithError("StudioTestService:GetTestArgs() returned nil after 50 polls (5s)")
 	return
 end
 
@@ -60,7 +59,123 @@ if not requireOk then
 	return
 end
 
-local runOk, entriesOrErr = pcall(Runner.runProjects, script, configs)
+-- Runtime injection of jest.config ModuleScripts per config. Studio +
+-- multi-project does NOT write jest.config.luau into the user's source
+-- tree — the configs travel via the WebSocket payload and we materialize
+-- them into DataModel ModuleScripts just before Jest discovery runs. The
+-- session-UUID `_G` key keeps each Run Mode invocation isolated against
+-- re-entrancy (the assert below fails loud if state from a prior run
+-- somehow persisted).
+local SESSION_KEY = "__JEST_ROBLOX_RT_" .. HttpService:GenerateGUID(false):gsub("-", "")
+assert(_G[SESSION_KEY] == nil, "Session key collision — re-entrant run detected")
+_G[SESSION_KEY] = { configs = {} }
+
+local function findInstance(path: string): Instance
+	local parts = string.split(path, "/")
+	local current: any = game:FindService(parts[1])
+	assert(current, "service not found: " .. parts[1])
+	for i = 2, #parts do
+		current = current:FindFirstChild(parts[i])
+		assert(current, "missing segment '" .. parts[i] .. "' in " .. path)
+	end
+	return current
+end
+
+-- Per-config record of injected ModuleScripts so cleanup after each
+-- config's Jest invocation can destroy exactly the stubs that config
+-- created. Per-config (rather than upfront-all) avoids the nested-project
+-- contamination path where configs at e.g. `ReplicatedStorage` and
+-- `ReplicatedStorage/Foo` would both have stubs in DataModel
+-- simultaneously and Jest's parent-traversal could resolve the wrong one.
+local injectedPerConfig: { [number]: { Instance } } = {}
+
+-- The CLI sends a filtered `runtimeStubMounts[i]` list per config,
+-- excluding mounts that already have a user-authored `jest.config.luau`
+-- on disk (synced naturally by Rojo). We must iterate this filtered list,
+-- not `cfg.projects`, or we'd inject over the user's canonical config.
+-- Defaults to empty when the field is missing (defensive against
+-- malformed payload from a divergent plugin).
+local function injectStubsForConfig(cfg, configIndex: number, injectionPaths: { string })
+	local sessionTable = _G[SESSION_KEY]
+	sessionTable.configs[configIndex] = cfg
+	-- Register the slot BEFORE parenting any stub. If a later mount
+	-- throws (findInstance miss, structural collision), the partially-
+	-- parented stubs are already tracked so cleanupStubsForConfig /
+	-- cleanupAllStubs can find and destroy them. Without this, an early
+	-- stub would linger in DataModel after cleanup.
+	local injected: { Instance } = {}
+	injectedPerConfig[configIndex] = injected
+
+	for _, projectPath in injectionPaths do
+		local leaf = findInstance(projectPath)
+		assert(
+			leaf:FindFirstChild("jest.config") == nil,
+			"Structural collision: jest.config already exists under "
+				.. projectPath
+				.. ". This may be a user-authored config not declared as a string entry, "
+				.. "a rojo tree mapping, or a model-file mount."
+		)
+		local stub = Instance.new("ModuleScript")
+		stub.Name = "jest.config"
+		stub.Source = string.format(
+			'return _G["%s"].configs[%d]',
+			SESSION_KEY,
+			configIndex
+		)
+		stub.Parent = leaf
+		-- Record immediately after parenting so a subsequent mount's
+		-- failure does not strand this one.
+		table.insert(injected, stub)
+	end
+end
+
+local function cleanupStubsForConfig(configIndex: number)
+	local injected = injectedPerConfig[configIndex]
+	if injected ~= nil then
+		for _, inst in injected do
+			pcall(function() inst:Destroy() end)
+		end
+		injectedPerConfig[configIndex] = nil
+	end
+
+	local sessionTable = _G[SESSION_KEY]
+	if sessionTable ~= nil then
+		sessionTable.configs[configIndex] = nil
+	end
+end
+
+local function cleanupAllStubs()
+	for index in injectedPerConfig do
+		cleanupStubsForConfig(index)
+	end
+	_G[SESSION_KEY] = nil
+end
+
+-- Per-config injection target lists, parallel to `configs`. The CLI sends a
+-- pre-filtered list excluding mount paths whose source tree already has a
+-- user-authored `jest.config.luau` synced by Rojo. Empty entry (or missing
+-- field) means: skip injection for this config. The hooks below let
+-- `Runner.runProjects` call our inject/cleanup just-in-time per config, so
+-- nested-project mounts (e.g. `ReplicatedStorage` and `ReplicatedStorage/Foo`)
+-- never have stubs in DataModel simultaneously — which would let Jest's
+-- parent-traversal config lookup resolve the wrong project's config.
+local runtimeStubMounts: { { string } } = testArgs.runtimeStubMounts
+	or table.create(#configs, {})
+
+local hooks = {
+	beforeConfig = function(cfg, index)
+		local paths = runtimeStubMounts[index] or {}
+		injectStubsForConfig(cfg, index, paths)
+	end,
+	afterConfig = function(_cfg, index)
+		cleanupStubsForConfig(index)
+	end,
+}
+
+local runOk, entriesOrErr = pcall(Runner.runProjects, script, configs, hooks)
+-- Defensive: also clear `_G` even if every afterConfig hook already cleaned
+-- per-config. Belt-and-suspenders against a hook-call that yielded early.
+cleanupAllStubs()
 if not runOk then
 	endWithError("Runner.runProjects threw: " .. tostring(entriesOrErr))
 	return