@isentinel/eslint-config 6.0.0-beta.27 → 6.0.0-beta.28

package/dist/cli.mjs

@@ -9,7 +9,7 @@ import path from "node:path";
 import { existsSync, readFileSync } from "fs";
 import { execSync } from "node:child_process";
 //#region package.json
-var version = "6.0.0-beta.27";
+var version = "6.0.0-beta.28";
 var package_default = {
 	name: "@isentinel/eslint-config",
 	version,

package/dist/index.mjs

@@ -15662,6 +15662,7 @@ const oxlintRuleMapping = {
 	"vitest/no-hooks": "native",
 	"vitest/no-identical-title": "native",
 	"vitest/no-import-node-test": "native",
+	"vitest/no-importing-vitest-globals": "native",
 	"vitest/no-interpolation-in-snapshots": "native",
 	"vitest/no-large-snapshots": "native",
 	"vitest/no-mocks-import": "native",

package/dist/lint-cli.mjs

@@ -36,7 +36,7 @@ var __toESM = (mod, isNodeMode, target) => (target = mod != null ? __create(__ge
 }) : target, mod));
 //#endregion
 //#region package.json
-var version = "6.0.0-beta.27";
+var version = "6.0.0-beta.28";
 //#endregion
 //#region src/lint-cli/lib/cli/types.ts
 /**

package/dist/oxlint.d.mts

@@ -32538,6 +32538,17 @@ type OxlintFactoryOptions = {
    * see no effect from this option.
    */
   oxc?: boolean;
+  /**
+   * Warn about `overrides` entries oxlint cannot apply. Defaults to `true`.
+   *
+   * An override is authoritative: it applies at the scope its config option
+   * covers whether or not the preset enables the rule. A few cannot be
+   * honoured — a rule that needs type information oxlint has no jsPlugin
+   * route for, a plugin that is not installed, or one dropped by
+   * `jsPlugins: false` — and those are reported rather than discarded in
+   * silence.
+   */
+  warnDroppedOverrides?: boolean;
 } & Omit<TypedOxlintConfigItem, "files" | "jsPlugins"> & OxlintOptionsConfig;
 //#endregion
 //#region src/oxlint/factory.d.ts

package/dist/oxlint.mjs

@@ -1523,6 +1523,7 @@ const oxlintRuleMapping = {
 	"vitest/no-hooks": "native",
 	"vitest/no-identical-title": "native",
 	"vitest/no-import-node-test": "native",
+	"vitest/no-importing-vitest-globals": "native",
 	"vitest/no-interpolation-in-snapshots": "native",
 	"vitest/no-large-snapshots": "native",
 	"vitest/no-mocks-import": "native",
@@ -1772,6 +1773,18 @@ function isOxlintCovered(rule) {
 	return rule in oxlintRuleMapping || rule in oxcCoveredRules;
 }
 /**
+* Whether the rule's oxlint side is a differently-named native oxc rule, which
+* {@link translateRuleToOxlint} resolves. Such rules are in
+* {@link excludedFromOxlint} so the preset never emits both halves, but a user
+* override naming one still has somewhere to go.
+*
+* @param rule - The canonical ESLint rule name.
+* @returns Whether an oxc rule covers the rule under another name.
+*/
+function isOxcCoveredRule(rule) {
+	return rule in oxcCoveredRules;
+}
+/**
 * Whether the rule runs via oxlint-tsgolint (`oxlint --type-aware`); such rules
 * are noise without type information, so they are gated on `typeAware`.
 *
@@ -2660,6 +2673,76 @@ function commentLengthRules({ maxLength, multiLineMaxLength, semanticComments, t
 	};
 }
 //#endregion
+//#region src/oxlint/override-diagnostics.ts
+const REASON_TEXT = {
+	"eslint-only": "oxlint cannot run this rule; it stays in ESLint",
+	"missing-plugin": "the plugin that owns it is not installed",
+	"native-only": "it needs a jsPlugin, and `jsPlugins: false` is set"
+};
+/**
+* Override diagnostics for the config build in progress: the entries that never
+* reached the generated config, and the oxlint names of the ones that did.
+*
+* The splitter runs deep inside the config modules, which return config
+* fragments and have no channel for diagnostics — and an override can be
+* dropped without leaving a fragment behind at all. The factory drains both
+* buffers per build, which is safe because it builds synchronously from start
+* to finish.
+*/
+const droppedOverrides = [];
+const overrideRules = /* @__PURE__ */ new Set();
+/**
+* Record an override that never reached the generated config.
+*
+* @param entry - The dropped override and the reason it was dropped.
+*/
+function recordDroppedOverride(entry) {
+	droppedOverrides.push(entry);
+}
+/**
+* Record the oxlint names of overrides that made it into a fragment, so a later
+* pass that deletes rules (native-only mode) can tell a user's entry from the
+* preset's.
+*
+* @param rules - The oxlint rule names.
+*/
+function recordOverrideRules(rules) {
+	for (const rule of rules) overrideRules.add(rule);
+}
+/**
+* Take everything recorded since the last call, emptying both buffers.
+*
+* @returns The dropped overrides (deduplicated by rule and reason) and the
+*   oxlint names of the overrides that were emitted.
+*/
+function takeOverrideDiagnostics() {
+	const taken = droppedOverrides.splice(0);
+	const emitted = new Set(overrideRules);
+	overrideRules.clear();
+	const seen = /* @__PURE__ */ new Set();
+	return {
+		dropped: taken.filter(({ reason, rule }) => {
+			const key = `${rule} ${reason}`;
+			if (seen.has(key)) return false;
+			seen.add(key);
+			return true;
+		}),
+		emitted
+	};
+}
+/**
+* Warn about `overrides` entries that could not be applied. An override is a
+* deliberate instruction, so a silently discarded one leaves a rule reporting
+* (or not reporting) with no way to tell why.
+*
+* @param entries - What was dropped, and why; an empty list warns nothing.
+*/
+function warnDroppedOverrides(entries) {
+	if (entries.length === 0) return;
+	const lines = entries.map(({ reason, rule }) => `  - "${rule}": ${REASON_TEXT[reason]}`);
+	console.warn(`[@isentinel/eslint-config] These \`overrides\` entries could not be applied to oxlint:\n${lines.join("\n")}`);
+}
+//#endregion
 //#region src/oxlint/utils.ts
 /**
 * Every plugin oxlint implements natively, derived from the generated rule
@@ -2681,6 +2764,7 @@ function isNativePlugin(prefix) {
 */
 const consumerAnchor = pathToFileURL(`${process.cwd()}/`).href;
 const specifierCache = /* @__PURE__ */ new Map();
+const NO_OVERRIDES = /* @__PURE__ */ new Set();
 /**
 * Resolve a jsPlugin specifier, throwing when the package is not installed.
 *
@@ -2785,16 +2869,22 @@ function scopeOverridePlugins(overrides, globalPlugins) {
 *
 * @param overrides - The merged overrides (mutated).
 * @param registeredPlugins - Every native plugin and jsPlugin name registered.
+* @returns The oxlint names of the rules that were deleted.
 */
 function stripUnregisteredPluginRules(overrides, registeredPlugins) {
+	const stripped = /* @__PURE__ */ new Set();
 	for (const override of overrides) {
 		const { rules } = override;
 		if (rules === void 0) continue;
 		for (const rule of Object.keys(rules)) {
 			const slashIndex = rule.indexOf("/");
-			if (slashIndex !== -1 && !registeredPlugins.has(rule.slice(0, slashIndex))) delete rules[rule];
+			if (slashIndex !== -1 && !registeredPlugins.has(rule.slice(0, slashIndex))) {
+				delete rules[rule];
+				stripped.add(rule);
+			}
 		}
 	}
+	return stripped;
 }
 /**
 * Split a canonical (ESLint-named) rule map into oxlint-native rules and
@@ -2804,22 +2894,32 @@ function stripUnregisteredPluginRules(overrides, registeredPlugins) {
 * rules, which only run in standalone mode) are treated as jsPlugin rules.
 * Disabled unmapped rules are skipped so that no jsPlugin is loaded solely for
 * an "off" entry, unless `keepUnmappedOff` is set (user options.rules must not
-* silently discard an explicit disable).
+* silently discard an explicit disable) or the entry is a user override, which
+* is authoritative.
 *
 * @param rules - The canonical rule map.
-* @param keepUnmappedOff - Emit disabled unmapped rules instead of skipping
-*   them (without registering a jsPlugin for them).
+* @param options - Which entries survive the filters, and which came from the
+*   user.
 * @returns The split rules with the plugins each side requires.
 */
-function splitOxlintRules(rules, keepUnmappedOff = false) {
+function splitOxlintRules(rules, { keepUnmappedOff = false, overrides = NO_OVERRIDES } = {}) {
 	const nativeRules = {};
 	const jsPluginRules = {};
 	const nativePlugins = /* @__PURE__ */ new Set();
 	const jsPluginPrefixes = /* @__PURE__ */ new Set();
 	const tsCollapsed = /* @__PURE__ */ new Set();
+	const overrideRules = /* @__PURE__ */ new Set();
 	const entries = Object.entries(rules ?? {});
 	for (const [rule, value] of entries) {
-		if (value === void 0 || excludedFromOxlint.has(rule)) continue;
+		if (value === void 0) continue;
+		const isOverride = overrides.has(rule);
+		if (excludedFromOxlint.has(rule) && (!isOverride || !isOxcCoveredRule(rule))) {
+			if (isOverride) recordDroppedOverride({
+				reason: "eslint-only",
+				rule
+			});
+			continue;
+		}
 		const covered = isOxlintCovered(rule);
 		const severity = Array.isArray(value) ? value[0] : value;
 		const isOff = severity === "off" || severity === 0;
@@ -2827,7 +2927,8 @@ function splitOxlintRules(rules, keepUnmappedOff = false) {
 		const slashIndex = translated.indexOf("/");
 		const prefix = slashIndex === -1 ? "eslint" : translated.slice(0, slashIndex);
 		const nativePrefix = isNativePlugin(prefix) ? prefix : void 0;
-		if (!covered && isOff && keepUnmappedOff) {
+		if (isOverride) overrideRules.add(translated);
+		if (!covered && isOff && (keepUnmappedOff || isOverride)) {
 			if (nativePrefix !== void 0) {
 				nativeRules[translated] = value;
 				nativePlugins.add(nativePrefix);
@@ -2836,7 +2937,10 @@ function splitOxlintRules(rules, keepUnmappedOff = false) {
 				if (specifier !== void 0 && canResolveJsPlugin(specifier)) {
 					jsPluginRules[translated] = value;
 					jsPluginPrefixes.add(prefix);
-				}
+				} else if (isOverride) recordDroppedOverride({
+					reason: "missing-plugin",
+					rule
+				});
 			}
 			continue;
 		}
@@ -2846,10 +2950,11 @@ function splitOxlintRules(rules, keepUnmappedOff = false) {
 			jsPluginPrefixes.add(prefix);
 			continue;
 		}
+		if (!isOverride && overrideRules.has(translated) && (collapsesToTsCoreRule(rule) || isTsCoreCounterpartRule(rule))) continue;
 		if (collapsesToTsCoreRule(rule)) {
 			tsCollapsed.add(translated);
 			nativeRules[translated] = value;
-		} else if (!isTsCoreCounterpartRule(rule) || !tsCollapsed.has(translated)) nativeRules[translated] = value;
+		} else if (isOverride || !isTsCoreCounterpartRule(rule) || !tsCollapsed.has(translated)) nativeRules[translated] = value;
 		if (nativePrefix !== void 0) nativePlugins.add(nativePrefix);
 	}
 	const jsPlugins = [];
@@ -2865,7 +2970,8 @@ function splitOxlintRules(rules, keepUnmappedOff = false) {
 		jsPluginRules,
 		jsPlugins,
 		nativePlugins: [...nativePlugins],
-		nativeRules
+		nativeRules,
+		overrideRules: [...overrideRules]
 	};
 }
 /**
@@ -2875,8 +2981,15 @@ function splitOxlintRules(rules, keepUnmappedOff = false) {
 * @param options - The fragment options.
 * @returns The generated config fragments.
 */
-function createOxlintConfigs({ name, excludeFiles, files, globals, keepUnmappedOff = false, rules, settings }) {
-	const { jsPluginRules, jsPlugins, nativePlugins, nativeRules } = splitOxlintRules(rules, keepUnmappedOff);
+function createOxlintConfigs({ name, excludeFiles, files, globals, keepUnmappedOff = false, overrides, rules, settings }) {
+	const { jsPluginRules, jsPlugins, nativePlugins, nativeRules, overrideRules } = splitOxlintRules(overrides === void 0 ? rules : {
+		...rules,
+		...overrides
+	}, {
+		keepUnmappedOff,
+		overrides: new Set(Object.keys(overrides ?? {}))
+	});
+	recordOverrideRules(overrideRules);
 	const fragments = [];
 	if (Object.keys(nativeRules).length > 0) fragments.push({
 		name,
@@ -3295,14 +3408,12 @@ function oxlintE18e({ excludeFiles, files = [GLOB_SRC], modernization = true, no
 		name: "isentinel/e18e",
 		...excludeFiles ? { excludeFiles } : {},
 		files: files.flat(),
-		rules: {
-			...e18eRules({
-				modernization,
-				nodeMajor,
-				performanceImprovements
-			}),
-			...overrides
-		}
+		overrides,
+		rules: e18eRules({
+			modernization,
+			nodeMajor,
+			performanceImprovements
+		})
 	}), ...createOxlintConfigs({
 		name: "isentinel/e18e/disables/test",
 		files: [...GLOB_TESTS],
@@ -3365,10 +3476,8 @@ function oxlintEslintPlugin(options = {}) {
 	return createOxlintConfigs({
 		name: "isentinel/eslint-plugin",
 		files: options.files?.flat() ?? ["**/*.{,c,m}[jt]s{,x}"],
-		rules: {
-			...eslintPluginRules(),
-			...overrides
-		}
+		overrides,
+		rules: eslintPluginRules()
 	});
 }
 //#endregion
@@ -3817,14 +3926,12 @@ function oxlintJavascript(options = {}) {
 			navigator: "readonly",
 			window: "readonly"
 		},
-		rules: {
-			...javascriptRules({
-				isInEditor,
-				roblox,
-				stylistic
-			}),
-			...overrides
-		}
+		overrides,
+		rules: javascriptRules({
+			isInEditor,
+			roblox,
+			stylistic
+		})
 	});
 }
 function toGlobals(source, override) {
@@ -4608,14 +4715,12 @@ function oxlintReact(options = {}) {
 	return [...createOxlintConfigs({
 		name: "isentinel/react",
 		files,
-		rules: {
-			...reactRules({
-				filenameCase,
-				reactCompiler,
-				stylistic
-			}),
-			...overrides
-		},
+		overrides,
+		rules: reactRules({
+			filenameCase,
+			reactCompiler,
+			stylistic
+		}),
 		settings: { "react-x": {
 			importSource: importSource ?? "@rbxts",
 			version: "17.0.2"
@@ -4681,10 +4786,8 @@ function oxlintRoblox(options = {}) {
 			"**/*/*.{,c,m}tsx",
 			...componentExtensions.map((extension) => `**/*/*.${extension}`)
 		],
-		rules: {
-			...robloxRules({ stylistic }),
-			...overrides
-		}
+		overrides,
+		rules: robloxRules({ stylistic })
 	});
 }
 //#endregion
@@ -5189,6 +5292,10 @@ function oxlintTest({ files = GLOB_TESTS, isInEditor = false, jest = false, over
 	if (enableJest) configs.push(...createOxlintConfigs({
 		name: "isentinel/test/jest",
 		files: jestOptions.files?.flat() ?? files.flat(),
+		overrides: {
+			...overrides,
+			...jestOptions.overrides
+		},
 		rules: {
 			...jestRules({
 				extended: jestOptions.extended === true,
@@ -5199,9 +5306,7 @@ function oxlintTest({ files = GLOB_TESTS, isInEditor = false, jest = false, over
 			...sonarjsTestRules({
 				jest: true,
 				roblox: isRoblox
-			}),
-			...overrides,
-			...jestOptions.overrides
+			})
 		},
 		settings: { jest: {
 			globalPackage: "@rbxts/jest-globals",
@@ -5216,15 +5321,17 @@ function oxlintTest({ files = GLOB_TESTS, isInEditor = false, jest = false, over
 	if (enableVitest) configs.push(...createOxlintConfigs({
 		name: "isentinel/test/vitest",
 		files: vitestOptions.files?.flat() ?? files.flat(),
+		overrides: {
+			...overrides,
+			...vitestOptions.overrides
+		},
 		rules: {
 			...vitestRules({
 				extended: vitestOptions.extended === true,
 				isInEditor,
 				stylistic
 			}),
-			...sonarjsTestRules({ roblox: isRoblox }),
-			...overrides,
-			...vitestOptions.overrides
+			...sonarjsTestRules({ roblox: isRoblox })
 		},
 		settings: { vitest: { typecheck: vitestOptions.typecheck ?? false } }
 	}), ...createOxlintConfigs({
@@ -5495,13 +5602,13 @@ function oxlintTypescript(options = {}) {
 		name: "isentinel/typescript",
 		...excludeFiles ? { excludeFiles } : {},
 		files,
+		overrides,
 		rules: {
 			...typescriptRecommendedOverrides(),
 			...typescriptStrictPresetRules(),
 			...typescriptRules({ stylistic }),
 			...gatedTypeAwareRules,
-			...erasableOnly ? erasableSyntaxOnlyRules() : {},
-			...overrides
+			...erasableOnly ? erasableSyntaxOnlyRules() : {}
 		}
 	});
 }
@@ -5753,7 +5860,7 @@ const NATIVE_ONLY_JS_PLUGINS = /* @__PURE__ */ new Set(["oxlint-comments"]);
 */
 function isentinel(factoryOptions, ...userConfigs) {
 	const options = factoryOptions ?? { name: "isentinel" };
-	const { categories, componentExts: componentExtensions = [], e18e: enableE18e = true, env, eslintPlugin: enableEslintPlugin = false, formatters, gitignore: enableGitignore = true, globals, ignores, jsdoc: enableJsdoc = true, jsPlugins: userJsPlugins, jsx: enableJsx = true, options: linterOptions, oxc: enableOxc = true, react: enableReact = false, root: customRootGlobs, rules = {}, spellCheck: enableSpellCheck, test: enableTest = false } = options;
+	const { categories, componentExts: componentExtensions = [], e18e: enableE18e = true, env, eslintPlugin: enableEslintPlugin = false, formatters, gitignore: enableGitignore = true, globals, ignores, jsdoc: enableJsdoc = true, jsPlugins: userJsPlugins, jsx: enableJsx = true, options: linterOptions, oxc: enableOxc = true, react: enableReact = false, root: customRootGlobs, rules = {}, spellCheck: enableSpellCheck, test: enableTest = false, warnDroppedOverrides: enableDroppedOverrideWarning = true } = options;
 	const rootGlobs = mergeGlobs(GLOB_ROOT, customRootGlobs);
 	const enableRoblox = options.roblox !== false;
 	const nativeOnly = userJsPlugins === false;
@@ -5938,9 +6045,12 @@ function isentinel(factoryOptions, ...userConfigs) {
 		if (override.excludeFiles !== void 0) override.excludeFiles = override.excludeFiles.map(anchorOxlintGlob);
 		overrides.push(override);
 	}
+	const removedRules = /* @__PURE__ */ new Set();
 	for (const fragment of configs.flat()) {
 		if (nativeOnly && droppedByNativeOnly(fragment)) {
 			if (fragment.settings) Object.assign(mergedSettings, fragment.settings);
+			const fragmentRules = Object.keys(fragment.rules ?? {});
+			for (const rule of fragmentRules) removedRules.add(rule);
 			continue;
 		}
 		mergeFragment(fragment);
@@ -5964,12 +6074,21 @@ function isentinel(factoryOptions, ...userConfigs) {
 	});
 	for (const userConfig of userConfigs) mergeFragment(userConfig);
 	if (Array.isArray(userJsPlugins)) for (const jsPlugin of userJsPlugins) jsPlugins.set(jsPluginKey(jsPlugin), jsPlugin);
-	if (nativeOnly) stripUnregisteredPluginRules(overrides, /* @__PURE__ */ new Set([...nativePlugins, ...jsPlugins.keys()]));
+	if (nativeOnly) {
+		const stripped = stripUnregisteredPluginRules(overrides, /* @__PURE__ */ new Set([...nativePlugins, ...jsPlugins.keys()]));
+		for (const rule of stripped) removedRules.add(rule);
+	}
 	scopeOverridePlugins(overrides, globalPlugins);
 	if (defaultSeverity) {
 		const severityExcludeRules = /* @__PURE__ */ new Set(["sonar/todo-tag"]);
 		for (const override of overrides) if (override.rules) override.rules = overrideRuleSeverity(override.rules, defaultSeverity, severityExcludeRules);
 	}
+	const { dropped, emitted } = takeOverrideDiagnostics();
+	for (const rule of removedRules) if (emitted.has(rule)) dropped.push({
+		reason: "native-only",
+		rule
+	});
+	if (enableDroppedOverrideWarning) warnDroppedOverrides(dropped);
 	return defineConfig({
 		categories: {
 			...DEFAULT_CATEGORIES,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@isentinel/eslint-config",
-  "version": "6.0.0-beta.27",
+  "version": "6.0.0-beta.28",
   "description": "iSentinel's ESLint config",
   "keywords": [
     "eslint-config",
@@ -142,7 +142,7 @@
     "typescript": "6.0.3",
     "unplugin-unused": "0.5.7",
     "vitest": "4.1.10",
-    "@isentinel/eslint-config": "6.0.0-beta.27"
+    "@isentinel/eslint-config": "6.0.0-beta.28"
   },
   "peerDependencies": {
     "@vitest/eslint-plugin": "^1.6.4",