@isentinel/eslint-config 0.4.0 → 0.5.1

package/dist/index.cjs

@@ -40,9 +40,9 @@ var init_cjs_shims = __esm({
   }
 });
 
-// node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.1.1/node_modules/eslint-plugin-simple-import-sort/shared.js
+// node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.3.0/node_modules/eslint-plugin-simple-import-sort/shared.js
 var require_shared = __commonJS({
-  "node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.1.1/node_modules/eslint-plugin-simple-import-sort/shared.js"(exports2, module2) {
+  "node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.3.0/node_modules/eslint-plugin-simple-import-sort/shared.js"(exports2, module2) {
     "use strict";
     init_cjs_shims();
     function extractChunks(parentNode, isPartOfChunk) {
@@ -581,9 +581,9 @@ var require_shared = __commonJS({
   }
 });
 
-// node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.1.1/node_modules/eslint-plugin-simple-import-sort/imports.js
+// node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.3.0/node_modules/eslint-plugin-simple-import-sort/imports.js
 var require_imports = __commonJS({
-  "node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.1.1/node_modules/eslint-plugin-simple-import-sort/imports.js"(exports2, module2) {
+  "node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.3.0/node_modules/eslint-plugin-simple-import-sort/imports.js"(exports2, module2) {
     "use strict";
     init_cjs_shims();
     var shared = require_shared();
@@ -708,9 +708,9 @@ var require_imports = __commonJS({
   }
 });
 
-// node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.1.1/node_modules/eslint-plugin-simple-import-sort/exports.js
+// node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.3.0/node_modules/eslint-plugin-simple-import-sort/exports.js
 var require_exports = __commonJS({
-  "node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.1.1/node_modules/eslint-plugin-simple-import-sort/exports.js"(exports2, module2) {
+  "node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.3.0/node_modules/eslint-plugin-simple-import-sort/exports.js"(exports2, module2) {
     "use strict";
     init_cjs_shims();
     var shared = require_shared();
@@ -799,9 +799,9 @@ var require_exports = __commonJS({
   }
 });
 
-// node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.1.1/node_modules/eslint-plugin-simple-import-sort/index.js
+// node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.3.0/node_modules/eslint-plugin-simple-import-sort/index.js
 var require_eslint_plugin_simple_import_sort = __commonJS({
-  "node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.1.1/node_modules/eslint-plugin-simple-import-sort/index.js"(exports2, module2) {
+  "node_modules/.pnpm/eslint-plugin-simple-import-sort@12.1.0_eslint@9.3.0/node_modules/eslint-plugin-simple-import-sort/index.js"(exports2, module2) {
     "use strict";
     init_cjs_shims();
     var importsRule = require_imports();
@@ -897,11 +897,11 @@ var pluginImport = __toESM(require("eslint-plugin-import-x"), 1);
 var import_eslint_plugin_no_autofix = __toESM(require("eslint-plugin-no-autofix"), 1);
 var import_eslint_plugin_perfectionist = __toESM(require("eslint-plugin-perfectionist"), 1);
 var import_eslint_plugin_promise = __toESM(require("eslint-plugin-promise"), 1);
-var import_eslint_plugin_roblox_ts = __toESM(require("eslint-plugin-roblox-ts"), 1);
 var import_eslint_plugin_simple_import_sort = __toESM(require_eslint_plugin_simple_import_sort(), 1);
 var pluginSonar = __toESM(require("eslint-plugin-sonarjs"), 1);
 var import_eslint_plugin_unicorn = __toESM(require("eslint-plugin-unicorn"), 1);
 var import_eslint_plugin_unused_imports = __toESM(require("eslint-plugin-unused-imports"), 1);
+var import_isentinel_eslint_plugin_roblox_ts = __toESM(require("isentinel-eslint-plugin-roblox-ts"), 1);
 
 // src/configs/comments.ts
 async function comments() {
@@ -1006,11 +1006,13 @@ async function combine(...configs) {
   const resolved = await Promise.all(configs);
   return resolved.flat();
 }
-function renameRules(rules, from, to) {
+function renameRules(rules, map) {
   return Object.fromEntries(
     Object.entries(rules).map(([key, value]) => {
-      if (key.startsWith(from)) {
-        return [to + key.slice(from.length), value];
+      for (const [from, to] of Object.entries(map)) {
+        if (key.startsWith(`${from}/`)) {
+          return [to + key.slice(from.length), value];
+        }
       }
       return [key, value];
     })
@@ -1376,7 +1378,7 @@ async function jsdoc(options = {}) {
       },
       rules: {
         "jsdoc/check-access": "warn",
-        "jsdoc/check-param-names": "warn",
+        "jsdoc/check-param-names": ["warn", { checkDestructured: false }],
         "jsdoc/check-property-names": "warn",
         "jsdoc/check-types": "warn",
         "jsdoc/empty-tags": "warn",
@@ -1391,7 +1393,10 @@ async function jsdoc(options = {}) {
         "jsdoc/require-description": ["warn", { exemptedBy: ["hidden, ignore"] }],
         "jsdoc/require-description-complete-sentence": "warn",
         "jsdoc/require-hyphen-before-param-description": "warn",
-        "jsdoc/require-param": ["warn", { exemptedBy: ["hidden"] }],
+        "jsdoc/require-param": [
+          "warn",
+          { checkDestructured: false, exemptedBy: ["ignore"] }
+        ],
         "jsdoc/require-param-description": "warn",
         "jsdoc/require-param-name": "warn",
         "jsdoc/require-property": "warn",
@@ -1627,23 +1632,23 @@ async function perfectionist() {
 
 // src/configs/prettier.ts
 init_cjs_shims();
-async function prettier(options = {}) {
-  const { componentExts: componentExtensions = [] } = options;
-  const files = options.files ?? [
+async function prettier(options) {
+  const {
+    componentExts: componentExtensions = [],
+    files: prettierFiles,
+    prettierOptions
+  } = options ?? {};
+  const files = prettierFiles ?? [
     GLOB_SRC,
     ...componentExtensions.map((extension) => `**/*.${extension}`)
   ];
-  const prettierOptions = {
+  const defaultPrettierOptions = prettierOptions ?? {
     arrowParens: "avoid",
-    jsdocPreferCodeFences: true,
-    jsdocPrintWidth: 80,
-    plugins: ["prettier-plugin-jsdoc"],
-    printWidth: 100,
+    printWidth: 120,
     semi: true,
     singleQuote: false,
     tabWidth: 4,
     trailingComma: "all",
-    tsdoc: true,
     useTabs: true
   };
   return [
@@ -1659,7 +1664,7 @@ async function prettier(options = {}) {
         "format/prettier": [
           "error",
           {
-            ...prettierOptions,
+            ...defaultPrettierOptions,
             parser: "typescript"
           }
         ],
@@ -1760,12 +1765,13 @@ async function prettier(options = {}) {
 
 // src/configs/promise.ts
 init_cjs_shims();
+var import_compat = require("@eslint/compat");
 async function promise() {
   return [
     {
       name: "style:promise",
       plugins: {
-        promise: import_eslint_plugin_promise.default
+        promise: (0, import_compat.fixupPluginRules)(import_eslint_plugin_promise.default)
       },
       rules: {
         "promise/always-return": [
@@ -1785,11 +1791,11 @@ async function promise() {
         "promise/no-callback-in-promise": "off",
         "promise/no-multiple-resolved": "warn",
         "promise/no-native": "off",
-        // "promise/no-nesting": "warn",
+        "promise/no-nesting": "warn",
         "promise/no-new-statics": "off",
-        // "promise/no-promise-in-callback": "warn",
+        "promise/no-promise-in-callback": "warn",
         "promise/no-return-in-finally": "warn",
-        // "promise/no-return-wrap": "error",
+        "promise/no-return-wrap": "error",
         "promise/param-names": "warn",
         "promise/prefer-await-to-callbacks": "off",
         "promise/prefer-await-to-then": "off"
@@ -1800,8 +1806,9 @@ async function promise() {
 
 // src/configs/react.ts
 init_cjs_shims();
+var import_compat2 = require("@eslint/compat");
 async function react(options = {}) {
-  const { files = [GLOB_JSX, GLOB_TSX], overrides = {} } = options;
+  const { files = [GLOB_TS, GLOB_TSX], overrides = {} } = options;
   await ensurePackages(["@eslint-react/eslint-plugin", "eslint-plugin-react-hooks"]);
   const [pluginReact, pluginReactHooks, pluginStylistic, parserTs] = await Promise.all([
     interopDefault(import("@eslint-react/eslint-plugin")),
@@ -1815,16 +1822,11 @@ async function react(options = {}) {
     {
       name: "style:react:setup",
       plugins: {
-        react: pluginReact,
-        "react-hooks": pluginReactHooks,
+        react: plugins["@eslint-react"],
+        "react-hooks": (0, import_compat2.fixupPluginRules)(pluginReactHooks),
         "react-hooks-extra": plugins["@eslint-react/hooks-extra"],
         "react-naming-convention": plugins["@eslint-react/naming-convention"],
         style: pluginStylistic
-      },
-      settings: {
-        react: {
-          version: "detect"
-        }
       }
     },
     {
@@ -1841,9 +1843,8 @@ async function react(options = {}) {
       },
       name: "style:react:rules",
       rules: {
+        // recommended rules from @eslint-react
         "react/ensure-forward-ref-using-ref": "warn",
-        // recommended rules from @eslint-react/naming-convention
-        "react/naming-convention/use-state": "error",
         "react/no-access-state-in-setstate": "error",
         "react/no-array-index-key": "warn",
         "react/no-children-count": "warn",
@@ -1852,18 +1853,17 @@ async function react(options = {}) {
         "react/no-children-only": "warn",
         "react/no-children-prop": "warn",
         "react/no-children-to-array": "warn",
-        // recommended rules from @eslint-react
         "react/no-class-component": "error",
         "react/no-clone-element": "warn",
         "react/no-comment-textnodes": "warn",
-        "react/no-complicated-conditional-rendering": "warn",
+        "react/no-complicated-conditional-rendering": "off",
         "react/no-component-will-mount": "error",
         "react/no-component-will-receive-props": "error",
         "react/no-component-will-update": "error",
         "react/no-create-ref": "error",
         "react/no-direct-mutation-state": "error",
         "react/no-duplicate-key": "error",
-        "react/no-implicit-key": "error",
+        "react/no-implicit-key": "off",
         "react/no-leaked-conditional-rendering": "warn",
         "react/no-missing-key": "error",
         "react/no-nested-components": "warn",
@@ -1887,8 +1887,12 @@ async function react(options = {}) {
         "react-hooks/exhaustive-deps": "warn",
         "react-hooks/rules-of-hooks": "error",
         // recommended rules from @eslint-react/hooks-extra
-        "react-hooks-extra/ensure-custom-hooks-using-other-hooks": "warn",
-        "react-hooks-extra/ensure-use-callback-has-non-empty-deps": "warn",
+        "react-hooks-extra/ensure-custom-hooks-using-other-hooks": "error",
+        "react-hooks-extra/ensure-use-callback-has-non-empty-deps": "error",
+        "react-hooks-extra/ensure-use-memo-has-non-empty-deps": "error",
+        "react-hooks-extra/prefer-use-state-lazy-initialization": "error",
+        // recommended rules from @eslint-react/naming-convention
+        "react-naming-convention/use-state": "error",
         // "react/destructuring-assignment": [
         // 	"error",
         // 	"always",
@@ -1945,8 +1949,6 @@ async function react(options = {}) {
         // 		component: true,
         // 	},
         // ],
-        "react-hooks-extra/ensure-use-memo-has-non-empty-deps": "warn",
-        "react-hooks-extra/prefer-use-state-lazy-initialization": "warn",
         "style/jsx-curly-brace-presence": [
           "error",
           {
@@ -1971,6 +1973,10 @@ async function react(options = {}) {
       settings: {
         react: {
           version: "17.0"
+        },
+        reactOptions: {
+          importSource: "@rbxts",
+          jsxPragma: "React"
         }
       }
     },
@@ -2013,7 +2019,7 @@ async function roblox(options = {}) {
       },
       name: "style:roblox",
       plugins: {
-        roblox: import_eslint_plugin_roblox_ts.default
+        roblox: import_isentinel_eslint_plugin_roblox_ts.default
       },
       rules: {
         "roblox/lua-truthiness": "warn",
@@ -2044,17 +2050,18 @@ async function roblox(options = {}) {
 
 // src/configs/shopify.ts
 init_cjs_shims();
+var import_compat3 = require("@eslint/compat");
 async function shopify() {
   return [
     {
       name: "style:shopify",
       plugins: {
-        shopify: import_eslint_plugin.default
+        shopify: (0, import_compat3.fixupPluginRules)(import_eslint_plugin.default)
       },
       rules: {
         "shopify/prefer-class-properties": "error",
         "shopify/prefer-early-return": ["error", { maximumStatements: 1 }],
-        // "shopify/prefer-module-scope-constants": "error",
+        "shopify/prefer-module-scope-constants": "error",
         "shopify/strict-component-boundaries": "error",
         "shopify/typescript/prefer-pascal-case-enums": "error",
         "shopify/typescript/prefer-singular-enums": "error"
@@ -2086,8 +2093,8 @@ async function sonarjs() {
         ],
         "sonar/no-duplicated-branches": "error",
         "sonar/no-element-overwrite": "error",
-        // "sonar/no-empty-collection": "error",
-        // "sonar/no-gratuitous-expressions": "off",
+        "sonar/no-empty-collection": "error",
+        "sonar/no-gratuitous-expressions": "off",
         "sonar/no-identical-conditions": "error",
         "sonar/no-identical-expressions": "error",
         "sonar/no-identical-functions": "error",
@@ -2095,11 +2102,11 @@ async function sonarjs() {
         "sonar/no-inverted-boolean-check": "error",
         "sonar/no-nested-switch": "error",
         "sonar/no-nested-template-literals": "error",
-        // "sonar/no-one-iteration-loop": "error",
+        "sonar/no-one-iteration-loop": "error",
         "sonar/no-redundant-boolean": "error",
-        // "sonar/no-redundant-jump": "error",
-        // "sonar/no-unused-collection": "error",
-        // "sonar/no-use-of-empty-return-value": "error",
+        "sonar/no-redundant-jump": "error",
+        "sonar/no-unused-collection": "error",
+        "sonar/no-use-of-empty-return-value": "error",
         "sonar/no-useless-catch": "error",
         "sonar/non-existent-operator": "error",
         "sonar/prefer-immediate-return": "error",
@@ -2481,12 +2488,10 @@ async function typescript(options = {}) {
       },
       name: "style:typescript:rules",
       rules: {
-        ...renameRules(
-          pluginTs.configs["eslint-recommended"].overrides?.[0].rules ?? {},
-          "@typescript-eslint/",
-          "ts/"
-        ),
-        ...renameRules(pluginTs.configs.strict.rules ?? {}, "@typescript-eslint/", "ts/"),
+        ...renameRules(pluginTs.configs["eslint-recommended"].overrides?.[0].rules ?? {}, {
+          "@typescript-eslint": "ts"
+        }),
+        ...renameRules(pluginTs.configs.strict.rules ?? {}, { "@typescript-eslint": "ts" }),
         "array-callback-return": [
           "error",
           {
@@ -2503,6 +2508,13 @@ async function typescript(options = {}) {
           }
         ],
         "logical-assignment-operators": "error",
+        "max-classes-per-file": "error",
+        "max-depth": "error",
+        "max-lines": "warn",
+        "max-lines-per-function": [
+          "warn",
+          { max: 30, skipBlankLines: true, skipComments: true }
+        ],
         "no-autofix/no-useless-return": "error",
         "no-autofix/prefer-const": [
           "error",
@@ -2533,6 +2545,7 @@ async function typescript(options = {}) {
         "no-useless-return": "off",
         "object-shorthand": "error",
         "prefer-const": "off",
+        "prefer-destructuring": "off",
         "ts/adjacent-overload-signatures": "error",
         "ts/array-type": [
           "error",
@@ -2659,7 +2672,7 @@ async function unicorn() {
         "unicorn/no-unreadable-array-destructuring": "error",
         "unicorn/no-unused-properties": "error",
         "unicorn/no-useless-promise-resolve-reject": "error",
-        "unicorn/no-useless-spread": "error",
+        "unicorn/no-useless-spread": "off",
         "unicorn/no-useless-undefined": ["error", { checkArguments: false }],
         "unicorn/number-literal-case": "error",
         "unicorn/prefer-default-parameters": "error",
@@ -2846,7 +2859,8 @@ function style(options = {}, ...userConfigs) {
     prettier({
       ...typeof enableTypeScript !== "boolean" ? enableTypeScript : {},
       componentExts: componentExtensions,
-      overrides: getOverrides(options, "typescript")
+      overrides: getOverrides(options, "typescript"),
+      prettierOptions: typeof options["formatters"] === "boolean" ? {} : options["formatters"]?.prettierOptions || {}
     })
   );
   const fusedConfig = flatConfigProps.reduce((accumulator, key) => {