@isaacriehm/cairn-core 0.22.5 → 0.23.0

package/dist/sensors/structural.js

@@ -1,196 +0,0 @@
-/**
- * Layer C — generic project-agnostic structural sensors.
- *
- * Triggered when the diff touches files matching the project's glob keys.
- * Each sensor inspects the POST-change content of those files (not just
- * the diff) — Layer C is "do these load-bearing files follow contract",
- * which is stricter than Layer A's "did this run add new debt".
- *
- *   route-handler-non-empty — every method in a route/controller class has a
- *                             non-trivial body. Catches "added handler that
- *                             does nothing" disguised as completion.
- *   dto-no-fake-fields      — @IsOptional() fields with no other validator
- *                             are fake-thoroughness; they look like work and
- *                             do nothing.
- *
- * Both are pattern-based; profiles plug stack-specific globs. The regex is
- * intentionally conservative (false-negatives over false-positives) — sensors
- * that fail-loud-on-noise get disabled which defeats the purpose.
- */
-import { lineOf, matchAnyGlob } from "@isaacriehm/cairn-state";
-const ROUTE_SENSOR_ID = "route-handler-non-empty";
-const DTO_SENSOR_ID = "dto-no-fake-fields";
-/** Method body that's effectively a no-op — language-agnostic regex. */
-const EMPTY_BODY_PATTERNS = [
-    // TypeScript/JavaScript class method with empty body or null/undefined return.
-    {
-        regex: /^\s*(?:public|private|protected|async)?\s*(?:async\s+)?(\w+)\s*\([^)]*\)\s*(?::\s*[^{]+)?\{\s*(?:return\s*(?:null|undefined)?\s*;?)?\s*\}/gm,
-        reason: "empty / return-null / return-undefined body",
-    },
-    // throw new Error('not implemented').
-    {
-        regex: /\b(\w+)\s*\([^)]*\)\s*(?::\s*[^{]+)?\{\s*throw\s+new\s+Error\s*\(\s*['"`][^'"`]*not[\s_]?implemented/gi,
-        reason: "throws not-implemented",
-    },
-    // Python: `def foo(...): pass` with nothing else.
-    {
-        regex: /def\s+(\w+)\s*\([^)]*\)\s*(?:->[^:]+)?:\s*\n\s*pass\s*\n/g,
-        reason: "Python def with `pass` body",
-    },
-    // Python: `def foo(...): return None`.
-    {
-        regex: /def\s+(\w+)\s*\([^)]*\)\s*(?:->[^:]+)?:\s*\n\s*return(?:\s+None)?\s*\n/g,
-        reason: "Python def returning None",
-    },
-];
-/** Detect a class context for TypeScript/JavaScript controllers. */
-const TS_CONTROLLER_HINT = /\bclass\s+\w+(?:Controller|Resource|Resolver|Handler)\b|@(?:Controller|Resource|Resolver|Handler)\b|extends\s+(?:Controller|Resource)\b/;
-/** Detect Python route registration. */
-const PY_ROUTE_HINT = /@(?:app|router|blueprint|bp)\.(?:get|post|put|patch|delete|route)\b|@route\b|class\s+\w+(?:View|Resource)\b/;
-/** Run route-handler-non-empty against changed files matching globs. */
-export function runRouteHandlerNonEmpty(args) {
-    const startedAt = Date.now();
-    const findings = [];
-    if (!args.globs || args.globs.length === 0) {
-        return {
-            sensor_id: ROUTE_SENSOR_ID,
-            ok: true,
-            duration_ms: Date.now() - startedAt,
-            findings,
-            skipped: { reason: "route_handler_globs not configured for this project" },
-        };
-    }
-    const inScope = args.diff.filter((d) => d.status !== "deleted" && matchAnyGlob(d.path, args.globs ?? []));
-    if (inScope.length === 0) {
-        return {
-            sensor_id: ROUTE_SENSOR_ID,
-            ok: true,
-            duration_ms: Date.now() - startedAt,
-            findings,
-            skipped: { reason: "no diff entries match route_handler_globs" },
-        };
-    }
-    for (const entry of inScope) {
-        const text = entry.afterContent ?? "";
-        if (text.length === 0)
-            continue;
-        if (!isRouteHandlerFile(entry.path, text))
-            continue;
-        for (const { regex, reason } of EMPTY_BODY_PATTERNS) {
-            const re = new RegExp(regex.source, regex.flags);
-            let m;
-            while ((m = re.exec(text)) !== null) {
-                const methodName = m[1] ?? "<anon>";
-                if (METHOD_ALLOWLIST.has(methodName))
-                    continue;
-                const line = lineOf(text, m.index);
-                findings.push({
-                    sensor_id: ROUTE_SENSOR_ID,
-                    path: entry.path,
-                    line,
-                    matched_text: m[0].slice(0, 200),
-                    message: `${entry.path}:${line} route-handler method \`${methodName}\` — ${reason}`,
-                    severity: "hard",
-                });
-                if (re.lastIndex === m.index)
-                    re.lastIndex += 1;
-            }
-        }
-    }
-    return {
-        sensor_id: ROUTE_SENSOR_ID,
-        ok: findings.length === 0,
-        duration_ms: Date.now() - startedAt,
-        findings,
-    };
-}
-/** Run dto-no-fake-fields against changed files matching globs. */
-export function runDtoNoFakeFields(args) {
-    const startedAt = Date.now();
-    const findings = [];
-    if (!args.globs || args.globs.length === 0) {
-        return {
-            sensor_id: DTO_SENSOR_ID,
-            ok: true,
-            duration_ms: Date.now() - startedAt,
-            findings,
-            skipped: { reason: "dto_globs not configured for this project" },
-        };
-    }
-    const inScope = args.diff.filter((d) => d.status !== "deleted" && matchAnyGlob(d.path, args.globs ?? []));
-    if (inScope.length === 0) {
-        return {
-            sensor_id: DTO_SENSOR_ID,
-            ok: true,
-            duration_ms: Date.now() - startedAt,
-            findings,
-            skipped: { reason: "no diff entries match dto_globs" },
-        };
-    }
-    for (const entry of inScope) {
-        const text = entry.afterContent ?? "";
-        if (text.length === 0)
-            continue;
-        findings.push(...findFakeOptionalFields(entry.path, text));
-    }
-    return {
-        sensor_id: DTO_SENSOR_ID,
-        ok: findings.every((f) => f.severity !== "hard"),
-        duration_ms: Date.now() - startedAt,
-        findings,
-    };
-}
-/**
- * `@IsOptional()` followed by a property declaration with NO additional
- * validator decorator on the same or preceding line(s). Capture group 1 is
- * the field name.
- */
-function findFakeOptionalFields(path, text) {
-    const findings = [];
-    // Match `@IsOptional()\n  fieldName?: Type;` with no other validator.
-    const re = /@IsOptional\s*\(\s*\)\s*\n((?:\s*@[A-Z]\w+\s*\([^)]*\)\s*\n)*)\s*(\w+)\s*\??\s*:\s*[^;\n]+;?/g;
-    let m;
-    while ((m = re.exec(text)) !== null) {
-        const otherDecorators = m[1] ?? "";
-        const field = m[2] ?? "";
-        // If only `@IsOptional()` and nothing else, that's fake-thoroughness.
-        if (otherDecorators.trim().length === 0) {
-            const line = lineOf(text, m.index);
-            findings.push({
-                sensor_id: DTO_SENSOR_ID,
-                path,
-                line,
-                matched_text: m[0].slice(0, 200),
-                message: `${path}:${line} field \`${field}\` decorated only with @IsOptional() — add a validator (@IsString, @IsNumber, etc.) or remove the decorator`,
-                severity: "soft",
-            });
-        }
-        if (re.lastIndex === m.index)
-            re.lastIndex += 1;
-    }
-    return findings;
-}
-/** Methods we don't want to flag: constructors, framework hooks, etc. */
-const METHOD_ALLOWLIST = new Set([
-    "constructor",
-    "ngOnInit",
-    "ngOnDestroy",
-    "onModuleInit",
-    "onModuleDestroy",
-    "onApplicationBootstrap",
-    "onApplicationShutdown",
-    "render",
-]);
-/** Heuristic: file LOOKS like a route/controller before regex-scanning bodies. */
-function isRouteHandlerFile(path, text) {
-    if (TS_CONTROLLER_HINT.test(text))
-        return true;
-    if (PY_ROUTE_HINT.test(text))
-        return true;
-    // Conservative fallback — if the path matches the glob but the file doesn't
-    // declare a class or route decorator, skip rather than false-positive.
-    void path;
-    return false;
-}
-/** 1-based line number from a character offset. */
-//# sourceMappingURL=structural.js.map

package/dist/sensors/structural.js.map

@@ -1 +0,0 @@
-{"version":3,"file":"structural.js","sourceRoot":"","sources":["../../src/sensors/structural.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;GAkBG;AAEH,OAAO,EAAE,MAAM,EAAE,YAAY,EAAE,MAAM,yBAAyB,CAAC;AAG/D,MAAM,eAAe,GAAG,yBAAyB,CAAC;AAClD,MAAM,aAAa,GAAG,oBAAoB,CAAC;AAE3C,wEAAwE;AACxE,MAAM,mBAAmB,GAAwC;IAC/D,+EAA+E;IAC/E;QACE,KAAK,EAAE,6IAA6I;QACpJ,MAAM,EAAE,6CAA6C;KACtD;IACD,sCAAsC;IACtC;QACE,KAAK,EAAE,wGAAwG;QAC/G,MAAM,EAAE,wBAAwB;KACjC;IACD,kDAAkD;IAClD;QACE,KAAK,EAAE,2DAA2D;QAClE,MAAM,EAAE,6BAA6B;KACtC;IACD,uCAAuC;IACvC;QACE,KAAK,EAAE,yEAAyE;QAChF,MAAM,EAAE,2BAA2B;KACpC;CACF,CAAC;AAEF,oEAAoE;AACpE,MAAM,kBAAkB,GAAG,yIAAyI,CAAC;AAErK,wCAAwC;AACxC,MAAM,aAAa,GAAG,6GAA6G,CAAC;AAEpI,wEAAwE;AACxE,MAAM,UAAU,uBAAuB,CAAC,IAGvC;IACC,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;IAC7B,MAAM,QAAQ,GAAoB,EAAE,CAAC;IACrC,IAAI,CAAC,IAAI,CAAC,KAAK,IAAI,IAAI,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC3C,OAAO;YACL,SAAS,EAAE,eAAe;YAC1B,EAAE,EAAE,IAAI;YACR,WAAW,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;YACnC,QAAQ;YACR,OAAO,EAAE,EAAE,MAAM,EAAE,qDAAqD,EAAE;SAC3E,CAAC;IACJ,CAAC;IACD,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,CAC9B,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,SAAS,IAAI,YAAY,CAAC,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC,CACxE,CAAC;IACF,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACzB,OAAO;YACL,SAAS,EAAE,eAAe;YAC1B,EAAE,EAAE,IAAI;YACR,WAAW,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;YACnC,QAAQ;YACR,OAAO,EAAE,EAAE,MAAM,EAAE,2CAA2C,EAAE;SACjE,CAAC;IACJ,CAAC;IACD,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;QAC5B,MAAM,IAAI,GAAG,KAAK,CAAC,YAAY,IAAI,EAAE,CAAC;QACtC,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QAChC,IAAI,CAAC,kBAAkB,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,CAAC;YAAE,SAAS;QACpD,KAAK,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,IAAI,mBAAmB,EAAE,CAAC;YACpD,MAAM,EAAE,GAAG,IAAI,MAAM,CAAC,KAAK,CAAC,MAAM,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC;YACjD,IAAI,CAAyB,CAAC;YAC9B,OAAO,CAAC,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;gBACpC,MAAM,UAAU,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,QAAQ,CAAC;gBACpC,IAAI,gBAAgB,CAAC,GAAG,CAAC,UAAU,CAAC;oBAAE,SAAS;gBAC/C,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC;gBACnC,QAAQ,CAAC,IAAI,CAAC;oBACZ,SAAS,EAAE,eAAe;oBAC1B,IAAI,EAAE,KAAK,CAAC,IAAI;oBAChB,IAAI;oBACJ,YAAY,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;oBAChC,OAAO,EAAE,GAAG,KAAK,CAAC,IAAI,IAAI,IAAI,2BAA2B,UAAU,QAAQ,MAAM,EAAE;oBACnF,QAAQ,EAAE,MAAM;iBACjB,CAAC,CAAC;gBACH,IAAI,EAAE,CAAC,SAAS,KAAK,CAAC,CAAC,KAAK;oBAAE,EAAE,CAAC,SAAS,IAAI,CAAC,CAAC;YAClD,CAAC;QACH,CAAC;IACH,CAAC;IACD,OAAO;QACL,SAAS,EAAE,eAAe;QAC1B,EAAE,EAAE,QAAQ,CAAC,MAAM,KAAK,CAAC;QACzB,WAAW,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;QACnC,QAAQ;KACT,CAAC;AACJ,CAAC;AAED,mEAAmE;AACnE,MAAM,UAAU,kBAAkB,CAAC,IAGlC;IACC,MAAM,SAAS,GAAG,IAAI,CAAC,GAAG,EAAE,CAAC;IAC7B,MAAM,QAAQ,GAAoB,EAAE,CAAC;IACrC,IAAI,CAAC,IAAI,CAAC,KAAK,IAAI,IAAI,CAAC,KAAK,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QAC3C,OAAO;YACL,SAAS,EAAE,aAAa;YACxB,EAAE,EAAE,IAAI;YACR,WAAW,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;YACnC,QAAQ;YACR,OAAO,EAAE,EAAE,MAAM,EAAE,2CAA2C,EAAE;SACjE,CAAC;IACJ,CAAC;IACD,MAAM,OAAO,GAAG,IAAI,CAAC,IAAI,CAAC,MAAM,CAC9B,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,MAAM,KAAK,SAAS,IAAI,YAAY,CAAC,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,KAAK,IAAI,EAAE,CAAC,CACxE,CAAC;IACF,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACzB,OAAO;YACL,SAAS,EAAE,aAAa;YACxB,EAAE,EAAE,IAAI;YACR,WAAW,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;YACnC,QAAQ;YACR,OAAO,EAAE,EAAE,MAAM,EAAE,iCAAiC,EAAE;SACvD,CAAC;IACJ,CAAC;IACD,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;QAC5B,MAAM,IAAI,GAAG,KAAK,CAAC,YAAY,IAAI,EAAE,CAAC;QACtC,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;YAAE,SAAS;QAChC,QAAQ,CAAC,IAAI,CAAC,GAAG,sBAAsB,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC;IAC7D,CAAC;IACD,OAAO;QACL,SAAS,EAAE,aAAa;QACxB,EAAE,EAAE,QAAQ,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,MAAM,CAAC;QAChD,WAAW,EAAE,IAAI,CAAC,GAAG,EAAE,GAAG,SAAS;QACnC,QAAQ;KACT,CAAC;AACJ,CAAC;AAED;;;;GAIG;AACH,SAAS,sBAAsB,CAAC,IAAY,EAAE,IAAY;IACxD,MAAM,QAAQ,GAAoB,EAAE,CAAC;IACrC,sEAAsE;IACtE,MAAM,EAAE,GAAG,+FAA+F,CAAC;IAC3G,IAAI,CAAyB,CAAC;IAC9B,OAAO,CAAC,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;QACpC,MAAM,eAAe,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;QACnC,MAAM,KAAK,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;QACzB,sEAAsE;QACtE,IAAI,eAAe,CAAC,IAAI,EAAE,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACxC,MAAM,IAAI,GAAG,MAAM,CAAC,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,CAAC;YACnC,QAAQ,CAAC,IAAI,CAAC;gBACZ,SAAS,EAAE,aAAa;gBACxB,IAAI;gBACJ,IAAI;gBACJ,YAAY,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,GAAG,CAAC;gBAChC,OAAO,EAAE,GAAG,IAAI,IAAI,IAAI,YAAY,KAAK,6GAA6G;gBACtJ,QAAQ,EAAE,MAAM;aACjB,CAAC,CAAC;QACL,CAAC;QACD,IAAI,EAAE,CAAC,SAAS,KAAK,CAAC,CAAC,KAAK;YAAE,EAAE,CAAC,SAAS,IAAI,CAAC,CAAC;IAClD,CAAC;IACD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,yEAAyE;AACzE,MAAM,gBAAgB,GAAG,IAAI,GAAG,CAAS;IACvC,aAAa;IACb,UAAU;IACV,aAAa;IACb,cAAc;IACd,iBAAiB;IACjB,wBAAwB;IACxB,uBAAuB;IACvB,QAAQ;CACT,CAAC,CAAC;AAEH,kFAAkF;AAClF,SAAS,kBAAkB,CAAC,IAAY,EAAE,IAAY;IACpD,IAAI,kBAAkB,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,IAAI,CAAC;IAC/C,IAAI,aAAa,CAAC,IAAI,CAAC,IAAI,CAAC;QAAE,OAAO,IAAI,CAAC;IAC1C,4EAA4E;IAC5E,uEAAuE;IACvE,KAAK,IAAI,CAAC;IACV,OAAO,KAAK,CAAC;AACf,CAAC;AAED,mDAAmD"}