@ironfang/n8n-nodes-ironfang 0.3.0 → 0.3.1

package/README.md

@@ -6,8 +6,9 @@ Use Renderwolf, Financewolf, Auditwolf and Ironfang's public developer tools in
 n8n. The Ironfang action node has **103 operations**, grouped by product. Ironfang
 Trigger receives signed Auditwolf and Renderwolf events.
 
-**Release: 0.3.0.** This version includes the product expansion and signed event
-trigger described below, plus the maintenance fixes from 0.2.3.
+**Release: 0.3.1.** This patch addresses the n8n submission feedback on webhook
+lifecycle hooks, static operation defaults and the shared Renderwolf module.
+It includes the product expansion and signed event trigger from 0.3.0.
 
 ## Installation and credentials
 
@@ -136,6 +137,10 @@ deleting the n8n workflow removes its local listener; disable/delete the product
 endpoint separately to stop deliveries. Rotating an endpoint secret requires
 updating the n8n credential.
 
+The required `checkExists`, `create` and `delete` lifecycle hooks acknowledge
+this external setup. They do not call the product management API or verify
+remote registration. Use Test Webhook/Test Destination to check delivery.
+
 ## Outputs, examples and compatibility
 
 Existing Renderwolf version 1 workflows retain string `bytes` and `error`
@@ -168,6 +173,8 @@ Run `npm ci --ignore-scripts` and `npm run check`. With Docker, run
 `bash scripts/check-runtime.sh` and `bash scripts/check-webhook-runtime.sh`.
 These execute local fixtures, including multipart/file handling and signed
 webhooks; they make no paid API calls. CI requires both before release.
+Lint runs with inline configuration disabled, matching the submission scanner's
+handling of suppression comments. Shared code in `lib/` is also linted and packaged.
 
 To refresh the catalogue from an Ironfang source checkout, use
 `python3 scripts/sync-contracts.py /path/to/ironfang` (development-only PyYAML).

package/dist/{nodes/Ironfang → lib}/renderwolf.d.ts

@@ -1,5 +1,5 @@
 import type { IExecuteFunctions, INodeExecutionData, INodeTypeDescription } from 'n8n-workflow';
-import { credentialTest } from './credentialTest';
+import { credentialTest } from '../nodes/Ironfang/credentialTest';
 /**
  * Ironfang node. One node per vendor: pick a product with Resource, then an
  * operation within it. Renderwolf (https://ironfang.uk/renderwolf/docs) is the

package/dist/{nodes/Ironfang → lib}/renderwolf.js

@@ -2,8 +2,8 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.renderwolf = void 0;
 const n8n_workflow_1 = require("n8n-workflow");
-const transport_1 = require("./transport");
-const credentialTest_1 = require("./credentialTest");
+const transport_1 = require("../nodes/Ironfang/transport");
+const credentialTest_1 = require("../nodes/Ironfang/credentialTest");
 /**
  * Ironfang node. One node per vendor: pick a product with Resource, then an
  * operation within it. Renderwolf (https://ironfang.uk/renderwolf/docs) is the

package/dist/nodes/Ironfang/Ironfang.node.js

@@ -1,7 +1,7 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.Ironfang = void 0;
-const renderwolf_1 = require("./renderwolf");
+const renderwolf_1 = require("../../lib/renderwolf");
 const catalog_1 = require("./catalog");
 const parameters_1 = require("./parameters");
 const execute_1 = require("./execute");
@@ -10,15 +10,31 @@ const templates_1 = require("./templates");
 const destinationCredentialTest_1 = require("./destinationCredentialTest");
 const legacy = renderwolf_1.renderwolf;
 const legacyOperations = (legacy.description.properties[1].options ?? []);
-const products = ['auditwolf', 'financewolf', 'renderwolf', 'tools'];
-// Resource-specific defaults are selected from the checked-in catalogue.
-// eslint-disable-next-line n8n-nodes-base/node-param-default-missing
-const operationParameters = products.map(product => ({
-    displayName: 'Operation', name: 'operation', type: 'options', noDataExpression: true,
-    default: product === 'renderwolf' ? 'screenshot' : catalog_1.operations.find(op => op.product === product).id,
-    displayOptions: { show: { resource: [product] } },
-    options: [...(product === 'renderwolf' ? legacyOperations : []), ...catalog_1.operations.filter(op => op.product === product).map(op => ({ name: op.name, value: op.id, description: op.description, action: op.description }))].sort((a, b) => a.name.localeCompare(b.name)),
-}));
+function operationOptions(product) {
+    return [...(product === 'renderwolf' ? legacyOperations : []), ...catalog_1.operations.filter(op => op.product === product).map(op => ({ name: op.name, value: op.id, description: op.description, action: op.description }))].sort((a, b) => a.name.localeCompare(b.name));
+}
+const operationParameters = [
+    {
+        displayName: 'Operation', name: 'operation', type: 'options', noDataExpression: true,
+        default: 'archiveMonitorsByMonitorId', displayOptions: { show: { resource: ['auditwolf'] } },
+        options: operationOptions('auditwolf'),
+    },
+    {
+        displayName: 'Operation', name: 'operation', type: 'options', noDataExpression: true,
+        default: 'deleteValidationResult', displayOptions: { show: { resource: ['financewolf'] } },
+        options: operationOptions('financewolf'),
+    },
+    {
+        displayName: 'Operation', name: 'operation', type: 'options', noDataExpression: true,
+        default: 'screenshot', displayOptions: { show: { resource: ['renderwolf'] } },
+        options: operationOptions('renderwolf'),
+    },
+    {
+        displayName: 'Operation', name: 'operation', type: 'options', noDataExpression: true,
+        default: 'convertImage', displayOptions: { show: { resource: ['tools'] } },
+        options: operationOptions('tools'),
+    },
+];
 class Ironfang {
     description = {
         ...legacy.description,

package/dist/nodes/Ironfang/IronfangTrigger.node.d.ts

@@ -1,4 +1,4 @@
-import type { INodeType, INodeTypeDescription, IWebhookFunctions, IWebhookResponseData } from 'n8n-workflow';
+import type { IHookFunctions, INodeType, INodeTypeDescription, IWebhookFunctions, IWebhookResponseData } from 'n8n-workflow';
 import { webhookCredentialTest } from './webhook';
 export declare class IronfangTrigger implements INodeType {
     description: INodeTypeDescription;
@@ -7,5 +7,12 @@ export declare class IronfangTrigger implements INodeType {
             ironfangWebhookTest: typeof webhookCredentialTest;
         };
     };
+    webhookMethods: {
+        default: {
+            checkExists(this: IHookFunctions): Promise<boolean>;
+            create(this: IHookFunctions): Promise<boolean>;
+            delete(this: IHookFunctions): Promise<boolean>;
+        };
+    };
     webhook(this: IWebhookFunctions): Promise<IWebhookResponseData>;
 }

package/dist/nodes/Ironfang/IronfangTrigger.node.js

@@ -3,8 +3,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.IronfangTrigger = void 0;
 const n8n_workflow_1 = require("n8n-workflow");
 const webhook_1 = require("./webhook");
-// Endpoints are registered explicitly and remain customer-owned; n8n owns its local route.
-// eslint-disable-next-line @n8n/community-nodes/webhook-lifecycle-complete
 class IronfangTrigger {
     description = {
         displayName: 'Ironfang Trigger', name: 'ironfangTrigger', group: ['trigger'], version: 1,
@@ -18,6 +16,25 @@ class IronfangTrigger {
         ],
     };
     methods = { credentialTest: { ironfangWebhookTest: webhook_1.webhookCredentialTest } };
+    webhookMethods = {
+        default: {
+            async checkExists() {
+                // External registration is required. True skips n8n-managed remote
+                // creation; it does not assert that a product endpoint exists.
+                return true;
+            },
+            async create() {
+                // The customer registers the URL and stores its signing secret.
+                // n8n creates the local route independently of this hook.
+                return true;
+            },
+            async delete() {
+                // n8n removes its local route. Leave customer-owned endpoints and
+                // duplicate state intact for later reactivation or shared use.
+                return true;
+            },
+        },
+    };
     async webhook() {
         const req = this.getRequestObject();
         const res = this.getResponseObject();

package/docs/n8n-re-review-0.3.1.md

@@ -0,0 +1,25 @@
+# n8n re-review request — 0.3.1
+
+Draft for the existing submission after npm publication is confirmed:
+
+Please re-review `@ironfang/n8n-nodes-ironfang` version **0.3.1**
+([source tag](https://github.com/ironfang-ltd/n8n-nodes-ironfang/tree/v0.3.1)).
+It addresses all three findings:
+
+1. `IronfangTrigger.node.ts` implements
+   `webhookMethods.default.checkExists`, `create` and `delete`. Endpoints are
+   explicitly registered through Auditwolf Create Webhooks or Renderwolf Create
+   Destination. The hooks acknowledge external management; they do not claim to
+   verify registration or delete customer-owned endpoints. Setup and testing
+   remain documented in the node and README.
+2. `Ironfang.node.ts` defines a separate operation parameter for each product,
+   each with a literal string default. Existing defaults and operation IDs are
+   preserved.
+3. The shared implementation moved from `nodes/Ironfang/renderwolf.ts` to
+   `lib/renderwolf.ts`. The two public node entry points retain their `.node.ts`
+   names and existing registration paths.
+
+All three suppression comments have been removed. `npm run check` runs lint
+with `--no-inline-config`, TypeScript, 151 regression tests and package checks.
+The release workflow also requires real n8n 2.38.1 action and signed webhook
+checks before publishing through npm trusted publishing with provenance.

package/docs/validation.md

@@ -12,13 +12,22 @@ routes and scopes were compared with the endpoint handlers (all 97 additional ro
 production OpenAPI YAML URLs returned HTTP 200. No live authenticated customer
 operation or paid render was used for these connector checks.
 
+The 0.3.1 submission patch passed `npm run check` (151 tests), both real n8n
+2.38.1 Docker checks and `npm audit` (zero reported vulnerabilities) locally on
+9 September. CI repeats the Node 22/24 and Docker gates before publication.
+The [re-review request](n8n-re-review-0.3.1.md) is prepared for the existing
+submission; manual approval is still pending.
+
 ## Automated coverage
 
-- Real n8n lint rules, TypeScript and package entry-point/icon/version checks.
-- 149 unit/execution tests: every action dispatch, legacy formats, product
+- Real n8n lint rules with inline configuration disabled, TypeScript and package
+  entry-point/icon/version checks, including the helper's location outside `nodes/`.
+- 151 unit/execution tests: every action dispatch, legacy formats, product
   routing, explicit public access, no anonymous fallback, traversal rejection,
   decimal strings, exact XML/hash checks, multipart files, pagination/repeated
-  cursors, destination credentials, structured problems and item linking.
+  cursors, destination credentials, structured problems and item linking. The
+  0.3.1 regression cases cover operation-selector defaults/options and lifecycle
+  activation/deletion/reactivation with retained duplicate state.
 - n8n 2.38.1 Docker workflow: seven original-operation/version cases plus 18
   expansion cases. It exercises authenticated and public helpers, XML/binary
   input, generation, multipart uploads/outputs, pagination, signed downloads,
@@ -39,10 +48,13 @@ attaches an API key to a public/signed download request.
 
 Webhook endpoints are registered explicitly and their secrets are stored in
 n8n credentials. The receiver does not own or delete those remote endpoints.
-There is a documented, targeted exception to the lint rule requiring automatic
-webhook registration/deletion. Other targeted exceptions cover the shared
-legacy implementation filename and a catalogue-selected operation default that
-the static rule cannot infer. These are not claims of manual Cloud verification.
+Version 0.3.1 implements `webhookMethods.default.checkExists`, `create` and
+`delete` as acknowledgements of external management. Returning true from
+`checkExists` skips automatic remote creation; it does not prove registration.
+The hooks perform no management API calls and preserve duplicate state.
+Each operation selector now has a literal default, and the shared Renderwolf
+implementation lives in `lib/`. All three submission-related lint suppressions
+have been removed. These checks do not establish manual Cloud verification.
 
 S3 and webhook credential connection checks validate supplied fields/format.
 Actual access/signing is checked through the product's destination/webhook test

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ironfang/n8n-nodes-ironfang",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "n8n nodes for Ironfang: Renderwolf, Financewolf, Auditwolf, public tools and signed events",
   "keywords": [
     "n8n-community-node-package",
@@ -33,7 +33,7 @@
     "build": "node scripts/clean.mjs && tsc && node scripts/copy-assets.mjs",
     "dev": "tsc --watch",
     "typecheck": "tsc --noEmit",
-    "lint": "eslint nodes credentials package.json",
+    "lint": "eslint --no-inline-config nodes lib credentials package.json",
     "test": "npm run build && node --test tests/*.test.cjs",
     "check": "npm run typecheck && npm run lint && npm test && node scripts/check-package.mjs"
   },