@ipv9/tokentracker-cli 0.39.33 → 0.39.35

package/src/commands/doctor.js

@@ -28,6 +28,11 @@ async function cmdDoctor(argv = []) {
     runtime,
     diagnostics,
     fetch: globalThis.fetch,
+    system: {
+      nodeVersion: process.version,
+      platform: process.platform,
+      env: process.env,
+    },
     paths: {
       trackerDir,
       configPath,

package/src/commands/serve.js

@@ -334,7 +334,7 @@ function parseArgs(argv, env = process.env) {
   const opts = {
     port: envPort || DEFAULT_PORT,
     portExplicit: Boolean(envPort),
-    open: true,
+    open: false,
     sync: false,
   };
   for (let i = 0; i < argv.length; i++) {
@@ -347,6 +347,8 @@ function parseArgs(argv, env = process.env) {
       }
     } else if (arg === "--no-open") {
       opts.open = false;
+    } else if (arg === "--open") {
+      opts.open = true;
     } else if (arg === "--sync") {
       opts.sync = true;
     } else if (arg === "--no-sync") {

package/src/lib/browser-auth.js

@@ -158,7 +158,40 @@ function buildBrowserList() {
   return [def, ...all.filter((b) => b !== def)];
 }
 
-function openInBrowser(url) {
+function buildBrowserOpenErrorMessage({ url, command, error, platform = process.platform } = {}) {
+  const commandName =
+    command || (platform === "win32" ? "cmd" : platform === "darwin" ? "open" : "xdg-open");
+  const reason =
+    error?.code === "ENOENT" ? `${commandName} not found` : error?.message || String(error || "unknown error");
+  const lines = [
+    `Could not open browser automatically: ${reason}.`,
+    `Open manually: ${url}`,
+  ];
+  if (platform === "linux" && commandName === "xdg-open") {
+    lines.push("Linux fix: sudo apt install -y xdg-utils");
+  }
+  return `${lines.join("\n")}\n`;
+}
+
+function spawnBrowserCommand(
+  command,
+  args,
+  { url, platform = process.platform, stderr = process.stderr, spawn = cp.spawn } = {},
+) {
+  try {
+    const child = spawn(command, args, { stdio: "ignore", detached: true });
+    child.on("error", (error) => {
+      stderr.write(buildBrowserOpenErrorMessage({ url, command, error, platform }));
+    });
+    child.unref();
+    return child;
+  } catch (error) {
+    stderr.write(buildBrowserOpenErrorMessage({ url, command, error, platform }));
+    return null;
+  }
+}
+
+function openInBrowser(url, { stderr = process.stderr } = {}) {
   const platform = process.platform;
 
   if (platform === "darwin") {
@@ -230,15 +263,10 @@ else
   open location "${url}"
 end if
 `;
-    try {
-      const child = cp.spawn("osascript", ["-e", script], { stdio: "ignore", detached: true });
-      child.unref();
-    } catch (_e) {
+    const child = spawnBrowserCommand("osascript", ["-e", script], { url, platform, stderr });
+    if (!child) {
       // Fallback to plain open
-      try {
-        const child = cp.spawn("open", [url], { stdio: "ignore", detached: true });
-        child.unref();
-      } catch (_e2) {}
+      spawnBrowserCommand("open", [url], { url, platform, stderr });
     }
     return;
   }
@@ -254,10 +282,7 @@ end if
     args = [url];
   }
 
-  try {
-    const child = cp.spawn(cmd, args, { stdio: "ignore", detached: true });
-    child.unref();
-  } catch (_e) {}
+  spawnBrowserCommand(cmd, args, { url, platform, stderr });
 }
 
 function resolvePostAuthRedirect({ dashboardUrl, authUrl }) {
@@ -278,4 +303,6 @@ function resolvePostAuthRedirect({ dashboardUrl, authUrl }) {
 module.exports = {
   beginBrowserAuth,
   openInBrowser,
+  buildBrowserOpenErrorMessage,
+  spawnBrowserCommand,
 };

package/src/lib/doctor.js

@@ -1,5 +1,6 @@
 const fs = require("node:fs/promises");
 const { constants } = require("node:fs");
+const path = require("node:path");
 
 const { readJsonStrict } = require("./fs");
 
@@ -9,10 +10,14 @@ async function buildDoctorReport({
   fetch = globalThis.fetch,
   now = () => new Date(),
   paths = {},
+  system = null,
 } = {}) {
   const checks = [];
 
   checks.push(...buildRuntimeChecks(runtime));
+  if (system) {
+    checks.push(...(await buildSystemChecks(system)));
+  }
 
   if (paths.trackerDir) {
     checks.push(await checkTrackerDir(paths.trackerDir));
@@ -42,6 +47,99 @@ async function buildDoctorReport({
   };
 }
 
+async function buildSystemChecks({
+  nodeVersion = process.version,
+  platform = process.platform,
+  env = process.env,
+  commandExists = commandExistsOnPath,
+} = {}) {
+  return [
+    buildNodeVersionCheck(nodeVersion),
+    await buildBrowserOpenerCheck({ platform, env, commandExists }),
+  ];
+}
+
+function buildNodeVersionCheck(nodeVersion) {
+  const major = parseNodeMajor(nodeVersion);
+  const ok = Number.isFinite(major) && major >= 20;
+  return {
+    id: "runtime.node_version",
+    status: ok ? "ok" : "fail",
+    detail: ok ? `Node.js ${nodeVersion} satisfies >=20` : `Node.js ${nodeVersion || "unknown"} is below required >=20`,
+    critical: !ok,
+    meta: {
+      node_version: nodeVersion || null,
+      required_major: 20,
+    },
+  };
+}
+
+async function buildBrowserOpenerCheck({ platform = process.platform, env = process.env, commandExists }) {
+  const headless = isHeadlessEnvironment({ platform, env });
+  if (headless) {
+    return {
+      id: "browser.opener",
+      status: "warn",
+      detail: "headless/session environment detected; use --no-open or open the printed URL manually",
+      critical: false,
+      meta: { platform, command: null, headless: true },
+    };
+  }
+
+  if (platform === "win32") {
+    return {
+      id: "browser.opener",
+      status: "ok",
+      detail: "Windows browser opener uses cmd /c start",
+      critical: false,
+      meta: { platform, command: "cmd", headless: false },
+    };
+  }
+
+  const command = platform === "darwin" ? "open" : "xdg-open";
+  const exists = await commandExists(command, env);
+  return {
+    id: "browser.opener",
+    status: exists ? "ok" : "warn",
+    detail: exists
+      ? `${command} available`
+      : command === "xdg-open"
+        ? "xdg-open missing; install xdg-utils or use --no-open"
+        : `${command} missing; use --no-open`,
+    critical: false,
+    meta: {
+      platform,
+      command,
+      headless: false,
+      linux_fix: command === "xdg-open" && !exists ? "sudo apt install -y xdg-utils" : null,
+    },
+  };
+}
+
+function parseNodeMajor(nodeVersion) {
+  const match = String(nodeVersion || "").match(/^v?(\d+)/);
+  return match ? Number(match[1]) : NaN;
+}
+
+function isHeadlessEnvironment({ platform, env = {} } = {}) {
+  if (env.CI === "true" || env.HEADLESS === "true" || env.TOKENTRACKER_HEADLESS === "1") return true;
+  if (platform === "linux" && !env.DISPLAY && !env.WAYLAND_DISPLAY && !env.WSL_DISTRO_NAME) return true;
+  return false;
+}
+
+async function commandExistsOnPath(command, env = process.env) {
+  const pathValue = env.PATH || "";
+  const dirs = pathValue.split(path.delimiter).filter(Boolean);
+  for (const dir of dirs) {
+    const candidate = path.join(dir, command);
+    try {
+      await fs.access(candidate, constants.X_OK);
+      return true;
+    } catch (_e) {}
+  }
+  return false;
+}
+
 function buildRuntimeChecks(runtime = {}) {
   const checks = [];
   const baseUrl =
@@ -335,4 +433,9 @@ function summarizeChecks(checks = []) {
   return summary;
 }
 
-module.exports = { buildDoctorReport };
+module.exports = {
+  buildDoctorReport,
+  buildBrowserOpenerCheck,
+  buildNodeVersionCheck,
+  isHeadlessEnvironment,
+};