@ipul-labs/forge 1.16.8 → 1.17.0

package/lib/server/forge/core/validator.d.ts

@@ -0,0 +1,58 @@
+/**
+ * server/forge/core/validator.ts
+ *
+ * Pre-flight runner. Auto-attributes each proposed change to the repo whose
+ * working tree actually contains that file, then runs the right toolchain
+ * (Node npm scripts vs Go go-tool commands) on each repo with at least one
+ * attributed change.
+ *
+ * Composition:
+ *
+ *   validator/cmd.js          — child-process + step-event helpers
+ *   validator/clone.js        — cache + git clone management
+ *   validator/attribute.js    — file-existence-based repo auto-detection
+ *   validator/overlay.js      — overlay changes + readback after format
+ *   validator/projectType.js  — per-repo type resolution (config + auto-detect)
+ *   validator/runners/node.js — npm ci + format/lint/typecheck/test
+ *   validator/runners/go.js   — go mod + go fmt/vet/build/test
+ *
+ * Scope (v1):
+ *   - Validates only repos that actually own at least one change (1, both, or
+ *     none — never a phantom block from a misrouted attribution).
+ *   - GitLab HTTPS clone using GITLAB_TOKEN. GitHub / Azure DevOps raise a
+ *     clear "not supported yet" error.
+ *   - Step names per runner: format/lint/typecheck/test (Node) or
+ *     fmt/vet/build/test (Go). Missing scripts (Node) are silently skipped.
+ */
+import type { ForgeChange, ForgeEvent } from "./types.ts";
+import type { StepResult } from "./validator/cmd.ts";
+interface AnalysisInput {
+    changes: ForgeChange[];
+    repos?: string[];
+    issue?: {
+        iid: number;
+        title?: string;
+    };
+    mrTitle?: string;
+}
+/**
+ * @param {{ changes: Array<{repo?: string, file: string, action: string, proposed: string}>, repos?: string[], issue?: { iid: number } }} analysis
+ * @param {(event: object) => void} onEvent
+ */
+export declare function validate(analysis: AnalysisInput, onEvent?: (event: ForgeEvent) => void): Promise<{
+    repo: string;
+    branchName: string;
+    results: Record<string, StepResult> | {
+        [k: string]: Record<string, StepResult>;
+    };
+    allPassed: boolean;
+    perRepo: {
+        repo: string;
+        branchName: string;
+        projectType: string;
+        results: Record<string, StepResult>;
+        allPassed: boolean;
+    }[];
+}>;
+export {};
+//# sourceMappingURL=validator.d.ts.map

package/lib/server/forge/core/validator.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"validator.d.ts","sourceRoot":"","sources":["../../../../server/forge/core/validator.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;GAyBG;AAIH,OAAO,KAAK,EAAE,WAAW,EAAE,UAAU,EAAE,MAAM,YAAY,CAAC;AAG1D,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,oBAAoB,CAAC;AAmBrD,UAAU,aAAa;IACtB,OAAO,EAAE,WAAW,EAAE,CAAC;IACvB,KAAK,CAAC,EAAE,MAAM,EAAE,CAAC;IACjB,KAAK,CAAC,EAAE;QAAE,GAAG,EAAE,MAAM,CAAC;QAAC,KAAK,CAAC,EAAE,MAAM,CAAA;KAAE,CAAC;IACxC,OAAO,CAAC,EAAE,MAAM,CAAC;CACjB;AAsDD;;;GAGG;AACH,wBAAsB,QAAQ,CAAC,QAAQ,EAAE,aAAa,EAAE,OAAO,CAAC,EAAE,CAAC,KAAK,EAAE,UAAU,KAAK,IAAI;;;;;;;;;;;;;;GAqE5F"}

package/lib/server/forge/core/validator.js

@@ -0,0 +1,150 @@
+/**
+ * server/forge/core/validator.ts
+ *
+ * Pre-flight runner. Auto-attributes each proposed change to the repo whose
+ * working tree actually contains that file, then runs the right toolchain
+ * (Node npm scripts vs Go go-tool commands) on each repo with at least one
+ * attributed change.
+ *
+ * Composition:
+ *
+ *   validator/cmd.js          — child-process + step-event helpers
+ *   validator/clone.js        — cache + git clone management
+ *   validator/attribute.js    — file-existence-based repo auto-detection
+ *   validator/overlay.js      — overlay changes + readback after format
+ *   validator/projectType.js  — per-repo type resolution (config + auto-detect)
+ *   validator/runners/node.js — npm ci + format/lint/typecheck/test
+ *   validator/runners/go.js   — go mod + go fmt/vet/build/test
+ *
+ * Scope (v1):
+ *   - Validates only repos that actually own at least one change (1, both, or
+ *     none — never a phantom block from a misrouted attribution).
+ *   - GitLab HTTPS clone using GITLAB_TOKEN. GitHub / Azure DevOps raise a
+ *     clear "not supported yet" error.
+ *   - Step names per runner: format/lint/typecheck/test (Node) or
+ *     fmt/vet/build/test (Go). Missing scripts (Node) are silently skipped.
+ */
+import { branchNameFor } from "./branchName.js";
+import * as configStore from "./configStore.js";
+import { attributeChanges } from "./validator/attribute.js";
+import { ensureClone } from "./validator/clone.js";
+import { overlayChanges } from "./validator/overlay.js";
+import { resolveProjectType } from "./validator/projectType.js";
+import * as goRunner from "./validator/runners/go.js";
+import * as nodeRunner from "./validator/runners/node.js";
+const RUNNERS = {
+    go: { run: goRunner.runGoRepo, stepOrder: goRunner.STEP_ORDER, fixableSteps: goRunner.FIXABLE_STEPS },
+    node: { run: nodeRunner.runNodeRepo, stepOrder: nodeRunner.STEP_ORDER, fixableSteps: nodeRunner.FIXABLE_STEPS },
+};
+async function validateRepo(repo, changes, branchName, emit) {
+    // Stamp every downstream event with the current repo so the frontend can
+    // route progress/log/step_result rows into the right per-repo block.
+    const repoEmit = (e) => emit({ ...e, repo });
+    const fileList = changes.map((c) => c.file).join(", ");
+    repoEmit({
+        type: "log",
+        message: `Validating ${changes.length} change(s) for ${repo} on ${branchName} — ${fileList}`,
+    });
+    // Idempotent — the candidate-clone phase already populated the cache, so
+    // this is essentially a fetch/reset that completes quickly and gives the
+    // UI its `clone` step events.
+    const dir = await ensureClone(repo, branchName, repoEmit);
+    const projectType = await resolveProjectType(repo, dir, changes);
+    const runner = RUNNERS[projectType] ?? RUNNERS.node;
+    // Send the runner's step contract up front so the UI can render rows in
+    // the runner's natural order (e.g. fmt/vet/build/test for Go) and gate
+    // the "Fix with AI" button on the right step keys.
+    repoEmit({
+        type: "repo_started",
+        projectType,
+        stepOrder: runner.stepOrder,
+        fixableSteps: runner.fixableSteps,
+    });
+    await overlayChanges(dir, changes, repoEmit);
+    const results = await runner.run(dir, changes, repoEmit);
+    const allPassed = Object.values(results).every((r) => r.passed);
+    repoEmit({
+        type: "repo_result",
+        projectType,
+        allPassed,
+        checkedAt: new Date().toISOString(),
+    });
+    return { repo, branchName, projectType, results, allPassed };
+}
+function resolveCandidates(analysis) {
+    const fromAnalysis = analysis.repos ?? [];
+    if (fromAnalysis.length)
+        return fromAnalysis;
+    const fromChange = analysis.changes?.[0]?.repo;
+    if (fromChange)
+        return [fromChange];
+    const primary = configStore.getPrimaryProject();
+    return primary ? [primary] : [];
+}
+/**
+ * @param {{ changes: Array<{repo?: string, file: string, action: string, proposed: string}>, repos?: string[], issue?: { iid: number } }} analysis
+ * @param {(event: object) => void} onEvent
+ */
+export async function validate(analysis, onEvent) {
+    const emit = onEvent ?? (() => { });
+    try {
+        const candidates = resolveCandidates(analysis);
+        if (!candidates.length)
+            throw new Error("No repos to validate against.");
+        const branchName = analysis.issue?.iid
+            ? branchNameFor(analysis.issue.iid, analysis)
+            : "forge/workspace";
+        // Step 1: attribute each change by querying the SCM API for file
+        // existence. No clones yet — we only clone repos we'll actually
+        // validate. The model's `c.repo` is advisory; we trust the API.
+        const { byRepo, unattributed } = await attributeChanges(analysis.changes, candidates, emit);
+        if (unattributed.length) {
+            for (const c of unattributed) {
+                emit({
+                    type: "log",
+                    message: `Dropping ${c.file} (${c.action}): not found in ${candidates.join(" or ")}.`,
+                });
+            }
+        }
+        if (!byRepo.size) {
+            throw new Error(`No proposed changes match files in ${candidates.join(" or ")}. ` +
+                `The file paths in the proposal don't exist in those repos — likely a wrong path.`);
+        }
+        // Step 3: order chosen repos by the analysis's repos[] (primary first).
+        const ordered = candidates.filter((r) => byRepo.has(r));
+        emit({
+            type: "log",
+            message: `Plan: ${ordered.length} repo(s): ${ordered.map((r) => { const changes = byRepo.get(r) ?? []; return `${r} (${changes.length} change${changes.length === 1 ? "" : "s"})`; }).join(", ")}`,
+        });
+        const perRepo = [];
+        for (const repo of ordered) {
+            perRepo.push(await validateRepo(repo, byRepo.get(repo), branchName, emit));
+        }
+        const allPassed = perRepo.length > 0 && perRepo.every((r) => r.allPassed);
+        const repoLabel = perRepo.length === 1
+            ? perRepo[0].repo
+            : perRepo.map((r) => r.repo).join(", ");
+        // Single-repo runs keep the original flat `results` shape; multi-repo
+        // runs nest by repo so older single-repo consumers still see something
+        // sensible at `results.<step>` for their own repo.
+        const results = perRepo.length === 1
+            ? perRepo[0].results
+            : Object.fromEntries(perRepo.map((r) => [r.repo, r.results]));
+        emit({
+            type: "result",
+            data: {
+                repo: repoLabel,
+                branchName,
+                results,
+                allPassed,
+                checkedAt: new Date().toISOString(),
+            },
+        });
+        return { repo: repoLabel, branchName, results, allPassed, perRepo };
+    }
+    catch (err) {
+        emit({ type: "error", message: (err instanceof Error ? err.message : null) ?? "Validation failed" });
+        throw err;
+    }
+}
+//# sourceMappingURL=validator.js.map

package/lib/server/forge/core/validator.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"validator.js","sourceRoot":"","sources":["../../../../server/forge/core/validator.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;GAyBG;AAEH,OAAO,EAAE,aAAa,EAAE,MAAM,iBAAiB,CAAC;AAChD,OAAO,KAAK,WAAW,MAAM,kBAAkB,CAAC;AAEhD,OAAO,EAAE,gBAAgB,EAAE,MAAM,0BAA0B,CAAC;AAC5D,OAAO,EAAE,WAAW,EAAE,MAAM,sBAAsB,CAAC;AAEnD,OAAO,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AACxD,OAAO,EAAE,kBAAkB,EAAE,MAAM,4BAA4B,CAAC;AAChE,OAAO,KAAK,QAAQ,MAAM,2BAA2B,CAAC;AACtD,OAAO,KAAK,UAAU,MAAM,6BAA6B,CAAC;AAU1D,MAAM,OAAO,GAA2B;IACvC,EAAE,EAAE,EAAE,GAAG,EAAE,QAAQ,CAAC,SAAS,EAAE,SAAS,EAAE,QAAQ,CAAC,UAAU,EAAE,YAAY,EAAE,QAAQ,CAAC,aAAa,EAAE;IACrG,IAAI,EAAE,EAAE,GAAG,EAAE,UAAU,CAAC,WAAW,EAAE,SAAS,EAAE,UAAU,CAAC,UAAU,EAAE,YAAY,EAAE,UAAU,CAAC,aAAa,EAAE;CAC/G,CAAC;AASF,KAAK,UAAU,YAAY,CAAC,IAAY,EAAE,OAAsB,EAAE,UAAkB,EAAE,IAAiC;IACtH,yEAAyE;IACzE,qEAAqE;IACrE,MAAM,QAAQ,GAAG,CAAC,CAAa,EAAE,EAAE,CAAC,IAAI,CAAC,EAAE,GAAG,CAAC,EAAE,IAAI,EAAE,CAAC,CAAC;IAEzD,MAAM,QAAQ,GAAG,OAAO,CAAC,GAAG,CAAC,CAAC,CAAc,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACpE,QAAQ,CAAC;QACR,IAAI,EAAE,KAAK;QACX,OAAO,EAAE,cAAc,OAAO,CAAC,MAAM,kBAAkB,IAAI,OAAO,UAAU,MAAM,QAAQ,EAAE;KAC5F,CAAC,CAAC;IAEH,yEAAyE;IACzE,yEAAyE;IACzE,8BAA8B;IAC9B,MAAM,GAAG,GAAG,MAAM,WAAW,CAAC,IAAI,EAAE,UAAU,EAAE,QAAQ,CAAC,CAAC;IAE1D,MAAM,WAAW,GAAG,MAAM,kBAAkB,CAAC,IAAI,EAAE,GAAG,EAAE,OAAO,CAAC,CAAC;IACjE,MAAM,MAAM,GAAG,OAAO,CAAC,WAAW,CAAC,IAAI,OAAO,CAAC,IAAI,CAAC;IAEpD,wEAAwE;IACxE,uEAAuE;IACvE,mDAAmD;IACnD,QAAQ,CAAC;QACR,IAAI,EAAE,cAAc;QACpB,WAAW;QACX,SAAS,EAAE,MAAM,CAAC,SAAS;QAC3B,YAAY,EAAE,MAAM,CAAC,YAAY;KACjC,CAAC,CAAC;IAEH,MAAM,cAAc,CAAC,GAAG,EAAE,OAAO,EAAE,QAAQ,CAAC,CAAC;IAE7C,MAAM,OAAO,GAAG,MAAM,MAAM,CAAC,GAAG,CAAC,GAAG,EAAE,OAAO,EAAE,QAAQ,CAAC,CAAC;IAEzD,MAAM,SAAS,GAAG,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,EAAE,CAAE,CAAgB,CAAC,MAAM,CAAC,CAAC;IAChF,QAAQ,CAAC;QACR,IAAI,EAAE,aAAa;QACnB,WAAW;QACX,SAAS;QACT,SAAS,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;KACnC,CAAC,CAAC;IACH,OAAO,EAAE,IAAI,EAAE,UAAU,EAAE,WAAW,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC;AAC9D,CAAC;AAED,SAAS,iBAAiB,CAAC,QAAuB;IACjD,MAAM,YAAY,GAAG,QAAQ,CAAC,KAAK,IAAI,EAAE,CAAC;IAC1C,IAAI,YAAY,CAAC,MAAM;QAAE,OAAO,YAAY,CAAC;IAC7C,MAAM,UAAU,GAAG,QAAQ,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC,EAAE,IAAI,CAAC;IAC/C,IAAI,UAAU;QAAE,OAAO,CAAC,UAAU,CAAC,CAAC;IACpC,MAAM,OAAO,GAAG,WAAW,CAAC,iBAAiB,EAAE,CAAC;IAChD,OAAO,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;AACjC,CAAC;AAED;;;GAGG;AACH,MAAM,CAAC,KAAK,UAAU,QAAQ,CAAC,QAAuB,EAAE,OAAqC;IAC5F,MAAM,IAAI,GAAG,OAAO,IAAI,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAC;IAEnC,IAAI,CAAC;QACJ,MAAM,UAAU,GAAG,iBAAiB,CAAC,QAAQ,CAAC,CAAC;QAC/C,IAAI,CAAC,UAAU,CAAC,MAAM;YAAE,MAAM,IAAI,KAAK,CAAC,+BAA+B,CAAC,CAAC;QAEzE,MAAM,UAAU,GAAG,QAAQ,CAAC,KAAK,EAAE,GAAG;YACrC,CAAC,CAAC,aAAa,CAAC,QAAQ,CAAC,KAAK,CAAC,GAAG,EAAE,QAAQ,CAAC;YAC7C,CAAC,CAAC,iBAAiB,CAAC;QAErB,iEAAiE;QACjE,gEAAgE;QAChE,gEAAgE;QAChE,MAAM,EAAE,MAAM,EAAE,YAAY,EAAE,GAAG,MAAM,gBAAgB,CAAC,QAAQ,CAAC,OAAO,EAAE,UAAU,EAAE,IAAI,CAAC,CAAC;QAC5F,IAAI,YAAY,CAAC,MAAM,EAAE,CAAC;YACzB,KAAK,MAAM,CAAC,IAAI,YAAY,EAAE,CAAC;gBAC9B,IAAI,CAAC;oBACJ,IAAI,EAAE,KAAK;oBACX,OAAO,EAAE,YAAY,CAAC,CAAC,IAAI,KAAK,CAAC,CAAC,MAAM,mBAAmB,UAAU,CAAC,IAAI,CAAC,MAAM,CAAC,GAAG;iBACrF,CAAC,CAAC;YACJ,CAAC;QACF,CAAC;QACD,IAAI,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC;YAClB,MAAM,IAAI,KAAK,CACd,sCAAsC,UAAU,CAAC,IAAI,CAAC,MAAM,CAAC,IAAI;gBACjE,kFAAkF,CAClF,CAAC;QACH,CAAC;QAED,wEAAwE;QACxE,MAAM,OAAO,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAS,EAAE,EAAE,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;QAEhE,IAAI,CAAC;YACJ,IAAI,EAAE,KAAK;YACX,OAAO,EAAE,SAAS,OAAO,CAAC,MAAM,aAAa,OAAO,CAAC,GAAG,CAAC,CAAC,CAAS,EAAE,EAAE,GAAG,MAAM,OAAO,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,OAAO,GAAG,CAAC,KAAK,OAAO,CAAC,MAAM,UAAU,OAAO,CAAC,MAAM,KAAK,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;SAC1M,CAAC,CAAC;QAEH,MAAM,OAAO,GAAG,EAAE,CAAC;QACnB,KAAK,MAAM,IAAI,IAAI,OAAO,EAAE,CAAC;YAC5B,OAAO,CAAC,IAAI,CAAC,MAAM,YAAY,CAAC,IAAI,EAAE,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,EAAE,UAAU,EAAE,IAAI,CAAC,CAAC,CAAC;QAC5E,CAAC;QAED,MAAM,SAAS,GAAG,OAAO,CAAC,MAAM,GAAG,CAAC,IAAI,OAAO,CAAC,KAAK,CAAC,CAAC,CAAyB,EAAE,EAAE,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;QAClG,MAAM,SAAS,GAAG,OAAO,CAAC,MAAM,KAAK,CAAC;YACrC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,IAAI;YACjB,CAAC,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAmB,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3D,sEAAsE;QACtE,uEAAuE;QACvE,mDAAmD;QACnD,MAAM,OAAO,GAAG,OAAO,CAAC,MAAM,KAAK,CAAC;YACnC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,OAAO;YACpB,CAAC,CAAC,MAAM,CAAC,WAAW,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC;QAE/D,IAAI,CAAC;YACJ,IAAI,EAAE,QAAQ;YACd,IAAI,EAAE;gBACL,IAAI,EAAE,SAAS;gBACf,UAAU;gBACV,OAAO;gBACP,SAAS;gBACT,SAAS,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;aACnC;SACD,CAAC,CAAC;QACH,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,UAAU,EAAE,OAAO,EAAE,SAAS,EAAE,OAAO,EAAE,CAAC;IACrE,CAAC;IAAC,OAAO,GAAG,EAAE,CAAC;QACd,IAAI,CAAC,EAAE,IAAI,EAAE,OAAO,EAAE,OAAO,EAAE,CAAC,GAAG,YAAY,KAAK,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,mBAAmB,EAAE,CAAC,CAAC;QACrG,MAAM,GAAG,CAAC;IACX,CAAC;AACF,CAAC"}

package/lib/server/forge/routes.d.ts

@@ -0,0 +1,22 @@
+/**
+ * server/forge/routes.js
+ *
+ * Express router for /api/forge/*.
+ *
+ * Required env vars:
+ *   FORGE_TOKEN   — dashboard password
+ *
+ * Project + token resolved via configStore (Settings UI) with env-var fallbacks.
+ *
+ * Multi-repo support
+ * ──────────────────
+ * Every endpoint accepts an optional `repo` param (primary, where the issue
+ * lives) and `secondaryRepos` param (additional repos that can participate in
+ * a full-stack fix). `secondaryRepos` may be sent as a comma-separated string
+ * in the query string, or as a JSON array in a POST body.
+ */
+declare const router: import("express-serve-static-core").Router;
+declare function broadcast(event: Record<string, unknown>): void;
+export { broadcast };
+export default router;
+//# sourceMappingURL=routes.d.ts.map

package/lib/server/forge/routes.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"routes.d.ts","sourceRoot":"","sources":["../../../server/forge/routes.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;GAgBG;AAiBH,QAAA,MAAM,MAAM,4CAAW,CAAC;AA0hCxB,iBAAS,SAAS,CAAC,KAAK,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,CAKvD;AAoBD,OAAO,EAAE,SAAS,EAAE,CAAC;AACrB,eAAe,MAAM,CAAC"}