@iowarp/clio-coder 0.3.6 → 0.3.7

package/src/interactive/watchdog-run.ts

@@ -0,0 +1,75 @@
+/**
+ * The watchdog's run: one read-only verifier dispatch, one transcript notice.
+ *
+ * The middleware registration decides when to fire and what the turn changed;
+ * this decides nothing. It dispatches through the ordinary path so admission,
+ * the receipt, and the Fleet Runs island treat a watchdog run exactly as they
+ * treat any other, reads the failed checks out of the `verifier-report`
+ * contract, and hands the operator one line. A passing report produces nothing
+ * at all.
+ */
+
+import { BusChannels } from "../core/bus-events.js";
+import type { SafeEventBus } from "../core/event-bus.js";
+import { parseVerifierResult } from "../domains/agents/index.js";
+import type { DispatchContract, DispatchRequest } from "../domains/dispatch/contract.js";
+import { type AgentRoleFactsResolver, requestExecutionRole } from "../domains/dispatch/execution-role.js";
+import { WATCHDOG_TASK, type WatchdogTrigger, watchdogBriefing } from "../domains/middleware/index.js";
+import { watchdogBlockersNotice } from "./bus-notices.js";
+
+/** The builtin recipe the watchdog reviews with. */
+export const WATCHDOG_AGENT_ID = "verifier";
+
+export interface WatchdogRunDeps {
+	dispatch: DispatchContract;
+	bus?: SafeEventBus;
+	getAgentRoleFacts?: AgentRoleFactsResolver;
+	/** `watchdog.target` when the operator set one; the session's active target otherwise. */
+	target?: string | undefined;
+	/** One transcript line for the operator. Absent means the finding has nowhere to go and the run is skipped. */
+	emitNotice?: (text: string) => void;
+}
+
+/**
+ * Dispatch one watchdog review and report what it found.
+ *
+ * Resolves when the run has settled, whatever the outcome. A watchdog that
+ * failed is not a turn that failed: the review is advisory, so a broken run
+ * stays silent rather than raising an alarm about itself in the middle of the
+ * operator's work.
+ */
+export async function runWatchdogReview(trigger: WatchdogTrigger, deps: WatchdogRunDeps): Promise<void> {
+	if (!deps.emitNotice) return;
+	const request: DispatchRequest = {
+		agentId: WATCHDOG_AGENT_ID,
+		task: WATCHDOG_TASK,
+		briefing: watchdogBriefing(trigger),
+		executionRole: requestExecutionRole({
+			agentId: WATCHDOG_AGENT_ID,
+			...(deps.getAgentRoleFacts ? { resolveFacts: deps.getAgentRoleFacts } : {}),
+		}),
+		requestOrigin: "internal",
+		// Narrowed below whatever the session holds. A reviewer that could write
+		// would be a second builder nobody admitted.
+		autonomy: "read-only",
+		...(deps.target ? { target: deps.target } : {}),
+	};
+	const progressBus = deps.dispatch.ownsProgressBus?.(deps.bus) === true ? undefined : deps.bus;
+	try {
+		const handle = await deps.dispatch.dispatch(request);
+		for await (const event of handle.events) {
+			const typed = event as { type?: string };
+			if (!typed.type || typed.type === "heartbeat") continue;
+			progressBus?.emit(BusChannels.DispatchProgress, { runId: handle.runId, agentId: WATCHDOG_AGENT_ID, event });
+		}
+		const receipt = await handle.finalPromise;
+		const report = parseVerifierResult(receipt.output?.text ?? null);
+		if (report === null) return;
+		const notice = watchdogBlockersNotice(report.checks);
+		if (notice === null) return;
+		deps.emitNotice(notice.text);
+	} catch {
+		// An advisory review that could not run says nothing. The receipt, if one
+		// was written at all, is in the dispatch board like every other run.
+	}
+}

package/src/interactive/worker-share.ts

@@ -11,6 +11,7 @@
  * Pure: no I/O, no bus, no session.
  */
 
+import type { CouncilReport } from "../domains/agents/result-contract.js";
 import { WORKER_OUTPUT_MAX_BYTES } from "../domains/dispatch/event-pump.js";
 import { truncateUtf8 } from "../tools/truncate-utf8.js";
 import { type WorkerEntryState, workerAskedByModel } from "./worker-stream.js";
@@ -56,12 +57,66 @@ export const WORKER_SHARE_ORIGIN = "shared by the operator";
  * produced no text is not worth a turn.
  */
 export function formatWorkerShareNote(facts: WorkerShareFacts): string | null {
-	const text = facts.text.trim();
+	return shareNote(facts, facts.text);
+}
+
+/** The header every shared note carries, plus one bounded body under it. */
+function shareNote(facts: WorkerShareFacts, body: string): string | null {
+	const text = body.trim();
 	if (text.length === 0) return null;
 	const header = `${WORKER_SHARE_NOTE_PREFIX} ${facts.agentId} · run ${facts.runId} · ${outcomeWord(facts.outcome)} · ${WORKER_SHARE_ORIGIN}`;
 	return `${header}\n${truncateUtf8(text, WORKER_SHARE_MAX_BYTES, SHARE_TRUNCATION_MARKER)}`;
 }
 
+/** One member's answer under its roster label, or its failure when it produced none. */
+function councilMemberLine(member: CouncilReport["members"][number]): string {
+	if (member.failed !== undefined) return `[${member.label}] failed: ${member.failed.reason}`;
+	const verdict = member.verdict === undefined ? "" : ` (verdict ${member.verdict})`;
+	return `[${member.label}]${verdict} ${member.answer.trim()}`;
+}
+
+/** The synthesis line: what the council concluded, and how it concluded it. */
+function councilSynthesisLines(synthesis: CouncilReport["synthesis"]): string[] {
+	if (synthesis.kind === "none") return ["[synthesis none] the members answered separately; no synthesis was run."];
+	const facts = [
+		...(synthesis.verdict !== undefined ? [`verdict ${synthesis.verdict}`] : []),
+		...(synthesis.tally !== undefined
+			? [
+					`tally ${Object.entries(synthesis.tally)
+						.map(([key, count]) => `${key}=${count}`)
+						.join(" ")}`,
+				]
+			: []),
+		...(synthesis.judgeRunId !== undefined ? [`judge run ${synthesis.judgeRunId}`] : []),
+	];
+	const head = `[synthesis ${synthesis.kind}]${facts.length > 0 ? ` ${facts.join(" · ")}` : ""}`;
+	const text = synthesis.text?.trim() ?? "";
+	return text.length > 0 ? [head, text] : [head];
+}
+
+/**
+ * A whole council as one operator note: every member's labelled answer, in the
+ * order the report seals them, then the synthesis. Sharing a synthesis run id
+ * means sharing what the council decided, and the members' answers are what it
+ * decided from, so they travel together in one bounded block rather than as
+ * several notes the main agent would have to reassemble.
+ */
+export function formatCouncilShareNote(facts: WorkerShareFacts, report: CouncilReport): string | null {
+	const finalRound = report.members.reduce((highest, member) => Math.max(highest, member.round), 1);
+	const body = [
+		...report.members.filter((member) => member.round === finalRound).map(councilMemberLine),
+		...councilSynthesisLines(report.synthesis),
+	].join("\n\n");
+	return shareNote(facts, body);
+}
+
+/** One council member's answer, labelled with the roster label the operator watched it under. */
+export function formatCouncilMemberShareNote(facts: WorkerShareFacts, label: string): string | null {
+	const text = facts.text.trim();
+	if (text.length === 0) return null;
+	return shareNote(facts, `[${label}] ${text}`);
+}
+
 /**
  * Whether operator text is a shared worker note. The header is the first line,
  * so the chat loop can tell the honesty rail a worker result entered the turn

package/src/interactive/worker-stream.ts

@@ -113,6 +113,12 @@ export interface WorkerEntryState {
 	/** Every attempt of this assignment, oldest first. */
 	attempts: WorkerAttempt[];
 	pending: boolean;
+	/**
+	 * Council provenance, present only on a run of a council group. `/share`
+	 * reads it so a member's answer reaches the main agent under the roster label
+	 * the operator watched it under, rather than as one unattributed voice.
+	 */
+	council?: { group: string; label: string; color?: string; round: number };
 	receipt?: WorkerReceiptSummary;
 	/** Agent origin: the tool call whose execution spawned this run. */
 	parentToolCallId?: string;
@@ -323,6 +329,7 @@ export function createWorkerStream(options: WorkerStreamOptions = {}): WorkerStr
 				progress: progress.snapshot(),
 				attempts: [{ runId, targetLabel: workerTargetLabel(runtime) }],
 				pending: true,
+				...(payload.council !== undefined ? { council: { ...payload.council } } : {}),
 				...(payload.parentToolCallId !== undefined ? { parentToolCallId: payload.parentToolCallId } : {}),
 			};
 			byAssignment.set(assignmentId, entry);

package/src/tools/bootstrap.ts

@@ -1,3 +1,4 @@
+import type { WorkerRosters } from "../core/defaults.js";
 import type { SafeEventBus } from "../core/event-bus.js";
 import type { AgentSpec } from "../domains/agents/spec.js";
 import type { DispatchContract } from "../domains/dispatch/contract.js";
@@ -22,6 +23,7 @@ export interface ToolBootstrapDeps extends CoreToolBootstrapDeps {
 	getAgentRoleFacts?: AgentRoleFactsResolver;
 	getAutonomy?: () => AutonomyLevel;
 	getCostCeilingUsd?: () => number;
+	getWorkerRosters?: () => WorkerRosters;
 	dispatchBackground?: DispatchBackgroundRegistry;
 }
 
@@ -44,6 +46,7 @@ export function registerAllTools(registry: ToolRegistry, deps: ToolBootstrapDeps
 			...(deps.getAgentRoleFacts ? { getAgentRoleFacts: deps.getAgentRoleFacts } : {}),
 			...(deps.getAutonomy ? { getAutonomy: deps.getAutonomy } : {}),
 			...(deps.getCostCeilingUsd ? { getCostCeilingUsd: deps.getCostCeilingUsd } : {}),
+			...(deps.getWorkerRosters ? { getWorkerRosters: deps.getWorkerRosters } : {}),
 			...(deps.dispatchBackground ? { background: deps.dispatchBackground } : {}),
 		};
 		registry.register({

package/src/tools/compete-worktrees.ts

@@ -33,8 +33,15 @@ import {
 	writeFileSync,
 } from "node:fs";
 import { hostname } from "node:os";
-import { isAbsolute, join, relative, resolve, sep } from "node:path";
+import { join, relative, resolve } from "node:path";
 import type { RunKind } from "../domains/dispatch/types.js";
+import {
+	commitWorktreePath,
+	isCanonicalWorktreePathInside,
+	mergeWorktreeBranch,
+	protectedPathsChangedByWorktreeBranch,
+	worktreeBranchDiffStat,
+} from "./task-worktree.js";
 
 export interface CandidateWorktree {
 	index: number;
@@ -300,20 +307,7 @@ function isCanonicalDirectoryAt(path: string): boolean {
  * be mistaken for a child of `/group-a` as it can with textual startsWith.
  */
 export function isCanonicalPathInside(parent: string, candidate: string): boolean {
-	let canonicalParent: string;
-	let canonicalCandidate: string;
-	try {
-		canonicalParent = realpathSync(parent);
-	} catch {
-		canonicalParent = resolve(parent);
-	}
-	try {
-		canonicalCandidate = realpathSync(candidate);
-	} catch {
-		canonicalCandidate = resolve(candidate);
-	}
-	const rel = relative(canonicalParent, canonicalCandidate);
-	return rel.length > 0 && rel !== ".." && !rel.startsWith(`..${sep}`) && !isAbsolute(rel);
+	return isCanonicalWorktreePathInside(parent, candidate);
 }
 
 function manifestFromUnknown(value: unknown): CompeteGroupManifest | null {
@@ -557,29 +551,12 @@ export function createCandidateWorktree(
  * builder changed nothing (an empty candidate is a legitimate ranking fact).
  */
 export function commitCandidateWork(worktree: CandidateWorktree, message: string): boolean {
-	git(worktree.path, ["add", "-A"]);
-	const staged = git(worktree.path, ["status", "--porcelain"]);
-	if (staged.length === 0) return false;
-	git(worktree.path, [
-		"-c",
-		`user.name=${COMPETE_COMMIT_IDENTITY}`,
-		"-c",
-		`user.email=${COMPETE_COMMIT_IDENTITY}@local`,
-		"commit",
-		"-m",
-		message,
-		"--no-verify",
-	]);
-	return true;
+	return commitWorktreePath(worktree.path, COMPETE_COMMIT_IDENTITY, message);
 }
 
 /** One-line stat summary of what a candidate branch changed relative to HEAD. */
 export function candidateDiffStat(root: string, branch: string): string {
-	try {
-		return git(root, ["diff", "--shortstat", `HEAD...${branch}`]) || "no changes";
-	} catch {
-		return "diff unavailable";
-	}
+	return worktreeBranchDiffStat(root, branch);
 }
 
 /**
@@ -592,31 +569,7 @@ export function protectedPathsChangedByCompeteBranch(
 	branch: string,
 	protectedPaths: ReadonlyArray<string>,
 ): string[] {
-	const canonical = canonicalRoot(root);
-	const protectedInside = protectedPaths
-		.map((path) => resolve(path))
-		.filter((path) => {
-			const rel = relative(canonical, path);
-			return rel.length > 0 && rel !== ".." && !rel.startsWith(`..${sep}`) && !isAbsolute(rel);
-		});
-	if (protectedInside.length === 0) return [];
-	const changed = git(canonical, ["diff", "--name-only", "-z", "--no-renames", `HEAD...${branch}`])
-		.split("\0")
-		.filter((path) => path.length > 0)
-		.map((path) => resolve(canonical, path));
-	const blocked = new Set<string>();
-	for (const candidate of changed) {
-		for (const protectedPath of protectedInside) {
-			const rel = relative(protectedPath, candidate);
-			if (
-				candidate === protectedPath ||
-				(rel.length > 0 && rel !== ".." && !rel.startsWith(`..${sep}`) && !isAbsolute(rel))
-			) {
-				blocked.add(protectedPath);
-			}
-		}
-	}
-	return [...blocked].sort();
+	return protectedPathsChangedByWorktreeBranch(root, branch, protectedPaths);
 }
 
 function registeredWorktreePaths(root: string): string[] {
@@ -687,26 +640,7 @@ export function removeCandidateWorktree(
  * the merge and reports failure so the operator decides.
  */
 export function mergeWinnerBranch(root: string, branch: string): { ok: true } | { ok: false; reason: string } {
-	try {
-		git(root, [
-			"-c",
-			`user.name=${COMPETE_COMMIT_IDENTITY}`,
-			"-c",
-			`user.email=${COMPETE_COMMIT_IDENTITY}@local`,
-			"merge",
-			"--no-edit",
-			"--no-verify",
-			branch,
-		]);
-		return { ok: true };
-	} catch (err) {
-		try {
-			git(root, ["merge", "--abort"]);
-		} catch {
-			// No merge in progress; nothing to abort.
-		}
-		return { ok: false, reason: err instanceof Error ? (err.message.split("\n")[0] ?? "merge failed") : String(err) };
-	}
+	return mergeWorktreeBranch(root, branch, COMPETE_COMMIT_IDENTITY);
 }
 
 /**