@ionic/core 7.5.4-dev.11701112913.1ea61220 → 7.5.4-dev.11702935369.11a4baba

package/dist/collection/components/note/test/a11y/note.e2e.js

@@ -48,48 +48,5 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
       const note = page.locator('ion-note');
       await expect(note).toHaveScreenshot(screenshot(`note-item-divider-scale`));
     });
-    test('should wrap label to the next line without truncating', async ({ page }) => {
-      await page.setContent(`
-        <style>
-          html {
-            font-size: 310%;
-          }
-        </style>
-
-        <ion-list>
-          <ion-item>
-            <ion-note slot="start">Really really long note</ion-note>
-            <ion-label>Label</ion-label>
-          </ion-item>
-
-          <ion-item>
-            <ion-label>Label</ion-label>
-            <ion-note slot="end">Really really long note</ion-note>
-          </ion-item>
-
-          <ion-item>
-            <ion-note slot="start">Note</ion-note>
-            <ion-label>Really really long label</ion-label>
-          </ion-item>
-
-          <ion-item>
-            <ion-label>Really really long label</ion-label>
-            <ion-note slot="end">Note</ion-note>
-          </ion-item>
-
-          <ion-item>
-            <ion-note slot="start">Really really long note</ion-note>
-            <ion-label>Really really long label</ion-label>
-          </ion-item>
-
-          <ion-item>
-            <ion-label>Really really long label</ion-label>
-            <ion-note slot="end">Really really long note</ion-note>
-          </ion-item>
-        </ion-list>
-      `, config);
-      const list = page.locator('ion-list');
-      await expect(list).toHaveScreenshot(screenshot(`note-wrapping-label-scale`));
-    });
   });
 });

package/dist/collection/components/radio/radio.js

@@ -2,7 +2,7 @@
  * (C) Ionic http://ionicframework.com - MIT License
  */
 import { Host, h } from "@stencil/core";
-import { createLegacyFormController, isOptionSelected } from "../../utils/forms/index";
+import { createLegacyFormController } from "../../utils/forms/index";
 import { addEventListener, getAriaLabel, removeEventListener } from "../../utils/helpers";
 import { printIonWarning } from "../../utils/logging/index";
 import { createColorClasses, hostContext } from "../../utils/theme";
@@ -23,8 +23,7 @@ export class Radio {
     this.hasLoggedDeprecationWarning = false;
     this.updateState = () => {
       if (this.radioGroup) {
-        const { compareWith, value: radioGroupValue } = this.radioGroup;
-        this.checked = isOptionSelected(radioGroupValue, this.value, compareWith);
+        this.checked = this.radioGroup.value === this.value;
       }
     };
     this.onClick = () => {
@@ -121,8 +120,6 @@ export class Radio {
   emitStyle() {
     const style = {
       'interactive-disabled': this.disabled,
-      // TODO(FW-3125): remove this
-      legacy: !!this.legacy,
     };
     if (this.legacyFormController.hasLegacyControl()) {
       style['radio-checked'] = this.checked;

package/dist/collection/components/radio-group/radio-group.js

@@ -47,7 +47,6 @@ export class RadioGroup {
       }
     };
     this.allowEmptySelection = false;
-    this.compareWith = undefined;
     this.name = this.inputId;
     this.value = undefined;
   }
@@ -159,29 +158,6 @@ export class RadioGroup {
         "reflect": false,
         "defaultValue": "false"
       },
-      "compareWith": {
-        "type": "string",
-        "mutable": false,
-        "complexType": {
-          "original": "string | RadioGroupCompareFn | null",
-          "resolved": "((currentValue: any, compareValue: any) => boolean) | null | string | undefined",
-          "references": {
-            "RadioGroupCompareFn": {
-              "location": "import",
-              "path": "./radio-group-interface",
-              "id": "src/components/radio-group/radio-group-interface.ts::RadioGroupCompareFn"
-            }
-          }
-        },
-        "required": false,
-        "optional": true,
-        "docs": {
-          "tags": [],
-          "text": "This property allows developers to specify a custom function or property\nname for comparing objects when determining the selected option in the\nion-radio-group. When not specified, the default behavior will use strict\nequality (===) for comparison."
-        },
-        "attribute": "compare-with",
-        "reflect": false
-      },
       "name": {
         "type": "string",
         "mutable": false,

package/dist/collection/components/range/range.js

@@ -226,8 +226,6 @@ export class Range {
       this.ionStyle.emit({
         interactive: true,
         'interactive-disabled': this.disabled,
-        // TODO(FW-2997): remove this
-        legacy: !!this.legacy,
       });
     }
   }

package/dist/collection/components/select/select.ios.css

@@ -110,11 +110,6 @@
   overflow: hidden;
 }
 
-:host(.in-item:not(.legacy-select)) {
-  flex: 1 1 0;
-  width: 0;
-}
-
 :host(.in-item.legacy-select) {
   position: static;
   max-width: 45%;
@@ -215,12 +210,6 @@ button {
   margin-top: 0;
   margin-bottom: 0;
   position: relative;
-  /**
-   * Prevent the icon from shrinking when the label and/or
-   * selected item text is long enough to fill the rest of
-   * the container.
-   */
-  flex-shrink: 0;
 }
 
 /**
@@ -304,23 +293,6 @@ button {
   transition: opacity 150ms cubic-bezier(0.4, 0, 0.2, 1);
 }
 
-.select-wrapper-inner {
-  display: flex;
-  align-items: center;
-  overflow: hidden;
-}
-
-:host(.select-label-placement-stacked) .select-wrapper-inner,
-:host(.select-label-placement-floating) .select-wrapper-inner {
-  /**
-   * When using a stacked/floating label, the inner wrapper is
-   * stacked vertically under the label container. This line
-   * ensures that the inner wrapper fills all the remaining height
-   * of the component.
-   */
-  flex-grow: 1;
-}
-
 :host(.ion-touched.ion-invalid) {
   --highlight-color: var(--highlight-color-invalid);
 }
@@ -561,23 +533,11 @@ button {
  * The placeholder should be hidden when the label
  * is on top of the select. This prevents the label
  * from overlapping any placeholder value.
- *
- * TODO(FW-5592): Remove :not(.label-floating) piece
  */
-:host(.select-label-placement-floating:not(.label-floating)) .native-wrapper .select-placeholder {
+:host(.select-label-placement-floating) .native-wrapper .select-placeholder {
   opacity: 0;
 }
 
-/**
- * We don't use .label-floating here because that would
- * also include the case where the label is floating due
- * to content in the start/end slot. We want the opacity
- * to remain at the default in this case, since the select
- * isn't being actively interacted with.
- *
- * TODO(FW-5592): Change entire selector to:
- * :host(.label-floating.select-label-placement-floating) .native-wrapper .select-placeholder
- */
 :host(.select-expanded.select-label-placement-floating) .native-wrapper .select-placeholder,
 :host(.ion-focused.select-label-placement-floating) .native-wrapper .select-placeholder,
 :host(.has-value.select-label-placement-floating) .native-wrapper .select-placeholder {
@@ -587,7 +547,10 @@ button {
 /**
  * This makes the label sit above the input.
  */
-:host(.label-floating) .label-text-wrapper {
+:host(.select-label-placement-stacked) .label-text-wrapper,
+:host(.select-expanded.select-label-placement-floating) .label-text-wrapper,
+:host(.ion-focused.select-label-placement-floating) .label-text-wrapper,
+:host(.has-value.select-label-placement-floating) .label-text-wrapper {
   transform: translateY(50%) scale(0.75);
   /**
    * Label text should not extend
@@ -596,23 +559,6 @@ button {
   max-width: calc(100% / 0.75);
 }
 
-::slotted([slot=start]), ::slotted([slot=end]) {
-  /**
-   * Prevent the slots from shrinking when the label and/or
-   * selected item text is long enough to fill the rest of
-   * the container.
-   */
-  flex-shrink: 0;
-}
-
-::slotted([slot=start]) {
-  margin-inline-end: 16px;
-}
-
-::slotted([slot=end]) {
-  margin-inline-start: 16px;
-}
-
 /**
  * Convert a font size to a dynamic font size.
  * Fonts that participate in Dynamic Type should use
@@ -692,8 +638,8 @@ button {
   color: var(--ion-color-step-650, #595959);
 }
 
-:host(.select-label-placement-stacked) .select-wrapper-inner,
-:host(.select-label-placement-floating) .select-wrapper-inner {
+:host(.select-label-placement-stacked) .native-wrapper,
+:host(.select-label-placement-floating) .native-wrapper {
   width: calc(100% - 1.125rem - 4px);
 }
 

package/dist/collection/components/select/select.js

@@ -2,7 +2,7 @@
  * (C) Ionic http://ionicframework.com - MIT License
  */
 import { Host, h, forceUpdate } from "@stencil/core";
-import { compareOptions, createLegacyFormController, createNotchController, isOptionSelected } from "../../utils/forms/index";
+import { createLegacyFormController, createNotchController } from "../../utils/forms/index";
 import { findItemLabel, focusElement, getAriaLabel, renderHiddenInput, inheritAttributes } from "../../utils/helpers";
 import { printIonWarning } from "../../utils/logging/index";
 import { actionSheetController, alertController, popoverController } from "../../utils/overlays";
@@ -16,8 +16,6 @@ import { getIonMode } from "../../global/ionic-global";
  * @virtualProp {"ios" | "md"} mode - The mode determines which platform styles to use.
  *
  * @slot label - The label text to associate with the select. Use the `labelPlacement` property to control where the label is placed relative to the select. Use this if you need to render a label with custom HTML.
- * @slot start - Content to display at the leading edge of the select.
- * @slot end - Content to display at the trailing edge of the select.
  *
  * @part placeholder - The text displayed in the select when there is no value.
  * @part text - The displayed value of the select.
@@ -32,22 +30,8 @@ export class Select {
     // This flag ensures we log the deprecation warning at most once.
     this.hasLoggedDeprecationWarning = false;
     this.onClick = (ev) => {
-      const target = ev.target;
-      const closestSlot = target.closest('[slot="start"], [slot="end"]');
-      if (target === this.el || closestSlot === null) {
-        this.setFocus();
-        this.open(ev);
-      }
-      else {
-        /**
-         * Prevent clicks to the start/end slots from opening the select.
-         * We ensure the target isn't this element in case the select is slotted
-         * in, for example, an item. This would prevent the select from ever
-         * being opened since the element itself has slot="start"/"end".
-         */
-        ev.stopPropagation();
-        ev.preventDefault();
-      }
+      this.setFocus();
+      this.open(ev);
     };
     this.onFocus = () => {
       this.ionFocus.emit();
@@ -481,8 +465,6 @@ export class Select {
       style['has-placeholder'] = this.placeholder !== undefined;
       style['has-value'] = this.hasValue();
       style['has-focus'] = this.isExpanded;
-      // TODO(FW-3194): remove this
-      style['legacy'] = !!this.legacy;
     }
     this.ionStyle.emit(style);
   }
@@ -550,27 +532,7 @@ export class Select {
     const rtl = isRTL(el) ? 'rtl' : 'ltr';
     const inItem = hostContext('ion-item', this.el);
     const shouldRenderHighlight = mode === 'md' && fill !== 'outline' && !inItem;
-    const hasValue = this.hasValue();
-    const hasStartEndSlots = el.querySelector('[slot="start"], [slot="end"]') !== null;
     renderHiddenInput(true, el, name, parseValue(value), disabled);
-    /**
-     * If the label is stacked, it should always sit above the select.
-     * For floating labels, the label should move above the select if
-     * the select has a value, is open, or has anything in either
-     * the start or end slot.
-     *
-     * If there is content in the start slot, the label would overlap
-     * it if not forced to float. This is also applied to the end slot
-     * because with the default or solid fills, the select is not
-     * vertically centered in the container, but the label is. This
-     * causes the slots and label to appear vertically offset from each
-     * other when the label isn't floating above the input. This doesn't
-     * apply to the outline fill, but this was not accounted for to keep
-     * things consistent.
-     *
-     * TODO(FW-5592): Remove hasStartEndSlots condition
-     */
-    const labelShouldFloat = labelPlacement === 'stacked' || (labelPlacement === 'floating' && (hasValue || isExpanded || hasStartEndSlots));
     return (h(Host, { onClick: this.onClick, class: createColorClasses(this.color, {
         [mode]: true,
         'in-item': inItem,
@@ -578,8 +540,7 @@ export class Select {
         'select-disabled': disabled,
         'select-expanded': isExpanded,
         'has-expanded-icon': expandedIcon !== undefined,
-        'has-value': hasValue,
-        'label-floating': labelShouldFloat,
+        'has-value': this.hasValue(),
         'has-placeholder': placeholder !== undefined,
         'ion-focusable': true,
         [`select-${rtl}`]: true,
@@ -587,7 +548,7 @@ export class Select {
         [`select-justify-${justify}`]: justifyEnabled,
         [`select-shape-${shape}`]: shape !== undefined,
         [`select-label-placement-${labelPlacement}`]: true,
-      }) }, h("label", { class: "select-wrapper", id: "select-label" }, this.renderLabelContainer(), h("div", { class: "select-wrapper-inner" }, h("slot", { name: "start" }), h("div", { class: "native-wrapper", ref: (el) => (this.nativeWrapperEl = el), part: "container" }, this.renderSelectText(), this.renderListbox()), h("slot", { name: "end" }), !hasFloatingOrStackedLabel && this.renderSelectIcon()), hasFloatingOrStackedLabel && this.renderSelectIcon(), shouldRenderHighlight && h("div", { class: "select-highlight" }))));
+      }) }, h("label", { class: "select-wrapper", id: "select-label" }, this.renderLabelContainer(), h("div", { class: "native-wrapper", ref: (el) => (this.nativeWrapperEl = el), part: "container" }, this.renderSelectText(), !hasFloatingOrStackedLabel && this.renderSelectIcon(), this.renderListbox()), hasFloatingOrStackedLabel && this.renderSelectIcon(), shouldRenderHighlight && h("div", { class: "select-highlight" }))));
   }
   // TODO FW-3194 - Remove this
   renderLegacySelect() {
@@ -776,7 +737,7 @@ Developers can use the "legacy" property to continue using the legacy form marku
         "optional": true,
         "docs": {
           "tags": [],
-          "text": "This property allows developers to specify a custom function or property\nname for comparing objects when determining the selected option in the\nion-select. When not specified, the default behavior will use strict\nequality (===) for comparison."
+          "text": "A property name or function used to compare object values"
         },
         "attribute": "compare-with",
         "reflect": false
@@ -1254,6 +1215,17 @@ Developers can use the "legacy" property to continue using the legacy form marku
       }];
   }
 }
+const isOptionSelected = (currentValue, compareValue, compareWith) => {
+  if (currentValue === undefined) {
+    return false;
+  }
+  if (Array.isArray(currentValue)) {
+    return currentValue.some((val) => compareOptions(val, compareValue, compareWith));
+  }
+  else {
+    return compareOptions(currentValue, compareValue, compareWith);
+  }
+};
 const getOptionValue = (el) => {
   const value = el.value;
   return value === undefined ? el.textContent || '' : value;
@@ -1267,6 +1239,17 @@ const parseValue = (value) => {
   }
   return value.toString();
 };
+const compareOptions = (currentValue, compareValue, compareWith) => {
+  if (typeof compareWith === 'function') {
+    return compareWith(currentValue, compareValue);
+  }
+  else if (typeof compareWith === 'string') {
+    return currentValue[compareWith] === compareValue[compareWith];
+  }
+  else {
+    return Array.isArray(compareValue) ? compareValue.includes(currentValue) : currentValue === compareValue;
+  }
+};
 const generateText = (opts, value, compareWith) => {
   if (value === undefined) {
     return '';

package/dist/collection/components/select/select.md.css

@@ -110,11 +110,6 @@
   overflow: hidden;
 }
 
-:host(.in-item:not(.legacy-select)) {
-  flex: 1 1 0;
-  width: 0;
-}
-
 :host(.in-item.legacy-select) {
   position: static;
   max-width: 45%;
@@ -215,12 +210,6 @@ button {
   margin-top: 0;
   margin-bottom: 0;
   position: relative;
-  /**
-   * Prevent the icon from shrinking when the label and/or
-   * selected item text is long enough to fill the rest of
-   * the container.
-   */
-  flex-shrink: 0;
 }
 
 /**
@@ -304,23 +293,6 @@ button {
   transition: opacity 150ms cubic-bezier(0.4, 0, 0.2, 1);
 }
 
-.select-wrapper-inner {
-  display: flex;
-  align-items: center;
-  overflow: hidden;
-}
-
-:host(.select-label-placement-stacked) .select-wrapper-inner,
-:host(.select-label-placement-floating) .select-wrapper-inner {
-  /**
-   * When using a stacked/floating label, the inner wrapper is
-   * stacked vertically under the label container. This line
-   * ensures that the inner wrapper fills all the remaining height
-   * of the component.
-   */
-  flex-grow: 1;
-}
-
 :host(.ion-touched.ion-invalid) {
   --highlight-color: var(--highlight-color-invalid);
 }
@@ -561,23 +533,11 @@ button {
  * The placeholder should be hidden when the label
  * is on top of the select. This prevents the label
  * from overlapping any placeholder value.
- *
- * TODO(FW-5592): Remove :not(.label-floating) piece
  */
-:host(.select-label-placement-floating:not(.label-floating)) .native-wrapper .select-placeholder {
+:host(.select-label-placement-floating) .native-wrapper .select-placeholder {
   opacity: 0;
 }
 
-/**
- * We don't use .label-floating here because that would
- * also include the case where the label is floating due
- * to content in the start/end slot. We want the opacity
- * to remain at the default in this case, since the select
- * isn't being actively interacted with.
- *
- * TODO(FW-5592): Change entire selector to:
- * :host(.label-floating.select-label-placement-floating) .native-wrapper .select-placeholder
- */
 :host(.select-expanded.select-label-placement-floating) .native-wrapper .select-placeholder,
 :host(.ion-focused.select-label-placement-floating) .native-wrapper .select-placeholder,
 :host(.has-value.select-label-placement-floating) .native-wrapper .select-placeholder {
@@ -587,7 +547,10 @@ button {
 /**
  * This makes the label sit above the input.
  */
-:host(.label-floating) .label-text-wrapper {
+:host(.select-label-placement-stacked) .label-text-wrapper,
+:host(.select-expanded.select-label-placement-floating) .label-text-wrapper,
+:host(.ion-focused.select-label-placement-floating) .label-text-wrapper,
+:host(.has-value.select-label-placement-floating) .label-text-wrapper {
   transform: translateY(50%) scale(0.75);
   /**
    * Label text should not extend
@@ -596,23 +559,6 @@ button {
   max-width: calc(100% / 0.75);
 }
 
-::slotted([slot=start]), ::slotted([slot=end]) {
-  /**
-   * Prevent the slots from shrinking when the label and/or
-   * selected item text is long enough to fill the rest of
-   * the container.
-   */
-  flex-shrink: 0;
-}
-
-::slotted([slot=start]) {
-  margin-inline-end: 16px;
-}
-
-::slotted([slot=end]) {
-  margin-inline-start: 16px;
-}
-
 /**
  * Convert a font size to a dynamic font size.
  * Fonts that participate in Dynamic Type should use
@@ -790,7 +736,10 @@ button {
   }
 }
 
-:host(.label-floating.select-fill-solid) .label-text-wrapper {
+:host(.select-fill-solid.select-label-placement-stacked) .label-text-wrapper,
+:host(.select-expanded.select-fill-solid.select-label-placement-floating) .label-text-wrapper,
+:host(.ion-focused.select-fill-solid.select-label-placement-floating) .label-text-wrapper,
+:host(.has-value.select-fill-solid.select-label-placement-floating) .label-text-wrapper {
   /**
    * Label text should not extend
    * beyond the bounds of the select.
@@ -924,7 +873,10 @@ button {
 /**
  * This makes the label sit above the select.
  */
-:host(.label-floating.select-fill-outline) .label-text-wrapper {
+:host(.select-expanded.select-fill-outline.select-label-placement-floating) .label-text-wrapper,
+:host(.ion-focused.select-fill-outline.select-label-placement-floating) .label-text-wrapper,
+:host(.has-value.select-fill-outline.select-label-placement-floating) .label-text-wrapper,
+:host(.select-fill-outline.select-label-placement-stacked) .label-text-wrapper {
   transform: translateY(-32%) scale(0.75);
   margin-left: 0;
   margin-right: 0;
@@ -1069,7 +1021,10 @@ button {
  * the floating/stacked label. We simulate this "cut out"
  * by removing the top border from the notch fragment.
  */
-:host(.label-floating.select-fill-outline) .select-outline-notch {
+:host(.select-expanded.select-fill-outline.select-label-placement-floating) .select-outline-notch,
+:host(.ion-focused.select-fill-outline.select-label-placement-floating) .select-outline-notch,
+:host(.has-value.select-fill-outline.select-label-placement-floating) .select-outline-notch,
+:host(.select-fill-outline.select-label-placement-stacked) .select-outline-notch {
   border-top: none;
 }
 
@@ -1234,8 +1189,8 @@ button {
   --border-radius: 16px;
 }
 
-:host(.select-label-placement-stacked) .select-wrapper-inner,
-:host(.select-label-placement-floating) .select-wrapper-inner {
+:host(.select-label-placement-stacked) .native-wrapper,
+:host(.select-label-placement-floating) .native-wrapper {
   width: calc(100% - 0.8125rem - 4px);
 }
 

package/dist/collection/components/select/test/label/select.e2e.js

@@ -121,7 +121,7 @@ configs().forEach(({ title, screenshot, config }) => {
       });
       test('label should appear on top of the select when the select is expanded', async ({ page }) => {
         await page.setContent(`
-           <ion-select class="select-expanded label-floating" label="Label" label-placement="floating" placeholder="Select a Fruit">
+           <ion-select class="select-expanded" label="Label" label-placement="floating" placeholder="Select a Fruit">
              <ion-select-option value="apples">Apples</ion-select-option>
            </ion-select>
          `, config);

package/dist/collection/components/select/test/legacy/wrapping/select.e2e.js

@@ -27,7 +27,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
       await page.setContent(`
         <ion-item>
           <ion-label>Really long label should not wrap</ion-label>
-          <ion-select value="wrap" legacy="true" class="ion-text-wrap">
+          <ion-select value="wrap" class="ion-text-wrap">
             <ion-select-option value="wrap">Should wrap value only when label exists and really long text exists to make it wrap the text</ion-select-option>
           </ion-select>
         </ion-item>

package/dist/collection/components/skeleton-text/skeleton-text.js

@@ -9,18 +9,6 @@ export class SkeletonText {
   constructor() {
     this.animated = false;
   }
-  componentWillLoad() {
-    this.emitStyle();
-  }
-  emitStyle() {
-    // The emitted property is used by item in order
-    // to add the item-skeleton-text class which applies
-    // overflow: hidden to its label
-    const style = {
-      'skeleton-text': true,
-    };
-    this.ionStyle.emit(style);
-  }
   render() {
     const animated = this.animated && config.getBoolean('animated', true);
     const inMedia = hostContext('ion-avatar', this.el) || hostContext('ion-thumbnail', this.el);
@@ -65,32 +53,5 @@ export class SkeletonText {
       }
     };
   }
-  static get events() {
-    return [{
-        "method": "ionStyle",
-        "name": "ionStyle",
-        "bubbles": true,
-        "cancelable": true,
-        "composed": true,
-        "docs": {
-          "tags": [{
-              "name": "internal",
-              "text": undefined
-            }],
-          "text": "Emitted when the styles change."
-        },
-        "complexType": {
-          "original": "StyleEventDetail",
-          "resolved": "StyleEventDetail",
-          "references": {
-            "StyleEventDetail": {
-              "location": "import",
-              "path": "../../interface",
-              "id": "src/interface.d.ts::StyleEventDetail"
-            }
-          }
-        }
-      }];
-  }
   static get elementRef() { return "el"; }
 }