@ionic/core 7.5.4-dev.11699300051.122a36ad → 7.5.4-dev.11699310489.151b2717

package/dist/collection/components/item/item.ios.css

@@ -188,10 +188,6 @@
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  padding-inline-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  -webkit-padding-end: var(--padding-end);
-  padding-inline-end: var(--padding-end);
   padding-top: var(--padding-top);
   padding-bottom: var(--padding-bottom);
   font-family: inherit;
@@ -206,6 +202,10 @@
   text-align: inherit;
   white-space: inherit;
   color: inherit;
+  /* stylelint-disable */
+  padding-right: var(--padding-end);
+  padding-left: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
+  /* stylelint-enable */
   display: flex;
   position: relative;
   align-items: inherit;
@@ -222,6 +222,22 @@
   box-sizing: border-box;
   z-index: 1;
 }
+:host-context([dir=rtl]) .item-native {
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  padding-left: var(--padding-end);
+}
+
+[dir=rtl] .item-native {
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  padding-left: var(--padding-end);
+}
+
+@supports selector(:dir(rtl)) {
+  .item-native:dir(rtl) {
+    padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+    padding-left: var(--padding-end);
+  }
+}
 
 .item-native::-moz-focus-inner {
   border: 0;
@@ -250,12 +266,12 @@ button, a {
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: var(--inner-padding-start);
-  padding-inline-start: var(--inner-padding-start);
-  -webkit-padding-end: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
-  padding-inline-end: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
   padding-top: var(--inner-padding-top);
   padding-bottom: var(--inner-padding-bottom);
+  /* stylelint-disable */
+  padding-right: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
+  padding-left: var(--inner-padding-start);
+  /* stylelint-enable */
   display: flex;
   position: relative;
   flex: 1;
@@ -270,21 +286,53 @@ button, a {
   overflow: inherit;
   box-sizing: border-box;
 }
+:host-context([dir=rtl]) .item-inner {
+  padding-right: var(--inner-padding-start);
+  padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+}
+
+[dir=rtl] .item-inner {
+  padding-right: var(--inner-padding-start);
+  padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+}
+
+@supports selector(:dir(rtl)) {
+  .item-inner:dir(rtl) {
+    padding-right: var(--inner-padding-start);
+    padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+  }
+}
 
 .item-bottom {
   margin-left: 0;
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  padding-inline-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  -webkit-padding-end: var(--inner-padding-end);
-  padding-inline-end: var(--inner-padding-end);
   padding-top: 0;
   padding-bottom: 0;
+  /* stylelint-disable */
+  padding-left: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--inner-padding-end) + var(--ion-safe-area-right, 0px));
+  /* stylelint-enable */
   display: flex;
   justify-content: space-between;
 }
+:host-context([dir=rtl]) .item-bottom {
+  padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+}
+
+[dir=rtl] .item-bottom {
+  padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+}
+
+@supports selector(:dir(rtl)) {
+  .item-bottom:dir(rtl) {
+    padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+    padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  }
+}
 
 .item-detail-icon {
   /**

package/dist/collection/components/item/item.md.css

@@ -188,10 +188,6 @@
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  padding-inline-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  -webkit-padding-end: var(--padding-end);
-  padding-inline-end: var(--padding-end);
   padding-top: var(--padding-top);
   padding-bottom: var(--padding-bottom);
   font-family: inherit;
@@ -206,6 +202,10 @@
   text-align: inherit;
   white-space: inherit;
   color: inherit;
+  /* stylelint-disable */
+  padding-right: var(--padding-end);
+  padding-left: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
+  /* stylelint-enable */
   display: flex;
   position: relative;
   align-items: inherit;
@@ -222,6 +222,22 @@
   box-sizing: border-box;
   z-index: 1;
 }
+:host-context([dir=rtl]) .item-native {
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  padding-left: var(--padding-end);
+}
+
+[dir=rtl] .item-native {
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  padding-left: var(--padding-end);
+}
+
+@supports selector(:dir(rtl)) {
+  .item-native:dir(rtl) {
+    padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+    padding-left: var(--padding-end);
+  }
+}
 
 .item-native::-moz-focus-inner {
   border: 0;
@@ -250,12 +266,12 @@ button, a {
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: var(--inner-padding-start);
-  padding-inline-start: var(--inner-padding-start);
-  -webkit-padding-end: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
-  padding-inline-end: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
   padding-top: var(--inner-padding-top);
   padding-bottom: var(--inner-padding-bottom);
+  /* stylelint-disable */
+  padding-right: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
+  padding-left: var(--inner-padding-start);
+  /* stylelint-enable */
   display: flex;
   position: relative;
   flex: 1;
@@ -270,21 +286,53 @@ button, a {
   overflow: inherit;
   box-sizing: border-box;
 }
+:host-context([dir=rtl]) .item-inner {
+  padding-right: var(--inner-padding-start);
+  padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+}
+
+[dir=rtl] .item-inner {
+  padding-right: var(--inner-padding-start);
+  padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+}
+
+@supports selector(:dir(rtl)) {
+  .item-inner:dir(rtl) {
+    padding-right: var(--inner-padding-start);
+    padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+  }
+}
 
 .item-bottom {
   margin-left: 0;
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  padding-inline-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  -webkit-padding-end: var(--inner-padding-end);
-  padding-inline-end: var(--inner-padding-end);
   padding-top: 0;
   padding-bottom: 0;
+  /* stylelint-disable */
+  padding-left: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--inner-padding-end) + var(--ion-safe-area-right, 0px));
+  /* stylelint-enable */
   display: flex;
   justify-content: space-between;
 }
+:host-context([dir=rtl]) .item-bottom {
+  padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+}
+
+[dir=rtl] .item-bottom {
+  padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+}
+
+@supports selector(:dir(rtl)) {
+  .item-bottom:dir(rtl) {
+    padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+    padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  }
+}
 
 .item-detail-icon {
   /**

package/dist/collection/components/item/test/basic/item.e2e.js

@@ -10,5 +10,31 @@ configs().forEach(({ title, screenshot, config }) => {
       await page.setIonViewport();
       await expect(page).toHaveScreenshot(screenshot(`item-diff`));
     });
+    /**
+     * This behavior needs to be tested for all modes & directions
+     * Safe padding should stay on the same side when the direction changes
+     */
+    test('should have safe area padding', async ({ page }) => {
+      await page.setContent(`
+        <style>
+          :root {
+            --ion-safe-area-left: 40px;
+            --ion-safe-area-right: 20px;
+          }
+        </style>
+        <ion-list>
+          <ion-item>
+            <ion-label>Item with helper</ion-label>
+            <div slot="helper">Helper</div>
+          </ion-item>
+
+          <ion-item>
+            <ion-label> Single line text that should have ellipses when it doesn't all fit in the item</ion-label>
+          </ion-item>
+        </ion-list>
+      `, config);
+      const list = page.locator('ion-list');
+      await expect(list).toHaveScreenshot(screenshot('item-safe-area'));
+    });
   });
 });

package/dist/collection/components/list/list.ios.css

@@ -130,7 +130,21 @@ ion-list.list-inset {
   border-radius: 10px;
 }
 
-.list-ios.list-inset ion-item:last-child {
+/**
+ * These selectors ensure the last item in the list
+ * has the correct border.
+ * We need to consider the following scenarios:
+ 1. The only item in a list.
+ 2. The last item in a list as long as it is not the only item.
+ 3. The item in the last item-sliding in a list.
+ * Note that we do not select ion-item:last-of-type
+ * because that will cause the borders to disappear on
+ * items in an item-sliding when the item is the last
+ * element in the item-sliding container.
+ */
+.list-ios.list-inset ion-item:only-child,
+.list-ios.list-inset ion-item:not(:only-of-type):last-of-type,
+.list-ios.list-inset ion-item-sliding:last-of-type ion-item {
   --border-width: 0;
   --inner-border-width: 0;
 }

package/dist/collection/components/list/list.md.css

@@ -166,12 +166,50 @@ ion-list.list-inset {
   border-radius: 2px;
 }
 
-.list-md.list-inset ion-item:first-child {
+/**
+ * These selectors ensure the first item in the list
+ * has the correct radius.
+ * We need to consider the following scenarios:
+ 1. The first item in a list as long as it is not the only item.
+ 2. The item in the first item-sliding in a list.
+ * Note that we do not select "ion-item-sliding ion-item:first-of-type"
+ * because that will cause the borders to disappear on
+ * items in an item-sliding when the item is the first
+ * element in the item-sliding container.
+ */
+.list-md.list-inset ion-item:not(:only-of-type):first-of-type,
+.list-md.list-inset ion-item-sliding:first-of-type ion-item {
   --border-radius: 2px 2px 0 0;
 }
 
-.list-md.list-inset ion-item:last-child {
-  --border-radius: 0 0 2px, 2px;
+/**
+ * These selectors ensure the last item in the list
+ * has the correct radius and border.
+ * We need to consider the following scenarios:
+ 1. The last item in a list as long as it is not the only item.
+ 2. The item in the last item-sliding in a list.
+ * Note that we do not select "ion-item-sliding ion-item:last-of-type"
+ * because that will cause the borders to disappear on
+ * items in an item-sliding when the item is the last
+ * element in the item-sliding container.
+ */
+.list-md.list-inset ion-item:not(:only-of-type):last-of-type,
+.list-md.list-inset ion-item-sliding:last-of-type ion-item {
+  --border-radius: 0 0 2px 2px;
+  --border-width: 0;
+  --inner-border-width: 0;
+}
+
+/**
+ * The only item in a list should have a border radius
+ * on all corners.
+ * We target :only-child instead of :only-of-type
+ * otherwise borders will disappear on items inside of
+ * ion-item-sliding because the item will be the only
+ * one of its type inside of the ion-item-sliding group.
+ */
+.list-md.list-inset ion-item:only-child {
+  --border-radius: 2px;
   --border-width: 0;
   --inner-border-width: 0;
 }

package/dist/collection/components/list/test/lines/list.e2e.js

@@ -22,3 +22,146 @@ configs().forEach(({ title, screenshot, config }) => {
     });
   });
 });
+/**
+ * Padding and border color ensures the bottom border can be easily seen if it regresses.
+ * The background color ensures that any border radius values can be seen.
+ */
+configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+  test.describe(title('list: lines with children'), () => {
+    test('only item in inset list should not have line', async ({ page }) => {
+      test.info().annotations.push({
+        type: 'issue',
+        description: 'https://github.com/ionic-team/ionic-framework/issues/28435',
+      });
+      await page.setContent(`
+        <style>
+          #container {
+            padding: 10px;
+            background: #0088cc;
+          }
+
+          ion-item {
+            --border-color: red;
+          }
+        </style>
+        <div id="container">
+          <ion-list inset="true">
+            <ion-item>
+              <ion-label>Item 0</ion-label>
+            </ion-item>
+          </ion-list>
+        </div>
+      `, config);
+      const container = page.locator('#container');
+      await expect(container).toHaveScreenshot(screenshot('inset-list-only-item-no-lines'));
+    });
+    test('last item in inset list with end options should not have line', async ({ page }) => {
+      test.info().annotations.push({
+        type: 'issue',
+        description: 'https://github.com/ionic-team/ionic-framework/issues/28435',
+      });
+      await page.setContent(`
+        <style>
+          #container {
+            padding: 10px;
+            background: #0088cc;
+          }
+
+          ion-item {
+            --border-color: red;
+          }
+        </style>
+        <div id="container">
+          <ion-list inset="true">
+            <ion-item-sliding>
+              <ion-item>
+                <ion-label>Item 0</ion-label>
+              </ion-item>
+              <ion-item-options slot="end">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+            </ion-item-sliding>
+
+            <ion-item-sliding>
+              <ion-item>
+                <ion-label>Item 1</ion-label>
+              </ion-item>
+              <ion-item-options slot="end">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+            </ion-item-sliding>
+
+            <ion-item-sliding>
+              <ion-item>
+                <ion-label>Item 2</ion-label>
+              </ion-item>
+              <ion-item-options slot="end">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+            </ion-item-sliding>
+          </ion-list>
+        </div>
+      `, config);
+      const container = page.locator('#container');
+      await expect(container).toHaveScreenshot(screenshot('inset-list-end-options-no-lines'));
+    });
+    test('last item in inset list with start options should not have line', async ({ page }) => {
+      await page.setContent(`
+        <style>
+          #container {
+            padding: 10px;
+            background: #0088cc;
+          }
+
+          ion-item {
+            --border-color: red;
+          }
+        </style>
+        <div id="container">
+          <ion-list inset="true">
+            <ion-item-sliding>
+              <ion-item-options slot="start">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+              <ion-item>
+                <ion-label>Item 0</ion-label>
+              </ion-item>
+            </ion-item-sliding>
+
+            <ion-item-sliding>
+              <ion-item-options slot="start">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+              <ion-item>
+                <ion-label>Item 1</ion-label>
+              </ion-item>
+            </ion-item-sliding>
+
+            <ion-item-sliding>
+              <ion-item-options slot="start">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+              <ion-item>
+                <ion-label>Item 2</ion-label>
+              </ion-item>
+            </ion-item-sliding>
+          </ion-list>
+        </div>
+      `, config);
+      const container = page.locator('#container');
+      await expect(container).toHaveScreenshot(screenshot('inset-list-start-options-no-lines'));
+    });
+  });
+});

package/dist/collection/components/picker-internal/test/basic/picker-internal.e2e.js

@@ -10,6 +10,11 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
   test.describe(title('picker-internal: rendering'), () => {
     test('inline pickers should not have visual regression', async ({ page }) => {
       await page.goto(`/src/components/picker-internal/test/basic`, config);
+      const fullStack = page.locator('#inline button[data-value="full-stack"]');
+      const onion = page.locator('#inline button[data-value="onion"]');
+      await expect(fullStack).toHaveClass(/picker-item-active/);
+      await expect(onion).toHaveClass(/picker-item-active/);
+      await page.waitForChanges();
       await expect(page.locator('#inline')).toHaveScreenshot(screenshot(`picker-internal-inline-diff`));
     });
   });

package/dist/collection/components/searchbar/searchbar.md.css

@@ -265,34 +265,40 @@
 }
 
 .searchbar-cancel-button {
+  /**
+   * The left edge of the cancel button
+   * should align with the left edge
+   * of the back button if the searchbar
+   * is used in a toolbar.
+   */
   top: 0;
   background-color: transparent;
   font-size: 1.6em;
 }
 @supports (inset-inline-start: 0) {
   .searchbar-cancel-button {
-    inset-inline-start: 5px;
+    inset-inline-start: 8px;
   }
 }
 @supports not (inset-inline-start: 0) {
   .searchbar-cancel-button {
-    left: 5px;
+    left: 8px;
   }
   :host-context([dir=rtl]) .searchbar-cancel-button {
     left: unset;
     right: unset;
-    right: 5px;
+    right: 8px;
   }
   [dir=rtl] .searchbar-cancel-button {
     left: unset;
     right: unset;
-    right: 5px;
+    right: 8px;
   }
   @supports selector(:dir(rtl)) {
     .searchbar-cancel-button:dir(rtl) {
       left: unset;
       right: unset;
-      right: 5px;
+      right: 8px;
     }
   }
 }

package/dist/collection/components/searchbar/test/basic/searchbar.e2e.js

@@ -134,3 +134,28 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, screenshot, c
     });
   });
 });
+configs({ modes: ['md'], directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+  test.describe(title('searchbar: cancel button alignment'), () => {
+    test('should align with the back button when used in a toolbar', async ({ page }, testInfo) => {
+      testInfo.annotations.push({
+        type: 'issue',
+        description: 'https://github.com/ionic-team/ionic-framework/issues/28468',
+      });
+      await page.setContent(`
+        <ion-header>
+          <ion-toolbar>
+          <ion-buttons slot="start">
+            <ion-back-button default-href="#"></ion-back-button>
+          </ion-buttons>
+          <ion-title>Test</ion-title>
+          </ion-toolbar>
+          <ion-toolbar>
+            <ion-searchbar show-cancel-button="always"></ion-searchbar>
+          </ion-toolbar>
+        </ion-header>
+      `, config);
+      const header = page.locator('ion-header');
+      await expect(header).toHaveScreenshot(screenshot(`searchbar-back-button-align`));
+    });
+  });
+});

package/dist/docs.json

@@ -1,5 +1,5 @@
 {
-  "timestamp": "2023-11-06T19:49:20",
+  "timestamp": "2023-11-06T22:43:13",
   "compiler": {
     "name": "@stencil/core",
     "version": "4.7.0",