@ionic/core 7.5.4-dev.11699037031.16f5cbc8 → 7.5.4-dev.11699282935.1db450b0

package/dist/collection/components/item/item.md.css

@@ -208,7 +208,6 @@
   /* stylelint-enable */
   display: flex;
   position: relative;
-  flex-wrap: wrap;
   align-items: inherit;
   justify-content: inherit;
   width: 100%;
@@ -220,8 +219,8 @@
   outline: none;
   background: var(--background);
   overflow: inherit;
-  z-index: 1;
   box-sizing: border-box;
+  z-index: 1;
 }
 :host-context([dir=rtl]) .item-native {
   padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
@@ -240,10 +239,6 @@
   }
 }
 
-:host(.item-legacy) .item-native {
-  flex-wrap: unset;
-}
-
 .item-native::-moz-focus-inner {
   border: 0;
 }
@@ -279,12 +274,10 @@ button, a {
   /* stylelint-enable */
   display: flex;
   position: relative;
-  flex: 1 0 auto;
+  flex: 1;
   flex-direction: inherit;
-  flex-wrap: wrap;
   align-items: inherit;
   align-self: stretch;
-  max-width: 100%;
   min-height: inherit;
   border-width: var(--inner-border-width);
   border-style: var(--border-style);
@@ -310,12 +303,6 @@ button, a {
   }
 }
 
-:host(.item-legacy) .item-inner {
-  flex: 1;
-  flex-wrap: unset;
-  max-width: unset;
-}
-
 .item-bottom {
   margin-left: 0;
   margin-right: 0;
@@ -379,7 +366,6 @@ button, a {
 
 ::slotted(ion-label:not([slot=end])) {
   flex: 1;
-  width: min-content;
 }
 
 :host(.item-input) {
@@ -388,23 +374,15 @@ button, a {
 
 .input-wrapper {
   display: flex;
-  flex: 1 0 auto;
+  flex: 1;
   flex-direction: inherit;
-  flex-wrap: wrap;
   align-items: inherit;
   align-self: stretch;
-  max-width: 100%;
   text-overflow: ellipsis;
   overflow: inherit;
   box-sizing: border-box;
 }
 
-:host(.item-legacy) .input-wrapper {
-  flex: 1;
-  flex-wrap: unset;
-  max-width: unset;
-}
-
 :host(.item-label-stacked),
 :host(.item-label-floating) {
   align-items: start;

package/dist/collection/components/item/test/basic/item.e2e.js

@@ -29,7 +29,7 @@ configs().forEach(({ title, screenshot, config }) => {
           </ion-item>
 
           <ion-item>
-            <ion-label class="ion-text-nowrap"> Single line text that should have ellipses when it doesn't all fit in the item</ion-label>
+            <ion-label> Single line text that should have ellipses when it doesn't all fit in the item</ion-label>
           </ion-item>
         </ion-list>
       `, config);

package/dist/collection/components/item/test/disabled/item.e2e.js

@@ -11,6 +11,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
     test('should not have visual regressions', async ({ page }) => {
       await page.goto(`/src/components/item/test/disabled`, config);
       await page.setIonViewport();
+      // TODO: FW-4037 - Fix label color inconsistency between disabled controls
       await expect(page).toHaveScreenshot(screenshot(`item-disabled-diff`));
     });
   });

package/dist/collection/components/item/test/text/item.e2e.js

@@ -0,0 +1,14 @@
+/*!
+ * (C) Ionic http://ionicframework.com - MIT License
+ */
+import { expect } from "@playwright/test";
+import { configs, test } from "../../../../utils/test/playwright/index";
+configs().forEach(({ title, screenshot, config }) => {
+  test.describe(title('item: text'), () => {
+    test('should not have visual regressions', async ({ page }) => {
+      await page.goto(`/src/components/item/test/text`, config);
+      await page.setIonViewport();
+      await expect(page).toHaveScreenshot(screenshot(`item-text-diff`));
+    });
+  });
+});

package/dist/collection/components/label/label.ios.css

@@ -41,24 +41,17 @@
   font-family: var(--ion-font-family, inherit);
   font-size: inherit;
   text-overflow: ellipsis;
-  box-sizing: border-box;
-}
-
-:host-context(.item-legacy) {
   white-space: nowrap;
   overflow: hidden;
-}
-
-:host-context(.item:not(.item-input):not(.item-legacy)) {
-  flex-grow: 1;
+  box-sizing: border-box;
 }
 
 :host(.ion-color) {
   color: var(--ion-color-base);
 }
 
-:host(.ion-text-nowrap) {
-  overflow: hidden;
+:host(.ion-text-wrap) {
+  white-space: normal;
 }
 
 :host-context(.item-interactive-disabled:not(.item-multiple-inputs)) {
@@ -77,10 +70,6 @@
   align-self: baseline;
 }
 
-:host-context(.item-skeleton-text) {
-  overflow: hidden;
-}
-
 :host(.label-fixed) {
   flex: 0 0 100px;
   width: 100px;

package/dist/collection/components/label/label.md.css

@@ -41,24 +41,17 @@
   font-family: var(--ion-font-family, inherit);
   font-size: inherit;
   text-overflow: ellipsis;
-  box-sizing: border-box;
-}
-
-:host-context(.item-legacy) {
   white-space: nowrap;
   overflow: hidden;
-}
-
-:host-context(.item:not(.item-input):not(.item-legacy)) {
-  flex-grow: 1;
+  box-sizing: border-box;
 }
 
 :host(.ion-color) {
   color: var(--ion-color-base);
 }
 
-:host(.ion-text-nowrap) {
-  overflow: hidden;
+:host(.ion-text-wrap) {
+  white-space: normal;
 }
 
 :host-context(.item-interactive-disabled:not(.item-multiple-inputs)) {
@@ -77,10 +70,6 @@
   align-self: baseline;
 }
 
-:host-context(.item-skeleton-text) {
-  overflow: hidden;
-}
-
 :host(.label-fixed) {
   flex: 0 0 100px;
   width: 100px;

package/dist/collection/components/list/list.ios.css

@@ -130,7 +130,21 @@ ion-list.list-inset {
   border-radius: 10px;
 }
 
-.list-ios.list-inset ion-item:last-child {
+/**
+ * These selectors ensure the last item in the list
+ * has the correct border.
+ * We need to consider the following scenarios:
+ 1. The only item in a list.
+ 2. The last item in a list as long as it is not the only item.
+ 3. The item in the last item-sliding in a list.
+ * Note that we do not select ion-item:last-of-type
+ * because that will cause the borders to disappear on
+ * items in an item-sliding when the item is the last
+ * element in the item-sliding container.
+ */
+.list-ios.list-inset ion-item:only-child,
+.list-ios.list-inset ion-item:not(:only-of-type):last-of-type,
+.list-ios.list-inset ion-item-sliding:last-of-type ion-item {
   --border-width: 0;
   --inner-border-width: 0;
 }

package/dist/collection/components/list/list.md.css

@@ -166,12 +166,50 @@ ion-list.list-inset {
   border-radius: 2px;
 }
 
-.list-md.list-inset ion-item:first-child {
+/**
+ * These selectors ensure the first item in the list
+ * has the correct radius.
+ * We need to consider the following scenarios:
+ 1. The first item in a list as long as it is not the only item.
+ 2. The item in the first item-sliding in a list.
+ * Note that we do not select "ion-item-sliding ion-item:first-of-type"
+ * because that will cause the borders to disappear on
+ * items in an item-sliding when the item is the first
+ * element in the item-sliding container.
+ */
+.list-md.list-inset ion-item:not(:only-of-type):first-of-type,
+.list-md.list-inset ion-item-sliding:first-of-type ion-item {
   --border-radius: 2px 2px 0 0;
 }
 
-.list-md.list-inset ion-item:last-child {
-  --border-radius: 0 0 2px, 2px;
+/**
+ * These selectors ensure the last item in the list
+ * has the correct radius and border.
+ * We need to consider the following scenarios:
+ 1. The last item in a list as long as it is not the only item.
+ 2. The item in the last item-sliding in a list.
+ * Note that we do not select "ion-item-sliding ion-item:last-of-type"
+ * because that will cause the borders to disappear on
+ * items in an item-sliding when the item is the last
+ * element in the item-sliding container.
+ */
+.list-md.list-inset ion-item:not(:only-of-type):last-of-type,
+.list-md.list-inset ion-item-sliding:last-of-type ion-item {
+  --border-radius: 0 0 2px 2px;
+  --border-width: 0;
+  --inner-border-width: 0;
+}
+
+/**
+ * The only item in a list should have a border radius
+ * on all corners.
+ * We target :only-child instead of :only-of-type
+ * otherwise borders will disappear on items inside of
+ * ion-item-sliding because the item will be the only
+ * one of its type inside of the ion-item-sliding group.
+ */
+.list-md.list-inset ion-item:only-child {
+  --border-radius: 2px;
   --border-width: 0;
   --inner-border-width: 0;
 }

package/dist/collection/components/list/test/lines/list.e2e.js

@@ -22,3 +22,146 @@ configs().forEach(({ title, screenshot, config }) => {
     });
   });
 });
+/**
+ * Padding and border color ensures the bottom border can be easily seen if it regresses.
+ * The background color ensures that any border radius values can be seen.
+ */
+configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
+  test.describe(title('list: lines with children'), () => {
+    test('only item in inset list should not have line', async ({ page }) => {
+      test.info().annotations.push({
+        type: 'issue',
+        description: 'https://github.com/ionic-team/ionic-framework/issues/28435',
+      });
+      await page.setContent(`
+        <style>
+          #container {
+            padding: 10px;
+            background: #0088cc;
+          }
+
+          ion-item {
+            --border-color: red;
+          }
+        </style>
+        <div id="container">
+          <ion-list inset="true">
+            <ion-item>
+              <ion-label>Item 0</ion-label>
+            </ion-item>
+          </ion-list>
+        </div>
+      `, config);
+      const container = page.locator('#container');
+      await expect(container).toHaveScreenshot(screenshot('inset-list-only-item-no-lines'));
+    });
+    test('last item in inset list with end options should not have line', async ({ page }) => {
+      test.info().annotations.push({
+        type: 'issue',
+        description: 'https://github.com/ionic-team/ionic-framework/issues/28435',
+      });
+      await page.setContent(`
+        <style>
+          #container {
+            padding: 10px;
+            background: #0088cc;
+          }
+
+          ion-item {
+            --border-color: red;
+          }
+        </style>
+        <div id="container">
+          <ion-list inset="true">
+            <ion-item-sliding>
+              <ion-item>
+                <ion-label>Item 0</ion-label>
+              </ion-item>
+              <ion-item-options slot="end">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+            </ion-item-sliding>
+
+            <ion-item-sliding>
+              <ion-item>
+                <ion-label>Item 1</ion-label>
+              </ion-item>
+              <ion-item-options slot="end">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+            </ion-item-sliding>
+
+            <ion-item-sliding>
+              <ion-item>
+                <ion-label>Item 2</ion-label>
+              </ion-item>
+              <ion-item-options slot="end">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+            </ion-item-sliding>
+          </ion-list>
+        </div>
+      `, config);
+      const container = page.locator('#container');
+      await expect(container).toHaveScreenshot(screenshot('inset-list-end-options-no-lines'));
+    });
+    test('last item in inset list with start options should not have line', async ({ page }) => {
+      await page.setContent(`
+        <style>
+          #container {
+            padding: 10px;
+            background: #0088cc;
+          }
+
+          ion-item {
+            --border-color: red;
+          }
+        </style>
+        <div id="container">
+          <ion-list inset="true">
+            <ion-item-sliding>
+              <ion-item-options slot="start">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+              <ion-item>
+                <ion-label>Item 0</ion-label>
+              </ion-item>
+            </ion-item-sliding>
+
+            <ion-item-sliding>
+              <ion-item-options slot="start">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+              <ion-item>
+                <ion-label>Item 1</ion-label>
+              </ion-item>
+            </ion-item-sliding>
+
+            <ion-item-sliding>
+              <ion-item-options slot="start">
+                <ion-item-option color="warning">
+                  <ion-icon slot="icon-only" name="pin"></ion-icon>
+                </ion-item-option>
+              </ion-item-options>
+              <ion-item>
+                <ion-label>Item 2</ion-label>
+              </ion-item>
+            </ion-item-sliding>
+          </ion-list>
+        </div>
+      `, config);
+      const container = page.locator('#container');
+      await expect(container).toHaveScreenshot(screenshot('inset-list-start-options-no-lines'));
+    });
+  });
+});

package/dist/collection/components/note/test/a11y/note.e2e.js

@@ -48,48 +48,5 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
       const note = page.locator('ion-note');
       await expect(note).toHaveScreenshot(screenshot(`note-item-divider-scale`));
     });
-    test('should wrap label to the next line without truncating', async ({ page }) => {
-      await page.setContent(`
-        <style>
-          html {
-            font-size: 310%;
-          }
-        </style>
-
-        <ion-list>
-          <ion-item>
-            <ion-note slot="start">Really really long note</ion-note>
-            <ion-label>Label</ion-label>
-          </ion-item>
-
-          <ion-item>
-            <ion-label>Label</ion-label>
-            <ion-note slot="end">Really really long note</ion-note>
-          </ion-item>
-
-          <ion-item>
-            <ion-note slot="start">Note</ion-note>
-            <ion-label>Really really long label</ion-label>
-          </ion-item>
-
-          <ion-item>
-            <ion-label>Really really long label</ion-label>
-            <ion-note slot="end">Note</ion-note>
-          </ion-item>
-
-          <ion-item>
-            <ion-note slot="start">Really really long note</ion-note>
-            <ion-label>Really really long label</ion-label>
-          </ion-item>
-
-          <ion-item>
-            <ion-label>Really really long label</ion-label>
-            <ion-note slot="end">Really really long note</ion-note>
-          </ion-item>
-        </ion-list>
-      `, config);
-      const list = page.locator('ion-list');
-      await expect(list).toHaveScreenshot(screenshot(`note-wrapping-label-scale`));
-    });
   });
 });

package/dist/collection/components/picker-internal/test/basic/picker-internal.e2e.js

@@ -10,6 +10,11 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
   test.describe(title('picker-internal: rendering'), () => {
     test('inline pickers should not have visual regression', async ({ page }) => {
       await page.goto(`/src/components/picker-internal/test/basic`, config);
+      const fullStack = page.locator('#inline button[data-value="full-stack"]');
+      const onion = page.locator('#inline button[data-value="onion"]');
+      await expect(fullStack).toHaveClass(/picker-item-active/);
+      await expect(onion).toHaveClass(/picker-item-active/);
+      await page.waitForChanges();
       await expect(page.locator('#inline')).toHaveScreenshot(screenshot(`picker-internal-inline-diff`));
     });
   });

package/dist/collection/components/radio/radio.js

@@ -2,7 +2,7 @@
  * (C) Ionic http://ionicframework.com - MIT License
  */
 import { Host, h } from "@stencil/core";
-import { createLegacyFormController, isOptionSelected } from "../../utils/forms/index";
+import { createLegacyFormController } from "../../utils/forms/index";
 import { addEventListener, getAriaLabel, removeEventListener } from "../../utils/helpers";
 import { printIonWarning } from "../../utils/logging/index";
 import { createColorClasses, hostContext } from "../../utils/theme";
@@ -23,8 +23,7 @@ export class Radio {
     this.hasLoggedDeprecationWarning = false;
     this.updateState = () => {
       if (this.radioGroup) {
-        const { compareWith, value: radioGroupValue } = this.radioGroup;
-        this.checked = isOptionSelected(radioGroupValue, this.value, compareWith);
+        this.checked = this.radioGroup.value === this.value;
       }
     };
     this.onClick = () => {
@@ -121,8 +120,6 @@ export class Radio {
   emitStyle() {
     const style = {
       'interactive-disabled': this.disabled,
-      // TODO(FW-3125): remove this
-      legacy: !!this.legacy,
     };
     if (this.legacyFormController.hasLegacyControl()) {
       style['radio-checked'] = this.checked;

package/dist/collection/components/radio-group/radio-group.js

@@ -47,7 +47,6 @@ export class RadioGroup {
       }
     };
     this.allowEmptySelection = false;
-    this.compareWith = undefined;
     this.name = this.inputId;
     this.value = undefined;
   }
@@ -159,29 +158,6 @@ export class RadioGroup {
         "reflect": false,
         "defaultValue": "false"
       },
-      "compareWith": {
-        "type": "string",
-        "mutable": false,
-        "complexType": {
-          "original": "string | RadioGroupCompareFn | null",
-          "resolved": "((currentValue: any, compareValue: any) => boolean) | null | string | undefined",
-          "references": {
-            "RadioGroupCompareFn": {
-              "location": "import",
-              "path": "./radio-group-interface",
-              "id": "src/components/radio-group/radio-group-interface.ts::RadioGroupCompareFn"
-            }
-          }
-        },
-        "required": false,
-        "optional": true,
-        "docs": {
-          "tags": [],
-          "text": "This property allows developers to specify a custom function or property\nname for comparing objects when determining the selected option in the\nion-radio-group. When not specified, the default behavior will use object\nequality (===) for comparison."
-        },
-        "attribute": "compare-with",
-        "reflect": false
-      },
       "name": {
         "type": "string",
         "mutable": false,

package/dist/collection/components/range/range.js

@@ -226,8 +226,6 @@ export class Range {
       this.ionStyle.emit({
         interactive: true,
         'interactive-disabled': this.disabled,
-        // TODO(FW-2997): remove this
-        legacy: !!this.legacy,
       });
     }
   }

package/dist/collection/components/select/select.ios.css

@@ -110,11 +110,6 @@
   overflow: hidden;
 }
 
-:host(.in-item:not(.legacy-select)) {
-  flex: 1 1 0;
-  width: 0;
-}
-
 :host(.in-item.legacy-select) {
   position: static;
   max-width: 45%;

package/dist/collection/components/select/select.js

@@ -2,7 +2,7 @@
  * (C) Ionic http://ionicframework.com - MIT License
  */
 import { Host, h, forceUpdate } from "@stencil/core";
-import { compareOptions, createLegacyFormController, createNotchController, isOptionSelected } from "../../utils/forms/index";
+import { createLegacyFormController, createNotchController } from "../../utils/forms/index";
 import { findItemLabel, focusElement, getAriaLabel, renderHiddenInput, inheritAttributes } from "../../utils/helpers";
 import { printIonWarning } from "../../utils/logging/index";
 import { actionSheetController, alertController, popoverController } from "../../utils/overlays";
@@ -465,8 +465,6 @@ export class Select {
       style['has-placeholder'] = this.placeholder !== undefined;
       style['has-value'] = this.hasValue();
       style['has-focus'] = this.isExpanded;
-      // TODO(FW-3194): remove this
-      style['legacy'] = !!this.legacy;
     }
     this.ionStyle.emit(style);
   }
@@ -739,7 +737,7 @@ Developers can use the "legacy" property to continue using the legacy form marku
         "optional": true,
         "docs": {
           "tags": [],
-          "text": "This property allows developers to specify a custom function or property\nname for comparing objects when determining the selected option in the\nion-select. When not specified, the default behavior will use object\nequality (===) for comparison."
+          "text": "A property name or function used to compare object values"
         },
         "attribute": "compare-with",
         "reflect": false
@@ -1217,6 +1215,17 @@ Developers can use the "legacy" property to continue using the legacy form marku
       }];
   }
 }
+const isOptionSelected = (currentValue, compareValue, compareWith) => {
+  if (currentValue === undefined) {
+    return false;
+  }
+  if (Array.isArray(currentValue)) {
+    return currentValue.some((val) => compareOptions(val, compareValue, compareWith));
+  }
+  else {
+    return compareOptions(currentValue, compareValue, compareWith);
+  }
+};
 const getOptionValue = (el) => {
   const value = el.value;
   return value === undefined ? el.textContent || '' : value;
@@ -1230,6 +1239,17 @@ const parseValue = (value) => {
   }
   return value.toString();
 };
+const compareOptions = (currentValue, compareValue, compareWith) => {
+  if (typeof compareWith === 'function') {
+    return compareWith(currentValue, compareValue);
+  }
+  else if (typeof compareWith === 'string') {
+    return currentValue[compareWith] === compareValue[compareWith];
+  }
+  else {
+    return Array.isArray(compareValue) ? compareValue.includes(currentValue) : currentValue === compareValue;
+  }
+};
 const generateText = (opts, value, compareWith) => {
   if (value === undefined) {
     return '';

package/dist/collection/components/select/select.md.css

@@ -110,11 +110,6 @@
   overflow: hidden;
 }
 
-:host(.in-item:not(.legacy-select)) {
-  flex: 1 1 0;
-  width: 0;
-}
-
 :host(.in-item.legacy-select) {
   position: static;
   max-width: 45%;

package/dist/collection/components/select/test/legacy/wrapping/select.e2e.js

@@ -27,7 +27,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
       await page.setContent(`
         <ion-item>
           <ion-label>Really long label should not wrap</ion-label>
-          <ion-select value="wrap" legacy="true" class="ion-text-wrap">
+          <ion-select value="wrap" class="ion-text-wrap">
             <ion-select-option value="wrap">Should wrap value only when label exists and really long text exists to make it wrap the text</ion-select-option>
           </ion-select>
         </ion-item>