@ionic/core 7.5.4-dev.11699031793.11a4baba → 7.5.4-dev.11699037031.16f5cbc8

package/dist/collection/components/item/item.ios.css

@@ -188,10 +188,6 @@
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  padding-inline-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  -webkit-padding-end: var(--padding-end);
-  padding-inline-end: var(--padding-end);
   padding-top: var(--padding-top);
   padding-bottom: var(--padding-bottom);
   font-family: inherit;
@@ -206,8 +202,13 @@
   text-align: inherit;
   white-space: inherit;
   color: inherit;
+  /* stylelint-disable */
+  padding-right: var(--padding-end);
+  padding-left: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
+  /* stylelint-enable */
   display: flex;
   position: relative;
+  flex-wrap: wrap;
   align-items: inherit;
   justify-content: inherit;
   width: 100%;
@@ -219,8 +220,28 @@
   outline: none;
   background: var(--background);
   overflow: inherit;
-  box-sizing: border-box;
   z-index: 1;
+  box-sizing: border-box;
+}
+:host-context([dir=rtl]) .item-native {
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  padding-left: var(--padding-end);
+}
+
+[dir=rtl] .item-native {
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  padding-left: var(--padding-end);
+}
+
+@supports selector(:dir(rtl)) {
+  .item-native:dir(rtl) {
+    padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+    padding-left: var(--padding-end);
+  }
+}
+
+:host(.item-legacy) .item-native {
+  flex-wrap: unset;
 }
 
 .item-native::-moz-focus-inner {
@@ -250,18 +271,20 @@ button, a {
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: var(--inner-padding-start);
-  padding-inline-start: var(--inner-padding-start);
-  -webkit-padding-end: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
-  padding-inline-end: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
   padding-top: var(--inner-padding-top);
   padding-bottom: var(--inner-padding-bottom);
+  /* stylelint-disable */
+  padding-right: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
+  padding-left: var(--inner-padding-start);
+  /* stylelint-enable */
   display: flex;
   position: relative;
-  flex: 1;
+  flex: 1 0 auto;
   flex-direction: inherit;
+  flex-wrap: wrap;
   align-items: inherit;
   align-self: stretch;
+  max-width: 100%;
   min-height: inherit;
   border-width: var(--inner-border-width);
   border-style: var(--border-style);
@@ -270,21 +293,59 @@ button, a {
   overflow: inherit;
   box-sizing: border-box;
 }
+:host-context([dir=rtl]) .item-inner {
+  padding-right: var(--inner-padding-start);
+  padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+}
+
+[dir=rtl] .item-inner {
+  padding-right: var(--inner-padding-start);
+  padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+}
+
+@supports selector(:dir(rtl)) {
+  .item-inner:dir(rtl) {
+    padding-right: var(--inner-padding-start);
+    padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+  }
+}
+
+:host(.item-legacy) .item-inner {
+  flex: 1;
+  flex-wrap: unset;
+  max-width: unset;
+}
 
 .item-bottom {
   margin-left: 0;
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  padding-inline-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  -webkit-padding-end: var(--inner-padding-end);
-  padding-inline-end: var(--inner-padding-end);
   padding-top: 0;
   padding-bottom: 0;
+  /* stylelint-disable */
+  padding-left: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--inner-padding-end) + var(--ion-safe-area-right, 0px));
+  /* stylelint-enable */
   display: flex;
   justify-content: space-between;
 }
+:host-context([dir=rtl]) .item-bottom {
+  padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+}
+
+[dir=rtl] .item-bottom {
+  padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+}
+
+@supports selector(:dir(rtl)) {
+  .item-bottom:dir(rtl) {
+    padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+    padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  }
+}
 
 .item-detail-icon {
   /**
@@ -318,6 +379,7 @@ button, a {
 
 ::slotted(ion-label:not([slot=end])) {
   flex: 1;
+  width: min-content;
 }
 
 :host(.item-input) {
@@ -326,15 +388,23 @@ button, a {
 
 .input-wrapper {
   display: flex;
-  flex: 1;
+  flex: 1 0 auto;
   flex-direction: inherit;
+  flex-wrap: wrap;
   align-items: inherit;
   align-self: stretch;
+  max-width: 100%;
   text-overflow: ellipsis;
   overflow: inherit;
   box-sizing: border-box;
 }
 
+:host(.item-legacy) .input-wrapper {
+  flex: 1;
+  flex-wrap: unset;
+  max-width: unset;
+}
+
 :host(.item-label-stacked),
 :host(.item-label-floating) {
   align-items: start;

package/dist/collection/components/item/item.md.css

@@ -188,10 +188,6 @@
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  padding-inline-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  -webkit-padding-end: var(--padding-end);
-  padding-inline-end: var(--padding-end);
   padding-top: var(--padding-top);
   padding-bottom: var(--padding-bottom);
   font-family: inherit;
@@ -206,8 +202,13 @@
   text-align: inherit;
   white-space: inherit;
   color: inherit;
+  /* stylelint-disable */
+  padding-right: var(--padding-end);
+  padding-left: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
+  /* stylelint-enable */
   display: flex;
   position: relative;
+  flex-wrap: wrap;
   align-items: inherit;
   justify-content: inherit;
   width: 100%;
@@ -219,8 +220,28 @@
   outline: none;
   background: var(--background);
   overflow: inherit;
-  box-sizing: border-box;
   z-index: 1;
+  box-sizing: border-box;
+}
+:host-context([dir=rtl]) .item-native {
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  padding-left: var(--padding-end);
+}
+
+[dir=rtl] .item-native {
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  padding-left: var(--padding-end);
+}
+
+@supports selector(:dir(rtl)) {
+  .item-native:dir(rtl) {
+    padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+    padding-left: var(--padding-end);
+  }
+}
+
+:host(.item-legacy) .item-native {
+  flex-wrap: unset;
 }
 
 .item-native::-moz-focus-inner {
@@ -250,18 +271,20 @@ button, a {
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: var(--inner-padding-start);
-  padding-inline-start: var(--inner-padding-start);
-  -webkit-padding-end: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
-  padding-inline-end: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
   padding-top: var(--inner-padding-top);
   padding-bottom: var(--inner-padding-bottom);
+  /* stylelint-disable */
+  padding-right: calc(var(--ion-safe-area-right, 0px) + var(--inner-padding-end));
+  padding-left: var(--inner-padding-start);
+  /* stylelint-enable */
   display: flex;
   position: relative;
-  flex: 1;
+  flex: 1 0 auto;
   flex-direction: inherit;
+  flex-wrap: wrap;
   align-items: inherit;
   align-self: stretch;
+  max-width: 100%;
   min-height: inherit;
   border-width: var(--inner-border-width);
   border-style: var(--border-style);
@@ -270,21 +293,59 @@ button, a {
   overflow: inherit;
   box-sizing: border-box;
 }
+:host-context([dir=rtl]) .item-inner {
+  padding-right: var(--inner-padding-start);
+  padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+}
+
+[dir=rtl] .item-inner {
+  padding-right: var(--inner-padding-start);
+  padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+}
+
+@supports selector(:dir(rtl)) {
+  .item-inner:dir(rtl) {
+    padding-right: var(--inner-padding-start);
+    padding-left: calc(var(--ion-safe-area-left, 0px) + var(--inner-padding-end));
+  }
+}
+
+:host(.item-legacy) .item-inner {
+  flex: 1;
+  flex-wrap: unset;
+  max-width: unset;
+}
 
 .item-bottom {
   margin-left: 0;
   margin-right: 0;
   margin-top: 0;
   margin-bottom: 0;
-  -webkit-padding-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  padding-inline-start: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
-  -webkit-padding-end: var(--inner-padding-end);
-  padding-inline-end: var(--inner-padding-end);
   padding-top: 0;
   padding-bottom: 0;
+  /* stylelint-disable */
+  padding-left: calc(var(--padding-start) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--inner-padding-end) + var(--ion-safe-area-right, 0px));
+  /* stylelint-enable */
   display: flex;
   justify-content: space-between;
 }
+:host-context([dir=rtl]) .item-bottom {
+  padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+}
+
+[dir=rtl] .item-bottom {
+  padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+  padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+}
+
+@supports selector(:dir(rtl)) {
+  .item-bottom:dir(rtl) {
+    padding-left: calc(var(--inner-padding-end) + var(--ion-safe-area-left, 0px));
+    padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
+  }
+}
 
 .item-detail-icon {
   /**
@@ -318,6 +379,7 @@ button, a {
 
 ::slotted(ion-label:not([slot=end])) {
   flex: 1;
+  width: min-content;
 }
 
 :host(.item-input) {
@@ -326,15 +388,23 @@ button, a {
 
 .input-wrapper {
   display: flex;
-  flex: 1;
+  flex: 1 0 auto;
   flex-direction: inherit;
+  flex-wrap: wrap;
   align-items: inherit;
   align-self: stretch;
+  max-width: 100%;
   text-overflow: ellipsis;
   overflow: inherit;
   box-sizing: border-box;
 }
 
+:host(.item-legacy) .input-wrapper {
+  flex: 1;
+  flex-wrap: unset;
+  max-width: unset;
+}
+
 :host(.item-label-stacked),
 :host(.item-label-floating) {
   align-items: start;

package/dist/collection/components/item/test/basic/item.e2e.js

@@ -10,5 +10,31 @@ configs().forEach(({ title, screenshot, config }) => {
       await page.setIonViewport();
       await expect(page).toHaveScreenshot(screenshot(`item-diff`));
     });
+    /**
+     * This behavior needs to be tested for all modes & directions
+     * Safe padding should stay on the same side when the direction changes
+     */
+    test('should have safe area padding', async ({ page }) => {
+      await page.setContent(`
+        <style>
+          :root {
+            --ion-safe-area-left: 40px;
+            --ion-safe-area-right: 20px;
+          }
+        </style>
+        <ion-list>
+          <ion-item>
+            <ion-label>Item with helper</ion-label>
+            <div slot="helper">Helper</div>
+          </ion-item>
+
+          <ion-item>
+            <ion-label class="ion-text-nowrap"> Single line text that should have ellipses when it doesn't all fit in the item</ion-label>
+          </ion-item>
+        </ion-list>
+      `, config);
+      const list = page.locator('ion-list');
+      await expect(list).toHaveScreenshot(screenshot('item-safe-area'));
+    });
   });
 });

package/dist/collection/components/item/test/disabled/item.e2e.js

@@ -11,7 +11,6 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
     test('should not have visual regressions', async ({ page }) => {
       await page.goto(`/src/components/item/test/disabled`, config);
       await page.setIonViewport();
-      // TODO: FW-4037 - Fix label color inconsistency between disabled controls
       await expect(page).toHaveScreenshot(screenshot(`item-disabled-diff`));
     });
   });

package/dist/collection/components/label/label.ios.css

@@ -41,17 +41,24 @@
   font-family: var(--ion-font-family, inherit);
   font-size: inherit;
   text-overflow: ellipsis;
+  box-sizing: border-box;
+}
+
+:host-context(.item-legacy) {
   white-space: nowrap;
   overflow: hidden;
-  box-sizing: border-box;
+}
+
+:host-context(.item:not(.item-input):not(.item-legacy)) {
+  flex-grow: 1;
 }
 
 :host(.ion-color) {
   color: var(--ion-color-base);
 }
 
-:host(.ion-text-wrap) {
-  white-space: normal;
+:host(.ion-text-nowrap) {
+  overflow: hidden;
 }
 
 :host-context(.item-interactive-disabled:not(.item-multiple-inputs)) {
@@ -70,6 +77,10 @@
   align-self: baseline;
 }
 
+:host-context(.item-skeleton-text) {
+  overflow: hidden;
+}
+
 :host(.label-fixed) {
   flex: 0 0 100px;
   width: 100px;

package/dist/collection/components/label/label.md.css

@@ -41,17 +41,24 @@
   font-family: var(--ion-font-family, inherit);
   font-size: inherit;
   text-overflow: ellipsis;
+  box-sizing: border-box;
+}
+
+:host-context(.item-legacy) {
   white-space: nowrap;
   overflow: hidden;
-  box-sizing: border-box;
+}
+
+:host-context(.item:not(.item-input):not(.item-legacy)) {
+  flex-grow: 1;
 }
 
 :host(.ion-color) {
   color: var(--ion-color-base);
 }
 
-:host(.ion-text-wrap) {
-  white-space: normal;
+:host(.ion-text-nowrap) {
+  overflow: hidden;
 }
 
 :host-context(.item-interactive-disabled:not(.item-multiple-inputs)) {
@@ -70,6 +77,10 @@
   align-self: baseline;
 }
 
+:host-context(.item-skeleton-text) {
+  overflow: hidden;
+}
+
 :host(.label-fixed) {
   flex: 0 0 100px;
   width: 100px;

package/dist/collection/components/note/test/a11y/note.e2e.js

@@ -48,5 +48,48 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
       const note = page.locator('ion-note');
       await expect(note).toHaveScreenshot(screenshot(`note-item-divider-scale`));
     });
+    test('should wrap label to the next line without truncating', async ({ page }) => {
+      await page.setContent(`
+        <style>
+          html {
+            font-size: 310%;
+          }
+        </style>
+
+        <ion-list>
+          <ion-item>
+            <ion-note slot="start">Really really long note</ion-note>
+            <ion-label>Label</ion-label>
+          </ion-item>
+
+          <ion-item>
+            <ion-label>Label</ion-label>
+            <ion-note slot="end">Really really long note</ion-note>
+          </ion-item>
+
+          <ion-item>
+            <ion-note slot="start">Note</ion-note>
+            <ion-label>Really really long label</ion-label>
+          </ion-item>
+
+          <ion-item>
+            <ion-label>Really really long label</ion-label>
+            <ion-note slot="end">Note</ion-note>
+          </ion-item>
+
+          <ion-item>
+            <ion-note slot="start">Really really long note</ion-note>
+            <ion-label>Really really long label</ion-label>
+          </ion-item>
+
+          <ion-item>
+            <ion-label>Really really long label</ion-label>
+            <ion-note slot="end">Really really long note</ion-note>
+          </ion-item>
+        </ion-list>
+      `, config);
+      const list = page.locator('ion-list');
+      await expect(list).toHaveScreenshot(screenshot(`note-wrapping-label-scale`));
+    });
   });
 });

package/dist/collection/components/radio/radio.js

@@ -2,7 +2,7 @@
  * (C) Ionic http://ionicframework.com - MIT License
  */
 import { Host, h } from "@stencil/core";
-import { createLegacyFormController } from "../../utils/forms/index";
+import { createLegacyFormController, isOptionSelected } from "../../utils/forms/index";
 import { addEventListener, getAriaLabel, removeEventListener } from "../../utils/helpers";
 import { printIonWarning } from "../../utils/logging/index";
 import { createColorClasses, hostContext } from "../../utils/theme";
@@ -23,7 +23,8 @@ export class Radio {
     this.hasLoggedDeprecationWarning = false;
     this.updateState = () => {
       if (this.radioGroup) {
-        this.checked = this.radioGroup.value === this.value;
+        const { compareWith, value: radioGroupValue } = this.radioGroup;
+        this.checked = isOptionSelected(radioGroupValue, this.value, compareWith);
       }
     };
     this.onClick = () => {
@@ -120,6 +121,8 @@ export class Radio {
   emitStyle() {
     const style = {
       'interactive-disabled': this.disabled,
+      // TODO(FW-3125): remove this
+      legacy: !!this.legacy,
     };
     if (this.legacyFormController.hasLegacyControl()) {
       style['radio-checked'] = this.checked;

package/dist/collection/components/radio-group/radio-group.js

@@ -47,6 +47,7 @@ export class RadioGroup {
       }
     };
     this.allowEmptySelection = false;
+    this.compareWith = undefined;
     this.name = this.inputId;
     this.value = undefined;
   }
@@ -158,6 +159,29 @@ export class RadioGroup {
         "reflect": false,
         "defaultValue": "false"
       },
+      "compareWith": {
+        "type": "string",
+        "mutable": false,
+        "complexType": {
+          "original": "string | RadioGroupCompareFn | null",
+          "resolved": "((currentValue: any, compareValue: any) => boolean) | null | string | undefined",
+          "references": {
+            "RadioGroupCompareFn": {
+              "location": "import",
+              "path": "./radio-group-interface",
+              "id": "src/components/radio-group/radio-group-interface.ts::RadioGroupCompareFn"
+            }
+          }
+        },
+        "required": false,
+        "optional": true,
+        "docs": {
+          "tags": [],
+          "text": "This property allows developers to specify a custom function or property\nname for comparing objects when determining the selected option in the\nion-radio-group. When not specified, the default behavior will use object\nequality (===) for comparison."
+        },
+        "attribute": "compare-with",
+        "reflect": false
+      },
       "name": {
         "type": "string",
         "mutable": false,

package/dist/collection/components/radio-group/test/compare-with/radio-group.e2e.js

@@ -0,0 +1,93 @@
+/*!
+ * (C) Ionic http://ionicframework.com - MIT License
+ */
+import { expect } from "@playwright/test";
+import { configs, test } from "../../../../utils/test/playwright/index";
+/**
+ * This behavior does not vary across modes/directions.
+ */
+configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
+  test.describe(title('radio-group: compare-with'), () => {
+    test('should correctly set value when using compareWith string', async ({ page }) => {
+      await page.goto('/src/components/radio-group/test/compare-with', config);
+      const radioGroupWithString = page.locator('#compareWithString');
+      const lastRadio = radioGroupWithString.locator('ion-radio').last();
+      await lastRadio.click();
+      await page.waitForChanges();
+      await expect(radioGroupWithString).toHaveJSProperty('value', {
+        label: 'Green',
+        value: 'green',
+      });
+      await expect(lastRadio).toHaveAttribute('aria-checked', 'true');
+    });
+    test('should correctly set value when using compareWith function', async ({ page }) => {
+      await page.goto('/src/components/radio-group/test/compare-with', config);
+      const radioGroupWithFn = page.locator('#compareWithFn');
+      const lastRadio = radioGroupWithFn.locator('ion-radio').last();
+      await lastRadio.click();
+      await page.waitForChanges();
+      await expect(radioGroupWithFn).toHaveJSProperty('value', {
+        label: 'Green',
+        value: 'green',
+      });
+      await expect(lastRadio).toHaveAttribute('aria-checked', 'true');
+    });
+    test('should correctly set value when using null compareWith', async ({ page }) => {
+      await page.goto('/src/components/radio-group/test/compare-with', config);
+      const radioGroupWithNull = page.locator('#compareWithNull');
+      const lastRadio = radioGroupWithNull.locator('ion-radio').last();
+      await lastRadio.click();
+      await page.waitForChanges();
+      await expect(radioGroupWithNull).toHaveJSProperty('value', {
+        label: 'Green',
+        value: 'green',
+      });
+      await expect(lastRadio).toHaveAttribute('aria-checked', 'true');
+    });
+    test('should work with different parameter types', async ({ page }) => {
+      test.info().annotations.push({
+        type: 'issue',
+        description: 'https://github.com/ionic-team/ionic-framework/issues/25759',
+      });
+      await page.setContent(`
+        <ion-radio-group value="3"></ion-radio-group>
+
+        <script>
+          const data = [
+            { id: 1, name: 'Option #1' },
+            { id: 2, name: 'Option #2' },
+            { id: 3, name: 'Option #3' },
+          ]
+          const radioGroup = document.querySelector('ion-radio-group');
+          radioGroup.compareWith = (val1, val2) => {
+            // convert val1 to a number
+            return +val1 === val2;
+          }
+
+          data.forEach((d) => {
+            const radio = document.createElement('ion-radio');
+
+            radio.value = d.id;
+            radio.textContent = d.name;
+
+            const item = document.createElement('ion-item');
+            item.appendChild(radio);
+
+            radioGroup.appendChild(item);
+          });
+        </script>
+      `, config);
+      const radioGroup = page.locator('ion-radio-group');
+      const radios = page.locator('ion-radio');
+      await expect(radios.nth(0)).toHaveAttribute('aria-checked', 'false');
+      await expect(radios.nth(1)).toHaveAttribute('aria-checked', 'false');
+      await expect(radios.nth(2)).toHaveAttribute('aria-checked', 'true');
+      await radios.nth(0).click();
+      await page.waitForChanges();
+      await expect(radios.nth(0)).toHaveAttribute('aria-checked', 'true');
+      await expect(radios.nth(1)).toHaveAttribute('aria-checked', 'false');
+      await expect(radios.nth(2)).toHaveAttribute('aria-checked', 'false');
+      await expect(radioGroup).toHaveJSProperty('value', 1);
+    });
+  });
+});

package/dist/collection/components/range/range.js

@@ -226,6 +226,8 @@ export class Range {
       this.ionStyle.emit({
         interactive: true,
         'interactive-disabled': this.disabled,
+        // TODO(FW-2997): remove this
+        legacy: !!this.legacy,
       });
     }
   }