@ionic/core 7.5.4-dev.11699023297.172bb30f → 7.5.4-dev.11699037031.16f5cbc8

package/dist/collection/components/item/item.ios.css

@@ -208,6 +208,7 @@
   /* stylelint-enable */
   display: flex;
   position: relative;
+  flex-wrap: wrap;
   align-items: inherit;
   justify-content: inherit;
   width: 100%;
@@ -219,8 +220,8 @@
   outline: none;
   background: var(--background);
   overflow: inherit;
-  box-sizing: border-box;
   z-index: 1;
+  box-sizing: border-box;
 }
 :host-context([dir=rtl]) .item-native {
   padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
@@ -239,6 +240,10 @@
   }
 }
 
+:host(.item-legacy) .item-native {
+  flex-wrap: unset;
+}
+
 .item-native::-moz-focus-inner {
   border: 0;
 }
@@ -274,10 +279,12 @@ button, a {
   /* stylelint-enable */
   display: flex;
   position: relative;
-  flex: 1;
+  flex: 1 0 auto;
   flex-direction: inherit;
+  flex-wrap: wrap;
   align-items: inherit;
   align-self: stretch;
+  max-width: 100%;
   min-height: inherit;
   border-width: var(--inner-border-width);
   border-style: var(--border-style);
@@ -303,6 +310,12 @@ button, a {
   }
 }
 
+:host(.item-legacy) .item-inner {
+  flex: 1;
+  flex-wrap: unset;
+  max-width: unset;
+}
+
 .item-bottom {
   margin-left: 0;
   margin-right: 0;
@@ -366,6 +379,7 @@ button, a {
 
 ::slotted(ion-label:not([slot=end])) {
   flex: 1;
+  width: min-content;
 }
 
 :host(.item-input) {
@@ -374,15 +388,23 @@ button, a {
 
 .input-wrapper {
   display: flex;
-  flex: 1;
+  flex: 1 0 auto;
   flex-direction: inherit;
+  flex-wrap: wrap;
   align-items: inherit;
   align-self: stretch;
+  max-width: 100%;
   text-overflow: ellipsis;
   overflow: inherit;
   box-sizing: border-box;
 }
 
+:host(.item-legacy) .input-wrapper {
+  flex: 1;
+  flex-wrap: unset;
+  max-width: unset;
+}
+
 :host(.item-label-stacked),
 :host(.item-label-floating) {
   align-items: start;

package/dist/collection/components/item/item.md.css

@@ -208,6 +208,7 @@
   /* stylelint-enable */
   display: flex;
   position: relative;
+  flex-wrap: wrap;
   align-items: inherit;
   justify-content: inherit;
   width: 100%;
@@ -219,8 +220,8 @@
   outline: none;
   background: var(--background);
   overflow: inherit;
-  box-sizing: border-box;
   z-index: 1;
+  box-sizing: border-box;
 }
 :host-context([dir=rtl]) .item-native {
   padding-right: calc(var(--padding-start) + var(--ion-safe-area-right, 0px));
@@ -239,6 +240,10 @@
   }
 }
 
+:host(.item-legacy) .item-native {
+  flex-wrap: unset;
+}
+
 .item-native::-moz-focus-inner {
   border: 0;
 }
@@ -274,10 +279,12 @@ button, a {
   /* stylelint-enable */
   display: flex;
   position: relative;
-  flex: 1;
+  flex: 1 0 auto;
   flex-direction: inherit;
+  flex-wrap: wrap;
   align-items: inherit;
   align-self: stretch;
+  max-width: 100%;
   min-height: inherit;
   border-width: var(--inner-border-width);
   border-style: var(--border-style);
@@ -303,6 +310,12 @@ button, a {
   }
 }
 
+:host(.item-legacy) .item-inner {
+  flex: 1;
+  flex-wrap: unset;
+  max-width: unset;
+}
+
 .item-bottom {
   margin-left: 0;
   margin-right: 0;
@@ -366,6 +379,7 @@ button, a {
 
 ::slotted(ion-label:not([slot=end])) {
   flex: 1;
+  width: min-content;
 }
 
 :host(.item-input) {
@@ -374,15 +388,23 @@ button, a {
 
 .input-wrapper {
   display: flex;
-  flex: 1;
+  flex: 1 0 auto;
   flex-direction: inherit;
+  flex-wrap: wrap;
   align-items: inherit;
   align-self: stretch;
+  max-width: 100%;
   text-overflow: ellipsis;
   overflow: inherit;
   box-sizing: border-box;
 }
 
+:host(.item-legacy) .input-wrapper {
+  flex: 1;
+  flex-wrap: unset;
+  max-width: unset;
+}
+
 :host(.item-label-stacked),
 :host(.item-label-floating) {
   align-items: start;

package/dist/collection/components/item/test/basic/item.e2e.js

@@ -29,7 +29,7 @@ configs().forEach(({ title, screenshot, config }) => {
           </ion-item>
 
           <ion-item>
-            <ion-label> Single line text that should have ellipses when it doesn't all fit in the item</ion-label>
+            <ion-label class="ion-text-nowrap"> Single line text that should have ellipses when it doesn't all fit in the item</ion-label>
           </ion-item>
         </ion-list>
       `, config);

package/dist/collection/components/item/test/disabled/item.e2e.js

@@ -11,7 +11,6 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
     test('should not have visual regressions', async ({ page }) => {
       await page.goto(`/src/components/item/test/disabled`, config);
       await page.setIonViewport();
-      // TODO: FW-4037 - Fix label color inconsistency between disabled controls
       await expect(page).toHaveScreenshot(screenshot(`item-disabled-diff`));
     });
   });

package/dist/collection/components/label/label.ios.css

@@ -41,17 +41,24 @@
   font-family: var(--ion-font-family, inherit);
   font-size: inherit;
   text-overflow: ellipsis;
+  box-sizing: border-box;
+}
+
+:host-context(.item-legacy) {
   white-space: nowrap;
   overflow: hidden;
-  box-sizing: border-box;
+}
+
+:host-context(.item:not(.item-input):not(.item-legacy)) {
+  flex-grow: 1;
 }
 
 :host(.ion-color) {
   color: var(--ion-color-base);
 }
 
-:host(.ion-text-wrap) {
-  white-space: normal;
+:host(.ion-text-nowrap) {
+  overflow: hidden;
 }
 
 :host-context(.item-interactive-disabled:not(.item-multiple-inputs)) {
@@ -70,6 +77,10 @@
   align-self: baseline;
 }
 
+:host-context(.item-skeleton-text) {
+  overflow: hidden;
+}
+
 :host(.label-fixed) {
   flex: 0 0 100px;
   width: 100px;

package/dist/collection/components/label/label.md.css

@@ -41,17 +41,24 @@
   font-family: var(--ion-font-family, inherit);
   font-size: inherit;
   text-overflow: ellipsis;
+  box-sizing: border-box;
+}
+
+:host-context(.item-legacy) {
   white-space: nowrap;
   overflow: hidden;
-  box-sizing: border-box;
+}
+
+:host-context(.item:not(.item-input):not(.item-legacy)) {
+  flex-grow: 1;
 }
 
 :host(.ion-color) {
   color: var(--ion-color-base);
 }
 
-:host(.ion-text-wrap) {
-  white-space: normal;
+:host(.ion-text-nowrap) {
+  overflow: hidden;
 }
 
 :host-context(.item-interactive-disabled:not(.item-multiple-inputs)) {
@@ -70,6 +77,10 @@
   align-self: baseline;
 }
 
+:host-context(.item-skeleton-text) {
+  overflow: hidden;
+}
+
 :host(.label-fixed) {
   flex: 0 0 100px;
   width: 100px;

package/dist/collection/components/note/test/a11y/note.e2e.js

@@ -48,5 +48,48 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
       const note = page.locator('ion-note');
       await expect(note).toHaveScreenshot(screenshot(`note-item-divider-scale`));
     });
+    test('should wrap label to the next line without truncating', async ({ page }) => {
+      await page.setContent(`
+        <style>
+          html {
+            font-size: 310%;
+          }
+        </style>
+
+        <ion-list>
+          <ion-item>
+            <ion-note slot="start">Really really long note</ion-note>
+            <ion-label>Label</ion-label>
+          </ion-item>
+
+          <ion-item>
+            <ion-label>Label</ion-label>
+            <ion-note slot="end">Really really long note</ion-note>
+          </ion-item>
+
+          <ion-item>
+            <ion-note slot="start">Note</ion-note>
+            <ion-label>Really really long label</ion-label>
+          </ion-item>
+
+          <ion-item>
+            <ion-label>Really really long label</ion-label>
+            <ion-note slot="end">Note</ion-note>
+          </ion-item>
+
+          <ion-item>
+            <ion-note slot="start">Really really long note</ion-note>
+            <ion-label>Really really long label</ion-label>
+          </ion-item>
+
+          <ion-item>
+            <ion-label>Really really long label</ion-label>
+            <ion-note slot="end">Really really long note</ion-note>
+          </ion-item>
+        </ion-list>
+      `, config);
+      const list = page.locator('ion-list');
+      await expect(list).toHaveScreenshot(screenshot(`note-wrapping-label-scale`));
+    });
   });
 });

package/dist/collection/components/picker-internal/test/basic/picker-internal.e2e.js

@@ -10,11 +10,6 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
   test.describe(title('picker-internal: rendering'), () => {
     test('inline pickers should not have visual regression', async ({ page }) => {
       await page.goto(`/src/components/picker-internal/test/basic`, config);
-      const fullStack = page.locator('#inline button[data-value="full-stack"]');
-      const onion = page.locator('#inline button[data-value="onion"]');
-      await expect(fullStack).toHaveClass(/picker-item-active/);
-      await expect(onion).toHaveClass(/picker-item-active/);
-      await page.waitForChanges();
       await expect(page.locator('#inline')).toHaveScreenshot(screenshot(`picker-internal-inline-diff`));
     });
   });

package/dist/collection/components/radio/radio.js

@@ -2,7 +2,7 @@
  * (C) Ionic http://ionicframework.com - MIT License
  */
 import { Host, h } from "@stencil/core";
-import { createLegacyFormController } from "../../utils/forms/index";
+import { createLegacyFormController, isOptionSelected } from "../../utils/forms/index";
 import { addEventListener, getAriaLabel, removeEventListener } from "../../utils/helpers";
 import { printIonWarning } from "../../utils/logging/index";
 import { createColorClasses, hostContext } from "../../utils/theme";
@@ -23,7 +23,8 @@ export class Radio {
     this.hasLoggedDeprecationWarning = false;
     this.updateState = () => {
       if (this.radioGroup) {
-        this.checked = this.radioGroup.value === this.value;
+        const { compareWith, value: radioGroupValue } = this.radioGroup;
+        this.checked = isOptionSelected(radioGroupValue, this.value, compareWith);
       }
     };
     this.onClick = () => {
@@ -120,6 +121,8 @@ export class Radio {
   emitStyle() {
     const style = {
       'interactive-disabled': this.disabled,
+      // TODO(FW-3125): remove this
+      legacy: !!this.legacy,
     };
     if (this.legacyFormController.hasLegacyControl()) {
       style['radio-checked'] = this.checked;

package/dist/collection/components/radio-group/radio-group.js

@@ -47,6 +47,7 @@ export class RadioGroup {
       }
     };
     this.allowEmptySelection = false;
+    this.compareWith = undefined;
     this.name = this.inputId;
     this.value = undefined;
   }
@@ -158,6 +159,29 @@ export class RadioGroup {
         "reflect": false,
         "defaultValue": "false"
       },
+      "compareWith": {
+        "type": "string",
+        "mutable": false,
+        "complexType": {
+          "original": "string | RadioGroupCompareFn | null",
+          "resolved": "((currentValue: any, compareValue: any) => boolean) | null | string | undefined",
+          "references": {
+            "RadioGroupCompareFn": {
+              "location": "import",
+              "path": "./radio-group-interface",
+              "id": "src/components/radio-group/radio-group-interface.ts::RadioGroupCompareFn"
+            }
+          }
+        },
+        "required": false,
+        "optional": true,
+        "docs": {
+          "tags": [],
+          "text": "This property allows developers to specify a custom function or property\nname for comparing objects when determining the selected option in the\nion-radio-group. When not specified, the default behavior will use object\nequality (===) for comparison."
+        },
+        "attribute": "compare-with",
+        "reflect": false
+      },
       "name": {
         "type": "string",
         "mutable": false,

package/dist/collection/components/radio-group/test/compare-with/radio-group.e2e.js

@@ -0,0 +1,93 @@
+/*!
+ * (C) Ionic http://ionicframework.com - MIT License
+ */
+import { expect } from "@playwright/test";
+import { configs, test } from "../../../../utils/test/playwright/index";
+/**
+ * This behavior does not vary across modes/directions.
+ */
+configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
+  test.describe(title('radio-group: compare-with'), () => {
+    test('should correctly set value when using compareWith string', async ({ page }) => {
+      await page.goto('/src/components/radio-group/test/compare-with', config);
+      const radioGroupWithString = page.locator('#compareWithString');
+      const lastRadio = radioGroupWithString.locator('ion-radio').last();
+      await lastRadio.click();
+      await page.waitForChanges();
+      await expect(radioGroupWithString).toHaveJSProperty('value', {
+        label: 'Green',
+        value: 'green',
+      });
+      await expect(lastRadio).toHaveAttribute('aria-checked', 'true');
+    });
+    test('should correctly set value when using compareWith function', async ({ page }) => {
+      await page.goto('/src/components/radio-group/test/compare-with', config);
+      const radioGroupWithFn = page.locator('#compareWithFn');
+      const lastRadio = radioGroupWithFn.locator('ion-radio').last();
+      await lastRadio.click();
+      await page.waitForChanges();
+      await expect(radioGroupWithFn).toHaveJSProperty('value', {
+        label: 'Green',
+        value: 'green',
+      });
+      await expect(lastRadio).toHaveAttribute('aria-checked', 'true');
+    });
+    test('should correctly set value when using null compareWith', async ({ page }) => {
+      await page.goto('/src/components/radio-group/test/compare-with', config);
+      const radioGroupWithNull = page.locator('#compareWithNull');
+      const lastRadio = radioGroupWithNull.locator('ion-radio').last();
+      await lastRadio.click();
+      await page.waitForChanges();
+      await expect(radioGroupWithNull).toHaveJSProperty('value', {
+        label: 'Green',
+        value: 'green',
+      });
+      await expect(lastRadio).toHaveAttribute('aria-checked', 'true');
+    });
+    test('should work with different parameter types', async ({ page }) => {
+      test.info().annotations.push({
+        type: 'issue',
+        description: 'https://github.com/ionic-team/ionic-framework/issues/25759',
+      });
+      await page.setContent(`
+        <ion-radio-group value="3"></ion-radio-group>
+
+        <script>
+          const data = [
+            { id: 1, name: 'Option #1' },
+            { id: 2, name: 'Option #2' },
+            { id: 3, name: 'Option #3' },
+          ]
+          const radioGroup = document.querySelector('ion-radio-group');
+          radioGroup.compareWith = (val1, val2) => {
+            // convert val1 to a number
+            return +val1 === val2;
+          }
+
+          data.forEach((d) => {
+            const radio = document.createElement('ion-radio');
+
+            radio.value = d.id;
+            radio.textContent = d.name;
+
+            const item = document.createElement('ion-item');
+            item.appendChild(radio);
+
+            radioGroup.appendChild(item);
+          });
+        </script>
+      `, config);
+      const radioGroup = page.locator('ion-radio-group');
+      const radios = page.locator('ion-radio');
+      await expect(radios.nth(0)).toHaveAttribute('aria-checked', 'false');
+      await expect(radios.nth(1)).toHaveAttribute('aria-checked', 'false');
+      await expect(radios.nth(2)).toHaveAttribute('aria-checked', 'true');
+      await radios.nth(0).click();
+      await page.waitForChanges();
+      await expect(radios.nth(0)).toHaveAttribute('aria-checked', 'true');
+      await expect(radios.nth(1)).toHaveAttribute('aria-checked', 'false');
+      await expect(radios.nth(2)).toHaveAttribute('aria-checked', 'false');
+      await expect(radioGroup).toHaveJSProperty('value', 1);
+    });
+  });
+});

package/dist/collection/components/range/range.js

@@ -226,6 +226,8 @@ export class Range {
       this.ionStyle.emit({
         interactive: true,
         'interactive-disabled': this.disabled,
+        // TODO(FW-2997): remove this
+        legacy: !!this.legacy,
       });
     }
   }

package/dist/collection/components/select/select.ios.css

@@ -110,6 +110,11 @@
   overflow: hidden;
 }
 
+:host(.in-item:not(.legacy-select)) {
+  flex: 1 1 0;
+  width: 0;
+}
+
 :host(.in-item.legacy-select) {
   position: static;
   max-width: 45%;

package/dist/collection/components/select/select.js

@@ -2,7 +2,7 @@
  * (C) Ionic http://ionicframework.com - MIT License
  */
 import { Host, h, forceUpdate } from "@stencil/core";
-import { createLegacyFormController, createNotchController } from "../../utils/forms/index";
+import { compareOptions, createLegacyFormController, createNotchController, isOptionSelected } from "../../utils/forms/index";
 import { findItemLabel, focusElement, getAriaLabel, renderHiddenInput, inheritAttributes } from "../../utils/helpers";
 import { printIonWarning } from "../../utils/logging/index";
 import { actionSheetController, alertController, popoverController } from "../../utils/overlays";
@@ -465,6 +465,8 @@ export class Select {
       style['has-placeholder'] = this.placeholder !== undefined;
       style['has-value'] = this.hasValue();
       style['has-focus'] = this.isExpanded;
+      // TODO(FW-3194): remove this
+      style['legacy'] = !!this.legacy;
     }
     this.ionStyle.emit(style);
   }
@@ -737,7 +739,7 @@ Developers can use the "legacy" property to continue using the legacy form marku
         "optional": true,
         "docs": {
           "tags": [],
-          "text": "A property name or function used to compare object values"
+          "text": "This property allows developers to specify a custom function or property\nname for comparing objects when determining the selected option in the\nion-select. When not specified, the default behavior will use object\nequality (===) for comparison."
         },
         "attribute": "compare-with",
         "reflect": false
@@ -1215,17 +1217,6 @@ Developers can use the "legacy" property to continue using the legacy form marku
       }];
   }
 }
-const isOptionSelected = (currentValue, compareValue, compareWith) => {
-  if (currentValue === undefined) {
-    return false;
-  }
-  if (Array.isArray(currentValue)) {
-    return currentValue.some((val) => compareOptions(val, compareValue, compareWith));
-  }
-  else {
-    return compareOptions(currentValue, compareValue, compareWith);
-  }
-};
 const getOptionValue = (el) => {
   const value = el.value;
   return value === undefined ? el.textContent || '' : value;
@@ -1239,17 +1230,6 @@ const parseValue = (value) => {
   }
   return value.toString();
 };
-const compareOptions = (currentValue, compareValue, compareWith) => {
-  if (typeof compareWith === 'function') {
-    return compareWith(currentValue, compareValue);
-  }
-  else if (typeof compareWith === 'string') {
-    return currentValue[compareWith] === compareValue[compareWith];
-  }
-  else {
-    return Array.isArray(compareValue) ? compareValue.includes(currentValue) : currentValue === compareValue;
-  }
-};
 const generateText = (opts, value, compareWith) => {
   if (value === undefined) {
     return '';

package/dist/collection/components/select/select.md.css

@@ -110,6 +110,11 @@
   overflow: hidden;
 }
 
+:host(.in-item:not(.legacy-select)) {
+  flex: 1 1 0;
+  width: 0;
+}
+
 :host(.in-item.legacy-select) {
   position: static;
   max-width: 45%;

package/dist/collection/components/select/test/legacy/wrapping/select.e2e.js

@@ -27,7 +27,7 @@ configs({ directions: ['ltr'] }).forEach(({ title, screenshot, config }) => {
       await page.setContent(`
         <ion-item>
           <ion-label>Really long label should not wrap</ion-label>
-          <ion-select value="wrap" class="ion-text-wrap">
+          <ion-select value="wrap" legacy="true" class="ion-text-wrap">
             <ion-select-option value="wrap">Should wrap value only when label exists and really long text exists to make it wrap the text</ion-select-option>
           </ion-select>
         </ion-item>

package/dist/collection/components/skeleton-text/skeleton-text.js

@@ -9,6 +9,18 @@ export class SkeletonText {
   constructor() {
     this.animated = false;
   }
+  componentWillLoad() {
+    this.emitStyle();
+  }
+  emitStyle() {
+    // The emitted property is used by item in order
+    // to add the item-skeleton-text class which applies
+    // overflow: hidden to its label
+    const style = {
+      'skeleton-text': true,
+    };
+    this.ionStyle.emit(style);
+  }
   render() {
     const animated = this.animated && config.getBoolean('animated', true);
     const inMedia = hostContext('ion-avatar', this.el) || hostContext('ion-thumbnail', this.el);
@@ -53,5 +65,32 @@ export class SkeletonText {
       }
     };
   }
+  static get events() {
+    return [{
+        "method": "ionStyle",
+        "name": "ionStyle",
+        "bubbles": true,
+        "cancelable": true,
+        "composed": true,
+        "docs": {
+          "tags": [{
+              "name": "internal",
+              "text": undefined
+            }],
+          "text": "Emitted when the styles change."
+        },
+        "complexType": {
+          "original": "StyleEventDetail",
+          "resolved": "StyleEventDetail",
+          "references": {
+            "StyleEventDetail": {
+              "location": "import",
+              "path": "../../interface",
+              "id": "src/interface.d.ts::StyleEventDetail"
+            }
+          }
+        }
+      }];
+  }
   static get elementRef() { return "el"; }
 }

package/dist/collection/components/textarea/textarea.js

@@ -189,6 +189,8 @@ export class Textarea {
         'has-placeholder': this.placeholder !== undefined,
         'has-value': this.hasValue(),
         'has-focus': this.hasFocus,
+        // TODO(FW-2876): remove this
+        legacy: !!this.legacy,
       });
     }
   }

package/dist/collection/components/toast/animations/md.enter.js

@@ -15,7 +15,7 @@ export const mdEnterAnimation = (baseEl, opts) => {
   wrapperAnimation.addElement(wrapperEl);
   switch (position) {
     case 'top':
-      wrapperEl.style.top = top;
+      wrapperEl.style.setProperty('transform', `translateY(${top})`);
       wrapperAnimation.fromTo('opacity', 0.01, 1);
       break;
     case 'middle':
@@ -24,7 +24,7 @@ export const mdEnterAnimation = (baseEl, opts) => {
       wrapperAnimation.fromTo('opacity', 0.01, 1);
       break;
     default:
-      wrapperEl.style.bottom = bottom;
+      wrapperEl.style.setProperty('transform', `translateY(${bottom})`);
       wrapperAnimation.fromTo('opacity', 0.01, 1);
       break;
   }