@iobroker/repochecker 5.20.1 → 5.20.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +8 -0
- package/index.js +8 -0
- package/lib/M0000_PackageJson.js +2 -2
- package/lib/M5000_Code.js +30 -7
- package/lib/M9000_GitNpmIgnore.js +43 -15
- package/lib/config.js +13 -3
- package/package.json +2 -2
package/README.md
CHANGED
|
@@ -31,6 +31,14 @@ Example:
|
|
|
31
31
|
Placeholder for the next version (at the beginning of the line):
|
|
32
32
|
### **WORK IN PROGRESS**
|
|
33
33
|
-->
|
|
34
|
+
### 5.20.3 (2026-08-07)
|
|
35
|
+
|
|
36
|
+
* (mcm1957) Fixed false positive `[S9508]` (and related packaging/i18n checks): negation entries (e.g. `!CHANGELOG_OLD.md`) in package.json `"files"` are now handled as exclusions instead of being wrongly matched. Related to #1097 and #1072.
|
|
37
|
+
|
|
38
|
+
### 5.20.2 (2026-08-07)
|
|
39
|
+
|
|
40
|
+
* (mcm1957) React usage is now also detected when `@iobroker/gui-components` is used as dependency.
|
|
41
|
+
|
|
34
42
|
### 5.20.1 (2026-07-17)
|
|
35
43
|
|
|
36
44
|
* (Copilot) Add a workflow check that rejects `always()` on standard test-and-release jobs and flags it for review on custom jobs.
|
package/index.js
CHANGED
|
@@ -343,6 +343,14 @@ if (typeof module !== 'undefined' && module.parent) {
|
|
|
343
343
|
}
|
|
344
344
|
console.log(`\ncreated by repochecker ${context.version} based on commit ${context.lastCommitSha}`);
|
|
345
345
|
|
|
346
|
+
if (common.isLocal()) {
|
|
347
|
+
console.log(`\n----------------------------------------------------------`);
|
|
348
|
+
console.log(`This check has been run using --local mode.`);
|
|
349
|
+
console.log(`Please note that local mode is experimental state only and`);
|
|
350
|
+
console.log(`may report false positive findings and miss real issues.`);
|
|
351
|
+
console.log(`----------------------------------------------------------`);
|
|
352
|
+
}
|
|
353
|
+
|
|
346
354
|
if (common.isLocal() && context.errors.length) {
|
|
347
355
|
process.exit(1);
|
|
348
356
|
}
|
package/lib/M0000_PackageJson.js
CHANGED
|
@@ -465,10 +465,10 @@ function parseDependencyDeclaration(packageName, packageVersion) {
|
|
|
465
465
|
*/
|
|
466
466
|
function getNpmUpdateRule(context, packageName) {
|
|
467
467
|
const rules = context.cfg?.npmUpdateSuggestions || {};
|
|
468
|
-
const defaultMinimumAgeDays = Number.isFinite(rules.defaultMinimumAgeDays) ? rules.defaultMinimumAgeDays :
|
|
468
|
+
const defaultMinimumAgeDays = Number.isFinite(rules.defaultMinimumAgeDays) ? rules.defaultMinimumAgeDays : 180;
|
|
469
469
|
const newAdapterMinimumAgeDays = Number.isFinite(rules.newAdapterMinimumAgeDays)
|
|
470
470
|
? rules.newAdapterMinimumAgeDays
|
|
471
|
-
:
|
|
471
|
+
: 30;
|
|
472
472
|
|
|
473
473
|
const defaultLevel = context.cfg?.isNewAdapter ? 'W' : 'S';
|
|
474
474
|
let minimumAgeDays = context.cfg?.isNewAdapter ? newAdapterMinimumAgeDays : defaultMinimumAgeDays;
|
package/lib/M5000_Code.js
CHANGED
|
@@ -849,6 +849,7 @@ async function checkCode(context) {
|
|
|
849
849
|
if (
|
|
850
850
|
context.packageJson.devDependencies &&
|
|
851
851
|
(context.packageJson.devDependencies['@iobroker/adapter-react-v5'] ||
|
|
852
|
+
context.packageJson.devDependencies['@iobroker/gui-components'] ||
|
|
852
853
|
context.packageJson.devDependencies['react'])
|
|
853
854
|
) {
|
|
854
855
|
common.info('REACT detected at package devDependencies');
|
|
@@ -856,18 +857,28 @@ async function checkCode(context) {
|
|
|
856
857
|
}
|
|
857
858
|
if (
|
|
858
859
|
context.packageJson.dependencies &&
|
|
859
|
-
(context.packageJson.dependencies['@iobroker/adapter-react-v5'] ||
|
|
860
|
+
(context.packageJson.dependencies['@iobroker/adapter-react-v5'] ||
|
|
861
|
+
context.packageJson.dependencies['@iobroker/gui-components'] ||
|
|
862
|
+
context.packageJson.dependencies['react'])
|
|
860
863
|
) {
|
|
861
864
|
common.info('REACT detected at package dependencies');
|
|
862
865
|
usesReact = true;
|
|
863
866
|
}
|
|
864
867
|
if (context['/src-admin/package.json']) {
|
|
865
868
|
const packageJson = JSON.parse(context['/src-admin/package.json']);
|
|
866
|
-
if (
|
|
869
|
+
if (
|
|
870
|
+
packageJson.devDependencies &&
|
|
871
|
+
(packageJson.devDependencies['@iobroker/adapter-react-v5'] ||
|
|
872
|
+
packageJson.devDependencies['@iobroker/gui-components'])
|
|
873
|
+
) {
|
|
867
874
|
common.info('REACT detected at src-admin/package devDependencies');
|
|
868
875
|
usesReact = true;
|
|
869
876
|
}
|
|
870
|
-
if (
|
|
877
|
+
if (
|
|
878
|
+
packageJson.dependencies &&
|
|
879
|
+
(packageJson.dependencies['@iobroker/adapter-react-v5'] ||
|
|
880
|
+
packageJson.dependencies['@iobroker/gui-components'])
|
|
881
|
+
) {
|
|
871
882
|
common.info('REACT detected at src-admin/package dependencies');
|
|
872
883
|
usesReact = true;
|
|
873
884
|
}
|
|
@@ -876,14 +887,18 @@ async function checkCode(context) {
|
|
|
876
887
|
const packageJson = JSON.parse(context['/src-widgets/package.json']);
|
|
877
888
|
if (
|
|
878
889
|
packageJson.devDependencies &&
|
|
879
|
-
(packageJson.devDependencies['@iobroker/adapter-react-v5'] ||
|
|
890
|
+
(packageJson.devDependencies['@iobroker/adapter-react-v5'] ||
|
|
891
|
+
packageJson.devDependencies['@iobroker/gui-components'] ||
|
|
892
|
+
packageJson.devDependencies['react'])
|
|
880
893
|
) {
|
|
881
894
|
common.info('REACT detected at src-widgets/package devDependencies');
|
|
882
895
|
usesReact = true;
|
|
883
896
|
}
|
|
884
897
|
if (
|
|
885
898
|
packageJson.dependencies &&
|
|
886
|
-
(packageJson.dependencies['@iobroker/adapter-react-v5'] ||
|
|
899
|
+
(packageJson.dependencies['@iobroker/adapter-react-v5'] ||
|
|
900
|
+
packageJson.dependencies['@iobroker/gui-components'] ||
|
|
901
|
+
packageJson.dependencies['react'])
|
|
887
902
|
) {
|
|
888
903
|
common.info('REACT detected at src-widgets/package dependencies');
|
|
889
904
|
usesReact = true;
|
|
@@ -892,11 +907,19 @@ async function checkCode(context) {
|
|
|
892
907
|
if (context['/src/package.json']) {
|
|
893
908
|
//console.log('"src/package.json" exists');
|
|
894
909
|
const packageJson = JSON.parse(context['/src/package.json']);
|
|
895
|
-
if (
|
|
910
|
+
if (
|
|
911
|
+
packageJson.devDependencies &&
|
|
912
|
+
(packageJson.devDependencies['@iobroker/adapter-react-v5'] ||
|
|
913
|
+
packageJson.devDependencies['@iobroker/gui-components'])
|
|
914
|
+
) {
|
|
896
915
|
// console.log('REACT detected');
|
|
897
916
|
usesReact = true;
|
|
898
917
|
}
|
|
899
|
-
if (
|
|
918
|
+
if (
|
|
919
|
+
packageJson.dependencies &&
|
|
920
|
+
(packageJson.dependencies['@iobroker/adapter-react-v5'] ||
|
|
921
|
+
packageJson.dependencies['@iobroker/gui-components'])
|
|
922
|
+
) {
|
|
900
923
|
// console.log('REACT detected');
|
|
901
924
|
usesReact = true;
|
|
902
925
|
}
|
|
@@ -222,15 +222,29 @@ function isGlobPattern(entry) {
|
|
|
222
222
|
* @returns {boolean} true if the file is included
|
|
223
223
|
*/
|
|
224
224
|
function isFileIncludedInFiles(filePath, filesEntries) {
|
|
225
|
-
|
|
226
|
-
|
|
227
|
-
|
|
228
|
-
|
|
229
|
-
|
|
225
|
+
// Process entries in order so that a later negation (e.g. "!CHANGELOG_OLD.md")
|
|
226
|
+
// can exclude a file that an earlier entry (e.g. "*.md") included.
|
|
227
|
+
let included = false;
|
|
228
|
+
for (const entry of filesEntries) {
|
|
229
|
+
// A leading "!" marks an exclusion; strip it and remember it separately
|
|
230
|
+
// instead of passing it to minimatch (which would treat "!" as its own
|
|
231
|
+
// negation operator and wrongly match unrelated files).
|
|
232
|
+
const isNegation = entry.startsWith('!');
|
|
233
|
+
const pattern = isNegation ? entry.slice(1) : entry;
|
|
234
|
+
const normalized = pattern.replace(/^\.?\//, '').replace(/\/+$/, '');
|
|
235
|
+
|
|
236
|
+
let matches;
|
|
237
|
+
if (isGlobPattern(pattern)) {
|
|
238
|
+
matches = minimatch(filePath, normalized, { dot: true });
|
|
239
|
+
} else {
|
|
240
|
+
matches = normalized === '.' || normalized === filePath || filePath.startsWith(`${normalized}/`);
|
|
230
241
|
}
|
|
231
242
|
|
|
232
|
-
|
|
233
|
-
|
|
243
|
+
if (matches) {
|
|
244
|
+
included = !isNegation;
|
|
245
|
+
}
|
|
246
|
+
}
|
|
247
|
+
return included;
|
|
234
248
|
}
|
|
235
249
|
|
|
236
250
|
/**
|
|
@@ -252,17 +266,31 @@ function isI18nDirIncludedInFiles(i18nDir, filesEntries, allFiles) {
|
|
|
252
266
|
})
|
|
253
267
|
.map(f => f.replace(/^\//, ''));
|
|
254
268
|
|
|
255
|
-
|
|
256
|
-
|
|
257
|
-
|
|
258
|
-
|
|
269
|
+
// Process entries in order so that a later negation (e.g. "!admin/i18n/**")
|
|
270
|
+
// can exclude a directory that an earlier entry included.
|
|
271
|
+
let included = false;
|
|
272
|
+
for (const entry of filesEntries) {
|
|
273
|
+
// A leading "!" marks an exclusion; strip it and remember it separately
|
|
274
|
+
// instead of passing it to minimatch (which would treat "!" as its own
|
|
275
|
+
// negation operator and wrongly match unrelated files).
|
|
276
|
+
const isNegation = entry.startsWith('!');
|
|
277
|
+
const pattern = isNegation ? entry.slice(1) : entry;
|
|
278
|
+
const normalized = pattern.replace(/^\.\//, '').replace(/\/+$/, '');
|
|
279
|
+
|
|
280
|
+
let matches;
|
|
281
|
+
if (isGlobPattern(pattern)) {
|
|
259
282
|
// Use minimatch to test whether any file inside the i18n directory matches the glob
|
|
260
|
-
|
|
283
|
+
matches = i18nFiles.some(file => minimatch(file, normalized, { dot: true }));
|
|
284
|
+
} else {
|
|
285
|
+
// Plain path: covered if entry is exactly the i18n dir, a parent dir, or '.' (root)
|
|
286
|
+
matches = normalized === '.' || normalized === i18nPath || i18nPath.startsWith(`${normalized}/`);
|
|
261
287
|
}
|
|
262
288
|
|
|
263
|
-
|
|
264
|
-
|
|
265
|
-
|
|
289
|
+
if (matches) {
|
|
290
|
+
included = !isNegation;
|
|
291
|
+
}
|
|
292
|
+
}
|
|
293
|
+
return included;
|
|
266
294
|
}
|
|
267
295
|
|
|
268
296
|
/**
|
package/lib/config.js
CHANGED
|
@@ -471,9 +471,19 @@ const testingNodeJs = {
|
|
|
471
471
|
|
|
472
472
|
const npmUpdateSuggestions = {
|
|
473
473
|
defaultMinimumAgeDays: 180,
|
|
474
|
-
newAdapterMinimumAgeDays:
|
|
475
|
-
standardPackages:
|
|
476
|
-
|
|
474
|
+
newAdapterMinimumAgeDays: 30,
|
|
475
|
+
standardPackages: {
|
|
476
|
+
typescript: {
|
|
477
|
+
defaultMinimumAgeDays: 180,
|
|
478
|
+
level: 'S',
|
|
479
|
+
},
|
|
480
|
+
},
|
|
481
|
+
blacklistedPackages: [
|
|
482
|
+
// do not check
|
|
483
|
+
'@types/node',
|
|
484
|
+
'@types/react-dom',
|
|
485
|
+
'@mui/material',
|
|
486
|
+
],
|
|
477
487
|
};
|
|
478
488
|
|
|
479
489
|
function initConfig(context) {
|
package/package.json
CHANGED
|
@@ -1,5 +1,5 @@
|
|
|
1
1
|
{
|
|
2
|
-
"version": "5.20.
|
|
2
|
+
"version": "5.20.3",
|
|
3
3
|
"name": "@iobroker/repochecker",
|
|
4
4
|
"dependencies": {
|
|
5
5
|
"ajv": "^8.20.0",
|
|
@@ -8,7 +8,7 @@
|
|
|
8
8
|
"image-size": "^1.2.0",
|
|
9
9
|
"js-yaml": "^4.1.1",
|
|
10
10
|
"json5": "^2.2.3",
|
|
11
|
-
"minimatch": "^10.
|
|
11
|
+
"minimatch": "^10.2.6",
|
|
12
12
|
"semver": "^7.8.5"
|
|
13
13
|
},
|
|
14
14
|
"devDependencies": {
|