@iobroker/repochecker 5.0.2 → 5.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +17 -11
- package/lib/M0000_PackageJson.js +130 -4
- package/lib/M1000_IOPackageJson.js +11 -11
- package/lib/M5000_Code.js +141 -20
- package/lib/M5500__JsonConfig.js +4 -4
- package/lib/M8000_Github.js +4 -0
- package/package.json +6 -5
package/README.md
CHANGED
|
@@ -6,15 +6,11 @@ If you want to add your adapter to the public ioBroker repository, all tests on
|
|
|
6
6
|
|
|
7
7
|
## How to test via cli
|
|
8
8
|
|
|
9
|
-
|
|
9
|
+
When running the repository checker via the command line, you **need** to add the repository as parameter, while the branch parameter (`master/main/dev`) is optional. If this parameter is omitted, the `default` branch (typically master / main) will be checked.
|
|
10
10
|
|
|
11
|
-
`npx @iobroker/repochecker <repo> [branch]`
|
|
12
|
-
|
|
13
|
-
```bash
|
|
14
|
-
npx @iobroker/repochecker https://github.com/ioBroker/ioBroker.javascript master
|
|
15
11
|
```
|
|
16
|
-
|
|
17
|
-
|
|
12
|
+
npx @iobroker/repochecker <repo> [branch]`
|
|
13
|
+
```
|
|
18
14
|
|
|
19
15
|
For extra debugging outputs you can pass the `--debug` parameter.
|
|
20
16
|
|
|
@@ -23,16 +19,26 @@ The link to the GitHub repository is still necessary because data from the proje
|
|
|
23
19
|
|
|
24
20
|
Example:
|
|
25
21
|
|
|
26
|
-
|
|
27
|
-
npx @iobroker/repochecker https://github.com/ioBroker/ioBroker.javascript --local
|
|
28
|
-
```
|
|
22
|
+
`npx @iobroker/repochecker https://github.com/ioBroker/ioBroker.repochecker --local`
|
|
29
23
|
|
|
30
24
|
<!--
|
|
31
25
|
Placeholder for the next version (at the beginning of the line):
|
|
32
26
|
### **WORK IN PROGRESS**
|
|
33
27
|
-->
|
|
28
|
+
### 5.1.0 (2025-11-25)
|
|
29
|
+
- (@copilot) Added check for conflicting JSON/JSON5 files with same base name in same directory (E5038) [#169]
|
|
30
|
+
- (@copilot) Added .releaseconfig.json verification to check plugins listed match installed devDependencies (E5036, W5037)
|
|
31
|
+
- (@copilot) Added YAML file validation check (E5035) to verify .yml and .yaml files are well-structured [#618]
|
|
32
|
+
- (@copilot) Added flexible conditional dependency requirements support [#609]
|
|
33
|
+
- (mcm1957) add warning if iobroker bot PRs are open. [#596]
|
|
34
|
+
- (mcm1957) remove S1094, protectedNative elements need not be encrypted. [#579]
|
|
35
|
+
- (mcm1957) required and suggested releases of standard pacakges have been updated.
|
|
36
|
+
- (mcm1957) Log errors at io-package validation as errors now.
|
|
37
|
+
- (mcm1957) Text for E1000 has been corrected. [#576]
|
|
38
|
+
- (mcm1957) Pathc information has been added to error E5509. [#394]
|
|
39
|
+
|
|
34
40
|
### 5.0.2 (2025-10-03)
|
|
35
|
-
- (mcm1957) Some debug log
|
|
41
|
+
- (mcm1957) Some debug log has been removed.
|
|
36
42
|
|
|
37
43
|
### 5.0.1 (2025-10-03)
|
|
38
44
|
- (mcm1957) A crash at adapters which do not contain news entry at io-package.json has been fixed. [#572]
|
package/lib/M0000_PackageJson.js
CHANGED
|
@@ -33,8 +33,48 @@ const dependenciesPackageJson = {
|
|
|
33
33
|
const devDependenciesPackageJson = {
|
|
34
34
|
'@alcalzone/release-script': {
|
|
35
35
|
required: '3.8.0',
|
|
36
|
-
recommended: '
|
|
37
|
-
actual: '
|
|
36
|
+
recommended: '5.0.0',
|
|
37
|
+
actual: '5.0.0',
|
|
38
|
+
optional: true,
|
|
39
|
+
suggested: true,
|
|
40
|
+
// Conditional requirements: when this package is >= a certain version,
|
|
41
|
+
// other packages have updated requirements
|
|
42
|
+
conditionalRequirements: [
|
|
43
|
+
{
|
|
44
|
+
ifVersion: '5.0.0',
|
|
45
|
+
targetDependency: '@alcalzone/release-script-plugin-iobroker',
|
|
46
|
+
required: '4.0.0',
|
|
47
|
+
},
|
|
48
|
+
{
|
|
49
|
+
ifVersion: '5.0.0',
|
|
50
|
+
targetDependency: '@alcalzone/release-script-plugin-license',
|
|
51
|
+
required: '4.0.0',
|
|
52
|
+
},
|
|
53
|
+
{
|
|
54
|
+
ifVersion: '5.0.0',
|
|
55
|
+
targetDependency: '@alcalzone/release-script-plugin-manual-review',
|
|
56
|
+
required: '4.0.0',
|
|
57
|
+
},
|
|
58
|
+
],
|
|
59
|
+
},
|
|
60
|
+
'@alcalzone/release-script-plugin-iobroker': {
|
|
61
|
+
required: '3.7.2',
|
|
62
|
+
recommended: '4.0.0',
|
|
63
|
+
actual: '4.0.0',
|
|
64
|
+
optional: true,
|
|
65
|
+
suggested: true,
|
|
66
|
+
},
|
|
67
|
+
'@alcalzone/release-script-plugin-license': {
|
|
68
|
+
required: '3.7.0',
|
|
69
|
+
recommended: '4.0.0',
|
|
70
|
+
actual: '4.0.0',
|
|
71
|
+
optional: true,
|
|
72
|
+
suggested: true,
|
|
73
|
+
},
|
|
74
|
+
'@alcalzone/release-script-plugin-manual-review': {
|
|
75
|
+
required: '3.7.0',
|
|
76
|
+
recommended: '4.0.0',
|
|
77
|
+
actual: '4.0.0',
|
|
38
78
|
optional: true,
|
|
39
79
|
suggested: true,
|
|
40
80
|
},
|
|
@@ -63,8 +103,8 @@ const devDependenciesPackageJson = {
|
|
|
63
103
|
},
|
|
64
104
|
'@iobroker/testing': {
|
|
65
105
|
required: '4.1.3',
|
|
66
|
-
recommended: '5.
|
|
67
|
-
actual: '5.
|
|
106
|
+
recommended: '5.2.2',
|
|
107
|
+
actual: '5.2.2',
|
|
68
108
|
onlyWWW: false,
|
|
69
109
|
alternatives: ['@iobroker/legacy-testing'],
|
|
70
110
|
},
|
|
@@ -240,6 +280,83 @@ const validObjectsPackageJson = [
|
|
|
240
280
|
'workspaces',
|
|
241
281
|
];
|
|
242
282
|
|
|
283
|
+
/**
|
|
284
|
+
* Applies conditional requirements based on dependencies present in package.json.
|
|
285
|
+
* When a source dependency is at a certain version or higher, it updates the
|
|
286
|
+
* required/recommended versions of target dependencies.
|
|
287
|
+
*
|
|
288
|
+
* @param {object} dependencyTable - The dependency requirements table (dependenciesPackageJson or devDependenciesPackageJson)
|
|
289
|
+
* @param {object} packageJsonDeps - The dependencies from package.json being checked
|
|
290
|
+
*/
|
|
291
|
+
function applyConditionalRequirements(dependencyTable, packageJsonDeps) {
|
|
292
|
+
if (!packageJsonDeps) {
|
|
293
|
+
return;
|
|
294
|
+
}
|
|
295
|
+
|
|
296
|
+
for (const sourceDep in dependencyTable) {
|
|
297
|
+
const config = dependencyTable[sourceDep];
|
|
298
|
+
if (!config.conditionalRequirements || !Array.isArray(config.conditionalRequirements)) {
|
|
299
|
+
continue;
|
|
300
|
+
}
|
|
301
|
+
|
|
302
|
+
// Check if the source dependency is present in package.json
|
|
303
|
+
let sourceVersion = packageJsonDeps[sourceDep];
|
|
304
|
+
if (!sourceVersion) {
|
|
305
|
+
continue;
|
|
306
|
+
}
|
|
307
|
+
|
|
308
|
+
// Remove ^ or ~ prefix to get the version number
|
|
309
|
+
sourceVersion = sourceVersion.replace(/[\^~]/g, '').trim();
|
|
310
|
+
|
|
311
|
+
// Process each conditional requirement
|
|
312
|
+
for (const condition of config.conditionalRequirements) {
|
|
313
|
+
const { ifVersion, targetDependency, required, recommended } = condition;
|
|
314
|
+
|
|
315
|
+
// Check if the source dependency version meets the condition
|
|
316
|
+
try {
|
|
317
|
+
if (compareVersions.compare(sourceVersion, ifVersion, '>=')) {
|
|
318
|
+
// Apply the conditional requirements to the target dependency
|
|
319
|
+
if (dependencyTable[targetDependency]) {
|
|
320
|
+
if (required) {
|
|
321
|
+
// Use the higher version between existing and conditional required
|
|
322
|
+
const existingRequired = dependencyTable[targetDependency].required;
|
|
323
|
+
if (existingRequired && compareVersions.compare(required, existingRequired, '>')) {
|
|
324
|
+
dependencyTable[targetDependency].required = required;
|
|
325
|
+
common.debug(
|
|
326
|
+
`Conditional requirement: ${targetDependency} required updated to ${required} due to ${sourceDep} >= ${ifVersion}`,
|
|
327
|
+
);
|
|
328
|
+
} else if (!existingRequired) {
|
|
329
|
+
dependencyTable[targetDependency].required = required;
|
|
330
|
+
common.debug(
|
|
331
|
+
`Conditional requirement: ${targetDependency} required set to ${required} due to ${sourceDep} >= ${ifVersion}`,
|
|
332
|
+
);
|
|
333
|
+
}
|
|
334
|
+
}
|
|
335
|
+
if (recommended) {
|
|
336
|
+
// Use the higher version between existing and conditional recommended
|
|
337
|
+
const existingRecommended = dependencyTable[targetDependency].recommended;
|
|
338
|
+
if (existingRecommended && compareVersions.compare(recommended, existingRecommended, '>')) {
|
|
339
|
+
dependencyTable[targetDependency].recommended = recommended;
|
|
340
|
+
common.debug(
|
|
341
|
+
`Conditional requirement: ${targetDependency} recommended updated to ${recommended} due to ${sourceDep} >= ${ifVersion}`,
|
|
342
|
+
);
|
|
343
|
+
} else if (!existingRecommended) {
|
|
344
|
+
dependencyTable[targetDependency].recommended = recommended;
|
|
345
|
+
common.debug(
|
|
346
|
+
`Conditional requirement: ${targetDependency} recommended set to ${recommended} due to ${sourceDep} >= ${ifVersion}`,
|
|
347
|
+
);
|
|
348
|
+
}
|
|
349
|
+
}
|
|
350
|
+
}
|
|
351
|
+
}
|
|
352
|
+
} catch (e) {
|
|
353
|
+
// Version comparison failed, skip this condition
|
|
354
|
+
common.debug(`Could not compare versions for conditional requirement: ${e}`);
|
|
355
|
+
}
|
|
356
|
+
}
|
|
357
|
+
}
|
|
358
|
+
}
|
|
359
|
+
|
|
243
360
|
/**
|
|
244
361
|
* Validates release format according to ioBroker semver subset requirements
|
|
245
362
|
*
|
|
@@ -814,6 +931,15 @@ async function checkPackageJson(context) {
|
|
|
814
931
|
context.checks.push('"engines" check skipped for wwwOnly adapter.');
|
|
815
932
|
}
|
|
816
933
|
|
|
934
|
+
// Apply conditional requirements based on dependencies present in package.json
|
|
935
|
+
// This must be done before checking dependencies so that version requirements are updated
|
|
936
|
+
if (context.packageJson.dependencies) {
|
|
937
|
+
applyConditionalRequirements(dependenciesPackageJson, context.packageJson.dependencies);
|
|
938
|
+
}
|
|
939
|
+
if (context.packageJson.devDependencies) {
|
|
940
|
+
applyConditionalRequirements(devDependenciesPackageJson, context.packageJson.devDependencies);
|
|
941
|
+
}
|
|
942
|
+
|
|
817
943
|
// check dependcy requirements
|
|
818
944
|
for (const dependency in dependenciesPackageJson) {
|
|
819
945
|
common.debug(`checking dependency ${dependency} ...`);
|
|
@@ -23,7 +23,7 @@ async function getIOPackageJson(context) {
|
|
|
23
23
|
try {
|
|
24
24
|
context.ioPackageJson = JSON.parse(context.ioPackageJson);
|
|
25
25
|
} catch (e) {
|
|
26
|
-
context.errors.push(`[E1000] Cannot parse
|
|
26
|
+
context.errors.push(`[E1000] Cannot parse io-package.json: ${e}`);
|
|
27
27
|
}
|
|
28
28
|
}
|
|
29
29
|
return context;
|
|
@@ -147,15 +147,15 @@ async function validateIOPackageSchema(context) {
|
|
|
147
147
|
errorMsg = `Property "${path}" ${message}`;
|
|
148
148
|
}
|
|
149
149
|
|
|
150
|
-
context.
|
|
150
|
+
context.errors.push(`[E1105] io-package.json schema validation error: ${errorMsg}`);
|
|
151
151
|
}
|
|
152
152
|
} else {
|
|
153
|
-
context.
|
|
153
|
+
context.errors.push('[E1105] io-package.json does not validate against schema');
|
|
154
154
|
}
|
|
155
155
|
}
|
|
156
156
|
} catch (error) {
|
|
157
157
|
common.debug(`Schema validation error: ${error.message}`);
|
|
158
|
-
context.
|
|
158
|
+
context.errors.push(`[E1108] io-package.json schema validation failed: ${error.message}`);
|
|
159
159
|
}
|
|
160
160
|
|
|
161
161
|
return context;
|
|
@@ -253,13 +253,13 @@ async function checkIOPackageJson(context) {
|
|
|
253
253
|
}
|
|
254
254
|
}
|
|
255
255
|
|
|
256
|
-
for (const key of context.ioPackageJson.protectedNative || []) {
|
|
257
|
-
|
|
258
|
-
|
|
259
|
-
|
|
260
|
-
|
|
261
|
-
|
|
262
|
-
}
|
|
256
|
+
// for (const key of context.ioPackageJson.protectedNative || []) {
|
|
257
|
+
// if (!(context.ioPackageJson.encryptedNative && context.ioPackageJson.encryptedNative.includes(key))) {
|
|
258
|
+
// context.warnings.push(
|
|
259
|
+
// `[S1094] Consider adding protected native "${key}" to "encryptedNative" in io-package.json`,
|
|
260
|
+
// );
|
|
261
|
+
// }
|
|
262
|
+
// }
|
|
263
263
|
|
|
264
264
|
for (const key of [
|
|
265
265
|
...new Set([
|
package/lib/M5000_Code.js
CHANGED
|
@@ -12,10 +12,14 @@ const path = require('node:path');
|
|
|
12
12
|
|
|
13
13
|
const compareVersions = require('compare-versions');
|
|
14
14
|
const JSON5 = require('json5');
|
|
15
|
+
const yaml = require('js-yaml');
|
|
15
16
|
|
|
16
17
|
const common = require('./common.js');
|
|
17
18
|
const M5500__jsonConfig = require('./M5500__JsonConfig.js');
|
|
18
19
|
|
|
20
|
+
// YAML file extensions for validation
|
|
21
|
+
const yamlExtensions = ['.yml', '.yaml'];
|
|
22
|
+
|
|
19
23
|
// utility to parse words.js
|
|
20
24
|
function extractWords(words) {
|
|
21
25
|
try {
|
|
@@ -132,6 +136,26 @@ async function checkCode(context) {
|
|
|
132
136
|
}
|
|
133
137
|
});
|
|
134
138
|
|
|
139
|
+
// Add all YAML files (.yml, .yaml) to readFiles for validation
|
|
140
|
+
const excludeDirsForYaml = ['node_modules', '.git', '.vscode', '.dev-server'];
|
|
141
|
+
|
|
142
|
+
tempFilesList.forEach(filePath => {
|
|
143
|
+
// Skip files in excluded directories
|
|
144
|
+
const pathParts = filePath.split('/').filter(part => part !== '');
|
|
145
|
+
const isInExcludedDir = pathParts.some(part => excludeDirsForYaml.includes(part));
|
|
146
|
+
|
|
147
|
+
if (!isInExcludedDir) {
|
|
148
|
+
const ext = path.extname(filePath);
|
|
149
|
+
if (yamlExtensions.includes(ext)) {
|
|
150
|
+
// Ensure the file path starts with /
|
|
151
|
+
const normalizedPath = filePath.startsWith('/') ? filePath : `/${filePath}`;
|
|
152
|
+
if (!readFiles.includes(normalizedPath)) {
|
|
153
|
+
readFiles.push(normalizedPath);
|
|
154
|
+
}
|
|
155
|
+
}
|
|
156
|
+
}
|
|
157
|
+
});
|
|
158
|
+
|
|
135
159
|
// if (!context.ioPackageJson.common.noConfig) {
|
|
136
160
|
// if (context.ioPackageJson.common.materialize || (context.ioPackageJson.common.adminUI && context.ioPackageJson.common.adminUI.config === 'materialize')) {
|
|
137
161
|
// readFiles.push('admin/index_m.html');
|
|
@@ -225,6 +249,64 @@ async function checkCode(context) {
|
|
|
225
249
|
});
|
|
226
250
|
});
|
|
227
251
|
|
|
252
|
+
// Check for conflicting JSON file extensions in the same directory
|
|
253
|
+
// E5038: Files with the same base name but different extensions (.json, .json5) in the same directory
|
|
254
|
+
const jsonExtensions = ['.json', '.json5'];
|
|
255
|
+
const jsonFilesByDirectory = new Map();
|
|
256
|
+
|
|
257
|
+
// Group files by directory and base name
|
|
258
|
+
context.filesList.forEach(filePath => {
|
|
259
|
+
const ext = path.extname(filePath);
|
|
260
|
+
if (jsonExtensions.includes(ext)) {
|
|
261
|
+
const dir = path.dirname(filePath);
|
|
262
|
+
const baseName = path.basename(filePath, ext);
|
|
263
|
+
|
|
264
|
+
if (!jsonFilesByDirectory.has(dir)) {
|
|
265
|
+
jsonFilesByDirectory.set(dir, new Map());
|
|
266
|
+
}
|
|
267
|
+
|
|
268
|
+
const dirFiles = jsonFilesByDirectory.get(dir);
|
|
269
|
+
if (!dirFiles.has(baseName)) {
|
|
270
|
+
dirFiles.set(baseName, []);
|
|
271
|
+
}
|
|
272
|
+
|
|
273
|
+
dirFiles.get(baseName).push({ ext, fullPath: filePath });
|
|
274
|
+
}
|
|
275
|
+
});
|
|
276
|
+
|
|
277
|
+
// Check for JSON/JSON5 conflicts
|
|
278
|
+
jsonFilesByDirectory.forEach((dirFiles, dir) => {
|
|
279
|
+
dirFiles.forEach((files, baseName) => {
|
|
280
|
+
if (files.length > 1) {
|
|
281
|
+
// Check if we have both .json and .json5 extensions
|
|
282
|
+
const hasJson = files.some(f => f.ext === '.json');
|
|
283
|
+
const hasJson5 = files.some(f => f.ext === '.json5');
|
|
284
|
+
if (hasJson && hasJson5) {
|
|
285
|
+
context.errors.push(
|
|
286
|
+
`[E5038] Conflicting JSON files in directory "${dir}": Both ${baseName}.json and ${baseName}.json5 versions of same file exist. Please remove one.`,
|
|
287
|
+
);
|
|
288
|
+
}
|
|
289
|
+
}
|
|
290
|
+
});
|
|
291
|
+
});
|
|
292
|
+
|
|
293
|
+
// Check all YAML files (.yml, .yaml) for valid syntax
|
|
294
|
+
// E5035: YAML file cannot be parsed
|
|
295
|
+
for (const fileName of Object.keys(context)) {
|
|
296
|
+
if (fileName.startsWith('/') && typeof context[fileName] === 'string') {
|
|
297
|
+
const ext = path.extname(fileName);
|
|
298
|
+
if (yamlExtensions.includes(ext)) {
|
|
299
|
+
try {
|
|
300
|
+
yaml.load(context[fileName]);
|
|
301
|
+
} catch (e) {
|
|
302
|
+
context.errors.push(
|
|
303
|
+
`[E5035] Cannot parse YAML file "${fileName.slice(1)}": ${e.message.split('\n')[0]}`,
|
|
304
|
+
);
|
|
305
|
+
}
|
|
306
|
+
}
|
|
307
|
+
}
|
|
308
|
+
}
|
|
309
|
+
|
|
228
310
|
let usesReact = false;
|
|
229
311
|
if (
|
|
230
312
|
context.packageJson.devDependencies &&
|
|
@@ -483,39 +565,74 @@ async function checkCode(context) {
|
|
|
483
565
|
const releaseConfigJson = JSON.parse(context['/.releaseconfig.json']);
|
|
484
566
|
common.debug(`releaseConfigJson: ${releaseConfigJson}`);
|
|
485
567
|
|
|
486
|
-
const plugins = releaseConfigJson.plugins;
|
|
568
|
+
const plugins = releaseConfigJson.plugins || [];
|
|
487
569
|
common.debug(`plugins: ${plugins}`);
|
|
570
|
+
|
|
571
|
+
// Mapping of plugin names to their package names
|
|
572
|
+
// Plugins bundled with @alcalzone/release-script (don't need separate installation):
|
|
573
|
+
// changelog, exec, git, package, version
|
|
574
|
+
// Plugins requiring separate installation:
|
|
575
|
+
// iobroker, license, manual-review, lerna
|
|
576
|
+
const pluginToPackage = {
|
|
577
|
+
iobroker: '@alcalzone/release-script-plugin-iobroker',
|
|
578
|
+
license: '@alcalzone/release-script-plugin-license',
|
|
579
|
+
'manual-review': '@alcalzone/release-script-plugin-manual-review',
|
|
580
|
+
lerna: '@alcalzone/release-script-plugin-lerna',
|
|
581
|
+
};
|
|
582
|
+
|
|
583
|
+
// Required plugins for ioBroker adapters
|
|
584
|
+
const requiredPlugins = ['iobroker', 'license'];
|
|
585
|
+
// Suggested plugins for ioBroker adapters
|
|
586
|
+
const suggestedPlugins = ['manual-review'];
|
|
587
|
+
|
|
588
|
+
// Check required plugins are installed as devDependencies
|
|
488
589
|
if (!context.packageJson.devDependencies['@alcalzone/release-script-plugin-iobroker']) {
|
|
489
590
|
context.errors.push(
|
|
490
591
|
'[E5024] "@alcalzone/release-script" requires plugin "@alcalzone/release-script-plugin-iobroker". Please add.',
|
|
491
592
|
);
|
|
492
|
-
} else {
|
|
493
|
-
if (!plugins.includes('iobroker')) {
|
|
494
|
-
context.errors.push(
|
|
495
|
-
'[E5027] Plugin "iobroker" missing at .releaseconfig.json. Please add.',
|
|
496
|
-
);
|
|
497
|
-
}
|
|
498
593
|
}
|
|
499
594
|
if (!context.packageJson.devDependencies['@alcalzone/release-script-plugin-license']) {
|
|
500
595
|
context.errors.push(
|
|
501
596
|
'[E5025] "@alcalzone/release-script" requires plugin "@alcalzone/release-script-plugin-license". Please add.',
|
|
502
597
|
);
|
|
503
|
-
} else {
|
|
504
|
-
if (!plugins.includes('license')) {
|
|
505
|
-
context.errors.push('[E5028] Plugin "license" missing at .releaseconfig.json. Please add.');
|
|
506
|
-
}
|
|
507
598
|
}
|
|
508
599
|
if (!context.packageJson.devDependencies['@alcalzone/release-script-plugin-manual-review']) {
|
|
509
600
|
context.warnings.push(
|
|
510
601
|
'[S5026] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".',
|
|
511
602
|
);
|
|
512
|
-
}
|
|
513
|
-
|
|
514
|
-
|
|
515
|
-
|
|
603
|
+
}
|
|
604
|
+
|
|
605
|
+
// Check all plugins listed in .releaseconfig.json are installed as devDependencies
|
|
606
|
+
for (const plugin of plugins) {
|
|
607
|
+
const packageName = pluginToPackage[plugin];
|
|
608
|
+
if (packageName && !context.packageJson.devDependencies[packageName]) {
|
|
609
|
+
context.errors.push(
|
|
610
|
+
`[E5036] Plugin "${plugin}" is listed at .releaseconfig.json but "${packageName}" is not installed as devDependency. Please add.`,
|
|
516
611
|
);
|
|
517
612
|
}
|
|
518
613
|
}
|
|
614
|
+
|
|
615
|
+
// Check all installed plugin devDependencies are listed in .releaseconfig.json
|
|
616
|
+
for (const pluginName in pluginToPackage) {
|
|
617
|
+
const packageName = pluginToPackage[pluginName];
|
|
618
|
+
if (context.packageJson.devDependencies[packageName]) {
|
|
619
|
+
if (!plugins.includes(pluginName)) {
|
|
620
|
+
if (requiredPlugins.includes(pluginName)) {
|
|
621
|
+
context.errors.push(
|
|
622
|
+
`[E5027] Plugin "${pluginName}" missing at .releaseconfig.json. Please add.`,
|
|
623
|
+
);
|
|
624
|
+
} else if (suggestedPlugins.includes(pluginName)) {
|
|
625
|
+
context.warnings.push(
|
|
626
|
+
`[W5029] Plugin "${pluginName}" missing at .releaseconfig.json. Please add.`,
|
|
627
|
+
);
|
|
628
|
+
} else {
|
|
629
|
+
context.warnings.push(
|
|
630
|
+
`[W5037] Plugin "${pluginName}" is installed but not listed at .releaseconfig.json. Please add or remove the devDependency.`,
|
|
631
|
+
);
|
|
632
|
+
}
|
|
633
|
+
}
|
|
634
|
+
}
|
|
635
|
+
}
|
|
519
636
|
} catch (e) {
|
|
520
637
|
context.errors.push(`[E5030] .releaseconfig.json is no valid json file - ${e}.`);
|
|
521
638
|
}
|
|
@@ -782,8 +899,8 @@ async function checkCode(context) {
|
|
|
782
899
|
}
|
|
783
900
|
}
|
|
784
901
|
|
|
785
|
-
// first free
|
|
786
|
-
//
|
|
902
|
+
// first free 5039
|
|
903
|
+
// 5500 - xxx reserved for jsonConfig module
|
|
787
904
|
|
|
788
905
|
return context;
|
|
789
906
|
}
|
|
@@ -826,13 +943,17 @@ exports.checkCode = checkCode;
|
|
|
826
943
|
// [5024] "@alcalzone/release-script" requires plugin "@alcalzone/release-script-plugin-iobroker". Please add.
|
|
827
944
|
// [5025] "@alcalzone/release-script" requires plugin "@alcalzone/release-script-plugin-license". Please add.
|
|
828
945
|
// [5026] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
|
|
829
|
-
// [5027] Plugin "
|
|
830
|
-
// [5028]
|
|
831
|
-
// [5029] Plugin "
|
|
946
|
+
// [5027] Plugin "${pluginName}" missing at .releaseconfig.json. Please add.
|
|
947
|
+
// [5028] -- merged into [5027]
|
|
948
|
+
// [5029] Plugin "${pluginName}" missing at .releaseconfig.json. Please add.
|
|
832
949
|
// [5030] .releaseconfig.json is no valid json file - ${e}.
|
|
950
|
+
// [5036] Plugin "${plugin}" is listed at .releaseconfig.json but "${packageName}" is not installed as devDependency. Please add.
|
|
951
|
+
// [5037] Plugin "${pluginName}" is installed but not listed at .releaseconfig.json. Please add or remove the devDependency.
|
|
833
952
|
// [5031] "gulpfile.js" found in repo with @iobroker/adapter-dev. Check if gulp is still needed.
|
|
834
953
|
// [5032] "lib/tools.js" found in repo but not used anywhere. Consider removing this outdated file.
|
|
835
954
|
// [5033] method "${method}()" is deprecated and will be removed with future js-controller version. Please use "set/deleteObject()" instead.
|
|
836
955
|
// [5034] Files with conflicting extensions found in directory "${dir}": ${filePaths} - Only one JavaScript file extension (.js, .cjs, or .mjs) should be used per file name.
|
|
956
|
+
// [5035] Cannot parse YAML file "${fileName}": ${e.message}
|
|
957
|
+
// [5038] Conflicting JSON files in directory "${dir}": Both ${baseName}.json and ${baseName}.json5 versions of same file exist. Please remove one.
|
|
837
958
|
|
|
838
959
|
// [5500 - ] see M5500_jsonConfig.js
|
package/lib/M5500__JsonConfig.js
CHANGED
|
@@ -192,7 +192,7 @@ function chk_responsive(context, path, jsonConfig, component, opts) {
|
|
|
192
192
|
if (jsonConfig.sm && jsonConfig.sm > ii) {
|
|
193
193
|
handleResponsiveError(
|
|
194
194
|
context,
|
|
195
|
-
`[E5509] "sm" value (${jsonConfig.sm}) for ${component} greater then value for smaller displays`,
|
|
195
|
+
`[E5509] "sm" value (${jsonConfig.sm}) for ${component} greater then value for smaller displays at ${path}`,
|
|
196
196
|
);
|
|
197
197
|
} else {
|
|
198
198
|
ii = jsonConfig.sm;
|
|
@@ -200,7 +200,7 @@ function chk_responsive(context, path, jsonConfig, component, opts) {
|
|
|
200
200
|
if (jsonConfig.md && jsonConfig.md > ii) {
|
|
201
201
|
handleResponsiveError(
|
|
202
202
|
context,
|
|
203
|
-
`[E5509] "md" value (${jsonConfig.md}) for ${component} greater then value for smaller displays`,
|
|
203
|
+
`[E5509] "md" value (${jsonConfig.md}) for ${component} greater then value for smaller displays at ${path}`,
|
|
204
204
|
);
|
|
205
205
|
} else {
|
|
206
206
|
ii = jsonConfig.md;
|
|
@@ -208,7 +208,7 @@ function chk_responsive(context, path, jsonConfig, component, opts) {
|
|
|
208
208
|
if (jsonConfig.lg && jsonConfig.lg > ii) {
|
|
209
209
|
handleResponsiveError(
|
|
210
210
|
context,
|
|
211
|
-
`[E5509] "lg" value (${jsonConfig.lg}) for ${component} greater then value for smaller displays`,
|
|
211
|
+
`[E5509] "lg" value (${jsonConfig.lg}) for ${component} greater then value for smaller displays at ${path}`,
|
|
212
212
|
);
|
|
213
213
|
} else {
|
|
214
214
|
ii = jsonConfig.lg;
|
|
@@ -216,7 +216,7 @@ function chk_responsive(context, path, jsonConfig, component, opts) {
|
|
|
216
216
|
if (jsonConfig.xl && jsonConfig.xl > ii) {
|
|
217
217
|
handleResponsiveError(
|
|
218
218
|
context,
|
|
219
|
-
`[E5509] "xl" value (${jsonConfig.xl}) for ${component} greater then value for smaller displays`,
|
|
219
|
+
`[E5509] "xl" value (${jsonConfig.xl}) for ${component} greater then value for smaller displays at ${path}`,
|
|
220
220
|
);
|
|
221
221
|
}
|
|
222
222
|
}
|
package/lib/M8000_Github.js
CHANGED
|
@@ -112,6 +112,10 @@ async function checkGithubRepo(context) {
|
|
|
112
112
|
context.warnings.push(
|
|
113
113
|
`[W8004] Please process ${type} [[#${issue.number}] "${issue.title}"](${context.githubUrlOriginal}/issues/${issue.number})`,
|
|
114
114
|
);
|
|
115
|
+
} else if (issue.title.startsWith('[iobroker-bot]')) {
|
|
116
|
+
context.warnings.push(
|
|
117
|
+
`[W8004] Please process ${type} [[#${issue.number}] "${issue.title}"](${context.githubUrlOriginal}/issues/${issue.number})`,
|
|
118
|
+
);
|
|
115
119
|
}
|
|
116
120
|
}
|
|
117
121
|
|
package/package.json
CHANGED
|
@@ -1,19 +1,20 @@
|
|
|
1
1
|
{
|
|
2
|
-
"version": "5.0
|
|
2
|
+
"version": "5.1.0",
|
|
3
3
|
"name": "@iobroker/repochecker",
|
|
4
4
|
"dependencies": {
|
|
5
5
|
"ajv": "^8.17.1",
|
|
6
|
-
"axios": "^1.
|
|
6
|
+
"axios": "^1.13.1",
|
|
7
7
|
"compare-versions": "^6.1.1",
|
|
8
8
|
"image-size": "^1.2.0",
|
|
9
|
+
"js-yaml": "^4.1.1",
|
|
9
10
|
"json5": "^2.2.3",
|
|
10
|
-
"semver": "^7.7.
|
|
11
|
+
"semver": "^7.7.3"
|
|
11
12
|
},
|
|
12
13
|
"devDependencies": {
|
|
13
|
-
"@alcalzone/release-script": "^
|
|
14
|
+
"@alcalzone/release-script": "^5.0.0",
|
|
14
15
|
"@iobroker/eslint-config": "^2.2.0",
|
|
15
16
|
"@tsconfig/node20": "^20.1.6",
|
|
16
|
-
"@types/node": "^24.
|
|
17
|
+
"@types/node": "^24.9.2",
|
|
17
18
|
"@types/semver": "^7.7.1"
|
|
18
19
|
},
|
|
19
20
|
"publishConfig": {
|