@iobroker/repochecker 3.3.0 → 3.3.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -33,6 +33,10 @@ npx @iobroker/repochecker https://github.com/ioBroker/ioBroker.javascript --loca
33
33
  -->
34
34
 
35
35
  ## Changelog
36
+ ### 3.3.1 (2025-01-19)
37
+
38
+ - (mcm1957) Report malformed semver specifications has been fixed.
39
+
36
40
  ### 3.3.0 (2025-01-19)
37
41
 
38
42
  - (mcm1957) "common.singleton" causes a warning now for non-onlyWWW Adapters.
@@ -453,20 +453,26 @@ async function checkPackageJson(context) {
453
453
  '@iobroker/testing',
454
454
  ];
455
455
  for (const dependency in context.packageJson.dependencies) {
456
- if (!context.packageJson.dependencies[dependency].match(/^(\^|~|>|>=|<|<=)?\d+\.\d+\.\d+$/gm)) {
456
+ const dependencyVersion = context.packageJson.dependencies[dependency];
457
+ if (dependencyVersion.toLowerCase().includes('github.com')) {
458
+ context.warnings.push(
459
+ `[W043] dependency should not require a github version. Please change "${dependency}:${dependencyVersion}"`,
460
+ );
461
+ } else if (dependencyVersion === '*') {
462
+ context.warnings.push(
463
+ `[W056] Wildcard dependencies should be avoided "${dependency}":"${dependencyVersion}". Use "~1.2.3" or "^1.2.3" syntax at package.json.`,
464
+ );
465
+ } else if (!common.validateSemver(dependencyVersion)) {
457
466
  context.errors.push(
458
- `[E054] malformed dependency detected "${dependency}":${context.packageJson.dependencies[dependency]}". Please fix at package.json.`,
467
+ `[E054] malformed dependency detected "${dependency}":"${dependencyVersion}". Please fix at package.json.`,
459
468
  );
460
469
  } else if (
461
470
  !context.packageJson.dependencies[dependency].startsWith('^') &&
462
471
  !context.packageJson.dependencies[dependency].startsWith('~') &&
463
- !context.packageJson.dependencies[dependency].startsWith('>')
472
+ !context.packageJson.dependencies[dependency].startsWith('>') &&
473
+ !context.packageJson.dependencies[dependency].startsWith('<')
464
474
  ) {
465
- if (context.packageJson.dependencies[dependency].toLowerCase().includes('github.com')) {
466
- context.warnings.push(
467
- `[W043] dependency should not require a github version. Please change "${dependency}:${context.packageJson.dependencies[dependency]}"`,
468
- );
469
- } else if (enforcedDependencies.includes(dependency)) {
475
+ if (enforcedDependencies.includes(dependency)) {
470
476
  context.errors.push(
471
477
  `[E044] dependency must not require a specific version. Use "~1.2.3" or "^1.2.3" syntax. Please update "${dependency}:${context.packageJson.dependencies[dependency]}"`,
472
478
  );
@@ -479,22 +485,28 @@ async function checkPackageJson(context) {
479
485
  }
480
486
 
481
487
  for (const dependency in context.packageJson.devDependencies) {
482
- if (!context.packageJson.devDependencies[dependency].match(/^(\^|~|>|>=|<|<=)?\d+\.\d+\.\d+$/gm)) {
488
+ const dependencyVersion = context.packageJson.devDependencies[dependency];
489
+ if (dependencyVersion.toLowerCase().includes('github.com')) {
490
+ context.warnings.push(
491
+ `[W045] devDependency should not require github versions. Please change "${dependency}":"${dependencyVersion}"`,
492
+ );
493
+ } else if (dependencyVersion === '*') {
494
+ context.warnings.push(
495
+ `[W057] Wildcard devDependencies should be avoided "${dependency}":"${dependencyVersion}". Use "~1.2.3" or "^1.2.3" syntax at package.json.`,
496
+ );
497
+ } else if (!common.validateSemver(dependencyVersion)) {
483
498
  context.errors.push(
484
- `[E055] malformed dependency detected "${dependency}":${context.packageJson.devDependencies[dependency]}". Please fix at package.json.`,
499
+ `[E055] malformed dependency detected "${dependency}":"${dependencyVersion}". Please fix at package.json.`,
485
500
  );
486
501
  } else if (
487
502
  !context.packageJson.devDependencies[dependency].startsWith('^') &&
488
503
  !context.packageJson.devDependencies[dependency].startsWith('~') &&
489
- !context.packageJson.devDependencies[dependency].startsWith('>')
504
+ !context.packageJson.devDependencies[dependency].startsWith('>') &&
505
+ !context.packageJson.devDependencies[dependency].startsWith('<')
490
506
  ) {
491
- if (context.packageJson.devDependencies[dependency].toLowerCase().includes('github.com')) {
492
- context.warnings.push(
493
- `[W045] devDependency should not require github versions. Please change "${dependency}:${context.packageJson.devDependencies[dependency]}"`,
494
- );
495
- } else if (enforcedDependencies.includes(dependency)) {
507
+ if (enforcedDependencies.includes(dependency)) {
496
508
  context.errors.push(
497
- `[E046] devDependency must not require a specific version. Use "~1.2.3" or "^1.2.3" syntax. Please update "${dependency}:${context.packageJson.devDependencies[dependency]}"`,
509
+ `[E046] devDependency must not require a specific version. Use "~1.2.3" or "^1.2.3" syntax. Please update "${dependency}:${dependencyVersion}"`,
498
510
  );
499
511
  } else {
500
512
  context.warnings.push(
@@ -645,3 +657,6 @@ exports.checkPackageJson = checkPackageJson;
645
657
  // [053] ${blacklistedDevDependenciesPackageJson[blacklist].msg}
646
658
  // [054] malformed dependency detected "${dependency}":${context.packageJson.dependencies[dependency]}". Please fix at package.json.`
647
659
  // [055] malformed dependency detected "${dependency}":${context.packageJson.devDependencies[dependency]}". Please fix at package.json.`
660
+ // [056] Wildcard dependencies should be avoided "${dependency}":"${dependencyVersion}". Use "~1.2.3" or "^1.2.3" syntax at package.json.`,
661
+ // [057] Wildcard devDependencies should be avoided "${dependency}":"${dependencyVersion}". Use "~1.2.3" or "^1.2.3" syntax at package.json.`,
662
+
@@ -16,7 +16,7 @@ const issuesToWatch = [
16
16
  ];
17
17
 
18
18
  // disable axios caching
19
- axios.defaults.headers = {
19
+ axios.defaults.headers.common = {
20
20
  'Cache-Control': 'no-cache',
21
21
  Pragma: 'no-cache',
22
22
  Expires: '0',
package/lib/common.js CHANGED
@@ -6,9 +6,10 @@
6
6
  const axios = require('axios');
7
7
  const fs = require('node:fs/promises');
8
8
  const compareVersions = require('compare-versions');
9
+ const semverValid = require('semver/functions/valid');
9
10
 
10
11
  // disable axios caching
11
- axios.defaults.headers = {
12
+ axios.defaults.headers.common = {
12
13
  'Cache-Control': 'no-cache',
13
14
  Pragma: 'no-cache',
14
15
  Expires: '0',
@@ -61,6 +62,7 @@ async function downloadFile(githubUrl, path, binary, noError) {
61
62
  return file;
62
63
  }
63
64
  }
65
+
64
66
  function getDependencyArray(deps) {
65
67
  return deps
66
68
  .map(dep => (typeof dep === 'object' ? Object.keys(dep) : [dep]))
@@ -116,6 +118,42 @@ function maxVersion(v1, v2) {
116
118
  return v2;
117
119
  }
118
120
 
121
+ /*
122
+ analyzes a semver string
123
+ */
124
+ function parseSemver(p_semver) {
125
+ // console.log(`parseSemver(${p_semver})`);
126
+ const ret = {
127
+ valid: false,
128
+ rangeOp: '',
129
+ trimmed: false,
130
+ version: '',
131
+ };
132
+
133
+ const semver = p_semver.trim();
134
+ ret.trimmed = semver !== p_semver;
135
+ ret.version = semver;
136
+ ret.uncompressed = false;
137
+
138
+ const m = semver.match(/^(\^|~|>|>=|<|<=)?(\s*)(.*)$/);
139
+ if (m) {
140
+ // console.log(m);
141
+ ret.rangeOp = m[1];
142
+ ret.uncompressed = m[2] !== '';
143
+ ret.version = m[3];
144
+ }
145
+ ret.version = semverValid(ret.version) || '';
146
+ ret.valid = semverValid(ret.version) !== undefined;
147
+ // console.log(JSON.stringify(ret));
148
+ return ret;
149
+ }
150
+
151
+ function validateSemver(p_semver) {
152
+ //console.log(`validateSemver(${p_semver})`);
153
+ const ret = parseSemver(p_semver);
154
+ return ret.valid && !ret.uncompressed;
155
+ }
156
+
119
157
  exports.setDebug = setDebug;
120
158
  exports.debug = debug;
121
159
  exports.setLocal = setLocal;
@@ -126,3 +164,5 @@ exports.downloadFile = downloadFile;
126
164
  exports.getDependencyArray = getDependencyArray;
127
165
  exports.getDependencies = getDependencies;
128
166
  exports.maxVersion = maxVersion;
167
+ exports.parseSemver = parseSemver;
168
+ exports.validateSemver = validateSemver;
package/package.json CHANGED
@@ -1,18 +1,20 @@
1
1
  {
2
- "version": "3.3.0",
2
+ "version": "3.3.1",
3
3
  "name": "@iobroker/repochecker",
4
4
  "devDependencies": {
5
5
  "@alcalzone/release-script": "^3.8.0",
6
6
  "@iobroker/eslint-config": "^1.0.0",
7
+ "@tsconfig/node20": "^20.1.4",
7
8
  "@types/node": "^20.16.5",
8
- "@tsconfig/node20": "^20.1.4"
9
+ "@types/semver": "^7.5.8"
9
10
  },
10
11
  "dependencies": {
11
12
  "axios": "^1.7.9",
12
13
  "compare-versions": "^6.1.1",
13
14
  "image-size": "^1.2.0",
14
- "unzipper": "^0.12.3",
15
- "json5": "^2.2.3"
15
+ "json5": "^2.2.3",
16
+ "semver": "^7.6.3",
17
+ "unzipper": "^0.12.3"
16
18
  },
17
19
  "publishConfig": {
18
20
  "access": "public"