@iobroker/js-controller-cli 8.0.0-alpha.1-20260921-e5941ca8a → 8.0.0-alpha.3-20260924-a3df0c4fe

package/build/cjs/lib/setup/setupInstall.d.ts

@@ -204,6 +204,21 @@ export declare class Install {
      * @param adapter adapter name
      */
     deleteAdapter(adapter: string): Promise<EXIT_CODES>;
+    /**
+     * Remove the virtual environment a Python adapter leaves behind in the data directory
+     *
+     * Host-local state like `node_modules` - rebuildable, but easily a few hundred megabytes - so it goes when
+     * the adapter goes. Deliberately not part of the npm uninstall: that one starts by resolving the adapter's
+     * `io-package.json`, so for a half-removed installation, where the package directory is already gone, it
+     * throws before ever getting here - and that is precisely the case which leaves the environment behind with
+     * nothing pointing at it.
+     *
+     * Removed without looking at `common.platform` for the same reason: the directory only exists for Python
+     * adapters, and the `io-package.json` that would say so may no longer be there.
+     *
+     * @param adapter adapter name, e.g. "pyexample"
+     */
+    private _removePythonEnvironment;
     /**
      * Deletes given instance of an adapter
      *
@@ -211,6 +226,21 @@ export declare class Install {
      * @param instance e.g. 1, if undefined deletes all instances
      */
     deleteInstance(adapter: string, instance?: number): Promise<void | EXIT_CODES.CANNOT_DELETE_DEPENDENCY>;
+    /**
+     * Free all exclusive resources (serial ports, TCP/UDP ports, ...) the given instance(s) had registered.
+     *
+     * This is needed because an instance can be deleted via the CLI while a js-controller is not running: it
+     * cannot notice that the instance object disappeared, so its `system.host.<host>.usedResources.<type>`
+     * states would keep listing the resources of an instance that no longer exists.
+     *
+     * Hosts that are running are deliberately skipped. Such a host cleans its own registry up when it sees the
+     * instance object being deleted, and it holds the registry in memory: it rewrites the state from that copy
+     * on its next change, which would silently undo a write made here.
+     *
+     * @param adapter adapter name, e.g. "mqtt"
+     * @param instance instance number; if undefined, all instances of the adapter are freed
+     */
+    private _freeUsedResources;
     /**
      * Remove all node modules that has been installed by this instance
      *

package/build/cjs/lib/setup/setupInstall.js

@@ -1126,6 +1126,7 @@ class Install {
         }
         await this._removeCustomFromObjects([adapter]);
         await _uninstallNpm();
+        await this._removePythonEnvironment(adapter);
       } else {
         const dependentInstance = await this._hasDependentInstances(adapter);
         if (dependentInstance) {
@@ -1143,16 +1144,43 @@ class Install {
         await this._deleteAdapterFiles(adapter, metaFilesToDelete);
         await this._deleteAdapterObjects(knownObjectIDs);
         await this._deleteAdapterStates(knownStateIDs);
+        await this._freeUsedResources(adapter);
         if (this.params.custom) {
           await this._removeCustomFromObjects([...instances, adapter]);
         }
         await _uninstallNpm();
+        await this._removePythonEnvironment(adapter);
       }
     } catch (e) {
       console.error(`There was an error uninstalling ${adapter} on ${hostname}: ${e.message}`);
     }
     return resultCode;
   }
+  /**
+   * Remove the virtual environment a Python adapter leaves behind in the data directory
+   *
+   * Host-local state like `node_modules` - rebuildable, but easily a few hundred megabytes - so it goes when
+   * the adapter goes. Deliberately not part of the npm uninstall: that one starts by resolving the adapter's
+   * `io-package.json`, so for a half-removed installation, where the package directory is already gone, it
+   * throws before ever getting here - and that is precisely the case which leaves the environment behind with
+   * nothing pointing at it.
+   *
+   * Removed without looking at `common.platform` for the same reason: the directory only exists for Python
+   * adapters, and the `io-package.json` that would say so may no longer be there.
+   *
+   * @param adapter adapter name, e.g. "pyexample"
+   */
+  async _removePythonEnvironment(adapter) {
+    try {
+      const pythonEnvDir = import_js_controller_common.tools.getPythonEnvDir(adapter);
+      if (await import_fs_extra.default.pathExists(pythonEnvDir)) {
+        await import_fs_extra.default.remove(pythonEnvDir);
+        console.log(`host.${hostname} Python environment "${pythonEnvDir}" deleted`);
+      }
+    } catch (e) {
+      console.error(`Cannot delete the Python environment of ${adapter}: ${e.message}`);
+    }
+  }
   /**
    * Deletes given instance of an adapter
    *
@@ -1176,10 +1204,79 @@ class Install {
     await this._enumerateAdapterDocs(knownObjectIDs, adapter, instance);
     await this._deleteAdapterObjects(knownObjectIDs);
     await this._deleteAdapterStates(knownStateIDs);
+    await this._freeUsedResources(adapter, instance);
     if (this.params.custom) {
       await this._removeCustomFromObjects([`${adapter}.${instance}`]);
     }
   }
+  /**
+   * Free all exclusive resources (serial ports, TCP/UDP ports, ...) the given instance(s) had registered.
+   *
+   * This is needed because an instance can be deleted via the CLI while a js-controller is not running: it
+   * cannot notice that the instance object disappeared, so its `system.host.<host>.usedResources.<type>`
+   * states would keep listing the resources of an instance that no longer exists.
+   *
+   * Hosts that are running are deliberately skipped. Such a host cleans its own registry up when it sees the
+   * instance object being deleted, and it holds the registry in memory: it rewrites the state from that copy
+   * on its next change, which would silently undo a write made here.
+   *
+   * @param adapter adapter name, e.g. "mqtt"
+   * @param instance instance number; if undefined, all instances of the adapter are freed
+   */
+  async _freeUsedResources(adapter, instance) {
+    const matches = /* @__PURE__ */ __name((namespace) => instance !== void 0 ? namespace === `${adapter}.${instance}` : namespace.startsWith(`${adapter}.`), "matches");
+    let keys;
+    try {
+      keys = await this.states.getKeys("system.host.*.usedResources.*");
+    } catch (e) {
+      console.warn(`Cannot read the used resources registry: ${e.message}`);
+      return;
+    }
+    if (!keys?.length) {
+      return;
+    }
+    const hostPrefix = "system.host.";
+    const registryMarker = ".usedResources.";
+    const hostIsRunning = /* @__PURE__ */ new Map();
+    for (const id of keys) {
+      const markerIndex = id.lastIndexOf(registryMarker);
+      if (!id.startsWith(hostPrefix) || markerIndex <= hostPrefix.length) {
+        continue;
+      }
+      const host = id.substring(hostPrefix.length, markerIndex);
+      let isRunning = hostIsRunning.get(host);
+      if (isRunning === void 0) {
+        try {
+          const aliveState = await this.states.getState(`${hostPrefix}${host}.alive`);
+          isRunning = aliveState?.val === true;
+        } catch (e) {
+          console.warn(`Cannot check whether host "${host}" is running: ${e.message}`);
+          isRunning = true;
+        }
+        hostIsRunning.set(host, isRunning);
+      }
+      if (isRunning) {
+        continue;
+      }
+      try {
+        const state = await this.states.getState(id);
+        if (!state || typeof state.val !== "string" || !state.val) {
+          continue;
+        }
+        const parsed = JSON.parse(state.val);
+        if (!Array.isArray(parsed)) {
+          continue;
+        }
+        const original = parsed;
+        const filtered = original.filter((entry) => typeof entry?.instance !== "string" || !matches(entry.instance));
+        if (filtered.length !== original.length) {
+          await this.states.setStateAsync(id, { val: JSON.stringify(filtered), ack: true });
+        }
+      } catch (e) {
+        console.warn(`Cannot free the used resources in "${id}": ${e.message}`);
+      }
+    }
+  }
   /**
    * Remove all node modules that has been installed by this instance
    *