@invisibleloop/pulse 0.20.0 → 0.20.2

package/src/server/index.js

@@ -593,9 +593,13 @@ export async function createServer(entries, options = {}) {
 
   const healthPath = healthCheck === true ? '/healthz' : (healthCheck || null)
 
+  // Store definition — `let` so the dev server can hot-swap it via updateStore()
+  // when pulse.store.js changes, the same way updateSpecs() swaps page specs.
+  let storeDef = store
+
   // Validate store at startup — fail fast before the server accepts connections
-  if (store) {
-    const { valid, errors } = validateStore(store)
+  if (storeDef) {
+    const { valid, errors } = validateStore(storeDef)
     if (!valid) {
       throw new Error(`Invalid Pulse store:\n${errors.map(e => `  — ${e}`).join('\n')}`)
     }
@@ -897,8 +901,8 @@ export async function createServer(entries, options = {}) {
       // Global store — resolve once per request, attach to ctx before guard/server fetchers.
       // Use global fetcherTimeout for store fetchers; spec-level override applied below.
       ctx.fetcherTimeout = fetcherTimeout ?? null
-      if (store) {
-        ctx.store = await resolveStoreState(store, ctx)
+      if (storeDef) {
+        ctx.store = await resolveStoreState(storeDef, ctx)
       }
 
       const spec = resolveSpec(match.spec, hydrateMap)
@@ -1020,11 +1024,11 @@ export async function createServer(entries, options = {}) {
       // string path — they are small, must carry an explicit status, and POST
       // bodies are already consumed.
       if (responseStatus !== 200 || req.method === 'POST') {
-        await handleStringResponse(spec, ctx, req, res, extraBody, dev, canonicalBase, nonce, runtimeBundle, defaultCache, store, csp, faviconPath, responseStatus, livePath)
+        await handleStringResponse(spec, ctx, req, res, extraBody, dev, canonicalBase, nonce, runtimeBundle, defaultCache, storeDef, csp, faviconPath, responseStatus, livePath)
       } else if (stream) {
-        await handleStreamResponse(spec, ctx, req, res, extraBody, dev, canonicalBase, nonce, runtimeBundle, defaultCache, store, csp, faviconPath, livePath)
+        await handleStreamResponse(spec, ctx, req, res, extraBody, dev, canonicalBase, nonce, runtimeBundle, defaultCache, storeDef, csp, faviconPath, livePath)
       } else {
-        await handleStringResponse(spec, ctx, req, res, extraBody, dev, canonicalBase, nonce, runtimeBundle, defaultCache, store, csp, faviconPath, 200, livePath)
+        await handleStringResponse(spec, ctx, req, res, extraBody, dev, canonicalBase, nonce, runtimeBundle, defaultCache, storeDef, csp, faviconPath, 200, livePath)
       }
 
     } catch (err) {
@@ -1119,6 +1123,14 @@ export async function createServer(entries, options = {}) {
       notFoundSpec = newSpecs.find(s => s.route === '*') || null
       router       = buildRouter(newSpecs.filter(s => s.route !== '*'))
       allSpecs     = newSpecs
+    },
+    /** Swap the store definition at runtime (dev hot reload of pulse.store.js). */
+    updateStore(newStoreDef) {
+      if (newStoreDef) {
+        const { valid, errors } = validateStore(newStoreDef)
+        if (!valid) throw new Error(`Invalid Pulse store:\n${errors.map(e => `  — ${e}`).join('\n')}`)
+      }
+      storeDef = newStoreDef || null
     }
   }
 }

package/src/server/server.test.js

@@ -1294,6 +1294,30 @@ await test('without a "*" spec the default 404 still works', async () => {
   })
 })
 
+await test('custom 404 works in production mode (manifest with runtime bundle present)', async () => {
+  // Regression: in production the manifest sets runtimeBundle, which made
+  // wrapDocument call isBundle(spec.hydrate) — undefined for non-hydrated pages
+  // like a typical 404 spec → TypeError → 500 instead of the custom 404.
+  // Dev never hit it because runtimeBundle is '' there.
+  const prodManifest = { _runtime: '/dist/runtime-abcd1234.js' }
+  await withServer([helloSpec, notFoundPageSpec], { stream: true, manifest: prodManifest }, async (port) => {
+    const { status, body } = await get(port, '/nope')
+    assert(status === 404, `Expected 404 in production mode, got ${status}`)
+    assert(body.includes('Custom not found'), `Expected custom 404 content: ${body.slice(0, 200)}`)
+  })
+})
+
+await test('non-hydrated pages render on the buffered path in production mode', async () => {
+  // Same root cause, different surface: stream: false + production manifest
+  // crashed EVERY zero-JS page, not just the 404.
+  const prodManifest = { _runtime: '/dist/runtime-abcd1234.js' }
+  await withServer([helloSpec], { stream: false, manifest: prodManifest }, async (port) => {
+    const { status, body } = await get(port, '/hello')
+    assert(status === 200, `Expected 200, got ${status}`)
+    assert(body.includes('Hello world'), 'Expected page content')
+  })
+})
+
 // ---------------------------------------------------------------------------
 
 console.log('\nServer-side forms (spec.submit) + CSRF\n')

package/types/server.d.ts

@@ -175,6 +175,9 @@ export interface ServerInstance {
   /** Swap the spec list at runtime (used by the dev server for hot reload). */
   updateSpecs(specs: PulseSpec[]): void
 
+  /** Swap the store definition at runtime (dev hot reload of pulse.store.js). Validates; throws on a bad definition. */
+  updateStore(storeDef: PulseStoreDefinition | null): void
+
   /**
    * Broadcast a store patch to every connected live client (requires the
    * `live` option). Pages subscribed via spec.store merge the patch and