@intuned/runtime-dev 1.3.18-dev.3 → 1.3.18-dev.4

package/dist/commands/intuned-cli/helpers/__test__/browser.test.js

@@ -4,6 +4,7 @@ var _vitest = require("vitest");
 var _browser = require("../browser");
 var _launchBrowser = require("../../../../common/launchBrowser");
 var _errors = require("../errors");
+function _interopRequireWildcard(e, t) { if ("function" == typeof WeakMap) var r = new WeakMap(), n = new WeakMap(); return (_interopRequireWildcard = function (e, t) { if (!t && e && e.__esModule) return e; var o, i, f = { __proto__: null, default: e }; if (null === e || "object" != typeof e && "function" != typeof e) return f; if (o = t ? n : r) { if (o.has(e)) return o.get(e); o.set(e, f); } for (const t in e) "default" !== t && {}.hasOwnProperty.call(e, t) && ((i = (o = Object.defineProperty) && Object.getOwnPropertyDescriptor(e, t)) && (i.get || i.set) ? o(f, t, i) : f[t] = e[t]); return f; })(e, t); }
 function getTerminal() {
   return new Proxy(() => ({}), {
     get: () => getTerminal(),
@@ -121,6 +122,42 @@ _vitest.vi.mock("../../../../common/browserTabs", () => {
         cdpAddress: "http://localhost:1234"
       }));
     });
+    (0, _vitest.it)("launches a browser with ignoreHttpErrors set to true when configured", async () => {
+      const {
+        getIgnoreHttpErrorsFromConfig
+      } = await Promise.resolve().then(() => _interopRequireWildcard(require("../../../../common/launchBrowser")));
+      _vitest.vi.mocked(getIgnoreHttpErrorsFromConfig).mockResolvedValueOnce(true);
+      const options = await (0, _browser.getCLIRunOptions)({
+        keepBrowserOpen: true,
+        headless: false
+      });
+      (0, _vitest.expect)(_launchBrowser.launchChromium).toHaveBeenCalledWith({
+        headless: false,
+        cdpPort: 1234,
+        ignoreHttpErrors: true
+      });
+      (0, _vitest.expect)(options).toEqual(_vitest.expect.objectContaining({
+        environment: "cdp",
+        cdpAddress: "http://localhost:1234"
+      }));
+    });
+    (0, _vitest.it)("passes CLI ignoreHttpErrors option to getIgnoreHttpErrorsFromConfig", async () => {
+      const {
+        getIgnoreHttpErrorsFromConfig
+      } = await Promise.resolve().then(() => _interopRequireWildcard(require("../../../../common/launchBrowser")));
+      _vitest.vi.mocked(getIgnoreHttpErrorsFromConfig).mockResolvedValueOnce(true);
+      await (0, _browser.getCLIRunOptions)({
+        keepBrowserOpen: true,
+        headless: false,
+        ignoreHttpErrors: true
+      });
+      (0, _vitest.expect)(getIgnoreHttpErrorsFromConfig).toHaveBeenCalledWith(true);
+      (0, _vitest.expect)(_launchBrowser.launchChromium).toHaveBeenCalledWith({
+        headless: false,
+        cdpPort: 1234,
+        ignoreHttpErrors: true
+      });
+    });
     (0, _vitest.it)("keeps context open until new context", async () => {
       await (0, _browser.getCLIRunOptions)({
         keepBrowserOpen: true,

package/dist/common/launchBrowser.d.ts

@@ -7,7 +7,7 @@ export interface Proxy {
 }
 /**
  * Get ignore_http_errors setting from CLI option, Intuned.json, or environment variable.
- * Priority: cliOption > environment variable > Intuned.json > false
+ * Priority: cliOption > Intuned.json > environment variable > false
  */
 export declare function getIgnoreHttpErrorsFromConfig(cliOption?: boolean): Promise<boolean>;
 export type LaunchBrowserResult = {

package/dist/common/launchBrowser.js

@@ -45,16 +45,16 @@ async function getIgnoreHttpErrorsFromConfig(cliOption) {
   if (cliOption !== undefined) {
     return cliOption;
   }
-  const envValue = process.env.IGNORE_HTTP_ERRORS;
-  if (envValue !== undefined) {
-    return envValue.toLowerCase() === "true" || envValue === "1" || envValue.toLowerCase() === "yes";
-  }
   try {
     const intunedJsonResult = await (0, _intunedJson.loadIntunedJson)();
     if (intunedJsonResult.isOk() && intunedJsonResult.value.ignoreHttpErrors !== undefined) {
       return intunedJsonResult.value.ignoreHttpErrors;
     }
   } catch (error) {}
+  const envValue = process.env.IGNORE_HTTP_ERRORS;
+  if (envValue !== undefined) {
+    return envValue.toLowerCase() === "true" || envValue === "1" || envValue.toLowerCase() === "yes";
+  }
   return false;
 }
 async function launchChromium(options) {
@@ -89,22 +89,22 @@ async function launchChromium(options) {
       context
     };
   }
-  let {
+  const {
     headless,
     appModeInitialUrl,
     cdpPort,
     proxy,
     downloadsPath,
-    ignoreHttpErrors
+    ignoreHttpErrors: ignoreHttpErrorsParam
   } = options;
   let {
     executablePath
   } = options;
   const envIgnoreHttpErrors = (0, _env.getIgnoreHttpErrors)();
+  let ignoreHttpErrors = ignoreHttpErrorsParam;
   if (envIgnoreHttpErrors === true && ignoreHttpErrors === undefined) {
     ignoreHttpErrors = true;
   }
-  console.log(`[ignore_http_errors] launchChromium: param=${options.ignoreHttpErrors}, env=${envIgnoreHttpErrors}, final=${ignoreHttpErrors}`);
   const defaultArgsToIgnore = ["--disable-extensions", "--disable-component-extensions-with-background-pages", "--disable-background-networking", "--disable-backgrounding-occluded-windows", "--disable-background-timer-throttling"];
   const extraArgs = [];
   const userDataDir = await createUserDirWithPreferences();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@intuned/runtime-dev",
-  "version": "1.3.18-dev.3",
+  "version": "1.3.18-dev.4",
   "description": "Intuned runtime",
   "packageManager": "yarn@4.12.0",
   "main": "./dist/index.js",
@@ -128,7 +128,7 @@
     "babel-preset-minify": "^0.5.2",
     "copyfiles": "^2.4.1",
     "dts-bundle-generator": "^8.0.1",
-    "eslint": "7.32.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.3.0",
     "eslint-plugin-deprecation": "^1.3.3",
     "eslint-plugin-prettier": "^4.2.1",