@internetarchive/ia-book-actions 1.4.6-alpha4 → 1.4.6

package/package.json

@@ -7,7 +7,7 @@
   },
   "author": "Internet Archive",
   "license": "AGPL-3.0-only",
-  "version": "1.4.6-alpha4",
+  "version": "1.4.6",
   "main": "index.js",
   "module": "index.js",
   "publishConfig": {

package/src/ia-book-actions.js

@@ -129,6 +129,16 @@ export default class IABookActions extends LitElement {
      */
     this.skipNextInitialTokenCall = false;
 
+    /**
+     * True once a create_token failure has torn the session down (see
+     * handleLendingActionError), until a renewal confirms access again. The
+     * teardown's lendingStatus change re-runs setupLendingToolbarActions(),
+     * which would otherwise start a fresh poller straight away; for a
+     * borrowed loan (user_has_borrowed is left as is) that poller's initial
+     * create_token fails the same way, tearing down again, in a tight loop.
+     */
+    this.tokenAccessLost = false;
+
     this.warningModalOpen = false;
 
     /** Once dismissed, don't re-show the warning modal every tick — only
@@ -343,6 +353,7 @@ export default class IABookActions extends LitElement {
       if (
         !hasExpired &&
         !this.loanRenewInProgress &&
+        !this.tokenAccessLost &&
         !window.IALendingIntervals.tokenPoller
       ) {
         // Any confirmed renewal's response already minted a valid access
@@ -781,6 +792,7 @@ export default class IABookActions extends LitElement {
       // redundant confirming create_token call, regardless of which path
       // triggered this renewal.
       this.skipNextInitialTokenCall = true;
+      this.tokenAccessLost = false;
 
       // A page image requested in the gap between expiry and this renewal
       // landing can come back broken — browsers don't retry a failed <img>
@@ -1070,6 +1082,7 @@ export default class IABookActions extends LitElement {
       // that isn't accessible.
       window?.IALendingIntervals?.clearAll();
       this.tokenPoller?.disconnectedCallback();
+      this.tokenAccessLost = true;
       this.lendingStatus = {
         ...this.lendingStatus,
         user_has_browsed: false,

package/test/ia-book-actions.test.js

@@ -1891,3 +1891,43 @@ describe('handleLendingActionError - a run of unanswered token refreshes (WEBDEV
     expect(el.lendingStatus.secondsLeftOnLoan).to.equal(0);
   });
 });
+
+describe('create_token failure on a borrowed loan does not loop (WEBDEV-9595)', () => {
+  it('does not restart the token poller after the teardown', async () => {
+    const el = await fixture(
+      container({
+        userid: '@user1',
+        identifier: 'borrowed-teardown-loop',
+        lendingStatus: {
+          is_lendable: true,
+          user_has_borrowed: true,
+          available_to_borrow: false,
+          browsingExpired: false,
+        },
+      })
+    );
+    await el.updateComplete;
+    await aTimeout(150);
+    const startSpy = Sinon.spy(el, 'startLoanTokenPoller');
+    const showErrorModalSpy = Sinon.stub(el, 'showErrorModal');
+
+    el.handleLendingActionError({
+      detail: {
+        action: 'create_token',
+        isInitial: false,
+        consecutiveFailures: MAX_SILENT_TOKEN_REFRESH_FAILURES + 1,
+        data: {
+          error: networkError,
+          detail: 'TypeError: Failed to fetch',
+          networkFailure: true,
+        },
+      },
+    });
+    await el.updateComplete;
+    await aTimeout(300);
+
+    expect(showErrorModalSpy.calledOnce).to.be.true;
+    expect(startSpy.called).to.be.false;
+    expect(window.IALendingIntervals.tokenPoller).to.equal(0);
+  });
+});