@internetarchive/ia-book-actions 1.4.4-alpha10 → 1.4.4-alpha11

package/package.json

@@ -7,7 +7,7 @@
   },
   "author": "Internet Archive",
   "license": "AGPL-3.0-only",
-  "version": "1.4.4-alpha10",
+  "version": "1.4.4-alpha11",
   "main": "index.js",
   "module": "index.js",
   "publishConfig": {

package/src/ia-book-actions.js

@@ -61,6 +61,7 @@ export default class IABookActions extends LitElement {
       modal: { Object },
       tokenDelay: { type: Number },
       timerExecutionSeconds: { type: Number },
+      userActionGracePeriod: { type: Number },
       localCache: { type: Object },
       loanRenewTimeConfig: { type: Object },
       loanRenewResult: { type: Object },
@@ -83,6 +84,14 @@ export default class IABookActions extends LitElement {
     this.tokenDelay = 120; // in seconds
     this.timerExecutionSeconds = 30;
 
+    /**
+     * How long (ms) after bindLoanRenewEvents() runs to ignore
+     * BookReader:userAction events — BookReader fires that event on its
+     * own init-time jump to the last-read page, not just on genuine
+     * interaction. @see bindLoanRenewEvents
+     */
+    this.userActionGracePeriod = 2000;
+
     // private props
     this.postInitComplete = false;
     this.primaryActions = [];
@@ -283,7 +292,14 @@ export default class IABookActions extends LitElement {
 
     this.borrowType = actions.borrowType ? actions.borrowType : null;
 
-    if (this.borrowType === 'browsed') {
+    // Don't (re)start the countdown while a renewal is in flight — the
+    // optimistic browsingExpired flip in autoRenewExpiredLoan() (which
+    // triggers this same setupLendingToolbarActions() call) happens before
+    // renewal is confirmed, so secondsLeftOnLoan could still be a stale
+    // value from before the renewal. Wait for handleLoanAutoRenewed() to
+    // confirm the real value and clear loanRenewInProgress before showing
+    // a countdown again.
+    if (this.borrowType === 'browsed' && !this.loanRenewInProgress) {
       // start timer for loan-renew
       await this.startTimerCountdown();
 
@@ -327,10 +343,19 @@ export default class IABookActions extends LitElement {
    * 2. IABookActions:loanRenew - dispatched from timer-countdown component
    */
   bindLoanRenewEvents() {
+    this.userActionReadyAt = Date.now() + this.userActionGracePeriod;
+
     /**
      * dispatched this event from bookreader page changed
      */
     window.addEventListener('BookReader:userAction', () => {
+      if (Date.now() < this.userActionReadyAt) {
+        log(
+          '[IABookActions] BookReader:userAction ignored — within startup grace period'
+        );
+        return;
+      }
+
       // Capture before autoRenewExpiredLoan() runs — it synchronously flips
       // lendingStatus.browsingExpired to false as an optimistic UI update,
       // so checking the live property afterward would always see it as
@@ -448,11 +473,17 @@ export default class IABookActions extends LitElement {
 
     // Optimistically flip browsingExpired back to false so the action bar
     // stays red (patronIsReadingAction) while the renew_loan request is in
-    // flight, instead of showing the blue "Borrow" state.
+    // flight, instead of showing the blue "Borrow" state. Deliberately NOT
+    // resetting secondsLeftOnLoan here — the renewal hasn't been confirmed
+    // yet (it can take several seconds, or genuinely fail), so showing a
+    // full hour before we know the outcome would be misleading. The real
+    // value is set once handleLoanAutoRenewed() confirms success;
+    // loanRenewInProgress (already true above) is the signal consumers
+    // should use to show a "renewing" state instead of trusting the
+    // countdown during this window.
     this.lendingStatus = {
       ...this.lendingStatus,
       browsingExpired: false,
-      secondsLeftOnLoan: this.loanRenewTimeConfig.loanTotalTime,
     };
 
     // Defer renewNow until after lendingStatus timer setup completes.
@@ -505,19 +536,14 @@ export default class IABookActions extends LitElement {
       headerColor: '#194880',
       showCloseButton: false,
       closeOnBackdropClick: false,
-      message: html`<span
-        style="display:inline-flex;align-items:center;flex-wrap:nowrap;gap:4px;"
-      >
-        <span>${this.loanRenewHelper?.getMessageTexts(
-          warningTexts,
-          secondsLeft
-        )}</span>
+      message: html`<span>
+        ${this.loanRenewHelper?.getMessageTexts(warningTexts, secondsLeft)}
         <a
           href="https://help.archive.org/help/borrowing-from-the-lending-library"
           target="_blank"
           title="Get more info on borrowing from The Lending Library"
           data-event-click-tracking="BookReader|BrowsableMoreInfo"
-          style="display:inline-flex;flex-shrink:0;line-height:0;"
+          style="display:inline-block;vertical-align:middle;line-height:0;margin-left:4px;"
         >
           ${infoIcon}
         </a>

package/test/ia-book-actions.test.js

@@ -89,6 +89,8 @@ describe('<ia-book-actions>', () => {
         identifier: 'foobar',
       })
     );
+    // Not testing the BookReader-init grace period here — bypass it.
+    el.userActionReadyAt = 0;
 
     const spy = Sinon.spy(el, 'autoLoanRenewChecker');
     el.lendingStatus = { ...el.lendingStatus, browsingExpired: false };
@@ -111,6 +113,8 @@ describe('<ia-book-actions>', () => {
         lendingStatus: { user_has_browsed: true, browsingExpired: true },
       })
     );
+    // Not testing the BookReader-init grace period here — bypass it.
+    el.userActionReadyAt = 0;
 
     const spy = Sinon.spy(el, 'autoRenewExpiredLoan');
     el.borrowType = 'browsed';
@@ -121,6 +125,34 @@ describe('<ia-book-actions>', () => {
 
     expect(spy.calledOnce).to.be.true;
   });
+
+  it('ignores BookReader:userAction fired within the startup grace period (WEBDEV-8322 follow-up)', async () => {
+    // Regression: BookReader.jumpToIndex() fires its own 'userAction'
+    // event any time it runs — including BookReader's own init-time jump
+    // to the reader's last-read page (updateFromParams(), called from
+    // init()), which has nothing to do with the patron doing anything.
+    // Without this grace period, a plain page refresh on an already-
+    // expired loan would silently auto-renew before the patron did
+    // anything at all.
+    const el = await fixture(
+      container({
+        userid: '@user1',
+        identifier: 'foobar',
+        lendingStatus: { user_has_browsed: true, browsingExpired: true },
+      })
+    );
+    el.borrowType = 'browsed';
+    await el.updateComplete;
+
+    const spy = Sinon.spy(el, 'autoRenewExpiredLoan');
+
+    // Fired immediately after bindLoanRenewEvents() ran (in firstUpdated())
+    // — well within the default grace period.
+    window.dispatchEvent(new Event('BookReader:userAction'));
+    await el.updateComplete;
+
+    expect(spy.called).to.be.false;
+  });
 });
 
 describe('Primary Actions data', () => {
@@ -595,6 +627,36 @@ describe('autoRenewExpiredLoan', () => {
     expect(el.primaryColor).to.equal('danger');
   });
 
+  it('does not (re)start the countdown during the optimistic pre-confirmation window (WEBDEV-8322 follow-up)', async () => {
+    // Regression: the optimistic browsingExpired flip above triggers
+    // setupLendingToolbarActions() before renew_loan is even dispatched,
+    // let alone confirmed. Without gating on loanRenewInProgress, that
+    // would (re)start the timer-countdown interval using whatever stale
+    // secondsLeftOnLoan was left over from before the loan expired,
+    // showing a wrong/flickering value until handleLoanAutoRenewed()
+    // corrects it moments later.
+    const el = await fixture(
+      container({
+        userid: '@user1',
+        identifier: 'foobar',
+        lendingStatus: {
+          user_has_browsed: true,
+          available_to_browse: true,
+          browsingExpired: true,
+        },
+      })
+    );
+    await el.updateComplete;
+
+    const startTimerCountdownSpy = Sinon.spy(el, 'startTimerCountdown');
+
+    el.autoRenewExpiredLoan();
+    await el.updateComplete;
+
+    expect(el.loanRenewInProgress).to.be.true;
+    expect(startTimerCountdownSpy.called).to.be.false;
+  });
+
   it('sets loanRenewInProgress and triggers renewNow after timeout', async () => {
     const el = await fixture(
       container({
@@ -882,6 +944,8 @@ describe('BookReader:userAction race regression (WEBDEV-8322)', () => {
     );
     await el.updateComplete;
     expect(el.borrowType).to.equal('browsed');
+    // Not testing the BookReader-init grace period here — bypass it.
+    el.userActionReadyAt = 0;
 
     el.lendingStatus = { ...baseStatus, browsingExpired: true };
     await el.updateComplete;
@@ -923,6 +987,8 @@ describe('BookReader:userAction race regression (WEBDEV-8322)', () => {
     );
     await el.updateComplete;
     expect(el.borrowType).to.equal('browsed');
+    // Not testing the BookReader-init grace period here — bypass it.
+    el.userActionReadyAt = 0;
 
     el.loanRenewInProgress = true;