@internetarchive/ia-book-actions 1.4.3 → 1.4.4-alpha1

package/src/core/services/actions-handler/actions-handler-service.js

@@ -1,5 +1,6 @@
 /* eslint-disable */
 import { sentryLogs } from '../../config/sentry-events.js';
+import log from '../log.js';
 
 /**
  * Helper to call loan service
@@ -29,7 +30,7 @@ export default async function ActionsHandlerService(options) {
     'return_loan',
   ];
   const shouldReturnError =
-    location?.href?.indexOf('?error=true') !== -1 &&
+    new URLSearchParams(location?.search).get('error') === 'true' &&
     location?.hostname !== 'archive.org';
 
   const testHostname = ['localhost', 'internetarchive.github.io'];
@@ -42,6 +43,7 @@ export default async function ActionsHandlerService(options) {
   let formData = new FormData();
   formData.append('action', option.action);
   formData.append('identifier', option.identifier);
+
   try {
     await fetch(baseHost, {
       method: 'POST',
@@ -82,8 +84,10 @@ export default async function ActionsHandlerService(options) {
       .then(data => {
         // `data` is the parsed version of the JSON returned from the above endpoint.
         if (!data?.error) {
+          log(`[ActionsHandlerService] ✓ ${option.action} succeeded`, data);
           option?.success(data);
         } else {
+          log(`[ActionsHandlerService] ✗ ${option.action} failed`, data);
           option?.error(data);
         }
       });

package/src/core/services/actions-handler/actions-handler.js

@@ -183,14 +183,15 @@ export default class ActionsHandler extends LitElement {
     ActionsHandlerService({
       action,
       identifier: this.identifier,
-      success: data => {
+      success: async data => {
         log('RENEW_LOAN --- ', data, action, data.loan, this.identifier);
         const activeLoan = data.loan ? data.loan : undefined;
         const isRenewal = activeLoan.renewal;
 
         if (activeLoan && isRenewal) {
-          // when loan is renewed, let's reset timer & let everyone know.
-          this.setBrowseTimeSession();
+          // Await — loanAutoRenewed listeners read this same cache key
+          // immediately; dispatching before the write lands was a race.
+          await this.setBrowseTimeSession();
         } else {
           log('RENEW_LOAN ERROR --- ', {
             action,

package/src/core/services/loan-analytics.js

@@ -150,7 +150,7 @@ export default class LoanAnanlytics {
   }
 
   /**
-   * reponsible to sent events to GA
+   * responsible to sent events to GA
    *
    * @param {*} eventCategory
    * @param {*} eventAction

package/src/core/services/loan-renew-helper.js

@@ -16,8 +16,7 @@ export class LoanRenewHelper {
     // messages for auto return machenism
     this.loanRenewMessage =
       'This book has been renewed for #time #unitsOfTime.';
-    this.loanReturnWarning =
-      'With no action, this book will be auto-returned in #time #unitsOfTime.';
+    this.loanReturnWarning = 'Go to any other page to keep your loan active.';
 
     // private props
     this.result = {
@@ -27,7 +26,7 @@ export class LoanRenewHelper {
     };
   }
 
-  handleLoanRenew() {
+  async handleLoanRenew() {
     try {
       if (this.hasPageChanged) {
         return this.pageChanged(); // user clicked on page