@internetarchive/ia-book-actions 1.4.3-canary.0 → 1.4.3

package/.github/workflows/pr-preview.yml

@@ -12,6 +12,10 @@ on:
       - synchronize
       - closed
 
+permissions:
+  contents: write
+  pull-requests: write
+
 concurrency: preview-${{ github.ref }}
 
 env:

package/package.json

@@ -3,11 +3,11 @@
   "description": "Bookreader actions for borrowable book",
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/internetarchive/iaux-book-actions.git"
+    "url": "git+https://github.com/internetarchive/iaux-account-settings.git"
   },
   "author": "Internet Archive",
   "license": "AGPL-3.0-only",
-  "version": "1.4.3-canary.0",
+  "version": "1.4.3",
   "main": "index.js",
   "module": "index.js",
   "publishConfig": {

package/src/core/services/actions-handler/actions-handler.js

@@ -409,6 +409,7 @@ export default class ActionsHandler extends LitElement {
    */
   setStickyAdminAccess(value) {
     const domain = window.location.hostname === 'localhost' ? 'localhost' : '.archive.org';
-    Cookies.setItem('sticky-admin-access', value, '', '/', domain);
+    const expires = new Date(Date.now() + 30 * 24 * 60 * 60 * 1000); // 30 days from now
+    Cookies.setItem('sticky-admin-access', value, expires, '/', domain);
   }
 }

package/src/core/services/loan-analytics.js

@@ -150,7 +150,7 @@ export default class LoanAnanlytics {
   }
 
   /**
-   * responsible to sent events to GA
+   * reponsible to sent events to GA
    *
    * @param {*} eventCategory
    * @param {*} eventAction

package/src/core/services/loan-renew-helper.js

@@ -27,7 +27,7 @@ export class LoanRenewHelper {
     };
   }
 
-  async handleLoanRenew() {
+  handleLoanRenew() {
     try {
       if (this.hasPageChanged) {
         return this.pageChanged(); // user clicked on page

package/src/ia-book-actions.js

@@ -98,10 +98,6 @@ export default class IABookActions extends LitElement {
      */
     this.returnNow = false;
 
-    this.loanRenewInProgress = false;
-
-    this.warningModalOpen = false;
-
     /**
      * contains one hour auto-loan-renew time configuration
      * defaults to 1 hour config
@@ -145,6 +141,7 @@ export default class IABookActions extends LitElement {
    * @param {string} msg
    */
   sentryCaptureMsg(msg) {
+    log(window?.Sentry);
     window?.Sentry?.captureMessage(msg);
   }
 
@@ -236,7 +233,7 @@ export default class IABookActions extends LitElement {
       'browsingExpired' in this.lendingStatus &&
       this.lendingStatus?.browsingExpired;
     if (hasExpired) {
-      log('[IABookActions] browsing expired — showing expired state');
+      log('setupLendingToolbarActions > hasExpired --- ');
 
       if (!this.tokenPoller) {
         this.sentryCaptureMsg(sentryLogs.bookWasExpired);
@@ -293,11 +290,7 @@ export default class IABookActions extends LitElement {
      * dispatched this event from bookreader page changed
      */
     window.addEventListener('BookReader:userAction', () => {
-      // If the loan expired while the tab stayed visible, auto-renew on page turn
-      if (this.lendingStatus.browsingExpired) {
-        this.autoRenewExpiredLoan();
-      }
-
+      log('IABookActions:BookReader:userAction');
       if (this.borrowType === 'browsed') {
         this.autoLoanRenewChecker(true);
       }
@@ -310,17 +303,17 @@ export default class IABookActions extends LitElement {
      */
     document.addEventListener('visibilitychange', async () => {
       if (!document.hidden) {
-        log('[IABookActions] visibilitychange:', this.borrowType);
-
-        // Loan already expired while tab was hidden — try to silently renew
-        if (this.lendingStatus.browsingExpired === true) {
-          this.autoRenewExpiredLoan();
-          return;
-        }
-
-        if (this.borrowType !== 'browsed') return;
-
-        if (this.lendingStatus.browsingExpired === false) {
+        log(
+          'visibilitychange event execute:------------------ ',
+          new Date().getMinutes(),
+          new Date().getSeconds(),
+          this.borrowType
+        );
+
+        if (
+          this.borrowType === 'browsed' &&
+          this.lendingStatus.browsingExpired === false
+        ) {
           const loanTime = await this.localCache.get(
             `${this.identifier}-loanTime`
           );
@@ -331,8 +324,7 @@ export default class IABookActions extends LitElement {
           if (secondsLeft >= this.timerExecutionSeconds) {
             this.loanStatusCheckInterval(Number(secondsLeft));
           } else {
-            // Loan expired while user was away — try to silently renew
-            this.autoRenewExpiredLoan();
+            this.browseHasExpired();
             this.disconnectedCallback();
           }
         }
@@ -358,36 +350,6 @@ export default class IABookActions extends LitElement {
     this.loanRenewResult = this.loanRenewHelper.result;
   }
 
-  /**
-   * Attempt to automatically renew a browse loan that has expired.
-   * Called on visibilitychange (user returns to tab) or on page turn when
-   * the loan has expired but the book may still be available.
-   *
-   * Reuses the same renew_loan path as the "Keep reading" warning modal button.
-   * On success: handleLoanAutoRenewed() resets the timer seamlessly.
-   * On error: handleLendingActionError() shows showLoanUnavailableModal().
-   */
-  autoRenewExpiredLoan() {
-    if (this.loanRenewInProgress) return;
-    this.loanRenewInProgress = true;
-
-    this.modal?.closeModal();
-
-    // Optimistically flip browsingExpired back to false so the action bar
-    // stays red (patronIsReadingAction) while the renew_loan request is in
-    // flight, instead of showing the blue "Borrow" state.
-    this.lendingStatus = {
-      ...this.lendingStatus,
-      browsingExpired: false,
-      secondsLeftOnLoan: this.loanRenewTimeConfig.loanTotalTime,
-    };
-
-    // Defer renewNow until after lendingStatus timer setup completes.
-    setTimeout(() => {
-      this.loanRenewResult = { texts: '', renewNow: true, renewType: 'auto' };
-    }, 0);
-  }
-
   /**
    * Required as sibling on page
    * @returns HTMLElement
@@ -403,34 +365,29 @@ export default class IABookActions extends LitElement {
    * Show the waring modal to ask user if they are still reading
    */
   async showWarningModal() {
-    if (this.warningModalOpen) return;
-    this.warningModalOpen = true;
-
-    log('[IABookActions] showWarningModal');
-
-    // Capture texts and secondsLeft before resetting loanRenewResult
-    const {
-      texts: warningTexts,
-      secondsLeft: rawSecondsLeft,
-    } = this.loanRenewResult;
-    let secondsLeft = rawSecondsLeft;
-    if (secondsLeft === undefined || secondsLeft <= 0) {
+    log('****** showWarningModal ******');
+    // clear modal
+    this.modal.customModalContent = nothing;
+    this.modal?.closeModal();
+    this.loanRenewResult = { texts: '', renewNow: false };
+
+    // if secondsLeft < 60, consider it 1 minute
+    let { secondsLeft } = this.loanRenewResult;
+    if (secondsLeft === undefined) {
       secondsLeft = this.lendingStatus.secondsLeftOnLoan;
     } else {
       secondsLeft = secondsLeft > 60 ? secondsLeft : 60;
     }
 
-    // clear modal and reset renew state
-    this.modal.customModalContent = nothing;
-    this.modal?.closeModal();
-    this.loanRenewResult = { texts: '', renewNow: false };
-
     const config = new ModalConfig({
       headline: 'Are you still reading?',
       headerColor: '#194880',
       showCloseButton: false,
       closeOnBackdropClick: false,
-      message: this.loanRenewHelper?.getMessageTexts(warningTexts, secondsLeft),
+      message: this.loanRenewHelper?.getMessageTexts(
+        this.loanRenewResult.texts,
+        secondsLeft
+      ),
     });
 
     const customModalContent = html`<br />
@@ -527,7 +484,6 @@ export default class IABookActions extends LitElement {
 
   /**
    * Show modal when book is auto returned
-   * @deprecated
    */
   async showExpiredModal() {
     const config = new ModalConfig({
@@ -557,7 +513,7 @@ export default class IABookActions extends LitElement {
    * Execute when loan is expired
    */
   async browseHasExpired() {
-    log('[IABookActions] browseHasExpired');
+    log('BrowseHasExpired ---');
     window?.IALendingIntervals?.clearAll();
 
     const currStatus = {
@@ -576,52 +532,31 @@ export default class IABookActions extends LitElement {
     this.loanRenewResult.texts =
       'This book has been returned due to inactivity.';
 
-    this.modal?.closeModal();
+    await this.showExpiredModal();
 
     this.sentryCaptureMsg(sentryLogs.browseHasExpired);
   }
 
-  /**
-   * Show modal when the book can no longer be automatically renewed
-   * because another patron has checked it out.
-   */
-  async showLoanUnavailableModal() {
-    const config = new ModalConfig({
-      headline: '',
-      showCloseButton: false,
-      closeOnBackdropClick: false,
-      headerColor: '#194880',
-      message:
-        'Another patron is borrowing this book. Please check back later.',
-    });
-
-    const customModalContent = html`<br />
-      <div style="text-align: center">
-        <button
-          style="${modalButtonStyle.iaButton} ${modalButtonStyle.renew}"
-          @click=${() => URLHelper.goToUrl(this.returnUrl, true)}
-        >
-          Okay
-        </button>
-      </div>`;
-
-    await this.modal?.showModal({ config, customModalContent });
-  }
-
   async startBrowseTimer() {
     window?.IALendingIntervals?.clearBrowseExpireTimeout();
 
-    const {
-      browsingExpired,
-      user_has_browsed,
-      secondsLeftOnLoan,
-    } = this.lendingStatus;
+    const { browsingExpired, user_has_browsed, secondsLeftOnLoan } =
+      this.lendingStatus;
 
     if (!user_has_browsed || browsingExpired) {
+      log('startBrowseTimer --- !user_has_browsed || browsingExpired', {
+        user_has_browsed,
+        browsingExpired,
+        secondsLeftOnLoan,
+      });
       return;
     }
 
     window.IALendingIntervals.browseExpireTimeout = setTimeout(() => {
+      log(
+        'startBrowseTimer > browseExpireTimeout --- will expire loan',
+        secondsLeftOnLoan
+      );
       this.browseHasExpired();
     }, secondsLeftOnLoan * 1000);
   }
@@ -703,9 +638,12 @@ export default class IABookActions extends LitElement {
 
       // number of seconds left in current loan
       const secondsLeft = Math.round((loanTime - new Date()) / 1000);
-      log('[IABookActions] handleLoanAutoRenewed', {
-        secondsLeft,
+      log(loanTime, secondsLeft);
+
+      log('IABookActions: handleLoanAutoRenewed --- ', {
         ajaxResponse: detail?.data,
+        loanRenewResult: this.loanRenewResult,
+        secondsLeftOnLoan: secondsLeft,
       });
 
       const currStatus = {
@@ -722,9 +660,6 @@ export default class IABookActions extends LitElement {
       this.modal.customModalContent = nothing;
       this.sentryCaptureMsg(sentryLogs.bookHasRenewed);
     }
-
-    this.warningModalOpen = false;
-    this.loanRenewInProgress = false;
   }
 
   /**
@@ -760,19 +695,29 @@ export default class IABookActions extends LitElement {
     // re-sync timer if gone off because of background window
     // side effect: updates this.lendingStatus & kicks off lifecycle,
     // if really updated, escape from here
-    const resyncd = this.reSyncTimerIfGoneOff(secondsLeft);
+    const resyncd = await this.reSyncTimerIfGoneOff(secondsLeft);
 
     if (resyncd.hasSynced) {
       secondsLeft = resyncd.whatShouldLeft;
-      log('[IABookActions] startTimerCountdown: timer re-synced', {
+      log('startTimerCountdown --- stale, timer has resyncd', {
         secondsLeft,
       });
     }
 
-    log('[IABookActions] startTimerCountdown', {
-      secondsLeft,
-      loanRenewAtLast: this.loanRenewTimeConfig.loanRenewAtLast,
-    });
+    log(
+      'startTimerCountdown --- countdown still valid. continue...',
+      {
+        resyncd,
+        secondsLeft,
+        loanRenewAtLast: this.loanRenewTimeConfig.loanRenewAtLast,
+      },
+      'time: ',
+      new Date().getMinutes(),
+      ':',
+      new Date().getSeconds(),
+      ', timerDelay: ',
+      this.timerExecutionSeconds
+    );
 
     /**
      * execute from last 10th minutes to 0th minute
@@ -797,7 +742,7 @@ export default class IABookActions extends LitElement {
    * @param {number} timerSecondsLeft - actual seconds left get from setInterval
    * @returns {Object} { hasSynced: [boolean], whatShouldLeft: [number] }
    */
-  reSyncTimerIfGoneOff(timerSecondsLeft) {
+  async reSyncTimerIfGoneOff(timerSecondsLeft) {
     const currentTime = new Date();
 
     // current time - loan time
@@ -807,11 +752,27 @@ export default class IABookActions extends LitElement {
     const secondsShouldLeft =
       this.lendingStatus.secondsLeftOnLoan - diffInSeconds;
 
+    log('currentTime: ', currentTime);
+    log('timeWhenTimerStart: ', this.timeWhenTimerStart);
+    log('diffInSeconds: ', diffInSeconds);
+    log('secondsShouldLeft: ', secondsShouldLeft);
+    log(
+      'this.lendingStatus.secondsLeftOnLoan: ',
+      this.lendingStatus.secondsLeftOnLoan
+    );
+
     // convert in minutes
     const whatIsleft = Math.round(timerSecondsLeft);
     const whatShouldLeft = Math.round(secondsShouldLeft);
     const timerElSeconds = this.timerCountdownEl.secondsLeftOnLoan || 0;
 
+    log(`reSyncTimerIfGoneOff?`, {
+      whatIsleft,
+      whatShouldLeft,
+      timerElSeconds,
+      timeLeftInMin: Math.ceil(timerSecondsLeft / 60),
+    });
+
     if (timerElSeconds !== whatShouldLeft || whatIsleft !== whatShouldLeft) {
       // set lending status with new time to update decrementor
       const currStatus = {
@@ -822,9 +783,7 @@ export default class IABookActions extends LitElement {
     }
 
     if (whatIsleft !== whatShouldLeft) {
-      log(
-        `[IABookActions] reSyncTimerIfGoneOff ${whatIsleft} - ${whatShouldLeft}: re-syncing timer`
-      );
+      log(`reSyncTimerIfGoneOff --- let's re-sync.`);
       return { hasSynced: true, whatShouldLeft };
     }
 
@@ -840,6 +799,10 @@ export default class IABookActions extends LitElement {
    * @memberof IABookActions
    */
   async loanRenewAttempt(secondsLeft) {
+    log('loanRenewAttempt ---', {
+      secondsLeft,
+      loanRenewResult: this.loanRenewResult,
+    });
     let loanSecondsLeft = secondsLeft;
     /**
      * auto-renew is not possible in last seconds (let say 50 second) because,
@@ -849,7 +812,7 @@ export default class IABookActions extends LitElement {
      * so if seconds left is < 50, just expire the loan
      */
     if (loanSecondsLeft < 50) {
-      log('[IABookActions] loanRenewAttempt: < 50s left, expiring loan');
+      log('loanRenewAttempt --- loanSecondsLeft < 50, will expire');
       await this.browseHasExpired();
       return;
     }
@@ -931,17 +894,9 @@ export default class IABookActions extends LitElement {
     const action = event?.detail?.action;
     const errorMsg = event?.detail?.data?.error;
 
-    // For renew_loan failures after auto-renew, show the patron-facing message
-    if (
-      errorMsg &&
-      action === 'renew_loan' &&
-      errorMsg.match(/not available/)
-    ) {
-      this.loanRenewInProgress = false;
-      this.showLoanUnavailableModal();
-    } else if (errorMsg && action !== 'create_token') {
+    // template not show create_token errors
+    if (errorMsg && action !== 'create_token')
       this.showErrorModal(errorMsg, action);
-    }
 
     // if error related to loan token
     // - set user_has_browsed to `false`

package/test/core/services/actions-handler.test.js

@@ -0,0 +1,91 @@
+import { expect, fixture } from '@open-wc/testing';
+import sinon from 'sinon';
+
+import ActionsHandler from '../../../src/core/services/actions-handler/actions-handler.js';
+
+// Define a temporary tag for this element for testing
+const TEST_TAG = 'ia-actions-handler-test';
+if (!customElements.get(TEST_TAG)) {
+  customElements.define(TEST_TAG, ActionsHandler);
+}
+
+describe('ActionsHandler#setStickyAdminAccess', () => {
+  let clock;
+  let lastSetCookie;
+  let cookieOverridden = false;
+  let actionsHandlerFixture;
+
+  beforeEach(async () => {
+    // Intercept document.cookie writes to capture the full cookie string
+    Object.defineProperty(document, 'cookie', {
+      configurable: true,
+      get() {
+        return '';
+      },
+      set(value) {
+        lastSetCookie = value;
+      },
+    });
+    cookieOverridden = true;
+
+    // Create the element via fixture (portable across browsers)
+    actionsHandlerFixture = await fixture(`<${TEST_TAG}></${TEST_TAG}>`);
+  });
+
+  afterEach(() => {
+    sinon.restore();
+    if (clock) {
+      clock.restore();
+      clock = undefined;
+    }
+    // restore document.cookie
+    if (cookieOverridden) {
+      try {
+        // remove our instance-level override
+        // eslint-disable-next-line no-param-reassign
+        delete document.cookie;
+      } catch (e) {
+        // ignore
+      }
+      cookieOverridden = false;
+    }
+    lastSetCookie = undefined;
+  });
+
+  it('sets the sticky-admin-access cookie with correct domain, path, and 30-day expiration', async () => {
+    // Arrange: fix time and stub cookie writer
+    const now = new Date('2025-01-01T00:00:00.000Z');
+    clock = sinon.useFakeTimers({ now: now.getTime() });
+
+    // Calculate expected values based on current environment
+    const expectedDomain = window.location.hostname === 'localhost' ? 'localhost' : '.archive.org';
+    const expectedExpires = new Date(now.getTime() + 30 * 24 * 60 * 60 * 1000);
+
+    // Act: call the method on the element created in beforeEach
+    actionsHandlerFixture.setStickyAdminAccess(true);
+
+    // Assert: verify the composed cookie string
+    expect(lastSetCookie).to.be.a('string');
+    // Name and value
+    expect(lastSetCookie).to.contain(`${encodeURIComponent('sticky-admin-access')}=${encodeURIComponent('true')}`);
+    // Domain
+    expect(lastSetCookie).to.contain(`domain=${expectedDomain}`);
+    // Path
+    expect(lastSetCookie).to.contain('path=/');
+    // Expiration close to 30 days from now
+    const match = /expires=([^;]+)/.exec(lastSetCookie);
+    expect(match).to.not.equal(null);
+    const expiresStr = match && match[1];
+    const parsed = expiresStr ? new Date(expiresStr) : null;
+    expect(parsed).to.be.instanceOf(Date);
+    expect(parsed && parsed.getTime()).to.equal(expectedExpires.getTime());
+  });
+
+  it('sets the cookie value to false when disabling', async () => {
+    // Act
+    actionsHandlerFixture.setStickyAdminAccess(false);
+
+    expect(lastSetCookie).to.be.a('string');
+    expect(lastSetCookie).to.contain(`${encodeURIComponent('sticky-admin-access')}=${encodeURIComponent('false')}`);
+  });
+});

package/test/ia-book-actions.test.js

@@ -82,7 +82,7 @@ describe('<ia-book-actions>', () => {
     expect(el.disableActionGroup).to.be.true;
   });
 
-  it('handles `BookReader:userAction` event when loan is active', async () => {
+  it('handles `BookReader:userAction` event', async () => {
     const el = await fixture(
       container({
         userid: '@user1',
@@ -91,28 +91,6 @@ describe('<ia-book-actions>', () => {
     );
 
     const spy = Sinon.spy(el, 'autoLoanRenewChecker');
-    el.lendingStatus = { ...el.lendingStatus, browsingExpired: false };
-    await el.updateComplete;
-    // Set borrowType after the update so setupLendingToolbarActions() doesn't overwrite it
-    el.borrowType = 'browsed';
-
-    window.dispatchEvent(new Event('BookReader:userAction'));
-    await el.updateComplete;
-
-    expect(spy.calledOnce).to.be.true;
-    expect(spy.calledWith(true)).to.be.true;
-  });
-
-  it('handles `BookReader:userAction` event when loan has expired', async () => {
-    const el = await fixture(
-      container({
-        userid: '@user1',
-        identifier: 'foobar',
-        lendingStatus: { user_has_browsed: true, browsingExpired: true },
-      })
-    );
-
-    const spy = Sinon.spy(el, 'autoRenewExpiredLoan');
     el.borrowType = 'browsed';
     await el.updateComplete;
 
@@ -120,6 +98,7 @@ describe('<ia-book-actions>', () => {
     await el.updateComplete;
 
     expect(spy.calledOnce).to.be.true;
+    expect(spy.calledWith(true)).to.be.true;
   });
 });
 
@@ -488,7 +467,7 @@ describe('Visibility change API for document', async () => {
     });
   });
 
-  it('when book is not expired and loan time is valid', async () => {
+  it('when book is not expired', async () => {
     const el = await fixture(
       container({
         userid: '@user1',
@@ -501,220 +480,31 @@ describe('Visibility change API for document', async () => {
     );
     await el.updateComplete;
 
-    // Set a valid loan time well into the future
-    await el.localCache.set({
-      key: 'foobar-loanTime',
-      value: new Date(new Date().getTime() + 3600 * 1000),
-      ttl: 3600,
-    });
-
     const spy = Sinon.spy(el, 'loanStatusCheckInterval');
     document.dispatchEvent(new Event('visibilitychange'));
-    await aTimeout(100);
-
-    expect(spy.calledOnce).to.be.true;
-  });
-
-  it('when loan expired while tab was hidden (browsingExpired false, loanTime past)', async () => {
-    const el = await fixture(
-      container({
-        userid: '@user1',
-        identifier: 'foobar',
-        lendingStatus: {
-          user_has_browsed: true,
-          browsingExpired: false,
-        },
-      })
-    );
-    await el.updateComplete;
-
-    // Set a loan time already in the past
-    await el.localCache.set({
-      key: 'foobar-loanTime',
-      value: new Date(new Date().getTime() - 10 * 1000),
-      ttl: 3600,
-    });
-
-    const spy = Sinon.spy(el, 'autoRenewExpiredLoan');
-    document.dispatchEvent(new Event('visibilitychange'));
-    await aTimeout(100);
 
     expect(spy.calledOnce).to.be.true;
   });
 
-  it('when loan already marked expired (browsingExpired true)', async () => {
+  it('when book is already expired', async () => {
     const el = await fixture(
       container({
         userid: '@user1',
         identifier: 'foobar',
         lendingStatus: {
           user_has_browsed: true,
-          browsingExpired: true,
         },
       })
     );
     await el.updateComplete;
 
-    el.borrowType = 'browsed';
-
-    const spy = Sinon.spy(el, 'autoRenewExpiredLoan');
+    const spy = Sinon.spy(el, 'browseHasExpired');
     document.dispatchEvent(new Event('visibilitychange'));
-    await aTimeout(100);
 
     expect(spy.calledOnce).to.be.true;
   });
 });
 
-describe('autoRenewExpiredLoan', () => {
-  it('optimistically resets browsingExpired so the button stays red', async () => {
-    const el = await fixture(
-      container({
-        userid: '@user1',
-        identifier: 'foobar',
-        lendingStatus: {
-          user_has_browsed: true,
-          available_to_browse: true,
-          browsingExpired: true,
-        },
-      })
-    );
-    await el.updateComplete;
-
-    // Before: browsingExpired true → borrow1HrAction → primary color is 'primary' (blue)
-    expect(el.primaryColor).to.equal('primary');
-
-    el.autoRenewExpiredLoan();
-    await el.updateComplete;
-
-    // After: browsingExpired flipped to false → patronIsReadingAction → 'danger' (red)
-    expect(el.lendingStatus.browsingExpired).to.be.false;
-    expect(el.primaryColor).to.equal('danger');
-  });
-
-  it('sets loanRenewInProgress and triggers renewNow after timeout', async () => {
-    const el = await fixture(
-      container({
-        userid: '@user1',
-        identifier: 'foobar',
-        lendingStatus: {
-          user_has_browsed: true,
-          browsingExpired: true,
-        },
-      })
-    );
-    await el.updateComplete;
-
-    el.autoRenewExpiredLoan();
-
-    expect(el.loanRenewInProgress).to.be.true;
-
-    // renewNow is set in a setTimeout — flush the macrotask queue
-    await aTimeout(50);
-    expect(el.loanRenewResult.renewNow).to.be.true;
-    expect(el.loanRenewResult.renewType).to.equal('auto');
-  });
-
-  it('ignores subsequent calls while a renewal is already in progress', async () => {
-    const el = await fixture(
-      container({
-        userid: '@user1',
-        identifier: 'foobar',
-        lendingStatus: {
-          user_has_browsed: true,
-          browsingExpired: true,
-        },
-      })
-    );
-    await el.updateComplete;
-
-    // Spy *after* fixture so the handler is the same instance
-    const spy = Sinon.spy(el, 'autoRenewExpiredLoan');
-
-    el.autoRenewExpiredLoan(); // first call — proceeds
-    el.autoRenewExpiredLoan(); // second call — should be a no-op
-
-    // The spy counts both invocations but the internal guard stops the second
-    expect(spy.callCount).to.equal(2);
-    // loanRenewInProgress is still true (not double-set or cleared)
-    expect(el.loanRenewInProgress).to.be.true;
-
-    // Only one setTimeout fires (the second call returned early)
-    await aTimeout(50);
-    expect(el.loanRenewResult.renewNow).to.be.true;
-  });
-
-  it('clears loanRenewInProgress after a successful loanAutoRenewed event', async () => {
-    const el = await fixture(
-      container({
-        userid: '@user1',
-        identifier: 'foobar',
-        lendingStatus: {
-          user_has_browsed: true,
-          browsingExpired: false,
-          secondsLeftOnLoan: 100,
-        },
-      })
-    );
-    await el.updateComplete;
-
-    await el.localCache.set({
-      key: 'foobar-loanTime',
-      value: new Date(new Date().getTime() + 3600 * 1000),
-      ttl: 3600,
-    });
-
-    el.autoRenewExpiredLoan();
-    expect(el.loanRenewInProgress).to.be.true;
-
-    // Wait for the deferred renewNow to be set
-    await aTimeout(50);
-
-    // Simulate the renew_loan success response
-    const collapsibleActionGroupEl = el.shadowRoot.querySelector(
-      'collapsible-action-group'
-    );
-    collapsibleActionGroupEl.dispatchEvent(
-      new CustomEvent('loanAutoRenewed', {
-        detail: { data: { loan: { identifier: 'foobar' } } },
-      })
-    );
-
-    await aTimeout(100);
-    await el.updateComplete;
-
-    expect(el.loanRenewInProgress).to.be.false;
-  });
-
-  it('clears loanRenewInProgress and shows unavailable modal on renew_loan failure', async () => {
-    const el = await fixture(
-      container({
-        userid: '@user1',
-        identifier: 'foobar',
-        lendingStatus: {
-          user_has_browsed: true,
-          browsingExpired: true,
-        },
-      })
-    );
-    await el.updateComplete;
-
-    const showModalSpy = Sinon.spy(el, 'showLoanUnavailableModal');
-
-    el.autoRenewExpiredLoan();
-    expect(el.loanRenewInProgress).to.be.true;
-
-    el.handleLendingActionError({
-      detail: {
-        action: 'renew_loan',
-        data: { error: 'book is not available' },
-      },
-    });
-
-    expect(el.loanRenewInProgress).to.be.false;
-    expect(showModalSpy.calledOnce).to.be.true;
-  });
-});
-
 describe('Shared Resize Observer', () => {
   it('can receive a Shared Resize Observer', async () => {
     const sharedObserverStub = new SharedResizeObserver();