@internetarchive/ia-book-actions 1.0.0 → 1.1.0-alpha1

package/demo/index.html

@@ -150,6 +150,25 @@
       });
     });
 
+    document.querySelectorAll('.searchParam input[type=checkbox]').forEach((item) => {
+      item.addEventListener('click', (e) => {
+        var searchParams = new URLSearchParams(window.location.search);
+        var separate = '';
+        if (e.target.checked) {
+          separate = '?';
+          searchParams.set('q', 'test');
+        } else {
+          separate = '';
+          searchParams.delete('q');
+        }
+
+        if (history.pushState) {
+          var newurl = window.location.protocol + "//" + window.location.host + window.location.pathname + separate + searchParams;
+          window.history.pushState({path:newurl},'',newurl);
+        }
+      });
+    });
+
     document.querySelectorAll('.errorEnable input[type=checkbox]').forEach((item) => {
       if (window.location.href.indexOf('?error=true') !== -1) {
         item.checked = true;
@@ -327,7 +346,6 @@
     // listen for IABookReader:BrowsingHasExpired
     window.addEventListener('IABookReader:BrowsingHasExpired', () => {
       console.log('IABookReader:BrowsingHasExpired EVENT FIRED');
-      alert('IABookReader:BrowsingHasExpired EVENT FIRED');
     });
 </script>
 
@@ -339,6 +357,8 @@
             <td class="titleBar">
               <label><input type="checkbox" name="title" value="title" />Title Bar</label>
             </td>
+            <td class="searchParam">
+              <label><input type="checkbox" name="search" value="Search Param" />Search Param</label>
             <td>
               <button class="pageChangedEvent">Page Change Event</button>
             </td>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@internetarchive/ia-book-actions",
-  "version": "1.0.0",
+  "version": "1.1.0-alpha1",
   "description": "Bookreader actions for borrowable book",
   "author": "Internet Archive",
   "license": "AGPL-3.0-only",
@@ -23,7 +23,9 @@
     "@internetarchive/modal-manager": "^0.2.12",
     "@internetarchive/shared-resize-observer": "^0.2.0",
     "@internetarchive/toast-manager": "0.1.0",
-    "lit": "^2.5.0"
+    "install-deps": "^1.1.0",
+    "lit": "^2.5.0",
+    "playwright": "^1.43.1"
   },
   "devDependencies": {
     "@open-wc/eslint-config": "^4.2.0",

package/src/components/collapsible-action-group.js

@@ -178,7 +178,7 @@ export class CollapsibleActionGroup extends ActionsHandler {
   get renderSecondaryActions() {
     if (!this.secondaryActions.length) return nothing;
 
-    return this.secondaryActions.map(action => this.renderActionLink(action));
+    return this.secondaryActions.map(action => this.renderActionButton(action));
   }
 
   /**

package/src/core/services/actions-config.js

@@ -207,8 +207,6 @@ export default class ActionsConfig {
       id: 'adminAccess',
       text: 'Admin Access',
       title: 'You have administrative privileges to read this book',
-      url: '?admin=1',
-      target: '_self',
       className: 'danger',
       analyticsEvent: {
         category: this.analyticsCategories.adminAccess,

package/src/core/services/actions-handler/actions-handler.js

@@ -115,6 +115,11 @@ export default class ActionsHandler extends LitElement {
     this.addEventListener('adminAccess', ({ detail }) => {
       const { category, action } = detail.event;
       this.loanAnanlytics?.sendEvent(category, action, this.identifier);
+
+      // keep existing params and add new one
+      const url = new URL(window.location.href);
+      url.searchParams.append('admin', 1);
+      window.location.search = url.search;
     });
 
     this.addEventListener('exitAdminAccess', ({ detail }) => {

package/src/ia-book-actions.js

@@ -403,10 +403,7 @@ export default class IABookActions extends LitElement {
               ></ia-activity-indicator>`
             : 'Keep reading'}
         </button>
-        <span
-          style="position: absolute; visibility: none; height: 1px; width: 1px; overflow: hidden;"
-          >Renewing loan, one moment please.</span
-        >
+        <span class="sr-only">Renewing loan, one moment please.</span>
         <button
           disabled
           style="${modalButtonStyle.iaButton} ${modalButtonStyle.return}"
@@ -506,7 +503,7 @@ export default class IABookActions extends LitElement {
     }
 
     const config = new ToastConfig();
-    config.dismisOnClick = true;
+    config.dismissOnClick = true;
     config.texts = this.loanRenewHelper?.getMessageTexts(
       this.loanRenewResult.texts,
       secondsLeft
@@ -988,6 +985,17 @@ export default class IABookActions extends LitElement {
         --toastBGColor: #333;
         --toastFontColor: #fff;
       }
+
+      .sr-only {
+        position: absolute;
+        left: -9999px;
+        width: 1px;
+        height: 1px;
+        margin: 0;
+        padding: 0;
+        border: none;
+        overflow: hidden;
+      }
     `;
   }
 }

package/test/ia-book-actions.test.js

@@ -421,7 +421,7 @@ describe('Auto renew one hour loan', () => {
     // timer-countdown reflects decreased loan time
     expect(el.timerCountdownEl.secondsLeftOnLoan).to.equal(8);
 
-    expect(el.postInitComplete).to.equal(33);
+    expect(el.postInitComplete).to.equal(false);
 
     // dispatch loanAutoRenewed event - test 200 callback
     const collapsibleActionGroupEl = el.shadowRoot.querySelector(
@@ -445,7 +445,7 @@ describe('Auto renew one hour loan', () => {
     expect(el.loanRenewResult.renewNow).to.equal(true);
     expect(el.loanRenewResult.secondsLeft).to.equal(10);
     expect(el.timerCountdownEl).to.exist;
-    expect(el.timerCountdownEl.secondsLeftOnLoan).to.equal(loanTime);
+    expect(el.timerCountdownEl.secondsLeftOnLoan).to.equal(8);
   });
 });