@internetarchive/ia-book-actions 0.1.5-b2 → 0.1.6-alpha1

package/demo/index.html

@@ -132,10 +132,10 @@
     iaBookActions.localCache = localCache;
 
     let loanTotalTime2Min = { loanTotalTime: 10, loanRenewAtLast: 5, pageChangedInLast: 5 };
-    let loanTotalTime5Min = { loanTotalTime: 300, loanRenewAtLast: 280, pageChangedInLast: 15 };
+    let loanTotalTime5Min = { loanTotalTime: 300, loanRenewAtLast: 180, pageChangedInLast: 15 };
     let loanTotalTime1Hour = { loanTotalTime: 3600, loanRenewAtLast: 600, pageChangedInLast: 900 };
 
-    iaBookActions.loanRenewTimeConfig = loanTotalTime5Min;
+    iaBookActions.loanRenewTimeConfig = loanTotalTime2Min;
 
     let lendingStatus1 = iaBookActions.lendingStatus;
     let secondsLeftOnLoan = iaBookActions.loanRenewTimeConfig.loanTotalTime;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@internetarchive/ia-book-actions",
-  "version": "0.1.5-b2",
+  "version": "0.1.6-alpha1",
   "description": "Bookreader actions for borrowable book",
   "author": "Internet Archive",
   "license": "AGPL-3.0-only",

package/src/core/config/sentry-events.js

@@ -5,6 +5,8 @@ export const sentryLogs = {
   disconnectedCallback: 'IABookActions:disconnectedCallback',
   bookHasRenewed:
     'IABookActions:handleLoanAutoRenewed - book has renewed for next one hour',
+  bookRenewFailed:
+    'IABookActions:handleLoanRenewNow - failed to renew',
   browseHasExpired:
     'IABookActions:browseHasExpired - one-hour loan has been expired',
   bookWasExpired:

package/src/core/services/actions-handler/actions-handler.js

@@ -1,6 +1,7 @@
 import { LitElement } from 'lit';
 
 import { URLHelper } from '../../config/url-helper.js';
+import { sentryLogs } from '../../config/sentry-events.js';
 
 import ActionsHandlerService from './actions-handler-service.js';
 import LoanAnanlytics from '../loan-analytics.js';
@@ -141,12 +142,18 @@ export default class ActionsHandler extends LitElement {
       action,
       identifier: this.identifier,
       success: data => {
-        this.setBrowseTimeSession();
-        this.dispatchEvent(
-          new CustomEvent('loanAutoRenewed', {
-            detail: { action, data },
-          })
-        );
+        if (data?.success === true && data?.loan?.renewal === true) {
+          this.setBrowseTimeSession();
+          this.dispatchEvent(
+            new CustomEvent('loanAutoRenewed', {
+              detail: { action, data },
+            })
+          );
+        } else {
+          window?.Sentry?.captureMessage(
+            `${sentryLogs.bookRenewFailed} - Error: ${JSON.stringify(data)}`
+          );
+        }
       },
       error: data => {
         this.dispatchActionError(action, data);

package/src/core/services/loan-analytics.js

@@ -144,14 +144,14 @@ export default class LoanAnanlytics {
    * @memberof LoanAnanlytics
    */
   sendEvent(eventCategory, eventAction, label, extraParams) {
-    // console.log(
-    //   'eventCategory:-',
-    //   eventCategory,
-    //   '\t||\teventAction:-',
-    //   eventAction,
-    //   '\t||\tlabel:-',
-    //   label
-    // );
+    console.log(
+      'eventCategory:-',
+      eventCategory,
+      '\t||\teventAction:-',
+      eventAction,
+      '\t||\tlabel:-',
+      label
+    );
 
     window?.archive_analytics?.send_event_no_sampling(
       eventCategory,

package/src/core/services/loan-renew-helper.js

@@ -126,13 +126,6 @@ export class LoanRenewHelper {
     // convert time from second to minute
     timeLeft = Math.ceil(timeLeft / 60);
 
-    /**
-     * reduce 1 min from the auto return warning texts
-     * to compensate for the 50 second buffer we’ve introduced to handle the race condition
-     * @see IABookActions:loanRenew addEventListener
-     */
-    if (timeLeft > 1) timeLeft = timeLeft - 1;
-
     // convert time from minute to hour
     if (timeLeft > 59) {
       timeLeft = 1; // 1 hour

package/src/ia-book-actions.js

@@ -539,7 +539,7 @@ export default class IABookActions extends LitElement {
       await this.showToastMessage();
       await this.resetTimerCountState();
 
-      window?.Sentry?.captureMessage(`${sentryLogs.bookHasRenewed}`);
+      window?.Sentry?.captureMessage(sentryLogs.bookHasRenewed);
 
       // testing console....
       console.log('IABookActions: AutoRenewed:- ', {

package/test/components/timer-countdown.test.js

@@ -2,7 +2,11 @@ import { html, fixture, expect, aTimeout } from '@open-wc/testing';
 import '../../src/ia-book-actions.js';
 import '../../src/components/timer-countdown.js';
 
-const container = ({ secondsLeftOnLoan, loanTotalTime, loanRenewAtLast } = {}) =>
+const container = ({
+  secondsLeftOnLoan,
+  loanTotalTime,
+  loanRenewAtLast,
+} = {}) =>
   html`<timer-countdown
     .secondsLeftOnLoan=${secondsLeftOnLoan}
     .loanTotalTime=${loanTotalTime}
@@ -20,7 +24,7 @@ describe('<timer-countdown>', () => {
     );
 
     await el.updateComplete;
-    // expect(el.timerCountdown).to.be.undefined;
+    // expect(window.IALendingIntervals.timerCountdown).to.be.undefined;
   });
 
   it('timer interval is not undefined when loan is active', async () => {
@@ -36,6 +40,6 @@ describe('<timer-countdown>', () => {
     await el.updateComplete;
 
     expect(el.secondsLeftOnLoan).to.equal(2);
-    // expect(el.timerInterval).to.not.be.undefined;
+    // expect(el.timerCountdown).to.not.be.undefined;
   });
 });

package/test/core/services/loan-renew-helper.test.js

@@ -79,9 +79,8 @@ describe('Loan Renew Determine', () => {
       '65' // in seconds
     );
 
-    // we will get 1 min remaining since, we reduced 1 min from remaining time
     expect(toastMsg).to.be.equal(
-      'This book will be automatically returned in 1 minute unless you turn a page.'
+      'This book will be automatically returned in 2 minutes unless you turn a page.'
     );
   });
 });