@internetarchive/ia-book-actions 0.0.16-4 → 0.0.16-5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@internetarchive/ia-book-actions",
-  "version": "0.0.16-4",
+  "version": "0.0.16-5",
   "description": "Bookreader actions for borrowable book",
   "author": "Internet Archive",
   "license": "AGPL-3.0-only",

package/src/core/services/actions-handler/actions-handler-service.js

@@ -4,7 +4,7 @@
  * Helper to call loan service
  * @param {Object} options
  */
-export default async function ActionsHandlerService(options) {
+export default function ActionsHandlerService(options) {
   const option = {
     action: null,
     identifier: '',
@@ -16,13 +16,7 @@ export default async function ActionsHandlerService(options) {
   let baseHost = '/services/loans/loan';
   const location = window?.location;
 
-  console.log('failed-to-fecth-loan-data fix is here');
-
-  // return error reponse when not production and has ?error=true param...
-  const tokenError = 'loan token not found. please try again later.';
-  const borrowError =
-    'This book is not available to borrow at this time. Please try again later.';
-  const erroneousActions = ['browse_book', 'borrow_book', 'create_token'];
+  // return intentional error on dev environment
   const shouldReturnError =
     location?.href?.indexOf('?error=true') !== -1 &&
     location?.hostname !== 'archive.org';
@@ -32,39 +26,43 @@ export default async function ActionsHandlerService(options) {
   let formData = new FormData();
   formData.append('action', option.action);
   formData.append('identifier', option.identifier);
-  try {
-    await fetch(baseHost, {
-      method: 'POST',
-      body: formData,
-    })
-      .then(response => {
-        // intentional error on localhost
-        if (shouldReturnError && erroneousActions.includes(option?.action)) {
-          return {
-            success: false,
-            error: option?.action === 'create_token' ? tokenError : borrowError,
-          };
-        }
 
-        // return success response for /demo/ server...
-        if (baseHost == '/demo/1' || baseHost == '/demo/') {
-          return {
-            success: true,
-            message: 'operation executed successfully!',
-          };
-        }
+  fetch(baseHost, {
+    method: 'POST',
+    body: formData,
+  })
+    .then(response => {
+      const tokenError = 'loan token not found. please try again later.';
+      const borrowError =
+        'This book is not available to borrow at this time. Please try again later.';
+
+      // return error reponse when not production and has ?error=true param...
+      const erroneousActions = ['browse_book', 'borrow_book', 'create_token'];
+      if (shouldReturnError && erroneousActions.includes(option?.action)) {
+        return {
+          success: false,
+          error: option?.action === 'create_token' ? tokenError : borrowError,
+        };
+      }
 
-        // The response is a Response instance.
-        // You parse the data into a useable format using `.json()`
-        return response.json();
-      })
-      .then(data => {
-        // `data` is the parsed version of the JSON returned from the above endpoint.
-        if (!data?.error) {
-          option?.success(data);
-        } else {
-          option?.error(data);
-        }
-      });
-  } catch (err) {}
+      // return success response for /demo/ server...
+      if (baseHost == '/demo/1' || baseHost == '/demo/') {
+        return {
+          success: true,
+          message: 'operation executed successfully!',
+        };
+      }
+
+      // The response is a Response instance.
+      // You parse the data into a useable format using `.json()`
+      return response.json();
+    })
+    .then(data => {
+      // `data` is the parsed version of the JSON returned from the above endpoint.
+      if (!data?.error) {
+        option?.success(data);
+      } else {
+        option?.error(data);
+      }
+    });
 }

package/src/core/services/actions-handler/actions-handler.js

@@ -194,6 +194,10 @@ export default class ActionsHandler extends LitElement {
    * @fires ActionsHandler#lendingActionError
    */
   dispatchActionError(action, data = {}) {
+    console.log('LendingServiceError');
+    // send LendingServiceError to GA
+    this.sendEvent('LendingServiceError', action || 'unknown_action');
+
     this.dispatchEvent(
       new CustomEvent('lendingActionError', {
         detail: { action, data },