@internetarchive/collection-browser 4.1.1 → 4.1.2-alpha10

package/package.json

@@ -1,120 +1,121 @@
-{
-  "name": "@internetarchive/collection-browser",
-  "description": "The Internet Archive Collection Browser.",
-  "license": "AGPL-3.0-only",
-  "author": "Internet Archive",
-  "version": "4.1.1",
-  "main": "dist/index.js",
-  "module": "dist/index.js",
-  "scripts": {
-    "start": "vite",
-    "prepare:ghpages": "rimraf ghpages && yarn run prepare && vite build",
-    "prepare": "rimraf dist && tsc && husky install",
-    "lint": "eslint . && prettier \"**/*.ts\" --check",
-    "format": "eslint . --fix && prettier \"**/*.ts\" --write",
-    "circular": "madge --circular --extensions ts .",
-    "test": "tsc && yarn run lint && yarn run circular && wtr --coverage",
-    "test:fast": "tsc && wtr --coverage",
-    "test:watch": "tsc && concurrently -k -r \"tsc --watch --preserveWatchOutput\" \"wtr --watch\"",
-    "deploy": "yarn run deploy:run -e $(git branch --show-current)",
-    "deploy:run": "yarn run prepare:ghpages && touch ghpages/.nojekyll && yarn run deploy:gh",
-    "deploy:gh": "gh-pages -t -d ghpages -m \"Build for $(git log --pretty=format:\"%h %an %ai %s\" -n1) [skip ci]\"",
-    "typecheck": "yarn tsc --noEmit"
-  },
-  "types": "dist/index.d.ts",
-  "dependencies": {
-    "@a11y/focus-trap": "^1.0.5",
-    "@internetarchive/analytics-manager": "^0.1.4",
-    "@internetarchive/elements": "^0.2.2",
-    "@internetarchive/feature-feedback": "^1.0.0",
-    "@internetarchive/field-parsers": "^1.0.0",
-    "@internetarchive/histogram-date-range": "^1.4.1",
-    "@internetarchive/ia-dropdown": "^2.0.0",
-    "@internetarchive/iaux-item-metadata": "^1.0.5",
-    "@internetarchive/infinite-scroller": "^1.0.1",
-    "@internetarchive/modal-manager": "^2.0.5",
-    "@internetarchive/search-service": "^2.7.0",
-    "@internetarchive/shared-resize-observer": "^0.2.0",
-    "@lit/localize": "^0.12.2",
-    "dompurify": "^3.2.4",
-    "lit": "^2.8.0 || ^3.3.2",
-    "typescript-cookie": "^1.0.6"
-  },
-  "devDependencies": {
-    "@internetarchive/result-type": "^0.0.1",
-    "@open-wc/eslint-config": "^12.0.3",
-    "@open-wc/testing": "^4.0.0",
-    "@rollup/plugin-image": "^3.0.3",
-    "@types/dompurify": "^3.2.0",
-    "@types/mocha": "^10.0.10",
-    "@typescript-eslint/eslint-plugin": "^8.27.0",
-    "@typescript-eslint/parser": "^8.27.0",
-    "@vitejs/plugin-basic-ssl": "^2.1.4",
-    "@web/dev-server": "^0.4.6",
-    "@web/dev-server-rollup": "^0.6.4",
-    "@web/test-runner": "^0.20.0",
-    "concurrently": "^9.1.2",
-    "eslint": "^9.22.0",
-    "eslint-config-prettier": "^10.1.1",
-    "eslint-plugin-html": "^8.1.2",
-    "eslint-plugin-import": "^2.31.0",
-    "eslint-plugin-lit": "^2.0.0",
-    "eslint-plugin-lit-a11y": "^4.1.4",
-    "eslint-plugin-no-only-tests": "^3.3.0",
-    "eslint-plugin-wc": "^3.0.0",
-    "gh-pages": "^6.3.0",
-    "husky": "^9.1.7",
-    "madge": "^8.0.0",
-    "prettier": "^3.5.3",
-    "rimraf": "^6.0.1",
-    "sinon": "^19.0.4",
-    "tslib": "^2.8.1",
-    "typescript": "^5.8.2",
-    "vite": "^6.2.2"
-  },
-  "publishConfig": {
-    "access": "public"
-  },
-  "eslintConfig": {
-    "parser": "@typescript-eslint/parser",
-    "extends": [
-      "@open-wc",
-      "prettier"
-    ],
-    "plugins": [
-      "@typescript-eslint"
-    ],
-    "rules": {
-      "no-unused-vars": "off",
-      "@typescript-eslint/no-unused-vars": [
-        "error"
-      ],
-      "no-shadow": "off",
-      "@typescript-eslint/no-shadow": [
-        "error"
-      ],
-      "class-methods-use-this": "off",
-      "import/no-unresolved": "off",
-      "import/extensions": [
-        "off",
-        "ignorePackages",
-        {
-          "js": "never",
-          "ts": "never"
-        }
-      ],
-      "no-unsafe-optional-chaining": "warn",
-      "default-param-last": "warn"
-    }
-  },
-  "prettier": {
-    "singleQuote": true,
-    "arrowParens": "avoid"
-  },
-  "lint-staged": {
-    "*.ts": [
-      "eslint --fix",
-      "prettier --write"
-    ]
-  }
-}
+{
+  "name": "@internetarchive/collection-browser",
+  "description": "The Internet Archive Collection Browser.",
+  "license": "AGPL-3.0-only",
+  "author": "Internet Archive",
+  "version": "4.1.2-alpha10",
+  "main": "dist/index.js",
+  "module": "dist/index.js",
+  "scripts": {
+    "start": "vite",
+    "prepare:ghpages": "rimraf ghpages && yarn run prepare && vite build",
+    "prepare": "rimraf dist && tsc && husky install",
+    "lint": "eslint . && prettier \"**/*.ts\" --check",
+    "format": "eslint . --fix && prettier \"**/*.ts\" --write",
+    "circular": "madge --circular --extensions ts .",
+    "test": "tsc && yarn run lint && yarn run circular && wtr --coverage",
+    "test:fast": "tsc && wtr --coverage",
+    "test:watch": "tsc && concurrently -k -r \"tsc --watch --preserveWatchOutput\" \"wtr --watch\"",
+    "deploy": "yarn run deploy:run -e $(git branch --show-current)",
+    "deploy:run": "yarn run prepare:ghpages && touch ghpages/.nojekyll && yarn run deploy:gh",
+    "deploy:gh": "gh-pages -t -d ghpages -m \"Build for $(git log --pretty=format:\"%h %an %ai %s\" -n1) [skip ci]\"",
+    "typecheck": "yarn tsc --noEmit"
+  },
+  "types": "dist/index.d.ts",
+  "dependencies": {
+    "@a11y/focus-trap": "^1.0.5",
+    "@internetarchive/analytics-manager": "^0.1.4",
+    "@internetarchive/elements": "^0.2.2",
+    "@internetarchive/feature-feedback": "^1.0.0",
+    "@internetarchive/field-parsers": "^1.0.0",
+    "@internetarchive/histogram-date-range": "^1.4.1",
+    "@internetarchive/ia-dropdown": "^2.0.0",
+    "@internetarchive/ia-userlist-settings": "^1.1.3-alpha3",
+    "@internetarchive/iaux-item-metadata": "^1.0.5",
+    "@internetarchive/infinite-scroller": "^1.0.1",
+    "@internetarchive/modal-manager": "^2.0.5",
+    "@internetarchive/search-service": "^2.7.1-alpha3",
+    "@internetarchive/shared-resize-observer": "^0.2.0",
+    "@lit/localize": "^0.12.2",
+    "dompurify": "^3.2.4",
+    "lit": "^2.8.0 || ^3.3.2",
+    "typescript-cookie": "^1.0.6"
+  },
+  "devDependencies": {
+    "@internetarchive/result-type": "^0.0.1",
+    "@open-wc/eslint-config": "^12.0.3",
+    "@open-wc/testing": "^4.0.0",
+    "@rollup/plugin-image": "^3.0.3",
+    "@types/dompurify": "^3.2.0",
+    "@types/mocha": "^10.0.10",
+    "@typescript-eslint/eslint-plugin": "^8.27.0",
+    "@typescript-eslint/parser": "^8.27.0",
+    "@vitejs/plugin-basic-ssl": "^2.1.4",
+    "@web/dev-server": "^0.4.6",
+    "@web/dev-server-rollup": "^0.6.4",
+    "@web/test-runner": "^0.20.0",
+    "concurrently": "^9.1.2",
+    "eslint": "^9.22.0",
+    "eslint-config-prettier": "^10.1.1",
+    "eslint-plugin-html": "^8.1.2",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-lit": "^2.0.0",
+    "eslint-plugin-lit-a11y": "^4.1.4",
+    "eslint-plugin-no-only-tests": "^3.3.0",
+    "eslint-plugin-wc": "^3.0.0",
+    "gh-pages": "^6.3.0",
+    "husky": "^9.1.7",
+    "madge": "^8.0.0",
+    "prettier": "^3.5.3",
+    "rimraf": "^6.0.1",
+    "sinon": "^19.0.4",
+    "tslib": "^2.8.1",
+    "typescript": "^5.8.2",
+    "vite": "^6.2.2"
+  },
+  "publishConfig": {
+    "access": "public"
+  },
+  "eslintConfig": {
+    "parser": "@typescript-eslint/parser",
+    "extends": [
+      "@open-wc",
+      "prettier"
+    ],
+    "plugins": [
+      "@typescript-eslint"
+    ],
+    "rules": {
+      "no-unused-vars": "off",
+      "@typescript-eslint/no-unused-vars": [
+        "error"
+      ],
+      "no-shadow": "off",
+      "@typescript-eslint/no-shadow": [
+        "error"
+      ],
+      "class-methods-use-this": "off",
+      "import/no-unresolved": "off",
+      "import/extensions": [
+        "off",
+        "ignorePackages",
+        {
+          "js": "never",
+          "ts": "never"
+        }
+      ],
+      "no-unsafe-optional-chaining": "warn",
+      "default-param-last": "warn"
+    }
+  },
+  "prettier": {
+    "singleQuote": true,
+    "arrowParens": "avoid"
+  },
+  "lint-staged": {
+    "*.ts": [
+      "eslint --fix",
+      "prettier --write"
+    ]
+  }
+}

package/renovate.json

@@ -1,6 +1,6 @@
-{
-  "extends": [
-    "config:base",
-    ":preserveSemverRanges"
-  ]
-}
+{
+  "extends": [
+    "config:base",
+    ":preserveSemverRanges"
+  ]
+}

package/src/app-root.ts

@@ -510,7 +510,10 @@ export class AppRoot extends LitElement {
           .loggedIn=${this.loggedIn}
           .modalManager=${this.modalManager}
           .analyticsHandler=${this.analyticsHandler}
-          .pageContext=${'search'}
+          .pageContext=${'profile'}
+          .pageType=${'account_details'}
+          .pageTarget=${'fav-neeraj_archive341'}
+          .profileElement=${'favorites'}
           @visiblePageChanged=${this.visiblePageChanged}
           @baseQueryChanged=${this.baseQueryChanged}
           @searchTypeChanged=${this.searchTypeChanged}

package/src/collection-browser.ts

@@ -860,8 +860,9 @@ export class CollectionBrowser
     let sortFieldAvailability = defaultSortAvailability;
 
     // We adjust the available sort options for a couple of special cases...
-    if (this.withinCollection?.startsWith('fav-')) {
-      // When viewing a fav- collection, we include the Date Favorited option as the default
+    if (this.withinCollection?.startsWith('fav-') || this.profileElement === 'favorites') {
+      // When viewing a fav- collection or the favorites profile tab,
+      // we include the Date Favorited option as the default
       sortFieldAvailability = favoritesSortAvailability;
     } else if (!this.withinCollection && this.searchType === SearchType.TV) {
       // When viewing TV search results, we exclude several of the usual date sort options.
@@ -1637,6 +1638,7 @@ export class CollectionBrowser
     this.addController(this.dataSource);
 
     this.baseQuery = queryState.baseQuery;
+    this.withinProfile = queryState.withinProfile;
     this.profileElement = queryState.profileElement;
     this.searchType = queryState.searchType;
     this.selectedFacets =
@@ -1649,6 +1651,14 @@ export class CollectionBrowser
     this.selectedTitleFilter = queryState.selectedTitleFilter;
     this.selectedCreatorFilter = queryState.selectedCreatorFilter;
 
+    // Apply the correct default sort for the new profile element immediately,
+    // so it is in place before hostUpdate() fires on the data source.
+    // Without this, a stale defaultSortField from a previously-active tab
+    // could be used in the first fetch for the incoming tab.
+    if (this.profileElement) {
+      this.applyDefaultProfileSort();
+    }
+
     this.pagesToRender = this.initialPageNumber;
 
     // We set this flag during the update to prevent the URL state persistence

package/src/data-source/collection-browser-data-source.ts

@@ -1127,7 +1127,7 @@ export class CollectionBrowserDataSource
       this.host.defaultSortField
     ) {
       const sortOption = SORT_OPTIONS[this.host.defaultSortField];
-      if (sortOption.searchServiceKey) {
+      if (sortOption.searchServiceKey && sortOption.handledBySearchService) {
         sortParams = [
           {
             field: sortOption.searchServiceKey,

package/src/models.ts

@@ -588,6 +588,7 @@ export const defaultProfileElementSorts: Record<
   reviews: SortField.datereviewed,
   collections: SortField.datearchived,
   web_archives: SortField.datearchived,
+  favorites: SortField.datefavorited,
 };
 
 /** A union of the fields that permit prefix filtering (e.g., alphabetical filtering) */