@internetarchive/collection-browser 3.5.2-alpha-webdev8164.0 → 3.5.2-webdev-8162.1

package/dist/src/collection-facets/more-facets-content.js

@@ -5,18 +5,13 @@ import { AggregationSortType, } from '@internetarchive/search-service';
 import { msg } from '@lit/localize';
 import { facetTitles, suppressedCollections, valueFacetSort, defaultFacetSort, getDefaultSelectedFacets, } from '../models';
 import '@internetarchive/elements/ia-status-indicator/ia-status-indicator';
+import './more-facets-pagination';
 import './facets-template';
 import { analyticsActions, analyticsCategories, } from '../utils/analytics-events';
 import './toggle-switch';
-import './more-facets-pagination';
 import { srOnlyStyle } from '../styles/sr-only';
 import { mergeSelectedFacets, sortBucketsBySelectionState, updateSelectedFacetBucket, } from '../utils/facet-utils';
 import { MORE_FACETS__DEFAULT_PAGE_SIZE, MORE_FACETS__MAX_AGGREGATIONS, } from './models';
-/**
- * Threshold for switching from horizontal scroll to pagination.
- * If facet count >= this value, use pagination. Otherwise use horizontal scroll.
- */
-const PAGINATION_THRESHOLD = 1000;
 let MoreFacetsContent = class MoreFacetsContent extends LitElement {
     constructor() {
         super(...arguments);
@@ -39,12 +34,7 @@ let MoreFacetsContent = class MoreFacetsContent extends LitElement {
          */
         this.unappliedFacetChanges = getDefaultSelectedFacets();
         /**
-         * Text entered by the user to filter facet buckets.
-         * Applied to bucket.key for case-insensitive matching.
-         */
-        this.filterText = '';
-        /**
-         * Current page number for pagination (when facet count >= PAGINATION_THRESHOLD).
+         * Which page of facets we are showing.
          */
         this.pageNumber = 1;
     }
@@ -58,10 +48,6 @@ let MoreFacetsContent = class MoreFacetsContent extends LitElement {
             // store it for reuse across pages.
             this.facetGroup = this.mergedFacets;
         }
-        // Reset to page 1 when filter text changes (only matters for pagination mode)
-        if (changed.has('filterText')) {
-            this.pageNumber = 1;
-        }
     }
     updated(changed) {
         // If any of the search properties change, it triggers a facet fetch
@@ -70,7 +56,7 @@ let MoreFacetsContent = class MoreFacetsContent extends LitElement {
             changed.has('searchType') ||
             changed.has('filterMap')) {
             this.facetsLoading = true;
-            this.pageNumber = 1; // Reset to page 1 on new search
+            this.pageNumber = 1;
             this.sortedBy = defaultFacetSort[this.facetKey];
             this.updateSpecificFacets();
         }
@@ -135,6 +121,20 @@ let MoreFacetsContent = class MoreFacetsContent extends LitElement {
             }
         }
     }
+    /**
+     * Handler for page number changes from the pagination widget.
+     */
+    pageNumberClicked(e) {
+        const page = e?.detail?.page;
+        if (page) {
+            this.pageNumber = Number(page);
+        }
+        this.analyticsHandler?.sendEvent({
+            category: analyticsCategories.default,
+            action: analyticsActions.moreFacetsPageChange,
+            label: `${this.pageNumber}`,
+        });
+    }
     /**
      * Combines the selected facets with the aggregations to create a single list of facets
      */
@@ -252,211 +252,122 @@ let MoreFacetsContent = class MoreFacetsContent extends LitElement {
         };
     }
     /**
-     * Returns the facet group with buckets filtered by the current filter text.
-     * Filters are applied to the full bucket list before pagination.
+     * Returns a FacetGroup representing only the current page of facet buckets to show.
      */
-    get filteredFacetGroup() {
-        const { facetGroup, filterText } = this;
+    get facetGroupForCurrentPage() {
+        const { facetGroup } = this;
         if (!facetGroup)
             return undefined;
-        // If no filter text, return the full group
-        if (!filterText.trim()) {
-            return facetGroup;
-        }
-        // Filter buckets case-insensitively by bucket key
-        const lowerFilter = filterText.toLowerCase().trim();
-        const filteredBuckets = facetGroup.buckets.filter(bucket => bucket.key.toLowerCase().includes(lowerFilter));
+        // Slice out only the current page of facet buckets
+        const firstBucketIndexOnPage = (this.pageNumber - 1) * this.facetsPerPage;
+        const truncatedBuckets = facetGroup.buckets.slice(firstBucketIndexOnPage, firstBucketIndexOnPage + this.facetsPerPage);
         return {
             ...facetGroup,
-            buckets: filteredBuckets,
-        };
-    }
-    /**
-     * Determines whether to use pagination based on the number of filtered facets.
-     * Returns true if facet count >= PAGINATION_THRESHOLD, false otherwise.
-     */
-    get usePagination() {
-        const facetCount = this.filteredFacetGroup?.buckets.length ?? 0;
-        return facetCount >= PAGINATION_THRESHOLD;
-    }
-    /**
-     * Returns the facet group for the current page.
-     * If using pagination (>= 1000 facets), slices to show only the current page.
-     * Otherwise, returns all facets for horizontal scrolling.
-     */
-    get facetGroupForCurrentPage() {
-        const filteredGroup = this.filteredFacetGroup;
-        if (!filteredGroup)
-            return undefined;
-        // If facet count is below threshold, show all facets with horizontal scroll
-        if (!this.usePagination) {
-            return filteredGroup;
-        }
-        // Otherwise, use pagination - slice to current page
-        const startIndex = (this.pageNumber - 1) * this.facetsPerPage;
-        const endIndex = startIndex + this.facetsPerPage;
-        const slicedBuckets = filteredGroup.buckets.slice(startIndex, endIndex);
-        return {
-            ...filteredGroup,
-            buckets: slicedBuckets,
+            buckets: truncatedBuckets,
         };
     }
     get moreFacetsTemplate() {
-        const facetGroup = this.facetGroupForCurrentPage;
-        // Show empty state if filtering returned no results
-        if (this.filterText.trim() &&
-            (!facetGroup || facetGroup.buckets.length === 0)) {
-            return this.emptyFilterResultsTemplate;
-        }
-        return html `
-      <facets-template
-        .facetGroup=${facetGroup}
-        .selectedFacets=${this.selectedFacets}
-        .collectionTitles=${this.collectionTitles}
+        return html `
+      <facets-template
+        .facetGroup=${this.facetGroupForCurrentPage}
+        .selectedFacets=${this.selectedFacets}
+        .collectionTitles=${this.collectionTitles}
         @facetClick=${(e) => {
             if (this.facetKey) {
                 this.unappliedFacetChanges = updateSelectedFacetBucket(this.unappliedFacetChanges, this.facetKey, e.detail.bucket);
             }
-        }}
-      ></facets-template>
+        }}
+      ></facets-template>
     `;
     }
     get loaderTemplate() {
-        return html `
-      <ia-status-indicator
-        class="facets-loader"
-        mode="loading"
-      ></ia-status-indicator>
-    `;
-    }
-    get emptyFilterResultsTemplate() {
-        return html `
-      <div class="empty-results">
-        <p>${msg('No matching values found.')}</p>
-        <p class="hint">${msg('Try a different search term.')}</p>
-      </div>
+        return html `
+      <ia-status-indicator
+        class="facets-loader"
+        mode="loading"
+      ></ia-status-indicator>
     `;
     }
     /**
-     * Number of pages for pagination (only used when facet count >= PAGINATION_THRESHOLD).
+     * How many pages of facets to show in the modal pagination widget
      */
     get paginationSize() {
-        const filteredBuckets = this.filteredFacetGroup?.buckets ?? [];
-        return Math.ceil(filteredBuckets.length / this.facetsPerPage);
+        if (!this.aggregations || !this.facetKey)
+            return 0;
+        // Calculate the appropriate number of pages to show in the modal pagination widget
+        const length = this.aggregations[this.facetKey]?.buckets.length;
+        return Math.ceil(length / this.facetsPerPage);
     }
-    /**
-     * Template for pagination component (only shown when facet count >= PAGINATION_THRESHOLD).
-     */
+    // render pagination if more then 1 page
     get facetsPaginationTemplate() {
-        if (!this.usePagination)
-            return nothing;
-        return html `<more-facets-pagination
-      .size=${this.paginationSize}
-      .currentPage=${this.pageNumber}
-      @pageNumberClicked=${this.pageNumberClicked}
-    ></more-facets-pagination>`;
+        return this.paginationSize > 1
+            ? html `<more-facets-pagination
+          .size=${this.paginationSize}
+          .currentPage=${1}
+          @pageNumberClicked=${this.pageNumberClicked}
+        ></more-facets-pagination>`
+            : nothing;
     }
     get footerTemplate() {
-        return html `
-      ${this.facetsPaginationTemplate}
-      <div class="footer">
-        <button class="btn btn-cancel" type="button" @click=${this.cancelClick}>
-          Cancel
-        </button>
-        <button
-          class="btn btn-submit"
-          type="button"
-          @click=${this.applySearchFacetsClicked}
-        >
-          Apply filters
-        </button>
-      </div>
-    `;
+        if (this.paginationSize > 0) {
+            return html `${this.facetsPaginationTemplate}
+        <div class="footer">
+          <button
+            class="btn btn-cancel"
+            type="button"
+            @click=${this.cancelClick}
+          >
+            Cancel
+          </button>
+          <button
+            class="btn btn-submit"
+            type="button"
+            @click=${this.applySearchFacetsClicked}
+          >
+            Apply filters
+          </button>
+        </div> `;
+        }
+        return nothing;
     }
     sortFacetAggregation(facetSortType) {
         this.sortedBy = facetSortType;
         this.dispatchEvent(new CustomEvent('sortedFacets', { detail: this.sortedBy }));
     }
-    /**
-     * Handler for filter input changes. Updates the filter text and triggers re-render.
-     */
-    handleFilterInput(e) {
-        const input = e.target;
-        this.filterText = input.value;
-    }
-    /**
-     * Handler for pagination page number clicks.
-     * Only used when facet count >= PAGINATION_THRESHOLD.
-     */
-    pageNumberClicked(e) {
-        this.pageNumber = e.detail.page;
-        // Track page navigation in analytics
-        this.analyticsHandler?.sendEvent({
-            category: analyticsCategories.default,
-            action: analyticsActions.moreFacetsPageChange,
-            label: `${this.pageNumber}`,
-        });
-        this.dispatchEvent(new CustomEvent('pageChanged', { detail: this.pageNumber }));
-    }
     get modalHeaderTemplate() {
         const facetSort = this.sortedBy ?? defaultFacetSort[this.facetKey];
         const defaultSwitchSide = facetSort === AggregationSortType.COUNT ? 'left' : 'right';
-        return html `<span class="sr-only">${msg('More facets for:')}</span>
-      <span class="title">
-        ${this.facetGroup?.title}
-
-        <label class="sort-label">${msg('Sort by:')}</label>
+        return html `<span class="sr-only">${msg('More facets for:')}</span>
+      <span class="title">
+        ${this.facetGroup?.title}
+
+        <label class="sort-label">${msg('Sort by:')}</label>
         ${this.facetKey
-            ? html `<toggle-switch
-              class="sort-toggle"
-              leftValue=${AggregationSortType.COUNT}
-              leftLabel="Count"
-              rightValue=${valueFacetSort[this.facetKey]}
-              .rightLabel=${this.facetGroup?.title}
-              side=${defaultSwitchSide}
+            ? html `<toggle-switch
+              class="sort-toggle"
+              leftValue=${AggregationSortType.COUNT}
+              leftLabel="Count"
+              rightValue=${valueFacetSort[this.facetKey]}
+              .rightLabel=${this.facetGroup?.title}
+              side=${defaultSwitchSide}
               @change=${(e) => {
                 this.sortFacetAggregation(Number(e.detail));
-            }}
+            }}
             ></toggle-switch>`
-            : nothing}
-
-        <label class="filter-label" for="facet-filter"
-          >${msg('Filter by:')}</label
-        >
-        <input
-          id="facet-filter"
-          type="text"
-          class="filter-input"
-          .value=${this.filterText}
-          @input=${this.handleFilterInput}
-          placeholder=${msg('Search...')}
-          aria-label=${msg('Filter facets')}
-        />
+            : nothing}
       </span>`;
     }
     render() {
-        const contentClass = this.usePagination
-            ? 'facets-content pagination-mode'
-            : 'facets-content horizontal-scroll-mode';
-        const sectionClass = this.usePagination
-            ? 'pagination-mode'
-            : 'horizontal-scroll-mode';
-        return html `
+        return html `
       ${this.facetsLoading
             ? this.loaderTemplate
-            : html `
-            <section id="more-facets" class="${sectionClass}">
-              <div class="header-content">${this.modalHeaderTemplate}</div>
-              <div class="${contentClass}">
-                ${this.usePagination
-                ? this.moreFacetsTemplate
-                : html `<div class="facets-horizontal-container">
-                      ${this.moreFacetsTemplate}
-                    </div>`}
-              </div>
-              ${this.footerTemplate}
-            </section>
-          `}
+            : html `
+            <section id="more-facets">
+              <div class="header-content">${this.modalHeaderTemplate}</div>
+              <div class="facets-content">${this.moreFacetsTemplate}</div>
+              ${this.footerTemplate}
+            </section>
+          `}
     `;
     }
     applySearchFacetsClicked() {
@@ -469,8 +380,6 @@ let MoreFacetsContent = class MoreFacetsContent extends LitElement {
         this.dispatchEvent(event);
         // Reset the unapplied changes back to default, now that they have been applied
         this.unappliedFacetChanges = getDefaultSelectedFacets();
-        // Reset filter text
-        this.filterText = '';
         this.modalManager?.closeModal();
         this.analyticsHandler?.sendEvent({
             category: analyticsCategories.default,
@@ -481,8 +390,6 @@ let MoreFacetsContent = class MoreFacetsContent extends LitElement {
     cancelClick() {
         // Reset the unapplied changes back to default
         this.unappliedFacetChanges = getDefaultSelectedFacets();
-        // Reset filter text
-        this.filterText = '';
         this.modalManager?.closeModal();
         this.analyticsHandler?.sendEvent({
             category: analyticsCategories.default,
@@ -494,176 +401,73 @@ let MoreFacetsContent = class MoreFacetsContent extends LitElement {
         const modalSubmitButton = css `var(--primaryButtonBGColor, #194880)`;
         return [
             srOnlyStyle,
-            css `
-        section#more-facets {
-          overflow: auto;
-          padding: 10px; /* leaves room for scroll bar to appear without overlaying on content */
-          --facetsColumnCount: 3;
-        }
-
-        /* Horizontal scroll mode: fixed column height for horizontal overflow */
-        section#more-facets.horizontal-scroll-mode {
-          --facetsColumnCount: 3;
-          --facetsMaxHeight: 280px;
-        }
-
-        /* Pagination mode: set height for proper column layout with vertical scroll */
-        section#more-facets.pagination-mode {
-          --facetsColumnCount: 3;
-          --facetsMaxHeight: 280px; /* Columns need height constraint to flow properly */
-        }
-        .header-content .title {
-          display: block;
-          text-align: left;
-          font-size: 1.8rem;
-          padding: 0 10px;
-          font-weight: bold;
-        }
-
-        .sort-label {
-          margin-left: 20px;
-          font-size: 1.3rem;
-        }
-
-        .sort-toggle {
-          font-weight: normal;
-        }
-
-        .filter-label {
-          margin-left: 20px;
-          font-size: 1.3rem;
-        }
-
-        .filter-input {
-          font-size: 1.3rem;
-          padding: 4px 8px;
-          border: 1px solid #ccc;
-          border-radius: 4px;
-          margin-left: 5px;
-          width: 150px;
-          font-family: inherit;
-        }
-
-        .filter-input:focus {
-          outline: 2px solid #194880;
-          outline-offset: 1px;
-          border-color: #194880;
-        }
-
-        .empty-results {
-          text-align: center;
-          padding: 40px 20px;
-          color: #666;
-        }
-
-        .empty-results .hint {
-          font-size: 1.1rem;
-          margin-top: 10px;
-        }
-
-        .facets-content {
-          font-size: 1.2rem;
-          max-height: 300px;
-          padding: 10px;
-          /* Force scrollbar to always be visible */
-          scrollbar-width: thin; /* Firefox */
-          scrollbar-color: #888 #f1f1f1; /* Firefox - thumb and track colors */
-        }
-
-        /* Pagination mode: vertical scrolling, allow taller height for multiple columns */
-        .facets-content.pagination-mode {
-          overflow-y: auto;
-          overflow-x: hidden;
-          max-height: none; /* Remove height constraint to allow columns to flow properly */
-          height: 300px; /* Fixed height to enable vertical scroll */
-        }
-
-        /* Horizontal scroll mode: horizontal scrolling only */
-        .facets-content.horizontal-scroll-mode {
-          overflow-x: auto;
-          overflow-y: hidden;
-        }
-
-        /* Webkit browsers scrollbar styling - always visible */
-        .facets-content::-webkit-scrollbar {
-          width: 12px; /* Vertical scrollbar width */
-          height: 12px; /* Horizontal scrollbar height */
-        }
-
-        .facets-content::-webkit-scrollbar-track {
-          background: #f1f1f1;
-          border-radius: 6px;
-        }
-
-        .facets-content::-webkit-scrollbar-thumb {
-          background: #888;
-          border-radius: 6px;
-          min-height: 30px; /* Ensure thumb is always visible when scrolling is possible */
-        }
-
-        .facets-content::-webkit-scrollbar-thumb:hover {
-          background: #555;
-        }
-
-        /* Force corner to match track color */
-        .facets-content::-webkit-scrollbar-corner {
-          background: #f1f1f1;
-        }
-
-        .facets-horizontal-container {
-          display: inline-block;
-          min-width: 100%;
-          /* Allow natural width expansion based on content */
-          width: fit-content;
-        }
-        .facets-loader {
-          --icon-width: 70px;
-          margin-bottom: 20px;
-          display: block;
-          margin-left: auto;
-          margin-right: auto;
-        }
-        .btn {
-          border: none;
-          padding: 10px;
-          margin-bottom: 10px;
-          width: auto;
-          border-radius: 4px;
-          cursor: pointer;
-        }
-        .btn-cancel {
-          background-color: #2c2c2c;
-          color: white;
-        }
-        .btn-submit {
-          background-color: ${modalSubmitButton};
-          color: white;
-        }
-        .footer {
-          text-align: center;
-          margin-top: 10px;
-        }
-
-        @media (max-width: 560px) {
-          section#more-facets.horizontal-scroll-mode,
-          section#more-facets.pagination-mode {
-            max-height: 450px;
-            --facetsColumnCount: 1; /* Single column on mobile */
-            --facetsMaxHeight: none; /* Remove fixed height for vertical scrolling */
-          }
-          /* On mobile, always use vertical scrolling regardless of mode */
-          .facets-content,
-          .facets-content.pagination-mode,
-          .facets-content.horizontal-scroll-mode {
-            overflow-y: auto;
-            overflow-x: hidden;
-            height: 300px;
-          }
-          .filter-input {
-            width: 120px;
-            font-size: 1.2rem;
-          }
-        }
+            css `
+        section#more-facets {
+          overflow: auto;
+          padding: 10px; /* leaves room for scroll bar to appear without overlaying on content */
+          --facetsColumnCount: 3;
+        }
+        .header-content .title {
+          display: block;
+          text-align: left;
+          font-size: 1.8rem;
+          padding: 0 10px;
+          font-weight: bold;
+        }
+
+        .sort-label {
+          margin-left: 20px;
+          font-size: 1.3rem;
+        }
+
+        .sort-toggle {
+          font-weight: normal;
+        }
+
+        .facets-content {
+          font-size: 1.2rem;
+          max-height: 300px;
+          overflow: auto;
+          padding: 10px;
+        }
+        .facets-loader {
+          --icon-width: 70px;
+          margin-bottom: 20px;
+          display: block;
+          margin-left: auto;
+          margin-right: auto;
+        }
+        .btn {
+          border: none;
+          padding: 10px;
+          margin-bottom: 10px;
+          width: auto;
+          border-radius: 4px;
+          cursor: pointer;
+        }
+        .btn-cancel {
+          background-color: #2c2c2c;
+          color: white;
+        }
+        .btn-submit {
+          background-color: ${modalSubmitButton};
+          color: white;
+        }
+        .footer {
+          text-align: center;
+          margin-top: 10px;
+        }
+
+        @media (max-width: 560px) {
+          section#more-facets {
+            max-height: 450px;
+            --facetsColumnCount: 1;
+          }
+          .facets-content {
+            overflow-y: auto;
+            height: 300px;
+          }
+        }
       `,
         ];
     }
@@ -725,9 +529,6 @@ __decorate([
 __decorate([
     state()
 ], MoreFacetsContent.prototype, "unappliedFacetChanges", void 0);
-__decorate([
-    state()
-], MoreFacetsContent.prototype, "filterText", void 0);
 __decorate([
     state()
 ], MoreFacetsContent.prototype, "pageNumber", void 0);