@internetarchive/collection-browser 2.5.2 → 2.6.1

package/src/empty-placeholder.ts

@@ -86,22 +86,29 @@ export class EmptyPlaceholder extends LitElement {
   }
 
   private get emptyQueryTemplate(): TemplateResult {
+    // Added data-testid for Playwright testing
     return html`
-      <h2 class="title">${EmptyPlaceholder.MESSAGE_EMPTY_QUERY}</h2>
+      <h2 class="title" data-testid="empty-query-text-msg">
+        ${EmptyPlaceholder.MESSAGE_EMPTY_QUERY}
+      </h2>
       <div>${emptyQueryIcon}</div>
     `;
   }
 
   private get emptyCollectionTemplate(): TemplateResult {
+    // Added data-testid for Playwright testing
     return html`
-      <h2 class="title">${EmptyPlaceholder.MESSAGE_NO_VIEWABLE_MEMBERS}</h2>
+      <h2 class="title" data-testid="empty-collection-text-msg">
+        ${EmptyPlaceholder.MESSAGE_NO_VIEWABLE_MEMBERS}
+      </h2>
       <div>${nullResultIcon}</div>
     `;
   }
 
   private get noResultsTemplate(): TemplateResult {
+    // Added data-testid for Playwright testing
     return html`
-      <h2 class="title">
+      <h2 class="title" data-testid="empty-results-text-msg">
         ${this.isCollection
           ? EmptyPlaceholder.MESSAGE_NO_COLLECTION_RESULTS
           : EmptyPlaceholder.MESSAGE_NO_SEARCH_RESULTS}
@@ -111,8 +118,11 @@ export class EmptyPlaceholder extends LitElement {
   }
 
   private get queryErrorTemplate(): TemplateResult {
+    // Added data-testid for Playwright testing
     return html`
-      <h2 class="title">${EmptyPlaceholder.MESSAGE_QUERY_ERROR}</h2>
+      <h2 class="title" data-testid="error-query-text-msg">
+        ${EmptyPlaceholder.MESSAGE_QUERY_ERROR}
+      </h2>
       <div>${nullResultIcon}</div>
       <p class="error-details">
         ${EmptyPlaceholder.QUERY_ERROR_DETAILS_MESSAGE} ${this.detailMessage}
@@ -121,8 +131,11 @@ export class EmptyPlaceholder extends LitElement {
   }
 
   private get collectionErrorTemplate(): TemplateResult {
+    // Added data-testid for Playwright testing
     return html`
-      <h2 class="title">${EmptyPlaceholder.MESSAGE_COLLECTION_ERROR}</h2>
+      <h2 class="title" data-testid="error-collection-text-msg">
+        ${EmptyPlaceholder.MESSAGE_COLLECTION_ERROR}
+      </h2>
       <div>${nullResultIcon}</div>
       <p class="error-details">
         ${EmptyPlaceholder.QUERY_ERROR_DETAILS_MESSAGE} ${this.detailMessage}

package/src/models.ts

@@ -467,12 +467,19 @@ export const prefixFilterAggregationKeys: Record<PrefixFilterType, string> = {
  *  - `eager`: Facet data is always loaded as soon as a search is performed
  *  - `lazy-mobile`: In the desktop layout, functions exactly as `eager`.
  *     In the mobile layout, facet data will only be loaded once the "Filters" accordion is opened.
+ *  - `opt-in-or-login`: Same as `opt-in` for guest users not logged into an account, but same as `eager` for
+ *     any logged in user.
  *  - `opt-in`: In the desktop layout, facet data will only be loaded after the user presses a "Load Facets" button.
  *     In the mobile layout, functions exactly as `lazy-mobile`.
  *  - `off`: Facet data will never be loaded, and a message will be displayed in place of facets
  *     indicating that they are unavailable.
  */
-export type FacetLoadStrategy = 'eager' | 'lazy-mobile' | 'opt-in' | 'off';
+export type FacetLoadStrategy =
+  | 'eager'
+  | 'lazy-mobile'
+  | 'opt-in-or-login'
+  | 'opt-in'
+  | 'off';
 
 /**
  * Union of the facet types that are available in the sidebar.

package/src/sort-filter-bar/sort-filter-bar.ts

@@ -662,6 +662,7 @@ export class SortFilterBar
   }
 
   /** Template for rendering the three display mode options */
+  /** Added data-testid for Playwright testing * */
   private get displayOptionTemplate() {
     return html`
       <ul>
@@ -673,6 +674,7 @@ export class SortFilterBar
             }}
             class=${this.displayMode === 'grid' ? 'active' : ''}
             title="Tile view"
+            data-testid="grid-button"
           >
             ${tileIcon}
           </button>
@@ -685,6 +687,7 @@ export class SortFilterBar
             }}
             class=${this.displayMode === 'list-detail' ? 'active' : ''}
             title="List view"
+            data-testid="list-detail-button"
           >
             ${listIcon}
           </button>
@@ -697,6 +700,7 @@ export class SortFilterBar
             }}
             class=${this.displayMode === 'list-compact' ? 'active' : ''}
             title="Compact list view"
+            data-testid="list-compact-button"
           >
             ${compactIcon}
           </button>

package/web-dev-server.config.mjs

@@ -1,30 +1,30 @@
-// import { hmrPlugin, presets } from '@open-wc/dev-server-hmr';
-
-/** Use Hot Module replacement by adding --hmr to the start command */
-const hmr = process.argv.includes('--hmr');
-
-export default /** @type {import('@web/dev-server').DevServerConfig} */ ({
-  nodeResolve: true,
-  open: '/',
-  watch: !hmr,
-
-  /** Compile JS for older browsers. Requires @web/dev-server-esbuild plugin */
-  // esbuildTarget: 'auto'
-
-  /** Set appIndex to enable SPA routing */
-  // appIndex: 'demo/index.html',
-
-  /** Confgure bare import resolve plugin */
-  // nodeResolve: {
-  //   exportConditions: ['browser', 'development']
-  // },
-
-  plugins: [
-    /** Use Hot Module Replacement by uncommenting. Requires @open-wc/dev-server-hmr plugin */
-    // hmr && hmrPlugin({ exclude: ['**/*/node_modules/**/*'], presets: [presets.litElement] }),
-  ],
-
-  http2: true,
-  sslCert: './local.archive.org.cert',
-  sslKey: './local.archive.org.key',
-});
+// import { hmrPlugin, presets } from '@open-wc/dev-server-hmr';
+
+/** Use Hot Module replacement by adding --hmr to the start command */
+const hmr = process.argv.includes('--hmr');
+
+export default /** @type {import('@web/dev-server').DevServerConfig} */ ({
+  nodeResolve: true,
+  open: '/',
+  watch: !hmr,
+
+  /** Compile JS for older browsers. Requires @web/dev-server-esbuild plugin */
+  // esbuildTarget: 'auto'
+
+  /** Set appIndex to enable SPA routing */
+  // appIndex: 'demo/index.html',
+
+  /** Confgure bare import resolve plugin */
+  // nodeResolve: {
+  //   exportConditions: ['browser', 'development']
+  // },
+
+  plugins: [
+    /** Use Hot Module Replacement by uncommenting. Requires @open-wc/dev-server-hmr plugin */
+    // hmr && hmrPlugin({ exclude: ['**/*/node_modules/**/*'], presets: [presets.litElement] }),
+  ],
+
+  http2: true,
+  sslCert: './local.archive.org.cert',
+  sslKey: './local.archive.org.key',
+});

package/web-test-runner.config.mjs

@@ -1,41 +1,41 @@
-// import { playwrightLauncher } from '@web/test-runner-playwright';
-
-const filteredLogs = ['Running in dev mode', 'lit-html is in dev mode'];
-
-export default /** @type {import("@web/test-runner").TestRunnerConfig} */ ({
-  /** Test files to run */
-  files: 'dist/test/**/*.test.js',
-
-  /** Resolve bare module imports */
-  nodeResolve: {
-    exportConditions: ['browser', 'development'],
-  },
-
-  /** Filter out lit dev mode logs */
-  filterBrowserLogs(log) {
-    for (const arg of log.args) {
-      if (typeof arg === 'string' && filteredLogs.some(l => arg.includes(l))) {
-        return false;
-      }
-    }
-    return true;
-  },
-
-  /** Compile JS for older browsers. Requires @web/dev-server-esbuild plugin */
-  // esbuildTarget: 'auto',
-
-  /** Amount of browsers to run concurrently */
-  // concurrentBrowsers: 2,
-
-  /** Amount of test files per browser to test concurrently */
-  // concurrency: 1,
-
-  /** Browsers to run tests on */
-  // browsers: [
-  //   playwrightLauncher({ product: 'chromium' }),
-  //   playwrightLauncher({ product: 'firefox' }),
-  //   playwrightLauncher({ product: 'webkit' }),
-  // ],
-
-  // See documentation for all available options
-});
+// import { playwrightLauncher } from '@web/test-runner-playwright';
+
+const filteredLogs = ['Running in dev mode', 'lit-html is in dev mode'];
+
+export default /** @type {import("@web/test-runner").TestRunnerConfig} */ ({
+  /** Test files to run */
+  files: 'dist/test/**/*.test.js',
+
+  /** Resolve bare module imports */
+  nodeResolve: {
+    exportConditions: ['browser', 'development'],
+  },
+
+  /** Filter out lit dev mode logs */
+  filterBrowserLogs(log) {
+    for (const arg of log.args) {
+      if (typeof arg === 'string' && filteredLogs.some(l => arg.includes(l))) {
+        return false;
+      }
+    }
+    return true;
+  },
+
+  /** Compile JS for older browsers. Requires @web/dev-server-esbuild plugin */
+  // esbuildTarget: 'auto',
+
+  /** Amount of browsers to run concurrently */
+  // concurrentBrowsers: 2,
+
+  /** Amount of test files per browser to test concurrently */
+  // concurrency: 1,
+
+  /** Browsers to run tests on */
+  // browsers: [
+  //   playwrightLauncher({ product: 'chromium' }),
+  //   playwrightLauncher({ product: 'firefox' }),
+  //   playwrightLauncher({ product: 'webkit' }),
+  // ],
+
+  // See documentation for all available options
+});