@internetarchive/collection-browser 1.11.1-alpha.3 → 1.13.0-alpha1

package/test/empty-placeholder.test.ts

@@ -14,11 +14,9 @@ describe('Empty Placeholder', () => {
     el.placeholderType = 'empty-query';
     await el.updateComplete;
 
-    expect(el.shadowRoot?.querySelector('.empty-query')).to.exist;
-
-    expect(el.shadowRoot?.querySelector('.empty-collection')).to.not.exist;
-    expect(el.shadowRoot?.querySelector('.no-results')).to.not.exist;
-    expect(el.shadowRoot?.querySelector('.query-error')).to.not.exist;
+    const placeholderElem = el.shadowRoot?.querySelector('.placeholder');
+    expect(placeholderElem).to.exist;
+    expect(placeholderElem).to.have.class('empty-query');
   });
 
   it('should render with empty-collection placeholder', async () => {
@@ -29,11 +27,9 @@ describe('Empty Placeholder', () => {
     el.placeholderType = 'empty-collection';
     await el.updateComplete;
 
-    expect(el.shadowRoot?.querySelector('.empty-collection')).to.exist;
-
-    expect(el.shadowRoot?.querySelector('.no-results')).to.not.exist;
-    expect(el.shadowRoot?.querySelector('.empty-query')).to.not.exist;
-    expect(el.shadowRoot?.querySelector('.query-error')).to.not.exist;
+    const placeholderElem = el.shadowRoot?.querySelector('.placeholder');
+    expect(placeholderElem).to.exist;
+    expect(placeholderElem).to.have.class('empty-collection');
   });
 
   it('should render with no-results placeholder', async () => {
@@ -44,11 +40,9 @@ describe('Empty Placeholder', () => {
     el.placeholderType = 'no-results';
     await el.updateComplete;
 
-    expect(el.shadowRoot?.querySelector('.no-results')).to.exist;
-
-    expect(el.shadowRoot?.querySelector('.empty-query')).to.not.exist;
-    expect(el.shadowRoot?.querySelector('.empty-collection')).to.not.exist;
-    expect(el.shadowRoot?.querySelector('.query-error')).to.not.exist;
+    const placeholderElem = el.shadowRoot?.querySelector('.placeholder');
+    expect(placeholderElem).to.exist;
+    expect(placeholderElem).to.have.class('no-results');
   });
 
   it('should render with query-error placeholder', async () => {
@@ -59,11 +53,22 @@ describe('Empty Placeholder', () => {
     el.placeholderType = 'query-error';
     await el.updateComplete;
 
-    expect(el.shadowRoot?.querySelector('.query-error')).to.exist;
+    const placeholderElem = el.shadowRoot?.querySelector('.placeholder');
+    expect(placeholderElem).to.exist;
+    expect(placeholderElem).to.have.class('query-error');
+  });
 
-    expect(el.shadowRoot?.querySelector('.empty-query')).to.not.exist;
-    expect(el.shadowRoot?.querySelector('.empty-collection')).to.not.exist;
-    expect(el.shadowRoot?.querySelector('.no-results')).to.not.exist;
+  it('should render with collection-error placeholder', async () => {
+    const el = await fixture<EmptyPlaceholder>(
+      html`<empty-placeholder></empty-placeholder>`
+    );
+
+    el.placeholderType = 'collection-error';
+    await el.updateComplete;
+
+    const placeholderElem = el.shadowRoot?.querySelector('.placeholder');
+    expect(placeholderElem).to.exist;
+    expect(placeholderElem).to.have.class('collection-error');
   });
 
   it('should not render any empty placeholder', async () => {
@@ -74,9 +79,11 @@ describe('Empty Placeholder', () => {
     el.placeholderType = null;
     await el.updateComplete;
 
+    expect(el.shadowRoot?.querySelector('.placeholder')).to.not.exist;
     expect(el.shadowRoot?.querySelector('.empty-query')).to.not.exist;
     expect(el.shadowRoot?.querySelector('.empty-collection')).to.not.exist;
     expect(el.shadowRoot?.querySelector('.no-results')).to.not.exist;
     expect(el.shadowRoot?.querySelector('.query-error')).to.not.exist;
+    expect(el.shadowRoot?.querySelector('.collection-error')).to.not.exist;
   });
 });

package/test/mocks/mock-search-responses.ts

@@ -728,6 +728,52 @@ export const getMockSuccessWithDefaultFavSort: () => Result<
   },
 });
 
+export const getMockSuccessWithParentCollections: () => Result<
+  SearchResponse,
+  SearchServiceError
+> = () => ({
+  success: {
+    request: {
+      kind: 'hits',
+      clientParameters: {
+        user_query: 'parent-collections',
+        sort: [],
+      },
+      backendRequests: {
+        primary: {
+          kind: 'hits',
+          finalized_parameters: {
+            user_query: 'parent-collections',
+            sort: [],
+          },
+        },
+      },
+    },
+    rawResponse: {},
+    response: {
+      totalResults: 1,
+      returnedCount: 1,
+      results: [
+        new ItemHit({
+          fields: {
+            identifier: 'foo',
+            title: 'Foo',
+          },
+        }),
+      ],
+      collectionExtraInfo: {
+        public_metadata: {
+          collection: ['foo', 'bar'],
+        },
+      },
+    },
+    responseHeader: {
+      succeeded: true,
+      query_time: 0,
+    },
+  },
+});
+
 export const getMockErrorResult: () => Result<
   SearchResponse,
   SearchServiceError

package/test/mocks/mock-search-service.ts

@@ -25,6 +25,7 @@ import {
   getMockSuccessWithDefaultSort,
   getMockSuccessWithConciseDefaultSort,
   getMockSuccessWithDefaultFavSort,
+  getMockSuccessWithParentCollections,
 } from './mock-search-responses';
 
 const responses: Record<
@@ -45,6 +46,7 @@ const responses: Record<
   'default-sort': getMockSuccessWithDefaultSort,
   'default-sort-concise': getMockSuccessWithConciseDefaultSort,
   'fav-sort': getMockSuccessWithDefaultFavSort,
+  'parent-collections': getMockSuccessWithParentCollections,
   error: getMockErrorResult,
   malformed: getMockMalformedResult,
 };

package/tsconfig.json

@@ -1,21 +1,21 @@
-{
-  "compilerOptions": {
-    "target": "es2018",
-    "module": "esnext",
-    "moduleResolution": "node",
-    "noEmitOnError": true,
-    "lib": ["es2017", "dom"],
-    "strict": true,
-    "esModuleInterop": false,
-    "allowSyntheticDefaultImports": true,
-    "experimentalDecorators": true,
-    "importHelpers": true,
-    "outDir": "dist",
-    "sourceMap": true,
-    "inlineSources": true,
-    "rootDir": "./",
-    "declaration": true,
-    "importsNotUsedAsValues": "error"
-  },
-  "include": ["src", "test", "index.ts", "types"],
-}
+{
+  "compilerOptions": {
+    "target": "es2018",
+    "module": "esnext",
+    "moduleResolution": "node",
+    "noEmitOnError": true,
+    "lib": ["es2017", "dom"],
+    "strict": true,
+    "esModuleInterop": false,
+    "allowSyntheticDefaultImports": true,
+    "experimentalDecorators": true,
+    "importHelpers": true,
+    "outDir": "dist",
+    "sourceMap": true,
+    "inlineSources": true,
+    "rootDir": "./",
+    "declaration": true,
+    "importsNotUsedAsValues": "error"
+  },
+  "include": ["src", "test", "index.ts", "types"],
+}

package/web-dev-server.config.mjs

@@ -1,30 +1,30 @@
-// import { hmrPlugin, presets } from '@open-wc/dev-server-hmr';
-
-/** Use Hot Module replacement by adding --hmr to the start command */
-const hmr = process.argv.includes('--hmr');
-
-export default /** @type {import('@web/dev-server').DevServerConfig} */ ({
-  nodeResolve: true,
-  open: '/',
-  watch: !hmr,
-
-  /** Compile JS for older browsers. Requires @web/dev-server-esbuild plugin */
-  // esbuildTarget: 'auto'
-
-  /** Set appIndex to enable SPA routing */
-  // appIndex: 'demo/index.html',
-
-  /** Confgure bare import resolve plugin */
-  // nodeResolve: {
-  //   exportConditions: ['browser', 'development']
-  // },
-
-  plugins: [
-    /** Use Hot Module Replacement by uncommenting. Requires @open-wc/dev-server-hmr plugin */
-    // hmr && hmrPlugin({ exclude: ['**/*/node_modules/**/*'], presets: [presets.litElement] }),
-  ],
-
-  http2: true,
-  sslCert: './local.archive.org.cert',
-  sslKey: './local.archive.org.key',
-});
+// import { hmrPlugin, presets } from '@open-wc/dev-server-hmr';
+
+/** Use Hot Module replacement by adding --hmr to the start command */
+const hmr = process.argv.includes('--hmr');
+
+export default /** @type {import('@web/dev-server').DevServerConfig} */ ({
+  nodeResolve: true,
+  open: '/',
+  watch: !hmr,
+
+  /** Compile JS for older browsers. Requires @web/dev-server-esbuild plugin */
+  // esbuildTarget: 'auto'
+
+  /** Set appIndex to enable SPA routing */
+  // appIndex: 'demo/index.html',
+
+  /** Confgure bare import resolve plugin */
+  // nodeResolve: {
+  //   exportConditions: ['browser', 'development']
+  // },
+
+  plugins: [
+    /** Use Hot Module Replacement by uncommenting. Requires @open-wc/dev-server-hmr plugin */
+    // hmr && hmrPlugin({ exclude: ['**/*/node_modules/**/*'], presets: [presets.litElement] }),
+  ],
+
+  http2: true,
+  sslCert: './local.archive.org.cert',
+  sslKey: './local.archive.org.key',
+});

package/web-test-runner.config.mjs

@@ -1,41 +1,41 @@
-// import { playwrightLauncher } from '@web/test-runner-playwright';
-
-const filteredLogs = ['Running in dev mode', 'lit-html is in dev mode'];
-
-export default /** @type {import("@web/test-runner").TestRunnerConfig} */ ({
-  /** Test files to run */
-  files: 'dist/test/**/*.test.js',
-
-  /** Resolve bare module imports */
-  nodeResolve: {
-    exportConditions: ['browser', 'development'],
-  },
-
-  /** Filter out lit dev mode logs */
-  filterBrowserLogs(log) {
-    for (const arg of log.args) {
-      if (typeof arg === 'string' && filteredLogs.some(l => arg.includes(l))) {
-        return false;
-      }
-    }
-    return true;
-  },
-
-  /** Compile JS for older browsers. Requires @web/dev-server-esbuild plugin */
-  // esbuildTarget: 'auto',
-
-  /** Amount of browsers to run concurrently */
-  // concurrentBrowsers: 2,
-
-  /** Amount of test files per browser to test concurrently */
-  // concurrency: 1,
-
-  /** Browsers to run tests on */
-  // browsers: [
-  //   playwrightLauncher({ product: 'chromium' }),
-  //   playwrightLauncher({ product: 'firefox' }),
-  //   playwrightLauncher({ product: 'webkit' }),
-  // ],
-
-  // See documentation for all available options
-});
+// import { playwrightLauncher } from '@web/test-runner-playwright';
+
+const filteredLogs = ['Running in dev mode', 'lit-html is in dev mode'];
+
+export default /** @type {import("@web/test-runner").TestRunnerConfig} */ ({
+  /** Test files to run */
+  files: 'dist/test/**/*.test.js',
+
+  /** Resolve bare module imports */
+  nodeResolve: {
+    exportConditions: ['browser', 'development'],
+  },
+
+  /** Filter out lit dev mode logs */
+  filterBrowserLogs(log) {
+    for (const arg of log.args) {
+      if (typeof arg === 'string' && filteredLogs.some(l => arg.includes(l))) {
+        return false;
+      }
+    }
+    return true;
+  },
+
+  /** Compile JS for older browsers. Requires @web/dev-server-esbuild plugin */
+  // esbuildTarget: 'auto',
+
+  /** Amount of browsers to run concurrently */
+  // concurrentBrowsers: 2,
+
+  /** Amount of test files per browser to test concurrently */
+  // concurrency: 1,
+
+  /** Browsers to run tests on */
+  // browsers: [
+  //   playwrightLauncher({ product: 'chromium' }),
+  //   playwrightLauncher({ product: 'firefox' }),
+  //   playwrightLauncher({ product: 'webkit' }),
+  // ],
+
+  // See documentation for all available options
+});