@internetarchive/bookreader 5.0.0-93 → 5.0.0-95

package/tests/jest/BookNavigator/search/search-provider.test.js

@@ -1,6 +1,6 @@
 import { fixtureCleanup, fixtureSync } from '@open-wc/testing-helpers';
 import sinon from 'sinon';
-import searchProvider from '@/src/BookNavigator/search/search-provider';
+import searchProvider from '@/src/BookNavigator/search/search-provider.js';
 
 afterEach(() => {
   sinon.restore();
@@ -88,7 +88,7 @@ describe('Search Provider', () => {
         onProviderChange: sinon.fake(),
         bookreader: {
           leafNumToIndex: sinon.fake(),
-          _plugins: {
+          plugins: {
             search: {
               jumpToMatch: sinon.fake(),
             },
@@ -104,7 +104,7 @@ describe('Search Provider', () => {
           { detail: searchResultStub }),
       );
 
-      expect(provider.bookreader._plugins.search.jumpToMatch.callCount).toEqual(1);
+      expect(provider.bookreader.plugins.search.jumpToMatch.callCount).toEqual(1);
     });
     test('update url when search is cancelled or input cleared', async() => {
       const urlPluginMock = {
@@ -115,7 +115,7 @@ describe('Search Provider', () => {
         onProviderChange: sinon.fake(),
         bookreader: {
           leafNumToIndex: sinon.fake(),
-          _plugins: {
+          plugins: {
             search: {
               jumpToMatch: sinon.fake(),
             },
@@ -153,7 +153,7 @@ describe('Search Provider', () => {
         onProviderChange: sinon.fake(),
         bookreader: {
           leafNumToIndex: sinon.fake(),
-          _plugins: {
+          plugins: {
             search: {
               jumpToMatch: sinon.fake(),
             },

package/tests/jest/BookReader.test.js

@@ -39,35 +39,35 @@ test('has registered fullscreen toggle event', () => {
 });
 
 test('checks cookie when initParams called', () => {
-  br._plugins.resume.getResumeValue = jest.fn(() => 15);
+  br.plugins.resume.getResumeValue = jest.fn(() => 15);
   br.urlReadFragment = jest.fn(() => '');
 
   const params = br.initParams();
-  expect(br._plugins.resume.getResumeValue).toHaveBeenCalledTimes(1);
+  expect(br.plugins.resume.getResumeValue).toHaveBeenCalledTimes(1);
   expect(params.init).toBe(true);
   expect(params.index).toBe(15);
   expect(params.fragmentChange).toBe(true);
 });
 
 test('does not check cookie when initParams called', () => {
-  br._plugins.resume.getResumeValue = jest.fn(() => null);
+  br.plugins.resume.getResumeValue = jest.fn(() => null);
   br.urlReadFragment = jest.fn(() => '');
   br.options.plugins.resume.enabled = false;
 
   const params = br.initParams();
-  expect(br._plugins.resume.getResumeValue).toHaveBeenCalledTimes(0);
+  expect(br.plugins.resume.getResumeValue).toHaveBeenCalledTimes(0);
   expect(params.init).toBe(true);
   expect(params.index).toBe(0);
   expect(params.fragmentChange).toBe(false);
 });
 
 test('gets index from fragment when both fragment and cookie when InitParams called', () => {
-  br._plugins.resume.getResumeValue = jest.fn(() => 15);
+  br.plugins.resume.getResumeValue = jest.fn(() => 15);
   br.urlReadFragment = jest.fn(() => 'page/n4');
   br.options.plugins.resume.enabled = true;
 
   const params = br.initParams();
-  expect(br._plugins.resume.getResumeValue).toHaveBeenCalledTimes(1);
+  expect(br.plugins.resume.getResumeValue).toHaveBeenCalledTimes(1);
   expect(params.init).toBe(true);
   expect(params.index).toBe(4);
   expect(params.fragmentChange).toBe(true);
@@ -117,7 +117,7 @@ test('has added BR property: bookPath', () => {
 });
 
 test('has suppressFragmentChange true when init with no input', () => {
-  br._plugins.resume.getResumeValue = jest.fn(() => null);
+  br.plugins.resume.getResumeValue = jest.fn(() => null);
   br.urlReadFragment = jest.fn(() => '');
   br.urlReadHashFragment = jest.fn(() => '');
   br.switchMode = jest.fn();
@@ -128,7 +128,7 @@ test('has suppressFragmentChange true when init with no input', () => {
 });
 
 test('has suppressFragmentChange false when init with cookie', () => {
-  br._plugins.resume.getResumeValue = jest.fn(() => 5);
+  br.plugins.resume.getResumeValue = jest.fn(() => 5);
   br.urlReadFragment = jest.fn(() => '');
   br.switchMode = jest.fn();
 
@@ -138,7 +138,7 @@ test('has suppressFragmentChange false when init with cookie', () => {
 });
 
 test('has suppressFragmentChange false when init with fragment', () => {
-  br._plugins.resume.getResumeValue = jest.fn(() => null);
+  br.plugins.resume.getResumeValue = jest.fn(() => null);
   br.urlReadFragment = jest.fn(() => 'mode/1up');
   br.switchMode = jest.fn();
 
@@ -148,7 +148,7 @@ test('has suppressFragmentChange false when init with fragment', () => {
 });
 
 test('has suppressFragmentChange false when init with hash fragment', () => {
-  br._plugins.resume.getResumeValue = jest.fn(() => null);
+  br.plugins.resume.getResumeValue = jest.fn(() => null);
   br.urlReadFragment = jest.fn(() => '');
   br.urlReadHashFragment = jest.fn(() => 'mode/1up');
   br.switchMode = jest.fn();

package/tests/jest/plugins/plugin.autoplay.test.js

@@ -15,21 +15,21 @@ afterEach(() => {
 
 describe('Plugin: Menu Toggle', () => {
   test('autoplay does not start when BookReaderInitializes', () => {
-    br._plugins.autoplay.toggle = jest.fn();
+    br.plugins.autoplay.toggle = jest.fn();
     br.init();
-    expect(br._plugins.autoplay.toggle).toHaveBeenCalledTimes(0);
+    expect(br.plugins.autoplay.toggle).toHaveBeenCalledTimes(0);
   });
   test('autoplay will run without `flipSpeed` parameters', () => {
-    const initialTimer = br._plugins.autoplay.timer;
+    const initialTimer = br.plugins.autoplay.timer;
     br.next = jest.fn();
-    br._plugins.autoplay.stop = jest.fn();
+    br.plugins.autoplay.stop = jest.fn();
     br.init();
-    br._plugins.autoplay.toggle();
+    br.plugins.autoplay.toggle();
     // internally referenced functions that fire
     expect(br.next).toHaveBeenCalledTimes(1);
 
     expect(initialTimer).toBeFalsy();
     // timer changes when autoplay turns on
-    expect(br._plugins.autoplay.timer).toBeTruthy();
+    expect(br.plugins.autoplay.timer).toBeTruthy();
   });
 });

package/tests/jest/plugins/plugin.chapters.test.js

@@ -2,8 +2,8 @@ import sinon from "sinon";
 
 import "@/src/BookReader.js";
 import {ChaptersPlugin} from "@/src/plugins/plugin.chapters.js";
-import { BookModel } from "@/src/BookReader/BookModel";
-import { deepCopy } from "../utils";
+import { BookModel } from "@/src/BookReader/BookModel.js";
+import { deepCopy } from "../utils.js";
 /** @typedef {import('@/src/plugins/plugin.chapters').TocEntry} TocEntry  */
 
 /** @type {TocEntry[]} */

package/tests/jest/plugins/plugin.resume.test.js

@@ -29,9 +29,9 @@ describe('updateResumeValue', () => {
     In this branch .toHaveBeenCalledTimes() === 1
   */
   test.skip('starts when BookReaderInit is called', () => {
-    br._plugins.resume.updateResumeValue = jest.fn();
+    br.plugins.resume.updateResumeValue = jest.fn();
     br.init();
-    expect(br._plugins.resume.updateResumeValue).toHaveBeenCalledTimes(2);
+    expect(br.plugins.resume.updateResumeValue).toHaveBeenCalledTimes(2);
   });
 
   test('handles cookieName=null', () => {
@@ -48,38 +48,38 @@ describe('updateResumeValue', () => {
   test('handles cookiePath not set', () => {
     const setItemSpy = sinon.spy(docCookies, 'setItem');
     // Save function
-    const saveFn = br._plugins.resume.getCookiePath;
-    br._plugins.resume.getCookiePath = jest.fn(() => '/details/foo');
-    br._plugins.resume.updateResumeValue(16);
+    const saveFn = br.plugins.resume.getCookiePath;
+    br.plugins.resume.getCookiePath = jest.fn(() => '/details/foo');
+    br.plugins.resume.updateResumeValue(16);
     expect(setItemSpy.args[0][3]).toEqual('/details/foo');
     // Restore function
-    br._plugins.resume.getCookiePath = saveFn;
+    br.plugins.resume.getCookiePath = saveFn;
   });
 
   test('handles cookie path from URL with decoration', () => {
     const complexPathWithPage = '/details/2008ELMValidityStudyFinalReportRevised/Executive%20Summary%20for%20the%20EPT%26ELM%20Validity%20Studie_20100603%20-%20Copy/page/n1/mode/2up';
     const complexPath = '/details/2008ELMValidityStudyFinalReportRevised/Executive%20Summary%20for%20the%20EPT%26ELM%20Validity%20Studie_20100603%20-%20Copy';
-    expect(br._plugins.resume.getCookiePath(complexPathWithPage))
+    expect(br.plugins.resume.getCookiePath(complexPathWithPage))
       .toEqual(complexPath);
 
-    expect(br._plugins.resume.getCookiePath('/details/item/mode/1up'))
+    expect(br.plugins.resume.getCookiePath('/details/item/mode/1up'))
       .toEqual('/details/item');
 
-    expect(br._plugins.resume.getCookiePath('/details/item/inside/a/long/path/model/is/used'))
+    expect(br.plugins.resume.getCookiePath('/details/item/inside/a/long/path/model/is/used'))
       .toEqual('/details/item/inside/a/long/path/model/is/used');
 
-    expect(br._plugins.resume.getCookiePath('/details/item/inside/a/long/path/mode/is/used'))
+    expect(br.plugins.resume.getCookiePath('/details/item/inside/a/long/path/mode/is/used'))
       .toEqual('/details/item/inside/a/long/path');
   });
 
   test('handles cookie path from URL with no decoration', () => {
-    expect(br._plugins.resume.getCookiePath('/details/item'))
+    expect(br.plugins.resume.getCookiePath('/details/item'))
       .toEqual('/details/item');
 
-    expect(br._plugins.resume.getCookiePath('/details/item/'))
+    expect(br.plugins.resume.getCookiePath('/details/item/'))
       .toEqual('/details/item/');
 
-    expect(br._plugins.resume.getCookiePath('/details/item/almost/any/kind/of/long/path'))
+    expect(br.plugins.resume.getCookiePath('/details/item/almost/any/kind/of/long/path'))
       .toEqual('/details/item/almost/any/kind/of/long/path');
   });
 });

package/tests/jest/plugins/plugin.text_selection.test.js

@@ -3,14 +3,14 @@ import sinon from 'sinon';
 import BookReader from '@/src/BookReader.js';
 import {
   Cache,
+  genAt,
+  genFilter,
   genMap,
   lookAroundWindow,
+  walkBetweenNodes,
   zip,
 } from '@/src/plugins/plugin.text_selection.js';
 
-
-/** @type {BookReader} */
-
 // djvu.xml book infos copied from https://ia803103.us.archive.org/14/items/goodytwoshoes00newyiala/goodytwoshoes00newyiala_djvu.xml
 const FAKE_XML_1WORD = `
   <OBJECT data="file://localhost//tmp/derive/goodytwoshoes00newyiala//goodytwoshoes00newyiala.djvu" height="3192" type="image/x.djvu" usemap="goodytwoshoes00newyiala_0001.djvu" width="2454">
@@ -113,9 +113,56 @@ describe("Generic tests", () => {
     $('.BRtextLayer').remove();
   });
 
+  test("_limitSelection handles short selection", async () => {
+    const $container = br.refs.$brContainer;
+    br.options.plugins.textSelection.maxProtectedWords = 5;
+    sinon.stub(br.plugins.textSelection, "getPageText")
+      .returns($(new DOMParser().parseFromString(FAKE_XML_MULT_LINES, "text/xml")));
+    await br.plugins.textSelection.createTextLayer({ $container, page: { index: 3, width: 100, height: 100 }});
+
+    const rangeBefore = document.createRange();
+    rangeBefore.setStart($container.find(".BRwordElement")[0].firstChild, 0);
+    rangeBefore.setEnd($container.find(".BRwordElement")[4].firstChild, 1);
+    const selection = window.getSelection();
+    selection.removeAllRanges();
+    selection.addRange(rangeBefore);
+
+    br.plugins.textSelection._limitSelection();
+
+    const rangeAfter = window.getSelection().getRangeAt(0);
+    expect(rangeAfter.startContainer).toBe(rangeBefore.startContainer);
+    expect(rangeAfter.startOffset).toBe(0);
+    expect(rangeAfter.endContainer).toBe(rangeBefore.endContainer);
+    expect(rangeAfter.endOffset).toBe(1);
+
+    window.getSelection().removeAllRanges();
+  });
+
+  test("_limitSelection shrinks selection", async () => {
+    const $container = br.refs.$brContainer;
+    br.options.plugins.textSelection.maxProtectedWords = 5;
+    sinon.stub(br.plugins.textSelection, "getPageText")
+      .returns($(new DOMParser().parseFromString(FAKE_XML_MULT_LINES, "text/xml")));
+
+    await br.plugins.textSelection.createTextLayer({ $container, page: { index: 3, width: 100, height: 100 }});
+
+    const rangeBefore = document.createRange();
+    rangeBefore.setStart($container.find(".BRwordElement")[0].firstChild, 0);
+    rangeBefore.setEnd($container.find(".BRwordElement")[12].firstChild, 1);
+    const selection = window.getSelection();
+    selection.removeAllRanges();
+    selection.addRange(rangeBefore);
+
+    br.plugins.textSelection._limitSelection();
+
+    const rangeAfter = window.getSelection().getRangeAt(0);
+    expect(rangeAfter.startContainer).toBe(rangeBefore.startContainer);
+    expect(rangeAfter.endContainer).toBe($container.find(".BRwordElement")[4].firstChild);
+  });
+
   test("_createPageContainer overridden function still creates a BRpagecontainer element", () => {
-    const spy = sinon.spy(br._plugins.textSelection, 'createTextLayer');
-    sinon.stub(br._plugins.textSelection, "getPageText")
+    const spy = sinon.spy(br.plugins.textSelection, 'createTextLayer');
+    sinon.stub(br.plugins.textSelection, "getPageText")
       .returns($(new DOMParser().parseFromString(FAKE_XML_1WORD, "text/xml")));
     const container = br._createPageContainer(1, {});
     expect(container).toBeTruthy();
@@ -124,24 +171,24 @@ describe("Generic tests", () => {
 
   // test loading first object from sample data
   test("_createPageContainer handles index 0", () => {
-    const spy = sinon.spy(br._plugins.textSelection, 'createTextLayer');
+    const spy = sinon.spy(br.plugins.textSelection, 'createTextLayer');
     br._createPageContainer(0, {});
     expect(spy.callCount).toBe(1);
   });
 
   // test loading last object from sample data
   test("_createPageContainer handles index -1", () => {
-    const spy = sinon.spy(br._plugins.textSelection, 'createTextLayer');
+    const spy = sinon.spy(br.plugins.textSelection, 'createTextLayer');
     br._createPageContainer(-1, {});
     expect(spy.callCount).toBe(0);
   });
 
   test("createTextLayer will render the last page and create text layer properly", async () => {
     const $container = br.refs.$brContainer;
-    sinon.stub(br._plugins.textSelection, "getPageText")
+    sinon.stub(br.plugins.textSelection, "getPageText")
       .returns($(new DOMParser().parseFromString(FAKE_XML_1WORD, "text/xml")));
     const pageIndex = br.data.length - 1;
-    await br._plugins.textSelection.createTextLayer({ $container, page: { index: pageIndex, width: 100, height: 100 }});
+    await br.plugins.textSelection.createTextLayer({ $container, page: { index: pageIndex, width: 100, height: 100 }});
     expect($container.find(".BRtextLayer").length).toBe(1);
     expect($container.find("p").length).toBe(1);
   });
@@ -149,9 +196,9 @@ describe("Generic tests", () => {
   test("createTextLayer will not create text layer if there are too many words", async () => {
     const $container = br.refs.$brContainer;
     const xml = FAKE_XML_1WORD.replace(/<WORD.*<\/WORD>/, FAKE_XML_1WORD.match(/<WORD.*<\/WORD>/)[0].repeat(3000));
-    sinon.stub(br._plugins.textSelection, "getPageText")
+    sinon.stub(br.plugins.textSelection, "getPageText")
       .returns($(new DOMParser().parseFromString(xml, "text/xml")));
-    await br._plugins.textSelection.createTextLayer({ $container, page: { index: 0, width: 100, height: 100 }});
+    await br.plugins.textSelection.createTextLayer({ $container, page: { index: 0, width: 100, height: 100 }});
     expect($container.find(".BRtextLayer").length).toBe(0);
     expect($container.find("p").length).toBe(0);
     expect($container.find(".BRwordElement").length).toBe(0);
@@ -159,9 +206,9 @@ describe("Generic tests", () => {
 
   test("createTextLayer creates text layer with paragraph with 1 word element", async () => {
     const $container = br.refs.$brContainer;
-    sinon.stub(br._plugins.textSelection, "getPageText")
+    sinon.stub(br.plugins.textSelection, "getPageText")
       .returns($(new DOMParser().parseFromString(FAKE_XML_1WORD, "text/xml")));
-    await br._plugins.textSelection.createTextLayer({ $container, page: { index: 1, width: 100, height: 100 }});
+    await br.plugins.textSelection.createTextLayer({ $container, page: { index: 1, width: 100, height: 100 }});
     expect($container.find(".BRtextLayer").length).toBe(1);
     expect($container.find("p").length).toBe(1);
     expect($container.find(".BRwordElement").length).toBe(1);
@@ -170,9 +217,9 @@ describe("Generic tests", () => {
 
   test("createTextLayer creates text layer with paragraph with multiple word elements", async () => {
     const $container = br.refs.$brContainer;
-    sinon.stub(br._plugins.textSelection, "getPageText")
+    sinon.stub(br.plugins.textSelection, "getPageText")
       .returns($(new DOMParser().parseFromString(FAKE_XML_MULT_WORDS, "text/xml")));
-    await br._plugins.textSelection.createTextLayer({ $container, page: { index: 2, width: 100, height: 100 }});
+    await br.plugins.textSelection.createTextLayer({ $container, page: { index: 2, width: 100, height: 100 }});
     expect($container.find(".BRtextLayer").length).toBe(1);
     expect($container.find("p").length).toBe(1);
     expect($container.find(".BRwordElement").length).toBe(3);
@@ -181,9 +228,9 @@ describe("Generic tests", () => {
 
   test("createTextLayer creates text layer with paragraph with word with 5 params coordinates", async () => {
     const $container = br.refs.$brContainer;
-    sinon.stub(br._plugins.textSelection, "getPageText")
+    sinon.stub(br.plugins.textSelection, "getPageText")
       .returns($(new DOMParser().parseFromString(FAKE_XML_5COORDS, "text/xml")));
-    await br._plugins.textSelection.createTextLayer({ $container, page: { index: 3, width: 100, height: 100 }});
+    await br.plugins.textSelection.createTextLayer({ $container, page: { index: 3, width: 100, height: 100 }});
     expect($container.find(".BRtextLayer").length).toBe(1);
     expect($container.find("p").length).toBe(1);
     expect($container.find(".BRwordElement").length).toBe(1);
@@ -191,9 +238,9 @@ describe("Generic tests", () => {
 
   test("createTextLayer handles multiple lines", async () => {
     const $container = br.refs.$brContainer;
-    sinon.stub(br._plugins.textSelection, "getPageText")
+    sinon.stub(br.plugins.textSelection, "getPageText")
       .returns($(new DOMParser().parseFromString(FAKE_XML_MULT_LINES, "text/xml")));
-    await br._plugins.textSelection.createTextLayer({ $container, page: { index: 3, width: 100, height: 100 }});
+    await br.plugins.textSelection.createTextLayer({ $container, page: { index: 3, width: 100, height: 100 }});
     expect($container.find(".BRtextLayer").length).toBe(1);
     expect($container.find("p").length).toBe(1);
     expect($container.find(".BRlineElement").length).toBe(3);
@@ -206,9 +253,9 @@ describe("Generic tests", () => {
 
   test("createTextLayer repairs trailing hyphens", async () => {
     const $container = br.refs.$brContainer;
-    sinon.stub(br._plugins.textSelection, "getPageText")
+    sinon.stub(br.plugins.textSelection, "getPageText")
       .returns($(new DOMParser().parseFromString(FAKE_XML_MULT_LINES, "text/xml")));
-    await br._plugins.textSelection.createTextLayer({ $container, page: { index: 3, width: 100, height: 100 }});
+    await br.plugins.textSelection.createTextLayer({ $container, page: { index: 3, width: 100, height: 100 }});
 
     expect($container.find(".BRwordElement--hyphen").length).toBe(1);
     expect($container.find(".BRwordElement--hyphen").closest(".BRlineElement").text().endsWith(' ')).toBe(false);
@@ -217,9 +264,9 @@ describe("Generic tests", () => {
 
   test("createTextLayer can handle empty xml", async () => {
     const $container = br.refs.$brContainer;
-    sinon.stub(br._plugins.textSelection, "getPageText")
+    sinon.stub(br.plugins.textSelection, "getPageText")
       .returns($(new DOMParser().parseFromString(FAKE_XML_EMPTY, "text/xml")));
-    await br._plugins.textSelection.createTextLayer({ $container, page: { index: 4, width: 100, height: 100 }});
+    await br.plugins.textSelection.createTextLayer({ $container, page: { index: 4, width: 100, height: 100 }});
     expect($container.find(".BRtextLayer").length).toBe(1);
     expect($container.find("p").length).toBe(0);
     expect($container.find(".BRwordElement").length).toBe(0);
@@ -228,7 +275,7 @@ describe("Generic tests", () => {
   const LONG_PRESS_DURATION = 500;
   test("calling stopPageFlip does not allow long click to flip the page", () => {
     const $container = br.refs.$brContainer;
-    br._plugins.textSelection.stopPageFlip($container);
+    br.plugins.textSelection.stopPageFlip($container);
     const currIndex = br.currentIndex();
     $container.find("BRwordElement").trigger("mousedown");
     // Waits for long press
@@ -270,6 +317,38 @@ describe("Cache", () => {
   });
 });
 
+describe('genAt', () => {
+  test('handles empty', () => {
+    expect(genAt(genRange(-1), 0)).toBeUndefined();
+  });
+
+  test('handles non-empty', () => {
+    expect(genAt(genRange(3), 0)).toBe(0);
+    expect(genAt(genRange(3), 1)).toBe(1);
+    expect(genAt(genRange(3), 2)).toBe(2);
+  });
+
+  test('handles out of bounds', () => {
+    expect(genAt(genRange(3), 4)).toBeUndefined();
+    expect(genAt(genRange(3), -1)).toBeUndefined();
+  });
+});
+
+describe('genFilter', () => {
+  test('handles empty', () => {
+    expect(Array.from(genFilter(genRange(0), x => x > 0))).toEqual([]);
+  });
+
+  test('handles non-empty', () => {
+    expect(Array.from(genFilter(genRange(3), x => x > 1))).toEqual([2, 3]);
+    expect(Array.from(genFilter(genRange(3), x => x < 1))).toEqual([0]);
+  });
+
+  test('handles all false', () => {
+    expect(Array.from(genFilter(genRange(3), x => x > 3))).toEqual([]);
+  });
+});
+
 describe('genMap', () => {
   test('handles empty', () => {
     expect(Array.from(genMap([], x => x ** 2))).toEqual([]);
@@ -314,3 +393,55 @@ describe('zip', () => {
     expect(Array.from(zip([1, 2], [3, 4]))).toEqual([[1, 3], [2, 4]]);
   });
 });
+
+describe('walkBetweenNodes', () => {
+  const tree = $(FAKE_XML_MULT_LINES);
+
+  test('handles empty', () => {
+    const result = Array.from(walkBetweenNodes(tree[0], tree[0]));
+    expect(result).toHaveLength(1);
+    expect(result[0]).toBe(tree[0]);
+  });
+
+  test('Words on same line', () => {
+    const start = tree.find('WORD')[2];
+    const end = start.nextElementSibling;
+    // Use first child so we hit the text nodes
+    const result = Array.from(walkBetweenNodes(start.firstChild, end.firstChild));
+    expect(result).toHaveLength(5);
+    expect(result[0].nodeType).toBe(Node.TEXT_NODE);
+    expect(result[0].textContent).toBe('false ');
+    expect(result[1]).toBe(start);
+    // Whitespace
+    expect(result[2].nodeType).toBe(Node.TEXT_NODE);
+    expect(result[2].textContent).toMatch(/^\s*$/);
+    expect(result[3]).toBe(end);
+    expect(result[4].nodeType).toBe(Node.TEXT_NODE);
+    expect(result[4].textContent).toBe('judgment ');
+  });
+
+  test('Words on different lines', () => {
+    const start = tree.find('WORD')[2];
+    const end = tree.find('WORD')[19];
+    const result = Array.from(walkBetweenNodes(start.firstChild, end.firstChild));
+    // Expect two LINES in result
+    expect(result.filter(x => x.nodeName == 'LINE')).toHaveLength(2);
+    // Expect 18 WORDs in result
+    expect(result.filter(x => x.nodeName == 'WORD')).toHaveLength(18);
+    // First word should be the start word
+    expect(result[0].parentElement).toBe(start);
+    expect(result[0].textContent).toBe('false ');
+    // Last word should be the end word
+    expect(result[result.length - 1].parentElement).toBe(end);
+    expect(result[result.length - 1].textContent).toBe('Suppose');
+  });
+});
+
+/**
+ * @param {number} n
+ */
+function* genRange(n) {
+  for (let i = 0; i <= n; i++) {
+    yield i;
+  }
+}

package/tests/jest/plugins/search/plugin.search.test.js

@@ -31,7 +31,7 @@ beforeEach(() => {
   });
   br.initToolbar = jest.fn();
   br.showProgressPopup = jest.fn();
-  br._plugins.search.searchXHR = jest.fn();
+  br.plugins.search.searchXHR = jest.fn();
 });
 
 afterEach(() => {
@@ -45,18 +45,18 @@ describe('Plugin: Search', () => {
   });
 
   test('Constructs SearchView', () => {
-    expect(br._plugins.search.searchView).toBeDefined();
+    expect(br.plugins.search.searchView).toBeDefined();
   });
 
   test('On init, it will run a search if given `options.initialSearchTerm`', () => {
-    br._plugins.search.search = jest.fn();
+    br.plugins.search.search = jest.fn();
     br.options.plugins.search.initialSearchTerm = 'foo';
     br.init();
 
-    expect(br._plugins.search.search).toHaveBeenCalled();
-    expect(br._plugins.search.search.mock.calls[0][1])
+    expect(br.plugins.search.search).toHaveBeenCalled();
+    expect(br.plugins.search.search.mock.calls[0][1])
       .toHaveProperty('goToFirstResult', true);
-    expect(br._plugins.search.search.mock.calls[0][1])
+    expect(br.plugins.search.search.mock.calls[0][1])
       .toHaveProperty('suppressFragmentChange', false);
   });
 
@@ -75,7 +75,7 @@ describe('Plugin: Search', () => {
   test('SearchStarted event fires and should go to first result', () => {
     br.init();
     br.search('foo', { goToFirstResult: true});
-    expect(br._plugins.search.options.goToFirstResult).toBeTruthy();
+    expect(br.plugins.search.options.goToFirstResult).toBeTruthy();
   });
 
   test('SearchCallback event fires when AJAX search returns results', async () => {

package/tests/jest/plugins/search/plugin.search.view.test.js

@@ -78,16 +78,16 @@ describe('View: Plugin: Search', () => {
       const event = new CustomEvent(`${namespace}SearchCallback`);
       const options = { goToFirstResult: false };
 
-      expect(br._plugins.search.searchView.dom.searchNavigation).toBeUndefined();
+      expect(br.plugins.search.searchView.dom.searchNavigation).toBeUndefined();
 
-      br._plugins.search.searchView.handleSearchCallback(event, { results, options});
-      expect(br._plugins.search.searchView.dom.searchNavigation).toBeDefined();
+      br.plugins.search.searchView.handleSearchCallback(event, { results, options});
+      expect(br.plugins.search.searchView.dom.searchNavigation).toBeDefined();
     });
     test('has controls', () => {
       br.init();
       const event = new CustomEvent(`${namespace}SearchCallback`);
       const options = { goToFirstResult: false };
-      br._plugins.search.searchView.handleSearchCallback(event, { results, options});
+      br.plugins.search.searchView.handleSearchCallback(event, { results, options});
 
       const searchResultsNav = document.querySelector('.BRsearch-navigation');
       expect(searchResultsNav).toBeDefined();
@@ -102,9 +102,9 @@ describe('View: Plugin: Search', () => {
       br.init();
       const event = new CustomEvent(`${namespace}SearchCallback`);
       const options = { goToFirstResult: false };
-      br._plugins.search.searchView.handleSearchCallback(event, { results: resultWithScript, options });
+      br.plugins.search.searchView.handleSearchCallback(event, { results: resultWithScript, options });
 
-      expect(br._plugins.search.searchView.dom.searchNavigation.parent().html()).not.toContain('<script>alert(1);</script>');
+      expect(br.plugins.search.searchView.dom.searchNavigation.parent().html()).not.toContain('<script>alert(1);</script>');
     });
 
     describe('Click events handlers', () => {
@@ -114,7 +114,7 @@ describe('View: Plugin: Search', () => {
         br.trigger = (eventName) => eventNameTriggered = eventName;
 
         expect(eventNameTriggered).toBeFalsy();
-        br._plugins.search.searchView.toggleSidebar();
+        br.plugins.search.searchView.toggleSidebar();
         expect(eventNameTriggered).toEqual('ToggleSearchMenu');
       });
       it('triggers custom event when closing navbar', () => {
@@ -123,7 +123,7 @@ describe('View: Plugin: Search', () => {
         br.trigger = (eventName) => eventNameTriggered = eventName;
 
         expect(eventNameTriggered).toBeFalsy();
-        br._plugins.search.searchView.clearSearchFieldAndResults();
+        br.plugins.search.searchView.clearSearchFieldAndResults();
         expect(eventNameTriggered).toEqual('SearchResultsCleared');
       });
     });

package/tests/jest/plugins/search/utils.js

@@ -1,4 +1,4 @@
-import { marshallSearchResults } from "@/src/plugins/search/utils";
+import { marshallSearchResults } from "@/src/plugins/search/utils.js";
 
 export const DUMMY_RESULTS = {
   ia: "adventuresofoli00dick",

package/tests/jest/plugins/tts/PageChunkIterator.test.js

@@ -1,6 +1,6 @@
 import sinon from 'sinon';
-import PageChunkIterator from "@/src/plugins/tts/PageChunkIterator";
-import PageChunk from '@/src/plugins/tts/PageChunk';
+import PageChunkIterator from "@/src/plugins/tts/PageChunkIterator.js";
+import PageChunk from '@/src/plugins/tts/PageChunk.js';
 
 describe('Buffers pages', () => {
   test('Does not error if no room for reverse buffer', async () => {

package/tests/jest/plugins/url/UrlPlugin.test.js

@@ -1,4 +1,4 @@
-import { UrlPlugin } from '@/src/plugins/url/UrlPlugin';
+import { UrlPlugin } from '@/src/plugins/url/UrlPlugin.js';
 
 afterEach(() => {
   jest.clearAllMocks();