@internetarchive/bookreader 5.0.0-82 → 5.0.0-83

package/BookReaderDemo/demo-iiif.html

@@ -5,7 +5,7 @@
     <meta name="apple-mobile-web-app-capable" content="yes">
 
     <!-- WC dependencies -->
-    <script type="text/javascript" src="https://polyfill.io/v3/polyfill.min.js?features=es2015%2Ces5%2CglobalThis"></script>
+    <script type="text/javascript" src="https://cdnjs.cloudflare.com/polyfill/v3/polyfill.min.js?features=es2015%2Ces5%2CglobalThis"></script>
     <script type="text/javascript" src="https://unpkg.com/lit@2.1.2/polyfill-support.js"></script>
     <script type="text/javascript" src="https://unpkg.com/@webcomponents/webcomponentsjs@2.2.10/webcomponents-bundle.js"></script>
 

package/BookReaderDemo/demo-internetarchive.html

@@ -8,7 +8,7 @@
     <meta name="apple-mobile-web-app-capable" content="yes">
 
     <!-- WC dependencies -->
-    <script type="text/javascript" src="https://polyfill.io/v3/polyfill.min.js?features=es2015%2Ces5%2CglobalThis"></script>
+    <script type="text/javascript" src="https://cdnjs.cloudflare.com/polyfill/v3/polyfill.min.js?features=es2015%2Ces5%2CglobalThis"></script>
     <script type="text/javascript" src="https://unpkg.com/lit@2.1.2/polyfill-support.js"></script>
     <script type="text/javascript" src="https://unpkg.com/@webcomponents/webcomponentsjs@2.2.10/webcomponents-bundle.js"></script>
 

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+# 5.0.0-83
+- Fix: Fix typo in search-results.js @sahalbelam
+- Dev: Bump cache action to v4 @williamtheaker
+- Fix: Fix toolbar requiring SearchView.init having already been called @cdrini
+- Dev: Replace deprecated codecov npm package with github action @cdrini
+- Dev: Add eslint trailing comma rule @cdrini
+- Fix: Fix IIIF plugin missing last page + error when metadata unspecified @glorieux-f
+- Fix: Remove polyfill.io from demo files @cdrini
+- Dev: Update build dependencies @cdrini
+- Dev: Update some dev deps @cdrini
+- Fix: Switch to new Thorium URL @rebecca-shoptaw
+
 # 5.0.0-82
 - Feature: New option to control unviewable page image: `unviewablePageURI` @cdrini
 

package/babel.config.js

@@ -6,15 +6,15 @@ module.exports = {
         process.env.NODE_ENV == "development" ? { targets: "last 2 Chrome versions, last 2 Firefox versions, last 2 Safari versions, last 2 Edge versions" } : {
           targets: "> 2%, ie 11, edge 14, samsung > 9, OperaMini all, UCAndroid > 12, Safari >= 9",
           useBuiltIns: "usage",
-          corejs: 3
-        }
-    ]
+          corejs: 3,
+        },
+    ],
   ],
   plugins: [
     ["@babel/plugin-proposal-decorators", {
       version: "2018-09",
-      decoratorsBeforeExport: true
+      decoratorsBeforeExport: true,
     }],
     ["@babel/plugin-proposal-class-properties"],
-  ]
+  ],
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@internetarchive/bookreader",
-  "version": "5.0.0-82",
+  "version": "5.0.0-83",
   "description": "The Internet Archive BookReader.",
   "repository": {
     "type": "git",
@@ -40,21 +40,20 @@
     "lit": "^2.5.0"
   },
   "devDependencies": {
-    "@babel/core": "7.24.7",
-    "@babel/eslint-parser": "7.24.7",
+    "@babel/core": "7.25.8",
+    "@babel/eslint-parser": "7.25.7",
     "@babel/plugin-proposal-class-properties": "7.18.6",
-    "@babel/plugin-proposal-decorators": "7.24.7",
-    "@babel/preset-env": "7.24.7",
+    "@babel/plugin-proposal-decorators": "7.25.7",
+    "@babel/preset-env": "7.25.8",
     "@iiif/presentation-2": "^1.0.4",
     "@iiif/presentation-3": "^2.1.3",
     "@open-wc/testing-helpers": "3.0.1",
-    "@types/jest": "29.5.12",
+    "@types/jest": "29.5.13",
     "@webcomponents/webcomponentsjs": "^2.6.0",
-    "babel-loader": "9.1.3",
-    "codecov": "^3.8.3",
-    "concurrently": "8.2.2",
-    "core-js": "3.37.1",
-    "cpx2": "4.2.3",
+    "babel-loader": "9.2.1",
+    "concurrently": "9.0.1",
+    "core-js": "3.38.1",
+    "cpx2": "8.0.0",
     "eslint": "^7.32.0",
     "eslint-plugin-no-jquery": "^2.7.0",
     "eslint-plugin-testcafe": "^0.2.1",
@@ -70,13 +69,13 @@
     "jquery.browser": "0.1.0",
     "live-server": "1.2.2",
     "regenerator-runtime": "0.14.1",
-    "sass": "1.77.6",
-    "sinon": "18.0.0",
+    "sass": "1.79.5",
+    "sinon": "19.0.2",
     "soundmanager2": "2.97.20170602",
     "svgo": "3.3.2",
-    "testcafe": "3.6.1",
+    "testcafe": "3.6.2",
     "testcafe-browser-provider-browserstack": "^1.13.2-alpha.1",
-    "webpack": "5.92.0",
+    "webpack": "5.95.0",
     "webpack-cli": "5.1.4"
   },
   "jest": {
@@ -118,9 +117,8 @@
     "test:e2e": "npm run build && npx testcafe",
     "test:e2e:dev": "npx testcafe --live --dev",
     "DOCS:update:test-deps": "If CI succeeds, these should be good to update",
-    "update:test-deps": "npm i @babel/eslint-parser@latest @open-wc/testing-helpers@latest @types/jest@latest codecov@latest eslint@7 eslint-plugin-testcafe@latest jest@latest sinon@latest testcafe@latest",
+    "update:test-deps": "npm i @babel/eslint-parser@latest @open-wc/testing-helpers@latest @types/jest@latest eslint@7 eslint-plugin-testcafe@latest jest@latest sinon@latest testcafe@latest",
     "DOCS:update:build-deps": "These can cause strange changes, so do an npm run build + check file size (git diff --stat), and check the site is as expected",
-    "update:build-deps": "npm i @babel/core@latest @babel/preset-env@latest @babel/plugin-proposal-class-properties@latest @babel/plugin-proposal-decorators@latest babel-loader@latest core-js@latest regenerator-runtime@latest sass@latest svgo@latest webpack@latest webpack-cli@latest",
-    "codecov": "npx codecov"
+    "update:build-deps": "npm i @babel/core@latest @babel/preset-env@latest @babel/plugin-proposal-class-properties@latest @babel/plugin-proposal-decorators@latest babel-loader@latest core-js@latest regenerator-runtime@latest sass@latest svgo@latest webpack@latest webpack-cli@latest"
   }
 }

package/renovate.json

@@ -9,7 +9,7 @@
         "@babel/eslint-parser",
         "@open-wc/testing-helpers",
         "@types/jest",
-        "codecov",
+        "codecov/codecov-action",
         "eslint",
         "eslint-plugin-no-jquery",
         "eslint-plugin-testcafe",

package/src/BookNavigator/book-navigator.js

@@ -71,14 +71,14 @@ export class BookNavigator extends LitElement {
       'volumes',
       'chapters',
       'search',
-      'bookmarks'
+      'bookmarks',
     ];
   }
 
   disconnectedCallback() {
     this.sharedObserver.removeObserver({
       target: this.mainBRContainer,
-      handler: this.sharedObserverHandler
+      handler: this.sharedObserverHandler,
     });
   }
 
@@ -148,7 +148,7 @@ export class BookNavigator extends LitElement {
       item: this.itemMD,
       signedIn: this.signedIn,
       isAdmin: this.isAdmin,
-      onProviderChange: () => {}
+      onProviderChange: () => {},
     };
   }
 
@@ -220,7 +220,7 @@ export class BookNavigator extends LitElement {
           const method = Object.keys(bookmarks).length ? 'add' : 'remove';
           this[`${method}MenuShortcut`]('bookmarks');
           this.updateMenuContents();
-        }
+        },
       });
     }
 
@@ -240,7 +240,7 @@ export class BookNavigator extends LitElement {
               this.updateSideMenu('volumes', 'open');
             });
           }
-        }
+        },
       });
     }
 
@@ -311,7 +311,7 @@ export class BookNavigator extends LitElement {
    */
   updateMenuContents() {
     const {
-      search, downloads, visualAdjustments, share, bookmarks, volumes, chapters
+      search, downloads, visualAdjustments, share, bookmarks, volumes, chapters,
     } = this.menuProviders;
     const availableMenus = [volumes, chapters, search, bookmarks, visualAdjustments, share].filter((menu) => !!menu);
 
@@ -460,7 +460,7 @@ export class BookNavigator extends LitElement {
     window.archive_analytics?.send_event(
       'BookReader',
       `contextmenu-${this.bookIsRestricted ? 'restricted' : 'unrestricted'}`,
-      e.target?.classList?.value
+      e.target?.classList?.value,
     );
     if (!this.bookIsRestricted) {
       return;
@@ -479,7 +479,7 @@ export class BookNavigator extends LitElement {
     this.sharedObserverHandler = { handleResize: this.handleResize.bind(this) };
     this.sharedObserver?.addObserver({
       target: this.mainBRContainer,
-      handler: this.sharedObserverHandler
+      handler: this.sharedObserverHandler,
     });
   }
 

package/src/BookNavigator/bookmarks/bookmarks-loginCTA.js

@@ -4,7 +4,7 @@ import buttonStyles from '../assets/button-base.js';
 class BookmarksLogin extends LitElement {
   static get properties() {
     return {
-      url: { type: String }
+      url: { type: String },
     };
   }
 

package/src/BookNavigator/bookmarks/bookmarks-provider.js

@@ -27,7 +27,7 @@ export default class BookmarksProvider {
     this.component.modal = modal;
     this.component.loginOptions = {
       loginClicked: this.bookmarksLoginClicked,
-      loginUrl
+      loginUrl,
     };
     this.bindEvents();
 

package/src/BookNavigator/bookmarks/ia-bookmarks.js

@@ -62,7 +62,7 @@ class IABookmarks extends LitElement {
       editedBookmark: { type: Object },
       deleteModalConfig: { type: Object},
       modal: { attribute: false },
-      loginOptions: { type: Object, attribute: false }
+      loginOptions: { type: Object, attribute: false },
     };
   }
 

package/src/BookNavigator/downloads/downloads.js

@@ -75,7 +75,7 @@ export class IABookDownloads extends LitElement {
     <ul>
       <li><a href="https://librarysimplified.org/simplye/" rel="noopener noreferrer nofollow" target="_blank">Install SimplyE</a></li>
       <li><a href="https://www.demarque.com/en-aldiko" rel="noopener noreferrer nofollow" target="_blank">Install Aldiko</a></li>
-      <li><a href="https://www.edrlab.org/software/thorium-reader/" rel="noopener noreferrer nofollow" target="_blank">Install Thorium</a></li>
+      <li><a href="https://thorium.edrlab.org/" rel="noopener noreferrer nofollow" target="_blank">Install Thorium</a></li>
     </ul>
   `;
   }

package/src/BookNavigator/search/search-provider.js

@@ -13,7 +13,7 @@ let searchState = {
 export default class SearchProvider {
   constructor({
     onProviderChange,
-    bookreader
+    bookreader,
   }) {
     /* search menu events */
     this.onBookSearchInitiated = this.onBookSearchInitiated.bind(this);
@@ -72,7 +72,7 @@ export default class SearchProvider {
       errorMessage: '',
     };
     const updateMenuFor = {
-      searchCanceled: true
+      searchCanceled: true,
     };
     this.updateMenu(updateMenuFor);
 

package/src/BookNavigator/search/search-results.js

@@ -28,7 +28,7 @@ export class IABookSearchResults extends LitElement {
     this.query = '';
     this.queryInProgress = false;
     this.renderHeader = false;
-    this.renderSearchAllFields = false;
+    this.renderSearchAllFiles = false;
     this.displayResultImages = false;
     this.errorMessage = '';
 

package/src/BookNavigator/sharing.js

@@ -6,7 +6,7 @@ export default class SharingProvider {
   constructor({
     item,
     baseHost,
-    bookreader
+    bookreader,
   }) {
     const { identifier, creator, title } = item?.metadata;
     const creatorToUse = Array.isArray(creator) ? creator[0] : creator;

package/src/BookNavigator/viewable-files.js

@@ -9,7 +9,7 @@ import '@internetarchive/ia-item-navigator/dist/src/menus/viewable-files';
 const sortTypes = {
   title_asc: 'title_asc',
   title_desc: 'title_desc',
-  default: 'default'
+  default: 'default',
 };
 export default class ViewableFilesProvider {
   /**

package/src/BookNavigator/visual-adjustments/visual-adjustments.js

@@ -43,7 +43,7 @@ export class IABookVisualAdjustments extends LitElement {
   get activeOptions() {
     return this.options.reduce(
       (results, option) => (option.active ? [...results, option.id] : results),
-      []
+      [],
     );
   }
 
@@ -71,7 +71,7 @@ export class IABookVisualAdjustments extends LitElement {
         bubbles: true,
         composed: true,
         detail,
-      })
+      }),
     );
   }
 
@@ -93,7 +93,7 @@ export class IABookVisualAdjustments extends LitElement {
   changeActiveStateFor(optionName) {
     const updatedOptions = [...this.options];
     const checkedOption = updatedOptions.find(
-      (option) => option.id === optionName
+      (option) => option.id === optionName,
     );
     checkedOption.active = !checkedOption.active;
     this.options = updatedOptions;

package/src/BookReader/BookModel.js

@@ -45,7 +45,7 @@ export class BookModel {
 
     this._medianPageSize = {
       width: widths[Math.floor(widths.length / 2)],
-      height: heights[Math.floor(heights.length / 2)]
+      height: heights[Math.floor(heights.length / 2)],
     };
     return this._medianPageSize;
   }

package/src/BookReader/DragScrollable.js

@@ -179,7 +179,7 @@ export class DragScrollable {
     // How much did the mouse move?
     const delta = {
       left: (lt.left - this.lastCoord.left),
-      top: (lt.top - this.lastCoord.top)
+      top: (lt.top - this.lastCoord.top),
     };
 
     const scrollTarget = this.settings.scrollWindow ? $(window) : this.handling_element;
@@ -218,7 +218,7 @@ export class DragScrollable {
     // How much did the mouse move total?
     const delta = {
       left: Math.abs(this.lastCoord.left - this.firstCoord.left),
-      top: Math.abs(this.lastCoord.top - this.firstCoord.top)
+      top: Math.abs(this.lastCoord.top - this.firstCoord.top),
     };
     const distance = Math.max(delta.left, delta.top);
 

package/src/BookReader/ModeSmoothZoom.js

@@ -65,7 +65,7 @@ export class ModeSmoothZoom {
       listeners: {
         start: this._pinchStart,
         end: this._pinchEnd,
-      }
+      },
     });
     if (isSamsungInternet()) {
       // Samsung internet pinch-zoom will not work unless we disable
@@ -79,7 +79,7 @@ export class ModeSmoothZoom {
             minSpeed: 100,
             allowResume: true,
           },
-          listeners: { move: this._dragMove }
+          listeners: { move: this._dragMove },
         });
     }
 
@@ -134,7 +134,7 @@ export class ModeSmoothZoom {
         start: this._pinchStart,
         move: this._pinchMove,
         end: this._pinchEnd,
-      }
+      },
     });
   }
 
@@ -159,7 +159,7 @@ export class ModeSmoothZoom {
       listeners: {
         start: this._pinchStart,
         end: this._pinchEnd,
-      }
+      },
     });
     // Want this to happen after the pinchMoveFrame,
     // if one is in progress; otherwise setting oldScale
@@ -185,7 +185,7 @@ export class ModeSmoothZoom {
     this.mode.$container.style.overflow = "hidden";
     this.pinchMoveFramePromiseRes = null;
     this.pinchMoveFramePromise = new Promise(
-      (res) => (this.pinchMoveFramePromiseRes = res)
+      (res) => (this.pinchMoveFramePromiseRes = res),
     );
     this.updateScaleCenter({
       clientX: this.lastEvent.clientX,

package/src/BookReader/ModeThumb.js

@@ -252,7 +252,7 @@ export class ModeThumb {
     this.br.thumbColumns = clamp(
       this.br.thumbColumns,
       this.br.options.thumbMinZoomColumns,
-      this.br.options.thumbMaxZoomColumns
+      this.br.options.thumbMaxZoomColumns,
     );
 
     if (this.br.thumbColumns != oldColumns) {
@@ -280,7 +280,7 @@ export class ModeThumb {
     this.br.refs.$brContainer.empty();
     this.br.refs.$brContainer.css({
       overflowY: 'scroll',
-      overflowX: 'auto'
+      overflowX: 'auto',
     });
 
     this.br.refs.$brPageViewEl = $("<div class='BRpageview'></div>");

package/src/BookReader/Navbar/Navbar.js

@@ -22,11 +22,11 @@ export class Navbar {
 
     /** @type {Object} controls will be switch over "this.maximumControls" */
     this.minimumControls = [
-      'viewmode'
+      'viewmode',
     ];
     /** @type {Object} controls will be switch over "this.minimumControls" */
     this.maximumControls = [
-      'book_left', 'book_right', 'zoom_in', 'zoom_out', 'onepg', 'twopg', 'thumb'
+      'book_left', 'book_right', 'zoom_in', 'zoom_out', 'onepg', 'twopg', 'thumb',
     ];
 
     this.updateNavIndexThrottled = throttle(this.updateNavIndex.bind(this), 250, false);
@@ -115,7 +115,7 @@ export class Navbar {
       this.updateViewModeButton(
         $button,
         currentViewModeButton.className,
-        currentViewModeButton.title
+        currentViewModeButton.title,
       );
     });
   }
@@ -218,7 +218,7 @@ export class Navbar {
       min: 0,
       max: br.book.getNumLeafs() - 1,
       value: br.currentIndex(),
-      range: "min"
+      range: "min",
     });
 
     $slider.on('slide', (event, ui) => {

package/src/BookReader/ReduceSet.js

@@ -7,7 +7,7 @@
 /** @type {ReduceSet} */
 export const IntegerReduceSet = {
   floor: Math.floor,
-  decr(n) { return n - 1; }
+  decr(n) { return n - 1; },
 };
 
 /** @type {ReduceSet} */
@@ -17,7 +17,7 @@ export const Pow2ReduceSet = {
   },
   decr(n) {
     return 2 ** (Math.log2(n) - 1);
-  }
+  },
 };
 
 export const NAMED_REDUCE_SETS = {

package/src/BookReader/Toolbar/Toolbar.js

@@ -53,7 +53,7 @@ export class Toolbar {
         $('<a>')
           .attr({href: br.bookUrl, title: br.bookUrlTitle})
           .addClass('BRreturn')
-          .html(br.bookUrlText || br.bookTitle)
+          .html(br.bookUrlText || br.bookTitle),
       );
     } else if (br.bookTitle) {
       $titleSectionEl.append(br.bookUrlText || br.bookTitle);
@@ -113,7 +113,7 @@ export class Toolbar {
       onLoad: () => {
         br.trigger(EVENTS.stop);
         br.$('.BRpageviewValue').val(window.location.href);
-      }
+      },
     });
     br.$('.info').colorbox({
       inline: true,
@@ -121,7 +121,7 @@ export class Toolbar {
       href: br.$('.BRinfo'),
       onLoad: () => {
         br.trigger(EVENTS.stop);
-      }
+      },
     });
   }
 
@@ -213,7 +213,7 @@ export class Toolbar {
     $form.find('.twitter-share-button').on("click", () => {
       const params = $.param({
         url: this._getSocialShareUrl(),
-        text: br.bookTitle
+        text: br.bookTitle,
       });
       const url = 'https://twitter.com/intent/tweet?' + params;
       createPopup(url, 600, 400, 'Share');

package/src/BookReader/options.js

@@ -65,7 +65,7 @@ export const DEFAULT_OPTIONS = {
     {reduce: 2, autofit: null},
     {reduce: 3, autofit: null},
     {reduce: 4, autofit: null},
-    {reduce: 6, autofit: null}
+    {reduce: 6, autofit: null},
   ],
 
   /** Object to hold parameters related to 1up mode */
@@ -83,7 +83,7 @@ export const DEFAULT_OPTIONS = {
     /** Width of book spine  $$$ consider sizing based on book length */
     bookSpineDivWidth: 64,
     /** @type {AutoFitValues} */
-    autofit: 'auto'
+    autofit: 'auto',
   },
 
   onePageMinBreakpoint: 800,
@@ -225,31 +225,31 @@ export const DEFAULT_OPTIONS = {
       visible: true,
       label: 'Flip left',
       className: 'book_left',
-      iconClassName: 'left-arrow'
+      iconClassName: 'left-arrow',
     },
     bookRight: {
       visible: true,
       label: 'Flip right',
       className: 'book_right',
-      iconClassName: 'left-arrow hflip'
+      iconClassName: 'left-arrow hflip',
     },
     onePage: {
       visible: true,
       label: 'One-page view',
       className: 'onepg',
-      iconClassName: 'onepg'
+      iconClassName: 'onepg',
     },
     twoPage: {
       visible: true,
       label: 'Two-page view',
       className: 'twopg',
-      iconClassName: 'twopg'
+      iconClassName: 'twopg',
     },
     thumbnail: {
       visible: true,
       label: 'Thumbnail view',
       className: 'thumb',
-      iconClassName: 'thumb'
+      iconClassName: 'thumb',
     },
     viewmode: {
       visible: true,
@@ -260,19 +260,19 @@ export const DEFAULT_OPTIONS = {
       visible: true,
       label: 'Zoom out',
       className: 'zoom_out',
-      iconClassName: 'magnify'
+      iconClassName: 'magnify',
     },
     zoomIn: {
       visible: true,
       label: 'Zoom in',
       className: 'zoom_in',
-      iconClassName: 'magnify plus'
+      iconClassName: 'magnify plus',
     },
     fullScreen: {
       visible: true,
       label: 'Toggle fullscreen',
       className: 'full',
-      iconClassName: 'fullscreen'
+      iconClassName: 'fullscreen',
     },
   },
 

package/src/BookReader/utils/classes.js

@@ -31,6 +31,6 @@ export function exposeOverrideable(FromClass, fromMethod, fromTransform, ToClass
         return overrideFn.apply(newThis, arguments);
       };
       wrapper = overrideFn;
-    }
+    },
   });
 }