@internetarchive/bookreader 5.0.0-56 → 5.0.0-57

package/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 5.0.0-57
+- Fix - do not show Download pane when there aren't any available @iisa
+
 # 5.0.0-56
 - Fix DOMException in sandboxed iframe in chrome @cdrini
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@internetarchive/bookreader",
-  "version": "5.0.0-56",
+  "version": "5.0.0-57",
   "description": "The Internet Archive BookReader.",
   "repository": {
     "type": "git",

package/src/BookNavigator/book-navigator.js

@@ -164,7 +164,6 @@ export class BookNavigator extends LitElement {
    */
   initializeBookSubmenus() {
     const providers = {
-      downloads: new DownloadProvider(this.baseProviderConfig),
       share: new SharingProvider(this.baseProviderConfig),
       visualAdjustments: new VisualAdjustmentProvider({
         ...this.baseProviderConfig,
@@ -175,6 +174,10 @@ export class BookNavigator extends LitElement {
       }),
     };
 
+    if (this.shouldShowDownloadsMenu()) {
+      providers.downloads = new DownloadProvider(this.baseProviderConfig);
+    }
+
     if (this.bookreader.options.enableSearch) {
       providers.search = new SearchProvider({
         ...this.baseProviderConfig,
@@ -325,6 +328,7 @@ export class BookNavigator extends LitElement {
    * @returns {bool}
    */
   shouldShowDownloadsMenu() {
+    if (!this.downloadableTypes.length) { return false; }
     if (this.bookIsRestricted === false) { return true; }
     if (this.isAdmin) { return true; }
     const { user_loan_record = {} } = this.lendingStatus;

package/tests/jest/BookNavigator/book-navigator.test.js

@@ -148,6 +148,9 @@ describe('<book-navigator>', () => {
         el.bookreader = brStub;
         await el.elementUpdated;
 
+        el.downloadableTypes = ['foo/bar'];
+        await el.elementUpdated;
+
         el.initializeBookSubmenus();
         await el.elementUpdated;
         const defaultMenus = Object.keys(el.menuProviders);
@@ -229,6 +232,27 @@ describe('<book-navigator>', () => {
         expect(baseConfigKeys).toContain('isAdmin');
         expect(baseConfigKeys).toContain('onProviderChange');
       });
+
+      test('Downloads panel - does not show if no available `downloadableTypes`', async () => {
+        const el = fixtureSync(container());
+        const $brContainer = document.createElement('div');
+        const brStub = {
+          resize: sinon.fake(),
+          currentIndex: sinon.fake(),
+          jumpToIndex: sinon.fake(),
+          options: {},
+          refs: {
+            $brContainer
+          }
+        };
+        el.bookreader = brStub;
+        await el.elementUpdated;
+
+        el.initializeBookSubmenus();
+        await el.elementUpdated;
+        const defaultMenus = Object.keys(el.menuProviders);
+        expect(defaultMenus.find(menu => menu === 'downloads')).toBeUndefined;
+      });
     });
 
     describe('Controlling Menu Side Panel & Shortcuts', () => {