@internetarchive/bookreader 5.0.0-32-shadydom3 → 5.0.0-32-1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@internetarchive/bookreader",
-  "version": "5.0.0-32-shadydom3",
+  "version": "5.0.0-32-1",
   "description": "The Internet Archive BookReader.",
   "repository": {
     "type": "git",

package/src/BookNavigator/bookmarks/bookmarks-provider.js

@@ -16,7 +16,7 @@ export default class BookmarksProvider {
       signedIn,
       bookreader,
       modal,
-      onProviderChange
+      onProviderChange,
     } = options;
 
     const referrerStr = `referer=${encodeURIComponent(location.href)}`;

package/src/BookNavigator/bookmarks/ia-bookmarks.js

@@ -142,8 +142,8 @@ class IABookmarks extends LitElement {
     if (this.displayMode === 'login') {
       return;
     }
+    this.fetchUserBookmarks();
     this.setBREventListeners();
-    this.initializeBookmarks();
   }
 
   updateDisplay() {
@@ -153,6 +153,9 @@ class IABookmarks extends LitElement {
   }
 
   fetchUserBookmarks() {
+    if (!this.api.identifier) {
+      return;
+    }
     this.fetchBookmarks()
       .then(() => {
         this.initializeBookmarks();
@@ -227,7 +230,7 @@ class IABookmarks extends LitElement {
   }
 
   fetchBookmarks() {
-    return this.api.getAll().then((res) => {
+    return this.api.getAll().then(res => res.text()).then((res) => {
       let response;
       try {
         response = JSON.parse(res);

package/tests/karma/BookNavigator/bookmarks/ia-bookmarks.test.js

@@ -0,0 +1,57 @@
+import {
+  html,
+  fixtureSync,
+  expect,
+  fixtureCleanup,
+} from '@open-wc/testing';
+import '../../../../src/BookNavigator/bookmarks/ia-bookmarks.js';
+import sinon from 'sinon';
+
+afterEach(() => {
+  sinon.restore();
+  fixtureCleanup();
+});
+
+describe('<ia-bookmarks>', () => {
+  it('uses `setup` to start component', async () => {
+    const el = fixtureSync(html`<ia-bookmarks></ia-bookmarks>`);
+    await el.updateComplete;
+
+    let fetchHappened = false;
+    el.bookreader.bookId = 'foo';
+    el.displayMode = 'bookmarks';
+
+    el.fetchBookmarks = async () => {
+      fetchHappened = true;
+      return await Promise.resolve();
+    };
+
+    const fetchSpy = sinon.spy(el, 'fetchUserBookmarks');
+
+    el.setup();
+    await el.updateComplete;
+
+    expect(fetchSpy.callCount).to.equal(1);
+    expect(fetchHappened).to.equal(true);
+  });
+  it('does not fetch user bookmarks if displayMode = login', async () => {
+    const el = fixtureSync(html`<ia-bookmarks></ia-bookmarks>`);
+    await el.updateComplete;
+
+    let fetchHappened = false;
+    el.displayMode = 'login';
+
+    el.fetchBookmarks = async () => {
+      fetchHappened = true;
+      return await Promise.resolve();
+    };
+
+    const fetchSpy = sinon.spy(el, 'fetchUserBookmarks');
+
+    el.setup();
+    await el.updateComplete;
+
+    expect(fetchSpy.callCount).to.equal(0);
+    expect(fetchHappened).to.equal(false);
+  });
+});