@intentius/chant 0.86.0 → 0.88.0

package/src/workspace/records-write-contract.test.ts

@@ -13,6 +13,7 @@ import { afterAll, describe, expect, test } from "vitest";
 import { RECORD_WARNING_CODES } from "./records";
 import amendSchema from "./records-amend.schema.json";
 import newSchema from "./records-new.schema.json";
+import closeSchema from "./records-close.schema.json";
 import reviewSchema from "./records-review.schema.json";
 import {
   AMEND_ERROR_CODES,
@@ -26,6 +27,7 @@ import {
   REVIEW_ERROR_CODES,
   reviewRecord,
 } from "./records-write";
+import { CLOSE_ERROR_CODES, RECORDS_CLOSE_SCHEMA_ID } from "./records-close";
 
 const REPO = join(import.meta.dirname, "..", "..", "..", "..");
 const KIND = "docs/design/decisions/decision.kind.mjs";
@@ -50,6 +52,7 @@ const SCHEMAS = [
   { name: "records-new", schema: newSchema, id: RECORDS_NEW_SCHEMA_ID, codes: NEW_ERROR_CODES },
   { name: "records-amend", schema: amendSchema, id: RECORDS_AMEND_SCHEMA_ID, codes: AMEND_ERROR_CODES },
   { name: "records-review", schema: reviewSchema, id: RECORDS_REVIEW_SCHEMA_ID, codes: REVIEW_ERROR_CODES },
+  { name: "records-close", schema: closeSchema, id: RECORDS_CLOSE_SCHEMA_ID, codes: CLOSE_ERROR_CODES },
 ] as const;
 
 function expectValid(schema: object, doc: unknown): void {
@@ -118,8 +121,9 @@ describe("real output validates", () => {
     expectValid(amendSchema, await amendRecord({ kind: KIND, id: "ws-003", fields: JSON.stringify({ title: "x" }), cwd: root }));
 
     for (const dryRun of [true, false]) {
-      expectValid(reviewSchema, await reviewRecord({ kind: KIND, id: made.id, verdict: "dissent", by: "alice", note: "Not yet.", session: "S-0001", dryRun, cwd: root }));
+      expectValid(reviewSchema, await reviewRecord({ kind: KIND, id: made.id, verdict: "dissent", by: "alice", note: "Not yet.", dryRun, cwd: root }));
     }
     expectValid(reviewSchema, await reviewRecord({ kind: KIND, id: made.id, verdict: "dissent", by: "alice", cwd: root }));
+    expectValid(reviewSchema, await reviewRecord({ kind: KIND, id: made.id, verdict: "agree", by: "alice", session: "S-0001", cwd: root }));
   });
 });

package/src/workspace/records-write.test.ts

@@ -311,8 +311,10 @@ describe("records review", () => {
     expect(code(await reviewRecord({ kind: KIND, id: "ws-001", verdict: "dissent", by: "bob", cwd: dir }))).toBe("review-note-required");
     expect(code(await reviewRecord({ kind: KIND, id: "ws-001", verdict: "dissent", by: "bob", note: "  ", cwd: dir }))).toBe("review-note-required");
     expect(touched(before, snapshot())).toEqual([]);
-    const doc = await reviewRecord({ kind: KIND, id: "ws-001", verdict: "dissent", by: "bob", note: "It leaves out X.", session: "S-0001", cwd: dir });
-    expect(doc).toMatchObject({ review: { reviewer: "bob", verdict: "dissent", note: "It leaves out X.", session: "S-0001" } });
+    const doc = await reviewRecord({ kind: KIND, id: "ws-001", verdict: "dissent", by: "bob", note: "It leaves out X.", cwd: dir });
+    expect(doc).toMatchObject({ review: { reviewer: "bob", verdict: "dissent", note: "It leaves out X." } });
+    // No session kind names these decisions as its subjects, so no session exists to give a verdict in (#2693).
+    expect(code(await reviewRecord({ kind: KIND, id: "ws-001", verdict: "agree", by: "carol", session: "S-0001", cwd: dir }))).toBe("session-unknown");
   });
 
   test("reviews accumulate on a proposal too", async () => {